VBA Rubberducking

[rubberduck-vba/Rubberduck] BZngr synchronized pull request #4127: Unreachable Case Inspection: follow-up

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4127: Unreachable Case Inspection: follow-up

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4127?src=pr&el=h1) Report
> Merging [#4127](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4127?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `92.25%`.

```diff
@@ Coverage Diff @@
## next #4127 +/- ##
=======================

@IvenBach you do know that this means you get to start writing your own articles?

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.Parsing/ParserRuleContextExtensions.cs of pull request #4127: Unreachable Case Inspection: follow-up

[rubberduck-vba/Rubberduck] build for commit 86e97989 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4127: Unreachable Case Inspection: follow-up

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4127?src=pr&el=h1) Report
> Merging [#4127](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4127?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `92.25%`.

```diff
@@ Coverage Diff @@
## next #4127 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit 86e97989 on unknown branch: 52.71% (target 0%)

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseInspection/Expressi‌onFilterFactory.cs of pull request #4127: Unreachable Case Inspection: follow-up

12:26 AM

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseInspection/Expressi‌onFilterFactory.cs of pull request #4127: Unreachable Case Inspection: follow-up

[rubberduck-vba/Rubberduck] Vogel612 commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

comment didn't show up correctly...

so I recommented after deletion

also ... I really need to sleep now.

'night @Vogel612

@MathieuGuindon Could we add @this to the dev team and clean up the contributors team?

AnnaVel is still in there and we haven't heard from her in ages

sure!

12:37 AM

same goes for IpshitaC and comintern

there might be more

~drops into bed

BBAAGNS

G'night

12:53 AM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/ParserRuleContextExtensions.cs of pull request #4127: Unreachable Case Inspection: follow-up

@Vogel612 removing them deletes their fork.. not gonna do that

1:11 AM

@MathieuGuindon can you move them to another team, without losing forks?

yeah

but what gives?

1:41 AM

@MathieuGuindon isn't that an option for maintaining the core teams without losing the forks of former contributors?

[rubberduck-vba/Rubberduck] ThunderFrame commented on Rubberduck.Parsing/ParserRuleContextExtensions.cs of pull request #4127: Unreachable Case Inspection: follow-up

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

@ThunderFrame there's little point, the privs aren't granular enough to warrant more teams

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] ThunderFrame commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

2:14 AM

[rubberduck-vba/Rubberduck] BZngr created comment on pull request #4127: Unreachable Case Inspection: follow-up

> Duplicate files and old folder structure are now removed.

2:25 AM

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.Parsing/ParserRuleContextExtensions.cs of pull request #4127: Unreachable Case Inspection: follow-up

MsgBox                           ("|

becomes:

MsgBox ("|")

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #4123: AutoComplete IV

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4123: AutoComplete IV

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=h1) Report
> Merging [#4123](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `0%`.

```diff
@@ Coverage Diff @@
## next #4123 +/- ##
===========================

[rubberduck-vba/Rubberduck] BZngr assigned BZngr to issue #4119: Unreachable case inspection does not understand enums

[rubberduck-vba/Rubberduck] build for commit f3211774 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4123: AutoComplete IV

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=h1) Report
> Merging [#4123](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0%`.

```diff
@@ Coverage Diff @@
## next #4123 +/- ##
===========================

[rubberduck-vba/Rubberduck] build for commit f3211774 on unknown branch: 52.56% (target 0%)

3:47 AM

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #4123: AutoComplete IV

@MathieuGuindon dealing with redundant parentheses when MsgBox is used LHS?

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4123: AutoComplete IV

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=h1) Report
> Merging [#4123](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0%`.

```diff
@@ Coverage Diff @@
## next #4123 +/- ##
===========================

@ThunderFrame actually locating the leftmost OutputToken RHS of the original caret position in the insertedCode, finding that OutputToken in the prettifiedCode, and setting the cursor at that position

so, yeah

just no longer assuming it's 1 space

(works like a charm!)

I'm merging the PR after this build succeeds

@MathieuGuindon sounds like another case of adopting a snippet syntax making this easier.

?

3:54 AM

Define the autocorrect using the same or similar way that VSCode/SublimeText define theirs. Then the autocorrect just uses the extensible list of rules, rather than hard-coding each AC in a class.

RD can ship with multiple snippets, but users can fine tune them and even create their own.

TBH it's pretty much already that... individual AC classes don't do much, all the logic is in the base class. but they can override it as needed

well except the user-customization part

I don't think autocomplete should work like autocorrect though

Isn't AC just a special form of snippet?

[rubberduck-vba/Rubberduck] build for commit d45c1c7b on unknown branch: AppVeyor build succeeded

how does a "snippet" know what to do with BACKSPACE depending on caret position relative to the )?

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4123: AutoComplete IV

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=h1) Report
> Merging [#4123](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4123?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `0%`.

```diff
@@ Coverage Diff @@
## next #4123 +/- ##
===========================

[rubberduck-vba/Rubberduck] build for commit d45c1c7b on unknown branch: 52.55% (target 0%)

4:00 AM

block AC's, perhaps

but then that's pretty much the email suggestion

@MathieuGuindon IDK, I'm assuming that syntax I linked dealt with things like that. It looked like regex, but there were undoubtedly some special markers in there. I haven't explored the syntax enough to know if it would allow that.

VSCode implements " completion with these rules?

TTGTB

@MathieuGuindon IDK. Will take a look at the docs

5:19 AM

@MathieuGuindon code.visualstudio.com/docs/editor/userdefinedsnippets

maybe something like:

{
    "double-quote": {
        "prefix": """",
        "body": ["""$0"""],
        "description": "Auto-close double-quotes"
    },
}

but that might not catch the complexity of what you've implemented

IvenBach

5:57 AM

@Vogel612 I have been. I’m not confident enough to expose myself to the world yet. Just a select few people.

One day I’ll shake the feeling of being an imposter.

@MathieuGuindon yay!

6:21 AM

Anyone home?

7:09 AM

I am @QHarr

@PeterMTaylor one moment....BRB

ok

Q: VBA retrieving HTML web data after filling up drop down lists and submitting a search

Sooooo

I was attempting to answer a SO question and my solution failed but I was interested in why solution failed.

There are no other answers given

0

I'm new to scripting HTML data from excel vba. The website I need to download data from is http://www.hkexnews.hk/sdw/search/mutualmarket.aspx?t=hk%2f%3f My objective is to automatically change the drop down lists to a specific date, and download the stock related data of that day. I managed...

That was the question. It is 6 months old.

I have decided to ask a new question but am worried it might be considered a duplicate

what's your goal?

Q: How to correctly set POST parameters to receive shareholding information for a specified date?

I have asked it here

0

tl;dr; I was attempting to answer this SO question. It has no given valid answers and is 7 months old now. My question is about why my solution to the same problem did not work. If this is considered a duplicate I will delete this, and potentially offer a bounty on the other question - but can...

excel-vba xmlhttprequest http-post

It can't actually be marked as a duplicate of that original.

But it feels a bit weird.

My goal:

As I have stated in my question..

To understand why POST request didn't work to get the data for the specified period from the page.

I could attach a bounty to the original question but can I then specify I want an answer that uses fiddler and POST request if possible?

7:17 AM

hang on. :) slow moving of my eyes this evening...

that is I'm reading your article in question

so my initial read is that you have fiddler examining the web traffic from that site

which browser did you examine the webpage from?

or was that all from fiddler?

I think what Jeeped suggested would be one element in the webpage that appears to prevent further access to elements.

not much help from me there sorry. I have the understanding of what GET and POST does via HTTP thats about all I know.

7:41 AM

Chrome

okay

And it matches with fiddler output

I am guessing what Jeeped is saying is this is not as clear cut as I had hoped.

Thank you for taking the time to look at it though!

no worries. I did wanted to help but stumped regarding POST

Grateful all the same :-)

How's things on your end?

8:08 AM

:) no worries. catch you sometime soon. family to feed now. bye

9:42 AM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

10:07 AM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

@Duga A commit on this PR, or a new PR?

10:24 AM

[rubberduck-vba/Rubberduck] mansellan synchronized pull request #4111: VB6 - Add missing VBForm grammar cases

@Duga I'll open another issue \ PR for the MID statement, it's not directly related to this PR.

[rubberduck-vba/Rubberduck] mansellan added label bug to issue #4128: Grammar - Mid statement is not correct

[rubberduck-vba/Rubberduck] mansellan opened issue #4128: Grammar - Mid statement is not correct

> Per https://msdn.microsoft.com/en-us/library/ee156918.aspx, this parser rule is not correct:

https://github.com/rubberduck-vba/Rubberduck/blob/e2468806b7da88f20ca28a4ea0f08edb92cacd78/Rubberduck.Parsing/Grammar/VBAParser.g4#L467

`ASSIGN` should be `EQ`. This should be fixed, and also a test added.

Related: Not sure if it's desirable to have `ASSIGN` defined in the lexer. The only other place it appears to be used is for named arguments, which could equally well be parsed with `COLON E

[rubberduck-vba/Rubberduck] mansellan added label parse-tree-processing to issue #4128: Grammar - Mid statement is not correct

[rubberduck-vba/Rubberduck] build for commit 2a8e2bb9 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4111: VB6 - Add missing VBForm grammar cases

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=h1) Report
> Merging [#4111](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/3489486aee1e5454ab71c938f7fb54fc29bba956?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `11.54%`.

```diff
@@ Coverage Diff @@
## next #4111 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit 2a8e2bb9 on unknown branch: 52.63% (target 0%)

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

10:53 AM

[rubberduck-vba/Rubberduck] mansellan added label PR-Status: WIP to pull request #4111: VB6 - Add missing VBForm grammar cases

@Duga re-adding WIP for now, as discussion still ongoing

[rubberduck-vba/Rubberduck] mansellan synchronized pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4111: VB6 - Add missing VBForm grammar cases

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=h1) Report
> Merging [#4111](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/3489486aee1e5454ab71c938f7fb54fc29bba956?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `11.54%`.

```diff
@@ Coverage Diff @@
## next #4111 +/- ##
=======================

@mansellan I was just thinking of a separate commit, only for this change alone.

@M.Doerner raised 4128 already... had other questions about the ASSIGN lexer rule anyway, so it seemed better to keep it separate.

I prefer the rule to stay.

11:03 AM

could you elaborate? assignment in VB is ordinarily just with EQ, so (at least the name of) the rule seems counter-intuitive?

[rubberduck-vba/Rubberduck] build for commit b2cb701f on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4111: VB6 - Add missing VBForm grammar cases

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=h1) Report
> Merging [#4111](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/3489486aee1e5454ab71c938f7fb54fc29bba956?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `11.54%`.

```diff
@@ Coverage Diff @@
## next #4111 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit b2cb701f on unknown branch: 52.63% (target 0%)

11:54 AM

did the VBA library parse get fixed?

1:21 PM

[rubberduck-vba/Rubberduck] mansellan synchronized pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4111: VB6 - Add missing VBForm grammar cases

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=h1) Report
> Merging [#4111](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/3489486aee1e5454ab71c938f7fb54fc29bba956?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `11.54%`.

```diff
@@ Coverage Diff @@
## next #4111 +/- ##
=======================

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

1:33 PM

[rubberduck-vba/Rubberduck] build for commit 14b31990 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4111: VB6 - Add missing VBForm grammar cases

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=h1) Report
> Merging [#4111](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4111?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/3489486aee1e5454ab71c938f7fb54fc29bba956?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `11.54%`.

```diff
@@ Coverage Diff @@
## next #4111 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit 14b31990 on unknown branch: 52.63% (target 0%)

2:16 PM

Regarding ASSIGN, this has never been intended to mea assignment in VBA; it is simply the mathematical assignemt operator. VBA chose to use EQ for assignment, except for the named parameters. Having it there does not harm the parser, but relieves it of any checks in case it is present, because in contrast to COLON EQ it just sees one completely different token.

My main point however, why not to change it is that it works very well. When writing grammar rules you should anyway know what tokens you use.

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseInspection/Expressi‌onFilterFactory.cs of pull request #4127: Unreachable Case Inspection: follow-up

this

2:43 PM

@BZngr TBH, I think I need some high-level overview of how all the objects work together. There are some stuff that are not immediately clear to me and I'm likely just missing the forest for trees. Maybe write up something either on the PR or on the wiki?

2:57 PM

@M.Doerner ok thanks :-)

BZngr

@this That sounds like a good idea to me. I'll put something together.

3:17 PM

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3956: Introducing Busy state and SuspendParser action

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #3956: Introducing Busy state and SuspendParser action

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3956?src=pr&el=h1) Report
> Merging [#3956](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3956?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `46.9%`.

```diff
@@ Coverage Diff @@
## next #3956 +/- ##
========================

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseInspection/Expressi‌onFilterFactory.cs of pull request #4127: Unreachable Case Inspection: follow-up

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.Parsing/ParserRuleContextExtensions.cs of pull request #4127: Unreachable Case Inspection: follow-up

[rubberduck-vba/Rubberduck] build for commit efe57a57 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #3956: Introducing Busy state and SuspendParser action

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3956?src=pr&el=h1) Report
> Merging [#3956](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3956?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/e2468806b7da88f20ca28a4ea0f08edb92cacd78?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `45.89%`.

```diff
@@ Coverage Diff @@
## next #3956 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit efe57a57 on unknown branch: 52.65% (target 0%)

this

@M.Doerner I've implemented the virtual BeginParse and refactored stuff out into a test subtype but I'm not 100% sure if that helps improves thing for testing.

I also had concerns about _isTestScope now absent, so I put in remarks to help remind future contributors that there is a subtype used exclusively for unit testing.

3:37 PM

[rubberduck-vba/Rubberduck] retailcoder merged pull request #4123: AutoComplete IV from retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder closed issue #4085: AutoComplete - Exit Function bug

[rubberduck-vba/Rubberduck] retailcoder closed issue #4087: AutoComplete interference with IntelliSense auto complete

[rubberduck-vba/Rubberduck] retailcoder closed issue #4086: AutoComplete shouldn't trigger on ElseIf...Then

[rubberduck-vba/Rubberduck] retailcoder closed issue #4088: Block completion needs to ignore string literals (and comments)

[rubberduck-vba/Rubberduck] retailcoder closed issue #4113: AutoCompletion using value in named argument for completion

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.Core/AutoComplete/AutoCompleteBase.cs of pull request #4123: AutoComplete IV

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.VBEEditor/Events/VBENativeServices.cs of pull request #4123: AutoComplete IV

this

Too late but they're only questions anyway.

[rubberduck-vba/Rubberduck] retailcoder published prerelease Rubberduck-v2.2.0.3435

[rubberduck-vba/Rubberduck] retailcoder created tag Rubberduck-v2.2.0.3435

[rubberduck-vba/Rubberduck] build for commit 487f9d32 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit 487f9d32 on next: 52.55% (target 0%)

Tweeting Duck

3:56 PM

💁‍♀️ Looking for Win32 APIs? We now have them on http://docs.microsoft.com: https://aka.ms/AA1ndse

Tweeted by docsmsft on June 22, 2018 at 10:31 PM

4:07 PM

[rubberduck-vba/Rubberduck] mansellan created pull request #4129: Grammar - fix MID statement to merge mansellan/Rubberduck/4111 into rubberduck-vba/Rubberduck/next

> Closes #4111

There were a few issues:

1. Was using `ASSIGN` instead of `EQ`
2. Was using `lExpression` instead of `expression`
3. Was not referenced from `mainBlockStmt`
4. No tests

[rubberduck-vba/Rubberduck] mansellan removed label PR-Status: WIP from pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] bclothier commented on RubberduckTests/Grammar/VBAParserTests.cs of pull request #4129: Grammar - fix MID statement

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.Parsing/Grammar/VBALexer.g4 of pull request #4111: VB6 - Add missing VBForm grammar cases

[rubberduck-vba/Rubberduck] build for commit 57e51f33 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) created comment on pull request #4129: Grammar - fix MID statement

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4129?src=pr&el=h1) Report
> Merging [#4129](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4129?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/487f9d32524de82877b7f1154a7be2a32a75d557?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4129 +/- ##
=======================================

[rubberduck-vba/Rubberduck] build for commit 57e51f33 on unknown branch: 52.55% (target 0%)

[rubberduck-vba/Rubberduck] bclothier created comment on pull request #4129: Grammar - fix MID statement

> Also, make sure to check whether you can remove the "hack" from the resolver

https://github.com/rubberduck-vba/Rubberduck/blob/c46cd4d6ee52770924f823d5140ce211426affc6/Rubberduck.Parsing/Binding/Bindings/SimpleNameDefaultBinding.cs#L78-L85

4:36 PM

[rubberduck-vba/Rubberduck] mansellan synchronized pull request #4129: Grammar - fix MID statement

[rubberduck-vba/Rubberduck] mansellan created comment on pull request #4129: Grammar - fix MID statement

> !image

[rubberduck-vba/Rubberduck] mansellan edited comment on pull request #4129: Grammar - fix MID statement

> ![image](https://user-images.githubusercontent.com/25420409/41811720-cc8567ba-770c-11e8-882c-ffec58cac9fb.png)

Guessing that `(function:Variant)` is due to function aliasing. But it's not resolving it to a variable now :-)

@Duga That probably worked for quite a while already, i.e. the hack was unneccessary. There had been problems with the custom declarations, which we use for the alias declarations. However, that whas been resolved some time ago.

[rubberduck-vba/Rubberduck] build for commit 9238e688 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4129: Grammar - fix MID statement

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4129?src=pr&el=h1) Report
> Merging [#4129](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4129?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/487f9d32524de82877b7f1154a7be2a32a75d557?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

```diff
@@ Coverage Diff @@
## next #4129 +/- ##
=========================

[rubberduck-vba/Rubberduck] build for commit 9238e688 on unknown branch: 52.55% (target 0%)

awgaya

5:04 PM

is the hack creating an undeclared variable or is it simply the check for mid/mid$?

[rubberduck-vba/Rubberduck] bclothier created comment on pull request #4129: Grammar - fix MID statement

> I wonder if it's necessary to have additional unit tests to prove that it's not an undeclared variable to directly test the effect of the hack that was removed?

5:48 PM

@awgaya if we create an undeclared variable for it, we've failed to correctly identify it =)

Mid$ should resolve to a string-returning function; we must not break the "use string-typed equivalent function" inspection & quickfix

awgaya

ok

Tweeting Duck

6:25 PM

Starting with the next release, we're making it very hard to get e.g. "Next without For" compile errors in #VBA. And confusing, unindented code, too. Pre-release build here: https://github.com/rubberduck-vba/Rubberduck/releases/tag/Rubberduck-v2.2.0.3435

Tweeted by rubberduckvba on June 23, 2018 at 5:41 PM

If you notice anything that doesn't feel exactly the way autocompletion should work in a modern IDE while typing #VBA code in the good ol'VBE, make an issue and we'll fix it. This feature means to work exactly like it does in @VisualStudio. Or smarter, if we can. #OSS #Contribute https://twitter.com/rubberduckvba/status/1010578624611848192

Tweeted by rubberduckvba on June 23, 2018 at 5:46 PM

7:44 PM

evening

Why can't I do Dim x As HTMLTable: Set x = New HTMLTable please? I get incorrect use of New.

8:10 PM

Oh... I have to do Set x = document.createElement("TABLE")

@QHarr not all classes are creatable. You can't do Set book = New Workbook either ;-)

@MathieuGuindon Thank you

Actually your own VBA class modules, when made public (to other VBA projects), aren't creatable either; you must provide a factory method somewhere

Oh...

So much to learn...

crap just realized I broke block completion

8:31 PM

[rubberduck-vba/Rubberduck] retailcoder created pull request #4130: fix block completion to merge retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder merged pull request #4130: fix block completion from retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder pushed commit 138677c1 to next: fix block completion

[rubberduck-vba/Rubberduck] web-flow pushed commit b20482c9 to next

Merge pull request #4130 from retailcoder/next

fix block completion

definitely need to figure out unit tests for AC

[rubberduck-vba/Rubberduck] build for commit 138677c1 on next: AppVeyor build cancelled

BUILD FAILURE!

8:44 PM

[rubberduck-vba/Rubberduck] retailcoder published prerelease Rubberduck-v2.2.0.3439

[rubberduck-vba/Rubberduck] retailcoder created tag Rubberduck-v2.2.0.3439

[rubberduck-vba/Rubberduck] build for commit b20482c9 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit b20482c9 on next: 52.55% (target 0%)

8:59 PM

[rubberduck-vba/Rubberduck] tommy9 created pull request #4131: Add fakes for Now, Time and Date functions to merge tommy9/Rubberduck/AddMoreFakes into rubberduck-vba/Rubberduck/next

> Adds fakes for the Now, Time and Date functions. Issue #2891 tracks the addition of each item.

Minor issue that integration test for passthrough of Time function could fail for 1 second out of every 24 hours (86 400 seconds). Not considered important enough to add complex logic to avoid this but let me know if this is needed.

@Duga ooooh nice!!

Timer would have been nice too

Tommy9's avatar suggests that it is @Hosch250's dog, Meadow...