VBA Rubberducking

Duga

12:01 AM

RELOAD!

[Cardshifter/HTML-Client] 1 commit. 31 additions. 24 deletions.

[rubberduck-vba/Rubberduck] 2 opened issues. 6 issue comments.

[Zomis/Server2] 11 commits. 57 additions. 38 deletions.

Mathieu Guindon

1:39 AM

Quack Exchange

0

Q: VBA UDF SUMIF with Array Parameters

I was trying to give SUMIFS3D User-Defined-Function a nice review and ended up getting pretty side-tracked trying to figure out how to pass some parameters by array and whether or not I could send a 3D-range through the function (seems not). It's a good one for review, I'm sure there are improve...

this

@MathieuGuindon ooh ooh! Let me guess. That exam was administered by Captain Obvious!

Mathieu Guindon

SO gold tag badge :)

I already had vba and excel-vba

now I can hammer mistagged VBA questions too!

Son Goku ssj4

7:13 AM

@MathieuGuindon: Hi Mathieu :-) I've noticed week ago you've changed the avatar and there was no Mug anymore. And now your name :-D I suppose live is a change :-) Congrats to your Excel badge :-)

ThunderFrame

@Hosch250 Maybe I'm part of the problem, but I remember when good IT policy involved staying at least one major build behind latest. Sure, there were bugs, but they were generally known bugs. It was simply too risky to upgrade or apply a service pack, until that had been proven for 12 months, by somebody else.

I've been thinking about the Avalon window.... Now that the crash-on-exit issues are largely resolved, and given that we can create a native MDI child ToolWindow.... Do we really need to attempt any of the SetParent/injection jiggery pokery? Can't the Avalon window just host the WPF we need?

Quack Exchange

10:09 AM

0

Q: Best procedure calling architecture

I am going back and forth between the following two architect types to write a program, and I was wondering if one is better than the other. Example one: usabableData1 = ReturnFunction1 usableData2 = ReturnFunction2(usableData1) usableData3 = ReturnFunction3(usableData2) etc. Example two: F...

design-patterns vba

FreeMan

11:32 AM

@ThunderFrame You say "jiggery pokery" like it's a Bad Thing™

(I just wanted an excuse to type jittery pokery.)

2

Mathieu Guindon

12:04 PM

@SonGokussj4 yup. you may or may not have seen this:

28

Q: Putting down my mug

I joined CR in May 2013, but only started living here in September of that year. I remember very well then, the site had been in beta for almost 1000 days, and I kept thinking that was a shame, CR was such an awesome twist of the Stack Exchange format, it had to "graduate". Soon I met folks that...

discussion moderators

FreeMan

12:42 PM

Now I want a chance to fix my spelling mistake, but it's too late. :/

Hosch250

12:56 PM

@ThunderFrame Meh. Somebody has to upgrade to find the bugs...

And I like getting brand new features.

1hr interview with MS on Thursday (not sure which Thursday yet. 2 days?).

3

Son Goku ssj4

@MathieuGuindon Ah, good for you :-) I really don't have many things to say in these situations. But, just... :) Hope it was fun ^_^

Mathieu Guindon

2:01 PM

Instead of having a method for this, consider using DI with a DI container. You can then use T in the constructor and "automagically" get the right type. — Hosch250 20 mins ago

@Hosch250 I'm so proud of you :)

Hosch250

:)

Massive release in two days.

We skipped the last release cycle because of massive bugs.

It's fairly stable, but I think we might need a hotfix or two once the clients start hitting some of the changes.

Duga

3:34 PM

[rubberduck-vba/Rubberduck] DiogoRNeves starred us

2

IvenBach

@Hosch250 Hope it goes well for you.

IvenBach

4:27 PM

Duck check: I have a single named range that's giving me problems.

Private Function GetNamedRange(ByVal parentSheet As String, ByVal namedRange As String) As Name
    If TypeOf ThisWorkbook.Names(namedRange).Parent Is Workbook Then
        Set GetNamedRange = ThisWorkbook.Names(namedRange)
    Else
        Set GetNamedRange = ThisWorkbook.Worksheets(parentSheet).Names(namedRange)
    End If
End Function

TypeOf ThisWorkbook.Names(namedRange).Parent Is Workbook is the part that it's erroring on.

I've checked that the correct information is provided as arguments for it to be found.

The scoping of the NamedRange is indeed where I'm expecting it and that the range is on that WorkSheet.

The why of having to do it this way is to identify when an edit moves ranges. There had been too many whoopsies and I'm using this as a check for shifting cells.

Mathieu Guindon

4:44 PM

@IvenBach parentSheet As String smells. and should be an optional, 2nd parameter IMO

(hey you have an excuse for using the reorder parameters refactoring!)

IvenBach

That's actually a thing?

Mathieu Guindon

yup

save your work first

it should flip the two params and update all call sites accordingly

IvenBach

@MathieuGuindon I acknowledge your confidence that RD won't crash :wink:

Mathieu Guindon

@IvenBach I don't think it'll crash. but it could wreck the code. likely won't (it's tested), but still.

IvenBach

I always SaveAs before using new features or code.

Mathieu Guindon

4:47 PM

put ThisWorkbook.Names(namedRange) on its own, and account for namedRange not being found

right now your function is assuming the input is sane

which is fine, ...until a user renames a worksheet

IvenBach

Any input to this will come from me no I'm confident it's valid.

Mathieu Guindon

why can't it work off an actual Worksheet object, instead of querying the Worksheets collection?

IvenBach

Renaming a WS will be shame-on-them.

Mathieu Guindon

protect workbook structure if you have hard-coded sheet names anywhere

IvenBach

Oh how I would like to....

I didn't get that far in the refactoring process of feeding in a Worksheet

this

4:52 PM

#WorksheetAintADataEntryForm

IvenBach

I make Excel do things it shouldn't.

As I'm sure many of us at the pond have done.

Mathieu Guindon

how many references to that function? I bet most call sites already have an actual Worksheet and they're passing Worksheet.Name there

IvenBach

That function has 1 caller.

Mathieu Guindon

well then, refactoring it to use a Worksheet shouldn't be too hard!

@IvenBach I've no idea what you mean

IvenBach

A bit beyond where I'm at presently. Each day I'm closing that gap though.

this

4:54 PM

hmm i wonder how feasible it is to make an inspection to convert a property into object

YOu have no idea how many time i saw functions that takes a string, only to pull it out of a collection.

while the caller has the object right there. :headdesk:

Mathieu Guindon

not quite "convert a property into object", but that would be a "change signature" refactoring

IvenBach

I've warned you not to look at my code. Stuff like that'd make you sick.

Mathieu Guindon

you showed it to me!

this

yes, better wording

IvenBach

I'm referring to this. I'll gladly expose my ignorance so I'll learn from it.

this

4:56 PM

"Don't use indexer when you can use an object" ... something like that

You're referring to what?

</tongueincheek>

Mathieu Guindon

@this IDK, I see it more as a refactoring than an inspection: sometimes you want the worksheet, other times you only want one of its properties. Per principle of least knowledge there's nothing wrong with passing a string if that's all you need.

problem is when you're using that string to fetch the object you were looking at 1 step up the call stack

this

the inspection would be deeper than that. Yeah

you need to check the call site, and see it's doing a object.property assignment to the function being called, then within the function it's then doing objectcollection[indexer]

if both are true, then you can flag that as an inspection for potential refactoring.

Mathieu Guindon

useful, but I'd think it's too much of a specific case to be worth the effort

this

hmm. but that implies we know what collection stores what object using what property....

Mathieu Guindon

^

this

5:00 PM

yeah, but TBH, it really annoys the hell out of me when I see functions from other people that pass around string for form names

then pull it out of the Forms collection.

Gee, you had it already, just gimme the object, already, will ya?!?

Mathieu Guindon

I know the feeling. I get the same when I see people getting a compile-time worksheet from the Worksheets (or worse, Sheets) collection, by name.

Hosch250

@MathieuGuindon That's eager, right?

Mathieu Guindon

well duh

:)

CallumDA

Don't suppose you guys know if functions like Average are quicker through Application or WorksheetFunction. I might set up the test anyway

Mathieu Guindon

in theory WorksheetFunction.Average being early-bound, should perform a nanosecond faster than the late-bound Application.Average equivalent.

CallumDA

5:04 PM

How is Application.Average late bound?

Mathieu Guindon

it's an extended interface

it's like the WorksheetFunction interface was tacked onto Application, at run-time

that's why you don't get intellisense for it; none of it exists at compile-time - hence, late-bound.

also Application.WhateverYouWant will happily compile

CallumDA

Oh okay

Makes me want to avoid it, but with Application.Something you can test with IsError

Mathieu Guindon

WorksheetFunction throws the error, which makes for more idiomatic VBA code :)

ThunderFrame

@CallumDA That's the other difference. With WorksheetFunction you can use real error handling

Mathieu Guindon

also Application.Something forces you to receive the result into a Variant, otherwise if what you get is an Error, you're looking at a type mismatch error anyway

CallumDA

5:08 PM

@ThunderFrame Go on?

So you catch the actual error in error handling and you don't get a type mismatch?

Mathieu Guindon

correct

CallumDA

brilliant

Mathieu Guindon

so instead of "type mismatch" you get "unable to get the Match property of the WorksheetFunction class"

which is slightly better at telling you what happened

this

#DumbQuestion -- is there a way to get error 1004 to be more meaningful?

Mathieu Guindon

yup. hijack it from Rubberduck and rewrite the stupid error message :)

IOW, not really :)

CallumDA

5:14 PM

Haha, it is awful

ThunderFrame

@CallumDA As Mat said. Also, Application.Match is circa Excel 95 syntax.

Mathieu Guindon

at least the error says "Match", which tells you more about the failure than "type mismatch" anyway

Dim result As Double
result = Application.WorksheetFunction.Match(something, somewhere, 0)

^ here the error is thrown before result is assigned, by the Match function itself

Dim result As Double
result = Application.Match(something, somewhere, 0)

here Match returns an Error value, and because that can't be coerced into a Double, a type mismatch error is thrown from the result = assignment

ThunderFrame

IIRC, WotksheetFunction is a member of Global, so you can omit the Application...

Mathieu Guindon

unless you type it like that

;-)

CallumDA

hahaha

Mathieu Guindon

5:17 PM

@ThunderFrame I tend to qualify with Application just to leverage autocomplete :)

CallumDA

@ThunderFrame, were you using Excel in 95 then?

Mathieu Guindon

the game-changer will be when we're able to type App[TAB].WF.Match and RD IntelliSense will just to the magic thing

ThunderFrame

@CallumDA Couldn't wait to get off Office 4.3...

IvenBach

@MathieuGuindon Make it so BDFL.

Quack Exchange

0

Q: Collections of classes in VBA

I have noticed this question in StackOverflow, but it got closed faster than I could have answered. However, it was concerning a best practice for usage of collections of classes. I usually use Array and I add to it like this: Public Sub AddToTeam(emp As Employee) Dim cnt As Long cnt ...

object-oriented vba

Mathieu Guindon

5:19 PM

what's BDFL?

IvenBach

Benevolent Dictator For Life

Mar 15 at 16:48, by IvenBach

Benevolent dictator for life

Benevolent Dictator For Life (BDFL) is a title given to a small number of open-source software development leaders, typically project founders who retain the final say in disputes or arguments within the community. The phrase originated in 1995 with reference to Guido van Rossum, creator of the Python programming language. Shortly after van Rossum joined the Corporation for National Research Initiatives, the term appeared in a follow-up mail by Ken Manheimer to a meeting trying to create a semi-formal group that would oversee Python development and workshops; this initial use included the additional...

ThunderFrame

@CallumDA Owning Office 1.4 doesn't make me old, right?

2

this

@IvenBach, thank you for volunteering for procuring Mat a nice uniform, awash with medals and a big peaked cap.

IvenBach

Of course. Naturally, it'll be purple velvet.

CallumDA

@ThunderFrame !! I'm having to check Wikipedia have any idea of when these versions were even released

Impressive though, wear those versions like a medal

Mathieu Guindon

5:23 PM

I can guess it was back when 16 colors was awesome, and 640K more memory than you could dream for

CallumDA

I've never even used 2007 and I think I'd find it a bit frustrating ;)

ThunderFrame

@CallumDA The early Office versions were really just bundles of Excel, Word and PowerPoint... There was no integration or interoperability... It was just Microsoft's way of bundling items at a small discount, to sell more software...

CallumDA

No VBA?

Mathieu Guindon

then OLE became a thing, and then you'd have Excel sheets in Word documents and PowerPoint presentations

ThunderFrame

@CallumDA 2007 isn't very different from 2010. Prior to 2007, there was no ribbon.

Mathieu Guindon

5:26 PM

VBA replaced the primitive macro language circa 1993 IIRC

last version I recall using is 2000

IvenBach

The ribbon was a huge stumbling block for those already adept pre-Ribbon.

Mathieu Guindon

although, I did use some monochrome version of Access around 1996, on a noisy 386

ThunderFrame

@CallumDA I forget when VBA hit Excel. Definitely by Excel 95, IIRC.

IvenBach

@ThunderFrame Pretty sure it was at least by Win95. I recall recording a macro and being amazed at that fact.

CallumDA

Didn't they keep the keyboard shortcuts the same when the ribbon was introduced at least?

IvenBach

5:28 PM

Yes.

All pre ribbon shortcuts were preserved.

Many ribbon shortcut keys are much longer too.

ThunderFrame

Office 2000 added support for COM add-ins in the VBE.... So, in theory, Rubberduck will save your Office 2000 bacon.

this

if you can install .NetFx 4.0....

IDK if you can install 2000 on anything newer than Windows 7.

ThunderFrame

@this I'm running Office 97 and 2000 on Windows 7 VMs.

They need to be running compatibility mode.

this

Yeah, but newer than that?

ThunderFrame

@this I seem to remember Paul Thurrott running Excel 95 on Windows 10.

this

5:32 PM

oh cool.

ThunderFrame

MS does like to make things compatible.

this

yeah, I simply didn't know if they kept it compatible given the recent trends.

Mathieu Guindon

heck, I've seen Win95 run on an iWatch or something like it. nothing surprises me anymore.

this

I bet it crashes a lot.

</captainobvious>

Mathieu Guindon

why you'd want Win95 on your watch, IDK. maybe useful when you need blue light

like, BSOD-blue light

this

5:33 PM

but what's more likely, running old skool Office on a old skool OS or a old skool Office on modern OS?

Mathieu Guindon

B

this

Hmm. IME, it's the opposite.

#SelectionBias #ConfirmationBias

Mathieu Guindon

I guess lol

ThunderFrame

@this It was Word 95 on Windows 10...

Mathieu Guindon

OMG

dat teal icon

IvenBach

5:36 PM

The limited color palette.

Mathieu Guindon

they could use 256, but only 16 at a time, right?

or they could go 256, but stuck to 16 for back-compat

ugh IDK anymore

IvenBach

Your memory has faded Mug.

Mathieu Guindon

I'm expecting that cloud background to fade any time to a black screen with orange lettering saying "IT'S NOW SAFE TO SHUT DOWN YOUR COMPUTER"

this

likely eclipsed by all those battlescars from all those crashes, bugs, and virus in that day.

oh my

IvenBach

Mathieu Guindon

5:53 PM

@IvenBach yup, that.

IvenBach

I don't recall that screen.

I can just imagine that people would turn off the monitor only thinking that was the computer.

Had to educate my duckling as to why I have 2 "Computers". It's 2 monitors for 1 computer.

ThunderFrame

@IvenBach You didn't elaborate and say it's multiple computers running under a hypervisor, with a single video card?

IvenBach

One computer with 2 monitors, kind of like how we have 1 brain with 2 eyes. Instead of the monitors seeing us we see it displays the information for us to see.

Mathieu Guindon

6:12 PM

@IvenBach that screen was my whole teenagehood

Tweeting Duck

TFW your #OSS project gets #VBA folks to learn some #dotnet and #csharp, and lands them an actual programming job. Happened twice already! Will you be the next Rubberduck contributor?

Tweeted by rubberduckvba on March 20, 2018 at 6:09 PM

Hosch250

@TweetingDuck Who's the second one?

It can't be me, even though it certainly helped land me a job. I don't know VBA.

Mathieu Guindon

@Hosch250 well, stretching a bit..

Hosch250

Oh. OK.

TFW you have a meeting in 12 minutes, so you can't start anything :P

We've got an issue with something that's pretty critical, but I can't see the error because we eat it and don't log it :(

Well, we might be logging it somewhere, but nowhere easy to find.

Of course, I can't reproduce it under debug mode because my computer doesn't have HyperV enabled, so I can't run a program on Docker to act as our "service bus".

Mathieu Guindon

Ctrl+F, "nom-nom", ENTER?

or "gulp"

> (backwards) convention: swallow-all catch blocks shall have a comment that reads // gulp, so that they can be easily found when they're identified as a problem.

Hosch250

6:25 PM

I know exactly where the problem is happening.

Or, I know where the AJAX handler is.

My browser refuses to let me modify the "running" JS, though, so I can't test the deployed system.

FreeMan

@ThunderFrame Just shift the decimal point and you'll be on a newer version than we are here at work.

Hosch250

@FreeMan You are on Office .13 or lower?

IvenBach

@MathieuGuindon Is it stretching it? @Hosch250 did your contributions to RD up your skillset?

I'm pretty sure the answer is 'Yes'.

Hosch250

Yeah.

But the thing is, I wasn't a VBA person.

So the statement is misleading.

IvenBach

It's advertising... Of course it's going to be misleading and deceptive.

Quack Exchange

6:33 PM

0

Q: Ways to Speed Up Code Execution - VBA

I have code that runs and does what I want it to do with the click of the command button, however when executing, it runs very slow. The code grabs data from one sheet and inserts/formats it into another sheet in two separate tables that have been converted into range. I did this because I need t...

vba excel

Mathieu Guindon

the fallacy would be "contribute to RD and you'll land a job as a C# programmer"

more than "RD contributed to 2 of its devs' career"

IvenBach

It could be that I end up being that 3rd duck. Likely not a direct programming gig I could be getting into my degree field.

ThunderFrame

@Hosch250 And yet your internship was on the second biggest vba project on GitHub ;-)

Mathieu Guindon

@ThunderFrame that's star-count. RD is arguably the largest vba-related project out there.

ThunderFrame

@MathieuGuindon and with the most ambitious roadmap....

this

6:46 PM

huh? it's #1 by star-count now?

github.com/topics/vba?o=desc&s=stars

ThunderFrame

@MathieuGuindon what do you think about my Avalon comment. Do we even need to inject, if we've got an MDI ToolWindow?

Mathieu Guindon

@this ha nice, I was just looking for "VBA" mentions

this

how does one find that?

Mathieu Guindon

ThunderFrame

@this wow, that must have happened recently... I'm surprised @MathieuGuindon hasn't tweeted it yet

waits for tweetingduck

IvenBach

6:49 PM

^

It'll be rectified shortly.

Mathieu Guindon

well we're still ranking 3rd among all repositories that say "vba" somewhere

ThunderFrame

notices that autocorrect wants to change "tweetingduck" to "tweeting fuck"

IvenBach

:+1:

this

@MathieuGuindon I don't get it- RD is nowhere on the page.... :(

that's using "Best match" sort (the default)

Mathieu Guindon

@this 3rd

this

6:51 PM

nope.

huh?

GH is confusing the hell out of me.

IDK if it's same but on this page (from the search bar): I see it nowhere: github.com/search?utf8=%E2%9C%93&q=vba&type=

Mathieu Guindon

VBA-WEB repo doesn't have any topics listed, that's why RD is #1 in topics

@this select "most stars" from the dropdown

this

but that's what I did earlier....

OMG

GH is awful

Mathieu Guindon

lol

this

sorry, it's appalling

because as you noted it's by topics

Mathieu Guindon

"topics" is basically the arbitrary "tags" one can put on their repo

it's a relatively new feature

2 mins ago, by Mathieu Guindon

VBA-WEB repo doesn't have any topics listed, that's why RD is #1 in topics

this

6:54 PM

yet, if I go to this: github.com/search?q=vba&type=Topics&utf8=%E2%9C%93

it's different than what I saw earlier though it's "topics"

Mathieu Guindon

that said we're going to be #1 in vba-ide for a looooong while :)

this

GH deserves a big fat F on discoverability from me, FWIW.

Mathieu Guindon

@this yeah, as I said the "vba" repos that have more stars than RD don't necessarily have their "topics" configured

@this and that

huh, the help-wanted label translates into "n issues need help" on the find page

this

7:08 PM

another thing to note --- RD has no license listed

on the other 2 project they have MIT License marked

RD says nothing.

Mathieu Guindon

huh

Duga

[rubberduck-vba/Rubberduck] web-flow pushed commit 2977e394 to next

Rename license to license.md

added file extension

Mathieu Guindon

@this and now?

this

and something's wrong - ClosedXML isn't even a vBA project. so what's it doing ther?

FreeMan

@Hosch250 That's the one!

Mathieu Guindon

7:10 PM

@this well, RD isn't a VBA project either ;-)

this

nope.

github.com/…

well it's not written in VBA, but it certainly deals with VBA

ClosedXML, otoh, has nothing to do with VBA whatsoever, AFAICT

it's just an OM for the open XML

Mathieu Guindon

> ClosedXML makes it easier for developers to create Excel 2007+ (.xlsx, .xlsm, etc) files. It provides a nice object oriented way to manipulate the files (similar to VBA) without dealing with the hassles of XML Documents. It can be used by any .NET language like C# and VisualBasic.NET.

this

yeah. But it's for and consumed by .NET

heck, there's no vba tag there.

#GoFigure

Mathieu Guindon

yeah but the description saying "VBA" is enough for it to be found when searching across github for "VBA" ;-)

this

so not only GH get a big fat F in discoverability, they're going to get another F in their ranking alogrithm

one lone mention of word should have been a flag that it might be just.... tangent

Mathieu Guindon

7:15 PM

ok off-topic, but help me out here. on Outlook.com when I hover my avatar at the bottom of any email's "reply" section, a "card" pops up and I can expand it by clicking on it. Under "coordinates", it's listing a work email I was using in 2012, that I'd like to remove... and it's nowhere in my MS account.

so.. wth?

my profile's "contact info" only has 1 email address, the correct one

this

sorry not familiar with outlook.com. Still using outlook the old skool way.

Duga

[rubberduck-vba/Rubberduck] web-flow pushed commit d1fafb5d to next: Rename license.md to LICENSE.MD

[rubberduck-vba/Rubberduck] web-flow pushed commit 6b0bb113 to next: Create LICENSE

[rubberduck-vba/Rubberduck] web-flow pushed commit 45b047f0 to next: Delete LICENSE.MD

Mathieu Guindon

still not showing

wtf

blaming caching for now

Duga

7:31 PM

[rubberduck-vba/Rubberduck] web-flow pushed commit 7a599fe6 to next

Update README.md

changed contact email to devs mailing list

Mathieu Guindon

ping'd GH support

Vogel612

ugh... having to change the build-pipeline on a project that currently only builds when skipping tests. ...

and I got 1 CPU on 100% for building the UI of the project rn...

this is madness

Tweeting Duck

7:59 PM

Hey @GitHubHelp why isn't my GPLv3 license showing up on the http://github.com/search page? Other repositories have "MIT license" showing up, expecting mine to say "GPLv3 license". Ideas?

Tweeted by rubberduckvba on March 20, 2018 at 7:34 PM

Link: https://github.com/search?o=desc&q=vba&s=stars&type=Repositories&utf8=%E2%9C%93

Tweeted by rubberduckvba on March 20, 2018 at 7:45 PM in reply to rubberduckvba

IvenBach

8:53 PM

Public Property Get DistributedRoofLiveLoad() As Double
    DistributedRoofLiveLoad = Me.Range("DistributedRoofLiveLoad").Value2
End Property
Public Property Let DistributedRoofLiveLoad(ByVal RHS As Double)
    Me.Range("DiscributedRoofLiveLoad").Value2 = RHS
End Property

Public Property Get PointRoofLiveLoad() As Double
    PointRoofLiveLoad = Me.Range("PointRoofLiveLoad").Value2
End Property
Public Property Let PointRoofLiveLoad(ByVal RHS As Double)
    Me.Range("PointRoofLiveLoad").Value2 = RHS

I'm trying to wonder if it'd be a CodeSmell to have both properties under RoofLiveLoad(byval loading as RoofLoading)

IvenBach

9:07 PM

@Hosch250 For the CodeExplorer Add button. Is it possible to provide a name before so it doesn't add and then you have to rename?

I'd guess it's the way it is because of a limitation on the VBE.

Hosch250

Should be easy enough.

Pretty sure the VBA API takes a parameter for the name.

IvenBach

I'll issue it then.

Hosch250

Should be something you could do. You can probably reuse the Rename window.

IvenBach

You're referring to RtClick>Rename?

Hosch250

Yep.

Mathieu Guindon

9:12 PM

@IvenBach IIRC there's an open issue for that

IvenBach

I do that often. I'd like to have a dialog open requesting the name before it's inserted to avoid Insert -> RD Parse, Rename -> and waiting for both.

Mathieu Guindon

RD can't rename a module it doesn't know exists

Hosch250

No, but the Rename UI can probably be reused.

Mathieu Guindon

yes

but it still would be insert > RD parse > rename > wait

IvenBach

But it'd be 1 step instead of 2.

Hosch250

9:15 PM

So, the VBA API doesn't take a parameter? I thought I'd seen that it did at one point. #PullingBunniesOutOfThinAir

Mathieu Guindon

the API takes a component type parameter, that's all :)

Hosch250

On the other hand, that would explain why it didn't prompt when we first implemented it.

Mathieu Guindon

our wrappers would have to provide the overload

IvenBach

Is it worth creating the new issue/feature request?

Hosch250

Hmmm... Could we "import" a string?

Mathieu Guindon

9:17 PM

@IvenBach it's already there

Hosch250

Then we could populate a string template and import it.

Mathieu Guindon

you still need to name the module

this

that can be done as part of import

I think Hosch has it right - importing is probably better.

Mathieu Guindon

yes. but we need it to disable event hooks

this

"wait, I'm the one doing that?"

Hosch250

9:18 PM

We need to have a way to disable those from anywhere in the project anyway.

this

there is sort of.

Mathieu Guindon

^

this

you have the VBEEvents.Terminate and VBEEvents.Initialize

Hosch250

Then disabling event hooks is the least of our problems.

this

though I didn't really mean to be use like that

ATM, it's used only at the startup adn shutdown

and besdies it was pointed out that our hotkey shouldn't have to be constantly hooked + unhooked

Mathieu Guindon

9:19 PM

@Hosch250 yes and no. you don't want the wrappers to do that.

do the wrappers even see VBEEvents?

this

they know nothing

all wrappers individually raise the events, if they are asked to

well, those that implements IComEventedWrapper

IvenBach

@MathieuGuindon I tried searching for the issue but couldn't find it. Do you recall a word to help locate it?

this

then VBEEvents is one that takes events from VBProjects and VBComponents

and basically acts as one big old sink

Mathieu Guindon

hmm but VBEEvents is in the same assembly, so it's technically possible

this

so it's simpler for us from .NET side; we only care about VBEEvents' event

Mathieu Guindon

9:21 PM

but I have a problem with the wrapper classes enabling and disabling events. it's not their job

this

no chasing random unknown component.

well, wrappers has to be

those htat implements the interface has 2 methods... AttachEvents and DisableEvents

Mathieu Guindon

@IvenBach 2031

this

which simply indicate that we are wanting to listen to events for that instance of the component

no, sorry, DetachEvents

anyway, VBEEVents calls those internally as part of its setup

Mathieu Guindon

I'd rather have that implemented as part of the feature itself

this

sorry not following

isn't the need to disable the events becuase we don't want RPS or whatever acting on our importing/renaming?

Mathieu Guindon

9:23 PM

we were discussing modifying the wrapper classes so that the VBComponents.Add method could take a name, and apply it immediately, right?

so, I don't think that should be implemented in the wrappers themselves

the "add module" feature would have to do it

and coordinate the prompting, disabling, adding, renaming, and re-enabling

(prompt first, if user cancels you bail out)

Duga

[rubberduck-vba/Rubberduck] IvenBach commented on issue #2031: When creating a new module, prompt for an immediate rename

> Don't let CodeExplorer get all the love. UnitTest>TestModule needs this as well.

Mathieu Guindon

@Duga good point

Hosch250

FWIW, unit tests would be an awesome use of this feature.

Currently we add the module, parse, add the text, parse.

If we imported instead, we could get rid of that double-parse.

IvenBach

:+1: for that

Hosch250

Also, we could add any attributes we liked right away this way.

this

9:27 PM

the sucky thing about is that ATM, the VBEEVents.Initialize and VBEEVents.TErminate are static.... (e.g. untestable)

becuase I really didn't expect it'd be use mid-session like so

wait

no, we shouldn't be monkeying with VBEEVents

WE should be telling RPS to not regard the events that comes becuase it's us

that way you stay purely within .NET

no additional COM access

Mathieu Guindon

@this I can agree with this

Hosch250

Precisely.

IvenBach

A year ago I'd never have thought of having written 101 unit tests, and counting.

Hosch250

@IvenBach Remember when we finally got that many in RD, @MathieuGuindon?

Mathieu Guindon

lol

IvenBach

9:33 PM

#GottaStartSomewhere

Mind-blowing how much progress I've because of my failures.

Hosch250

They weren't failures if they got you this far.

Just because something doesn't work doesn't mean you failed.

It means you know what not to try next time.

They say you aren't a master until you've made 10k mistakes, so...

Mathieu Guindon

hmm, it's not 10K rep on SO?

this

i liked one saying I came across --- Experience is recognizing the mistake when you make it again.

Hosch250

@MathieuGuindon Definitely not.

IvenBach

<CrotchetyOldManVoice>I still see them as failures. My goal wasn't achieved.</CrotchetyOldManVoice>

I chose to learn from those mistakes, that's the key difference IMO.

Mathieu Guindon

9:36 PM

TTQW

IvenBach

Be safe mug.

Hosch250

Taking off here too.

Duga

[rubberduck-vba/Rubberduck] IvenBach commented on issue #2031: When creating a new module, prompt for an immediate rename

> Don't let CodeExplorer get all the love. UnitTest>TestModule needs this as well. Same for TestMethod too.

Transcript for