RELOAD!

[retailcoder/Rubberduck] 19 commits. 745 additions. 451 deletions.

[rubberduck-vba/Rubberduck] 4 commits. 4 opened issues. 2 closed issues. 14 issue comments. 92 additions. 99 deletions.

[skiwi2/bit-vector] 3 commits. 16 additions. 39 deletions.

[Vogel612/TranslationHelper\‌​] 3 commits. 2 issue comments. 41 additions. 24 deletions.

[rubberduck-vba/Rubberduck] ThunderFrame created pull request #1701: Adds Unit Test support for MS Project, adds basic bitmap copy of Code Explorer treeview to merge ThunderFrame/Rubberduck/next into...

rubberduck-vba/Rubberduck/next

> Code Explorer bitmap needs to work with larger projects, but is usable with the visible treeview area for now

hi @MitropoulosMitropoulos lots of parsing fixes lately. Does your project parse in new builds?

@ThunderFrame what up! Sorry - I've been crazy busy with work lately and havent had a second to open any new builds (or keep up with what you guys have been up to, for that matter)

I was sorta kinda thinking I would wait for the beta, but if you think now is a good time to see what happens when I open some files, I can put that at the top of my list for Monday

There was a parsing bug for any module that had more than 1 WithEvents statement. I think you might just have that in your codebase?

lol

well, I haven't seen any... but there are oceans of the codebase I try not to look at, haha

so I wouldn't be surprised if there is

[rubberduck-vba/Rubberduck] build for commit 45243293 on unknown branch: AppVeyor build succeeded

(much of it wasn't written by me, or by anyone in the last 5-10 years, for that matter)

@Mat'sMug @ThunderFrame @Hosch250 @Vogel612 @awgaya Let's do this, just let me know when you would like me to pull the latest build and try opening files. I was thinking I would wait until the beta, but I am happy to do what goes best for you guys. The thing is I don't have a ton of time (sadly) to devote since things have been busier than usual lately - hence me wanting to wait until a maximally impactful exploration into the Fangorn woods that is my codebase is possible.

@MitropoulosMitropoulos Well, a beta is imminent. If you're pressed for time, wait for the beta. If you find a spare chunk of time, build and break rejoice.

[rubberduck-vba/Rubberduck] PeterMTaylor opened issue #1702: Code Explorer - Is the Visual Studio still waiting for thread to finish in UI?

[rubberduck-vba/Rubberduck] PeterMTaylor opened issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1702: Code Explorer - Is the Visual Studio still waiting for thread to finish in UI?

> The icon is part of the design of the form. You should only see it while the form is refreshing. I can't see your status toolbar, so I assume you got stuck on a Parse? IIRC this icon remaining visible is indicative of a parse failing because there is more than 1 workbook open

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1700: TLB crawler should collect helpfile and helpcontext IDs for TypeInfo members

[rubberduck-vba/Rubberduck] LNow opened issue #1704: Releasing COM objects.

[rubberduck-vba/Rubberduck] Vogel612 commented on issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

When I was working on #1703 I got a NRE in the ReferenceDeclarationsCollector

member.ModuleDeclaration was null on Line 297. @Mat'sMug that's your turf, right?

[rubberduck-vba/Rubberduck] autoboosh commented on issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

[rubberduck-vba/Rubberduck] autoboosh added label bug to issue #1705: Parameter default value builds wrong parse tree

[rubberduck-vba/Rubberduck] autoboosh opened issue #1705: Parameter default value builds wrong parse tree

[rubberduck-vba/Rubberduck] autoboosh added label vba-grammar to issue #1705: Parameter default value builds wrong parse tree

[rubberduck-vba/Rubberduck] autoboosh edited issue #1705: Parameter default value builds wrong parse tree

[rubberduck-vba/Rubberduck] autoboosh added label bug to issue [#1706: Wrong parse tree for [basetype]](github.com/rubberduck-vba/Rubberduck/issues/1706)

[rubberduck-vba/Rubberduck] autoboosh added label vba-grammar to issue [#1706: Wrong parse tree for [basetype]](github.com/rubberduck-vba/Rubberduck/issues/1706)

[rubberduck-vba/Rubberduck] autoboosh opened issue [#1706: Wrong parse tree for [basetype]](github.com/rubberduck-vba/Rubberduck/issues/1706)

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

> restLibrary appears to be this github.com/brucemcpherson/excelRestLibrary/blob/master/scripts/…

eurgh... tried to work around that NRE and got one in GetHashCode() for QualifiedModuleName instead

wtf?

that should basically be impossible

[rubberduck-vba/Rubberduck] autoboosh commented on issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

> Thanks. Looks like that parses fine here in a reasonably amount of time (1sec, times 10 on a normal PC).

[rubberduck-vba/Rubberduck] autoboosh commented on issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

> Thanks. Looks like that parses fine here in a reasonable amount of time (1sec, times 10 on a normal PC).

[rubberduck-vba/Rubberduck] autoboosh commented on issue #1697: Hide COM objects behind API

> I feel like we're talking about different things? What I meant is that we don't use e.g. VBComponent anywhere in code but at one place, where it would be used to create a "normal" CLR class. We would simply extract all information we need (e.g. the name, display name, ...). The rest of the codebase would only use those non-COM classes.

@Vogel612 how did you trigger that bug?

example code etc?

#1703, and then add a null-check on line 297 in ReferenceDeclarationsCollector

if (member.ModuleDeclaration != null && [...]

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1704: Releasing COM objects.

[rubberduck-vba/Rubberduck] retailcoder merged pull request #1699: Generalized RD's ignorance of IDispatch and IUnknown members. from comintern/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder pushed commit 1d5a7af8 to next

[rubberduck-vba/Rubberduck] retailcoder merged pull request #1701: Adds Unit Test support for MS Project, adds basic bitmap copy of Code Explorer treeview from ThunderFrame/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder pushed commit b96664e3 to next

[rubberduck-vba/Rubberduck] build for commit 1d5a7af8 on next: AppVeyor build succeeded

about in-process COM, is this relevant to us? stackoverflow.com/questions/159313/…

[rubberduck-vba/Rubberduck] build for commit b96664e3 on next: AppVeyor build succeeded

@awgaya I wonder if it applies to VBE addins, and if anything about it changed between Office 2007 and 2010

(Q/A's from 2008)

[rubberduck-vba/Rubberduck] transistor1 commented on issue #1704: Releasing COM objects.

[rubberduck-vba/Rubberduck] transistor1 commented on issue #1704: Releasing COM objects.

> BTW... Mike Rosenblum (Mr. Excel) is a great source for this. He has written a ton of stuff on this topic. Heres one stackoverflow.com/a/159419/864414

[rubberduck-vba/Rubberduck] LNow commented on issue #1704: Releasing COM objects.

[rubberduck-vba/Rubberduck] LNow commented on issue #1704: Releasing COM objects.

[rubberduck-vba/Rubberduck] comintern commented on issue #1703: Parser Error reported - no further information provided to help me understand why it failed.

here it comes...

[rubberduck-vba/Rubberduck] ThunderFrame created pull request #1707: Adds Unit Tests to Outlook to merge ThunderFrame/Rubberduck/next into rubberduck-vba/Rubberduck/next

> @ckuhn203 This one's for you.

[rubberduck-vba/Rubberduck] build for commit 6ac19794 on unknown branch: AppVeyor build succeeded

what was that with outlook tests and someone eating his hat?

or his rubberdudck?

yep - I have reminded him

TTGTB

good night

[rubberduck-vba/Rubberduck] ckuhn203 commented on pull request #1707: Adds Unit Tests to Outlook

> Beautiful hack! Just a couple of things. Why the empty catch? Mind adding some comments explaining why we need the hack to begin with? The current team know, but future maintainers might not immediately understand that Outlook doesn't have an Application.Run() method.

should we give netoffice another try?

@awgaya - I've been playing around with this, and AFAICT the comment @Mat'sMug made is closer to how RD is behaving. If the RCW was forcing COM objects to stay loaded, I'm not sure we could be getting 0x80070006 errors. Those are pointing to the opposite problem - the unmanaged side is releasing objects that the managed side still has open references to.

[rubberduck-vba/Rubberduck] retailcoder merged pull request #1707: Adds Unit Tests to Outlook from ThunderFrame/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder pushed 36 commits to next (only showing some of them below)

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit 81399f58 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit a08aaa9a to next: Fixes conflict

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit 44eb5afd to next: fixes merge conflict

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit 9137c48d to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit bcca2421 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit d97aa9c5 to next

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit 45243293 to next: Adds MS Project Application.Macro method

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit 53ffeb56 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

[rubberduck-vba/Rubberduck] ThunderFrame pushed commit 6ac19794 to next

[rubberduck-vba/Rubberduck] retailcoder pushed commit ccd6225f to next

@Mat'sMug - I just did some testing and from what I'm seeing, the GC isn't releasing COM references. Test code:

        public void GarbageCollectionReleaseTest(VBE vbe)
        {
            var unknown = GetReferenceCounter(vbe);
            //guineapig and duplicate lost scope and should be eligible for collection at this point.
            GC.Collect();
            GC.WaitForFullGCComplete();
            Debug.WriteLine("References after GC.WaitForFullGCComplete: {0}", ReadReferenceCount(unknown));
        }

        public IntPtr GetReferenceCounter(VBE vbe)
        {
            //Get a marshalled VBProject. RCW gets one reference here.

[rubberduck-vba/Rubberduck] build for commit ccd6225f on next: AppVeyor build succeeded

Output:

References after guineapig created: 3
References after duplicate created: 3
References after GC.WaitForFullGCComplete: 3

So.. releasing wouldn't change anything right?

The second line seems to confirm that the RCW only keeps a single reference (unless that gets optimized away).

Excel seems to stop crashing on exit if I release the objects in my test addin.

The real WTF is this one:

References after guineapig created: 3
References after duplicate created: 3
References after Marshal.FinalReleaseComObject(guineapig): 1

I think I may need to find a way to run the same tests without involving the marshaller at all. Might be tricky, but I think OLE has native APIs I can use.

The best part about this is, that I have not even the slightest clue as to wtf you're doing :D

[rubberduck-vba/Rubberduck] transistor1 commented on issue #1704: Releasing COM objects.

[rubberduck-vba/Rubberduck] transistor1 commented on issue #1704: Releasing COM objects.

Gah! Trying to determine how unmanaged code reacts to Interop interactions using C# is like trying to peek at Schrödinger's IUnknown.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1704: Releasing COM objects.

> NetOffice isn't going to cut it, as we found out last year (see #113). Has anyone succeeded in creating a docked toolwindow with the NetOffice PIA's? There's a number of things Office and VBE add-ins are very different about.

OK, apparently child Interop object do not get released after the parent is released and garbage collected. I put a call to Marshal.FinalReleaseComObject(vbe); into the reference counting test above, and the guineapig gets garbage collected, but never decrements its reference count on the COM side.

I'm coming to the conclusion that we need to start explicitly releasing references.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1704: Releasing COM objects.

> NetOffice isn't going to cut it, as we found out last year (see #113 and PR #617). Has anyone succeeded in creating a docked toolwindow with the NetOffice PIA's? There's a number of things Office and VBE add-ins are very different about.

@Comintern ok.. boy this is going to get ugly

The lifetime management would be the hard part.

FWIW I am NOT switching to NetOffice at this point in the project

God no. I wouldn't do that regardless of the point in the project. I'm too much the control freak.

high five

What I still don't get is how RD can be throwing 0x80070006 errors. That points to exactly the opposite problem. Leaking COM instances should prevent those.

Possibly relevant, and make me realize that I've never run a release build of anything after the 1.4 version.

> The debugger usually gets them on the Wrong Path, they want the Office program to exit on demand. The appropriate way to do that is by calling GC.Collect(). But they'll discover that it doesn't work when they debug their app, leading them into never-never land by calling Marshal.ReleaseComObject(). Manual memory management, it rarely works properly because they'll easily overlook an invisible interface reference. GC.Collect() actually works, just not when you debug the app.

Very interesting

Even Microsoft can't agree on this: One the one hand, Marshal.ReleaseComObject Considered Dangerous. On the other, Mixing deterministic and non-deterministic cleanup.

I think @Vogel612 just came up with a new inspection title:

> The best part about this is, that I have not even the slightest clue as to wtf you're doing :D

lol

OK, tested in release mode. All of the COM objects get released properly by the GC. The issue that causes Excel to remain open then crash with an access violation is related to concurrent garbage collection. If I disable it, everything seems to work just fine.

[rubberduck-vba/Rubberduck] PeterMTaylor commented on issue #1702: Code Explorer - Is the Visual Studio still waiting for thread to finish in UI?

> To be honest, this was the only workbook open.

@Comintern awesome!

@Mat'sMug - Actually, I think that may also prove to be problematic. Although it does indicate that the GC is doing it's job at releasing COM objects. I do think that the thread pool needs to be rejoined into the main process before the final GC runs. A couple times I was able to trap errors that suggested that they were making COM calls on objects that had been already been released as the GC was running.

Can we do that in the app teardown code?

Yep, I think so. App gets held open as RD is closing because it's the last thing that gets disposed before the Ninject kernel in OnDisconnection.

I'm running 32-bit Excel, so I can add ActiveX controls to a worksheet. Does anyone that is using 64-bit know what the Developer Insert menu looks like, and what Excel does when it open a workbook with ActiveX controls on the sheets?

^ That's the 32-bit Tab.

Thanks, so there are ActiveX controls in 64-bit...

[ckuhn203/VBEX] ericawarren starred us

[retailcoder/Rubberduck] retailcoder pushed 40 commits to next (only showing some of them below)

[retailcoder/Rubberduck] retailcoder pushed commit 8428eb47 to next

[retailcoder/Rubberduck] ThunderFrame pushed commit bcca2421 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

[retailcoder/Rubberduck] ThunderFrame pushed commit d97aa9c5 to next