RELOAD!

[Hosch250/Rubberduck] 71 commits. 71370 additions. 55649 deletions.

[retailcoder/Rubberduck] 35 commits. 2158 additions. 613 deletions.

[rolfl/MicroBench] 1 commit. 2 additions. 2 deletions.

[rubberduck-vba/Rubberduck] 11 commits. 2 opened issues. 2 closed issues. 16 issue comments. 9285 additions. 8190 deletions.

We're alive!

[skiwi2/sieve-multithreaded-shared] 2 commits. 150 additions. 8 deletions.

Just noticed, 2.0 is a whole megabyte larger than 1.4.3

@Mat'sMug We've done a lot of work.

In fact, we've literally re-written almost everything.

IKR

#RememberRefactorMenu

There are only a few files that haven't seriously changed.

It's 2.0 for a reason =)

@Gareth I'm still working on the Paste Specials. My train line has bus-replacements at the moment, so not conducive to getting stuff done

[Hosch250/Rubberduck] Hosch250 pushed commit c7f5c081 to bugs: Hard-code aliases as functions for resolver

There's one bug that should be 2-3 issues closed.

@Mat'sMug Perfect. I saw that in the TodoExplorer menu, but it didn't seem like I should be just using a string there. Anyway, I've just modified and now I have:

So its working the way I wanted:

I just need to pull in some data now. Might push through some dummy data initially.

@Rossco That isn't a plain string--it is the name of a resx value.

[Hosch250/Rubberduck] build for commit c7f5c081 on bugs: AppVeyor build succeeded

@Mat'sMug @Hosch250 what do you think regarding a dialog vs a toolwindow. The toolwindow can be non-modal and dockable and can listen for changes to the active project. Obviously the dialog will have similar UX to the builtin one.

I'd say dialog if it is just a reference picker.

It doesn't have to be though. It can be anything you want.

We are going to make the Code Explorer display the active references, or something, I heard.

Maybe, you can search the types inside a library...

@Mat'sMug What's up with that?

@Rossco I don't care, make it dockable if you want.

It won't hurt anything, although people might not leave it docked too often.

I'm not trying to be difficult BTW. I'm just trying to think outside the box..

I'd rather it be a dialog TBH. That ducky icon will be a legend soon =)

[Hosch250/Rubberduck] Hosch250 pushed commit 753825f8 to bugs: Prevent hard-coded declarations from having their references cleared for parse attempts with no changes

@Mat'sMug OK cool.

[rubberduck-vba/Rubberduck] Hosch250 created pull request #1923: Untyped functions are now resolved correctly to merge Hosch250/Rubberduck/bugs into rubberduck-vba/Rubberduck/next

> Close #1918

Besides we already have enough toolwindows to hide the whole code pane lol

What dependency should i pull in to get notified about the ActiveProject changing and retrieving a reference to it?

@Rossco that's the thing.. only App knows when the active project changes. Making it a modal dialog makes things simpler imo

[Hosch250/Rubberduck] build for commit 753825f8 on bugs: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit 753825f8 on unknown branch: AppVeyor build succeeded

The important stuff is really the tabbed control, to clearly separate prioritization, COM references, and project (VBA) references... and the default tab ought to be the favorites/recent tab

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1405: StringVariant Returning functions QuickFix breaks code.

> Whoever wrote this bug deserves to be shot. The trouble is it is a simple search/replace, and Hex gets replaced twice...

@Duga @Mat'sMug Want to review that PR?

@Duga hides

@Hosch250 putting the kids into bed

OK.

@Duga ~cranks shotgun

It looks like it is me and @Mat'sMug.

It was designed without considering Fix All.

And I refined it.

why not make it simple and use ReplaceAll("(gi?)(hex(?>!\$))", "\1$");

Because it isn't just Hex...

It could be any of these 21:

then run it in a loop

@Mat'sMug Ok, you've twisted my arm ;P

private readonly string[] _tokens = {
    Tokens.Error,
    Tokens.Hex,
    Tokens.Oct,
    Tokens.Str,
    Tokens.CurDir,
    Tokens.Command,
    Tokens.Environ,
    Tokens.Chr,
    Tokens.ChrW,
    Tokens.Format,
    Tokens.LCase,
    Tokens.Left,
    Tokens.LeftB,
    Tokens.LTrim,
    Tokens.Mid,
    Tokens.MidB,
    Tokens.Trim,
    Tokens.Right,
    Tokens.RightB,
    Tokens.RTrim,
    Tokens.UCase
};

it ain't that hard to assemble the pattern for each token

I don't like Regex, that's why.

you could even go so far as to make the capture group built of all of those with string.Join("|", ..); or so

And if I did do that, I'd just manually check the next character anyway.

@Vogel612 and VBA.Strings.Left should match, but not VBProject.Module1.Left

okay that makes it harder

like... just a teeny tiny bit

Wait, Strings.Left works too, but not if you have usercode with a std module named Strings having a Left method

How's the tiny bit now? lol

Oh wait--just plain Left works too.

Yep

RegexAssistant was easier than this

Unless there's a usercode Left function in scope

But depends on the location--we can have other plain lefts.

Right.

@Vogel612 On a more serious note, the resolver does all the work--I just need to either support fixing all, or disable that option.

var result = lines.Replace(originalInstruction, newInstruction);

I need to change that to focusing on the selection.

@Hosch250 does it?

@Mat'sMug Now that I hard-coded those, yes.

PAAAAAAARRRRRRTY!!!

They aren't resolved to _B_var_Left, but it shouldn't be too hard to shift the references to it once it is resolved.

Right

Or, does it even matter that they aren't resolved to it?

Not if we can still tell Chr from Chr$

@Mat'sMug Well, the inspection works correctly, as far as I can tell.

Although, it would be nice to not lie too much to the users :-)

@Hosch250 @Vogel612 Just change that with:

            var result = lines.Remove(Context.Start.Column, originalInstruction.Length)
            .Insert(Context.Start.Column, newInstruction);

@Mat'sMug As far as I can tell, we can't directly reference _B_var_Left in VBA.

@Hosch250 how's that going to work with the tree thing? Context won't be accessible right?

@Hosch250 right

@Mat'sMug So, no need to do it then.

@Mat'sMug When I get that done, everything will need to be re-written.

And when I say everything, I mean everything that touches the code.

Ah, well nevermind then

@Hosch250 that's pretty much everything lol

@Mat'sMug Right, and we use Context everywhere anyway.

One more usage in 2.0 isn't going to hurt anything.

We'll be on 2.x for a while I think

@Mat'sMug Oh, it also means everything that touches the declarations.

@Mat'sMug Sounds like when we were working on 1.4.

After 1.4.3, we were working on 1.5 with DI, and it became 2.0.

LOL, we had everything broken, and by the time it came together, it was just 2.0.

@Mat'sMug In a week and a half 1.4.3 will have been out for a full year.

[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #1923: Untyped functions are now resolved correctly

[Hosch250/Rubberduck] Hosch250 pushed commit 507ee656 to bugs: Close #1405

20 more minutes to go. What should I work on?

@Hosch250 take the rest of the day off, you earned it ;-)

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1134: Remember expanded/collapsed state of TreeView nodes and GroupingGrid groups

> Code Explorer remembers which nodes were open, and the Code Inspections sorts correctly now. Only thing left is leaving Grouping Grid group states the way they were. Is that even worth it, or should we close this now?

@Mat'sMug I can't. I have to report 40 hours a week.

And I would hardly say I earned it after getting literally next to nothing done all morning and early afternoon.

lol... go over open issues, I'm sure there's a bunch of older ones that can be closed already

Yeah, I'm doing that.

Did you notice you brought it down from 26% to 20%?

Brought what down?

% of opened issues

Nice.

6 days | 20%

Do you know that I brought the percentage 2.0 is finished up to 89%?

[rubberduck-vba/Rubberduck] Hosch250 assigned Hosch250 to issue #1918: Parser Confuses Application.Left with Left Function

[rubberduck-vba/Rubberduck] build for commit 507ee656 on unknown branch: AppVeyor build succeeded

@Hosch250 that's awesome!

[rubberduck-vba/Rubberduck] Hosch250 assigned Hosch250 to issue #1405: StringVariant Returning functions QuickFix breaks code.

[Hosch250/Rubberduck] build for commit 507ee656 on bugs: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #357: "Procedure not used" is a problem for native interface implementations

> What's up with this? Does the COM collector make this obsolete?

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1772: Renaming a TestModule when 2 or more unit-test documents are open results in Resolver error

> @ThunderFrame Can you verify that this is an issue on the latest release?

[rubberduck-vba/Rubberduck] Hosch250 assigned rossknudsen to issue #1276: Add/Remove Project References Dialog

@Rossco Here's the issue for your thing: github.com/rubberduck-vba/Rubberduck/issues/1276

Also, take a look at this: github.com/rubberduck-vba/Rubberduck/issues/950

And this: github.com/rubberduck-vba/Rubberduck/issues/1593

Not sure what will happen with the last one.

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1828: Return value of function 'iReturnSomething' is never used

> There have been two releases since this issue was created. Can you verify that it is still an issue?

[rubberduck-vba/Rubberduck] Hosch250 unassigned retailcoder from issue #1475: COM reflection needs to pick up method aliases

[rubberduck-vba/Rubberduck] Hosch250 assigned Hosch250 to issue #1475: COM reflection needs to pick up method aliases

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1475: COM reflection needs to pick up method aliases

> We just hardcoded these.

[rubberduck-vba/Rubberduck] Hosch250 edited pull request #1923: Untyped functions are now resolved correctly

See you.

@Hosch250 Cheers for the info.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1593: Code Explorer should show References to other VBA projects, just like Project Explorer

> @Hosch250 we'll make a dedicated References folder (the blue folder icons) under each project, and list all references - not just references to other VBA projects. "Find all references" will then locate all code that references anything from the selected project reference, fully qualified or not. The context menu will need an "Add/Remove references..." item, to bring up the RD references dialog.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1593: Code Explorer should show References to other VBA projects, just like Project Explorer

> Hmm we could also dim references that aren't used anywhere.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #357: "Procedure not used" is a problem for native interface implementations

> @Hosch250 completely

[rubberduck-vba/Rubberduck] retailcoder closed issue #357: "Procedure not used" is a problem for native interface implementations

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1593: Code Explorer should show References to other VBA projects, just like Project Explorer

> @retailcoder like #1733?

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1593: Code Explorer should show References to other VBA projects, just like Project Explorer

@Comintern Check out this link which calls members of IDispatch from VBA, using DispCallFunc

[rubberduck-vba/Rubberduck] web-flow pushed commit c751d9c5 to next: Update README.md

[rubberduck-vba/Rubberduck] build for commit c751d9c5 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder edited wiki page Todo Explorer

@Mat'sMug Holy smokes, revert that right now.

lol

What in the world did you do?

Is that the old settings?

yep

I don't see the General Settings tab.

> the wiki is outdated

That must be 1.2, or so.

1.22

@Mat'sMug Can you move most of that into the website?

did that work in 64-bit?

BTW, did I ever PR my SC changes to the main repo?

btw - I can reproduce the date literal line continuation

the old historical screenshots?

@ThunderFrame Yeah, theoretically. The installer didn't really, though :P

@ThunderFrame Uh, how?

then add the line-continuation after "("

That is allowed, isn't it?

and it becomes

We don't allow a line continuation after the "#".

and it runs!

Oh, huh.

Please kill me.

I'll fix that tomorrow--easy fix. Reopen the issue, if you please.

lol

[rubberduck-vba/Rubberduck] Hosch250 assigned Hosch250 to issue #1917: Parser Error for Multi-Line Date Array

[rubberduck-vba/Rubberduck] Hosch250 reopened issue #1917: Parser Error for Multi-Line Date Array

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1917: Parser Error for Multi-Line Date Array

> We figured out how to reproduce this. Expect a fix next release.

It just involves putting an optional line continuation in the lexer rule, and maybe a little bit of change in the date grammar.

the inspection that checks for parameters declared on multiple lines, I think it could be expanded to any variable/parameter/constant declared on multiple lines

hmm it wouldn't pick that up

After we get the hotkeys working a little better, everything seems to be running smoothly enough for a stable release.

Unless we get more critical issues.

@Mat'sMug I think I've thought through the process of that Source Control issue, and I'm not sure we can fix it.

If it is what I think it is, it doesn't really change the project itself.

it just crashed on me

unit tests are flaky

What happens is, the next time it loads, RD detects it is under source control, removes everything, and only reloads the modules in source control.

If we can't finish exporting (like a force-close like that guy did), we can't fix it.

let's get them off the parser state, we're going to have to get them off the parser state anyway

hmm, once the lin-continuation is there, and the code is "valid", any edit to the line will break the code....

@Mat'sMug Then why did you have me put them on the parser state?

@ThunderFrame @Mat'sMug Should I leave the issue closed then as too unstable?

@Hosch250 TBH I think it would be fine if we only parsed a method and were very efficient with keeping up with what's going on in the IDE. but an empty project with nothing but a test module takes too long to reparse every time a test method is added... we had a better UX before, and we won't be able to achieve the same speed with the current way we're doing things.

I mean, you must have noticed?

Not really, except in large projects.

Empty ones are pretty fast.

hmm wait a sec

damn

my home build isn't up-to-date

Build 2.0.2.38138

building

@Hosch250 shouldn't the build number be 2.0.3 in the about box?

I have 2.0.2.41940

@Mat'sMug Umm, I only changed the main Rubberduck dll, I think.

I don't know.

Oh, I didn't PR that.

If you download it, it should be OK.

hmm, why isn't the Test Explorer letting me add a new test method even though a test module is active?

and parser state is Ready

You don't have any code running, do you?

I can repro this. What happened, I wonder?

[rubberduck-vba/Rubberduck] retailcoder commented on pull request #1922: Remove unneeded logging

> I think we should discuss this PR in an "issue" - let's discuss and lay down exactly what we want to log at which log level, and sync this PR with the results; outright removing all log output at once? not sure. Thoughts?

[rubberduck-vba/Rubberduck] retailcoder closed issue #1475: COM reflection needs to pick up method aliases

[rubberduck-vba/Rubberduck] retailcoder merged pull request #1923: Untyped functions are now resolved correctly from Hosch250/Rubberduck/bugs into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder closed issue #1405: StringVariant Returning functions QuickFix breaks code.

[rubberduck-vba/Rubberduck] retailcoder closed issue #1918: Parser Confuses Application.Left with Left Function

[rubberduck-vba/Rubberduck] Hosch250 pushed commit e052769c to next: Fix hard-coded declarations for form parameters (make them be byref instead of byval)

[rubberduck-vba/Rubberduck] Hosch250 pushed commit c7f5c081 to next: Hard-code aliases as functions for resolver

[rubberduck-vba/Rubberduck] Hosch250 pushed commit 753825f8 to next: Prevent hard-coded declarations from having their references cleared for parse attempts with no changes

[rubberduck-vba/Rubberduck] Hosch250 pushed commit 507ee656 to next: Close #1405

[rubberduck-vba/Rubberduck] web-flow pushed commit fe4fe8d9 to next

[rubberduck-vba/Rubberduck] Hosch250 commented on pull request #1922: Remove unneeded logging

[retailcoder/Rubberduck] web-flow pushed commit d1eaa393 to next

[retailcoder/Rubberduck] Hosch250 pushed commit e052769c to next: Fix hard-coded declarations for form parameters (make them be byref instead of byval)

[retailcoder/Rubberduck] Hosch250 pushed commit c7f5c081 to next: Hard-code aliases as functions for resolver

One more closed issue, and we'll be at 90%.

[retailcoder/Rubberduck] Hosch250 pushed commit 753825f8 to next: Prevent hard-coded declarations from having their references cleared for parse attempts with no changes

[retailcoder/Rubberduck] Hosch250 pushed commit 507ee656 to next: Close #1405

Of course, you are going to be creating a bunch of issues now...

[retailcoder/Rubberduck] web-flow pushed commit c751d9c5 to next: Update README.md

[retailcoder/Rubberduck] web-flow pushed commit fe4fe8d9 to next

[retailcoder/Rubberduck] web-flow pushed commit a0090d65 to next

You know, for a dev to create a proper issue for something, with a full MVCE, it is faster to just fix the thing more than 75% of the time.

IKR :)

[rubberduck-vba/Rubberduck] Hosch250 added label bug to issue #1917: Parser Error for Multi-Line Date Array

[rubberduck-vba/Rubberduck] Hosch250 removed label status-by-design from issue #1917: Parser Error for Multi-Line Date Array

but doing it brings down the average time to completion metric lol

It increases the average time to fix, when measured properly.

Or, as my mom would say, "stop making more work for others."

Don't worry, I'm not as crabby as I sound.

[rubberduck-vba/Rubberduck] build for commit fe4fe8d9 on next: AppVeyor build succeeded

lol

In fact, I'm sitting here grinning to myself at the light sparring.

Question--should I become the top VBA expert in the nation and write a VBA-to-C# converter, or should I try to remain as dumb as possible in that area?

LOL

I think it would be more worth my while to write a Linq-to-code converter.

I'm sure I could handle the Where and Select statements if they were used by themselves on a collection.

if you're bored, you could always improve the COM API, and expose COM wrappers for StringBuilder and BackgroundWorker =)

It would be trickier if they were chained.

@Mat'sMug Doesn't sound that hard.

BackgroundWorker events need to be handled by VBA code - the ParserState API is trying to do that, and failing :)

Yeah, I need to get that down to one event with an argument.

We need to expose all of our commands through COM too.

I'm a little worried. In about 7 months, I need to write my bachelors thesis.

I don't have anything to write about, literally.

I could write whole dissertations on many subjects, but I don't feel qualified to write a thesis on any subject in my degree.

We've barely scratched the surface on anything I thought I would be learning about.

And what could I write about about my work on RD?

I've not done much completely by myself, really.

Most of my work is building on your guys work, except for the Settings UI and the SC UI.

I haven't done any original research, for example...

Well, I guess if I had, I'd be going a PhD :)

I'm considering asking my professor if I could write a paper comparing and contrasting different search or sort techniques and when they are best used.

They look nice together.

IKR :)

[rubberduck-vba/Rubberduck] retailcoder created wiki page User Interface

[rubberduck-vba/Rubberduck] retailcoder edited wiki page User Interface

[rubberduck-vba/Rubberduck] retailcoder edited wiki page _Sidebar

TTGTB

[rubberduck-vba/Rubberduck] woxovvoxow commented on issue #1552: can´t get Rubberduck 2.0.1a-pre working in Access

What is your thesis scope of reference @Hosch250? You pepped my curousity

@hosch250 When you do thesis I have heard from a friend of mine you build your research with lots of references to what you had read. refme.com/au This software is cool to sync across devices of anything you find. This could help you group your related GitHub sources and CR/SO code pieces

@hosch250

@Hosch250 an undergraduate thesis is not a research paper as is the case of PhD. But perhaps its different in the states. You're first port of call is to get to your uni library and take out a few of last years undergraduate papers. These will give you an idea of the standard you need to write at to get the grade you want to get.

@Hosch250 Most undergraduate degrees in the UK on IT require that you should apply some principle in IT to some code that you write. For instance in my case I would like to write about unit testing. I would gather as many resources I can on what unit testing is. The different frameworks for unit testing. Maybe take 2 languages and compare code side by side, and reference those code basis to your course material.

@Hosch250 I would suspect that you could go along way with your experience in this project. Not least would be a thesis on "Open Source: The use of chat.stackexchange to bind distributed teams". But that would be your own research, and would be a lot harder.

@Hosch250

@Hosch250 easier would probably be isolating a piece of code you wrote and highlighting the process of code review that helped you maintain quality. Or just taking the lifecycle of a piece of code from concept to delivery. Divide the subject up according to some other book, or a previous thesis that got good marks, and write to that formula. It shouldn't be scary. You have LOADS of experience from your work here from which to capitalise, and your clearly extremely enthusiastic.

@all. sorry verbal diarrhea

[rubberduck-vba/Rubberduck] lkavicky opened issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] lkavicky edited issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

@Gareth lol so many pings

pings?

morning @Vogel. I'm back. with a little less attitude hopefully. My move is over, and my divorce is over, and my job is stable.

@Gareth each and every message pinged Hosch

oh

:)

well didn't start over well then ... :-<

after promising to myself I wouldn't kick anyone or put Hosch or anyone else down

lolwhat ... why would you say that you did that?

it's all fine and dandy (or so)

Hosch got a full inbox

[rubberduck-vba/Rubberduck] lkavicky edited issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] lkavicky edited issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] Vogel612 commented on issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

> Nothing in the log indicates anything wrong in Rubberduck (apart from a few Resolver problems), since the log ends when you create the repository. The Call Stack unfortunately does not indicate any involvement of Rubberduck :neutral_face:

@Gareth welcome back!

[rubberduck-vba/Rubberduck] retailcoder added label critical to issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] retailcoder added label source-control-integration to issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] retailcoder assigned Hosch250 to issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #1925: Prefer 'Worksheets' collection over 'Sheets' (Excel-specific)

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #1925: Prefer 'Worksheets' collection over 'Sheets' (Excel-specific)

[rubberduck-vba/Rubberduck] retailcoder opened issue #1925: Prefer 'Worksheets' collection over 'Sheets' (Excel-specific)

@Mat'sMug - At this point I'll take anything thay works. We can always refactor later. #FamousLastWords ... what was this referring to?

lol

the hard time we're having with properly resolving VBA.Strings.Left/VBA.Strings.Left$

it's hard to work with, because these declarations are acquired from a type library that's loaded from the file system at runtime.

i.e. any test that works with built-in declarations is a PITA

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #1926: Statically accessed sheet can be referred to by its CodeName (Excel-specific)

[rubberduck-vba/Rubberduck] retailcoder opened issue #1926: Statically accessed sheet can be referred to by its CodeName (Excel-specific)

[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #1926: Statically accessed sheet can be referred to by its CodeName (Excel-specific)

[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #1927: Implicit reference to ActiveWorkbook needs a quick-fix

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #1927: Implicit reference to ActiveWorkbook needs a quick-fix

[rubberduck-vba/Rubberduck] retailcoder opened issue #1927: Implicit reference to ActiveWorkbook needs a quick-fix

PITA?

Pain In The Ass

hmmm. you know me and testing...

on the other hand, we've now resorted to hard-coding them (their declarations are pretty messed-up in the VBA standard library, which is what complicates them in the first place), so if that's done right we should be able to have tests to cover these inspections that, for now, seem to work properly.

I've lost track of what's covered and what isn't :-/

[rubberduck-vba/Rubberduck] retailcoder assigned Hosch250 to issue #1928: Type-hinted declaration's type is Variant

[rubberduck-vba/Rubberduck] retailcoder opened issue #1928: Type-hinted declaration's type is Variant

[rubberduck-vba/Rubberduck] retailcoder added label code-parsing to issue #1928: Type-hinted declaration's type is Variant

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #1928: Type-hinted declaration's type is Variant

[rubberduck-vba/Rubberduck] lkavicky edited issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

@PeterMTaylor Not sure.

Thanks for the info, @Gareth, reading other recent theses is a good idea.

renaming a worksheet doen't crash, but subsequent resolver runs into a resolver error state caused by what appears to be System.IO.DirectoryNotFoundException trying to call VBComponentClass.get_Designer(), in DeclarationSymbolsListener's constructor

@Mat'sMug I thought I had maybe fixed that in the last release.

it just happened here :)

Oh wait, I didn't get it with a worksheet, so I ignored those.

Yes, the only fix I found was to reload the project in the cache.

ugh

And that crash probably isn't on the Sheet1 component, but the ThisWorkbook component, or something.

'Module1' component actually

OK.

That is why I have to reload the entire thing.

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #1929: Moving a local variable closer to its usage creates duplicate declarations

[rubberduck-vba/Rubberduck] retailcoder assigned Hosch250 to issue #1929: Moving a local variable closer to its usage creates duplicate declarations

Those Document type components mess everything up internally.

[rubberduck-vba/Rubberduck] retailcoder opened issue #1929: Moving a local variable closer to its usage creates duplicate declarations

> I would expect the declaration to be moved, not copied; the original declaration shouldn't remain in place. Looks like that refactoring needs more tests!

[rubberduck-vba/Rubberduck] retailcoder added label refactorings to issue #1929: Moving a local variable closer to its usage creates duplicate declarations

@Duga It is supposed to be moved--half the refactoring is dedicated to removing the bloody thing.

@Mat'sMug I'm pretty sure I don't remove it until after the reparse.

well it didn't remove it at all here

Did you wait for the first reparse, then the second? I can actually improve performance here by handling the Resolved Declarations state instead of Ready.

> Abraham, you have 1 job change and 3 new updates waiting for you on LinkedIn

Umm, who's been taking jobs in my name?

[rubberduck-vba/Rubberduck] grleachman commented on issue #1929: Moving a local variable closer to its usage creates duplicate declarations

> is this my refactoring code?

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1929: Moving a local variable closer to its usage creates duplicate declarations

> No, mine.

@Hosch250 it's the technique I used when I did my degrees. It helps give perspective on the level required to get the grade you want, and if it's the same lecturer that's doing the course, to also identify styles that they like, and don't like.

localization is still messed-up. I have "English" as my UI language, but some inspections show up in French, as does the Rubberduck commandbar's status label

@Mat'sMug I'm pretty sure that is because of some of the ways we call it.

RubberduckUI.ResourceManager.GetString(name, currentThread.Localization)

Or however it is.

yup

[ResourceFile].[ResourceManager.GetString] needs to be extracted into a standardized interface I think

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

> Please check that you have the C:\Users\{user}\AppData\Roaming\Rubberduck folder.

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1552: can´t get Rubberduck 2.0.1a-pre working in Access

> OK, thanks for the updates.

@Mat'sMug Can't we wait for all these features for 2.1? I want to just focus on stabilizing 2.0 now.

[rubberduck-vba/Rubberduck] lkavicky commented on issue #1924: Crash when trying to create a new repository (Access/Excel 2010)

> Yes, the folder is there.

the new inspections, yes. the bugs.... bugs are bugs, 2.0 includes a number of features, a stable 2.0 release has these features working as intended. localization has been around since 1.3 IIRC, 2.0 is about time it gets done right ;-)

Bugs, yes, but you assigned 2.0 to new quick fixes and new inspections.