VBA Rubberducking

With pauUndo(piUndoCount)
    Set .oMod = modCode
    .sName = sName
    .lStartLine = iStartLine
    .lEndLine = iEndline
    ReDim .asIndented(0 To iEndline - iStartLine)
    ReDim .asOriginal(0 To iEndline - iStartLine)
End With

Vogel612

it shortcuts what's before .

Hosch250

Oh, I see.

Mat's Mug

it's the lazy coder's way of avoiding to type

Hosch250

10:38 PM

Yeah, I get it now.

Mat's Mug

so

var foo = pauUndo(piUndoCount)

and then

Vogel612

it's basically a local implied this

Mat's Mug

foo.oMod = modCode

and so on

@Vogel612 there's more to it

Vogel612

@Mat'sMug is it actually stored or is it reinvoked?

Mat's Mug

it's stored. the With block holds the reference

what's why I said "sort of" when you said "using"

Vogel612

10:40 PM

and you can nest them, right?

Mat's Mug

if you're the devil incarnate, yes

Vogel612

With foo
    .bar()
    With .quux()
       .callCthulu()
    End With
End With

hmm... that's just me, right?

Mat's Mug

what's that?

Vogel612

I have no idea

the dark background is SO Dark Chat +

Hosch250

Catch me doing this again...

Mat's Mug

10:42 PM

ah

Vogel612

but I don't know where the syntax highlight comes from

hmm... it vanished..

Mat's Mug

well I had quite a bit of fun writing resolver code that correctly handled nested withs; wouldn't surprise me that the syntax highlighter doesn't like it

Hosch250

Wow, I have no idea what I'm doing.

Set oCM = modCode

That is an assignment, right?

Mat's Mug

of an object variable, yes

Vogel612

hmm.. it only happens for new messages.

Hosch250

10:44 PM

oCM is declared earlier as an Object.

This is the first reference, so I change it to this: object objCodeModule = codeModule;

Vogel612

VB requires you to use a special assignment for refernce types.

Hosch250

Now, codeModule is a DI'ed CodeModule.

And the next statement is this: iMembers = oCM.Members.Count

Mat's Mug

and why can't you work off codeModule?

Hosch250

I have no idea.

Mat's Mug

ugh. full-on Hungarian FTW

Vogel612

10:45 PM

ohh cool, hungarian notation

Hosch250

But, an Object has no idea about a .Members whatever.

The best part? Those aren't really ints!

Vogel612

yea.. dynamically invoked languages

Hosch250

They are - guess what? - longs!

Mat's Mug

VB6 Integer == C# short

Hosch250

WT*$#?

Mat's Mug

10:46 PM

VB6 Long == C# int

Hosch250

What kind of imbecile designed this language?

Vogel612

actually @Hosch250 VB just is that old

Hosch250

Here come the psychopathic maintainers! :P

Vogel612

back then Integer meant Int16

Hosch250

OK. re-types longs to ints

Vogel612

10:47 PM

#define long int

Mat's Mug

lol

Hosch250

Fat chance.

Vogel612

#define int short

Hosch250

This was done wrong once, it is going to be done right the second time, then posted on CR.

Vogel612

rags-to-riches

Hey Mat did you hear back from that person with the two open PRs?

Mat's Mug

10:49 PM

@Hosch250 I think it could be more productive if you worked on the indenter settings

@Vogel612 nope

Hosch250

@Mat'sMug Probably.

Vogel612

... did I scare them away?

Hosch250

But the trouble is, I can't even read those files.

Don't worry, I'm actually making progress.

Vogel612

lol

Mat's Mug

whenever you see GetSetting, there's a registry key involved. They're sprinkled all over

SaveSetting too

Vogel612

10:51 PM

probably you need to translate it over and then refactor the hell out of it

more literally than I'd like.

Hosch250

That's what I'm doing.

Duga

[rubberduck-vba/Rubberduck] retailcoder merged pull request #779: Replaced "Menu Bar" by index number of the control bar so it should w… from INOPIAE/Rubberduck/#778 into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] INOPIAE pushed commit fc54a18a to next: Replaced "Menu Bar" by index number of the control bar so it should work on all langugae installations

[rubberduck-vba/Rubberduck] retailcoder pushed commit c0ff0753 to next

Merge pull request #779 from INOPIAE/#778

Replaced "Menu Bar" by index number of the control bar so it should w…

Mat's Mug

"Menu Bar" is index 1 on all locales

Vogel612

on a completely unrelated note.. I opened a PR at libgit2sharp 12 days ago, and haven't heard back from them. But the issue I opened was replied to and discussed within hours.

@Mat'sMug hmm.. but nothing guarantees that the Strings work for other locales.

Mat's Mug

well, the PR only had that changed, so.. merged. I'd have done that anyway

Hosch250

10:53 PM

Is For i = 1 To iMembers like for (int i = 1; i < iMembers; i++) or for (int i = 1; i <= iMembers; i++)?

Vogel612

hmm.. I'll place cleanup for 778 on my list.

the latter IIRC

remember 1-based collection access

Hosch250

Wow.

Oh, yeah.

Vogel612

which means that you need to iterate up to length including to get all the items.

Hosch250

VB.NET has And == & and AndAlso == &&. How does this work in VB6?

Mat's Mug

it doesn't

there's no short-circuiting operator in VB6

and And == & is falsey

Vogel612

10:56 PM

isn't & the binary one?

Mat's Mug

yes

Hosch250

OK...

Mat's Mug

but in VBA, whether "And" is a logical or a bitwise operator depends on ...context

Hosch250

I guess I'll use & for now.

Vogel612

fun, right?

Hosch250

10:57 PM

I'll leave a todo.

Vogel612

make that an XXX as per oracle guidelines :D

Mat's Mug

@Hosch250 use "&" when "And" is bitwise; use "&&" when "And" is logical

Hosch250

OK, I guess it is logical.

Mat's Mug

the fact that C#'s && short-circuits will not be a breaking change.

it would be different if VB6's logical operator short-circuited, but not C#'s

Vogel612

@Mat'sMug actually it could be if you invoke a method with side-effects.

Mat's Mug

11:00 PM

@Vogel612 yeah, ..you're right... but nobody does that, right?

Duga

[Hosch250/Rubberduck] Hosch250 pushed commit 7c8435fa to Indentation: I have no idea what I did...

2

Mat's Mug

(bangs head on desk)

2

Hosch250

Take a peek.

Mat's Mug

problem one:

SmartIndenter/CSharp6/modIndentRoutine.cs

Hosch250

I initially created it that, but then I changed the name.

That is VS's fault.

Mat's Mug

11:03 PM

haha

Hosch250

Mat's Mug

namespace Rubberduck.SmartIndenter.CSharp6

Hosch250

I just kept the same file structure. We can redo it later, I guess.

I bail out.

Mat's Mug

eh, not a biggie. Ctrl+R,R to the rescue

Hosch250

It'll be faster for you to do it.

Mat's Mug

11:05 PM

I think [next] should be merged into that branch first

Hosch250

I'll help unit test it and stuff once you get it up.

Probably.

And the methods are absolutely huge.

Mat's Mug

have you seen Smart Indenter's options?

Hosch250

No.

I'll install it now.

Mat's Mug

there's a shitload of 'em

as I said, if we first address the options, we'll have a good start.

Hosch250

Yep.

So, basically, we need to parse the XML file and DI them.

Mat's Mug

11:08 PM

because with that many options, everything is interfering with how the code works

we need to implement a SmartIndenterSettings serializable class

and then create a control for the RD settings dialog

Hosch250

You know, if we could simply get the hook in, it would be faster to write it from scratch.

Mat's Mug

then the SmartIndenter feature will use an IGeneralConfigService

what hook?

Hosch250

He uses a key hook to capture key presses.

Mat's Mug

yes, I want to inspire from that to eventually implement our own keyboard shortcuts :)

but we aren't rewriting that add-in from scratch

we're rewriting it in C#, with all of the functionality

Hosch250

Check the modVBEOnKey.bas file.

Mat's Mug

11:11 PM

it has to have the name "Smart Indenter", and live up to it

Hosch250

What happens when we add more features?

Mat's Mug

we can do that

but before we add features... we need the existing ones implemented ;-)

anyway, gtg / bbl

Hosch250

See you.

Transcript for