« first day (399 days earlier)      last day (2781 days later) » 

Duga
Duga
00:01
RELOAD!
[Cardshifter/extra-resources] 1 commit. 1 addition. 1 deletion.
[rubberduck-vba/Rubberduck] 22 commits. 1 opened issue. 1 closed issue. 2 issue comments. 6044 additions. 1081 deletions.
3
[Vogel612/TranslationHelper\‌​] 9 commits. 4 opened issues. 1 closed issue. 1 issue comment. 327 additions. 25 deletions.
Phrancis
Phrancis
Good job duckies!
Hosch250
Hosch250
27% covered.
Mat's Mug
Mat's Mug
The RD unit testing project is about to quadruple in size
By next month we'll have over 1000 tests :-)
Duga
Duga
[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #704: Fix bugs, more tests
[rubberduck-vba/Rubberduck] build for commit 99764c33 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 99764c33 on ???: AppVeyor build succeeded
Hosch250
Hosch250
I'm cleaning up my tests, don't merge quit yet.
RubberDuck
RubberDuck
00:08
Well done @Vogel612! Now I know who to pester next time I try...
Next thing you know we'll be expanding ninject into new frontiers.
Duga
Duga
[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #704: Fix bugs, more tests
[rubberduck-vba/Rubberduck] build for commit a5b1992d on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit a5b1992d on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #704: Fix bugs, more tests
[rubberduck-vba/Rubberduck] build for commit d5e6b645 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit d5e6b645 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #704: Fix bugs, more tests
Hosch250
Hosch250
00:24
Whoops.
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 2610366b on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 2610366b on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #704: Fix bugs, more tests
Hosch250
Hosch250
OK, I'm done here.
Merge when you're ready.
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 12c15bd5 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 12c15bd5 on ???: AppVeyor build succeeded
Duga
Duga
01:11
[rubberduck-vba/Rubberduck] ckuhn203 merged pull request #704: Fix bugs, more tests from Hosch250/Rubberduck/next into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] ckuhn203 pushed 14 commits to next (only showing some of them below)
[rubberduck-vba/Rubberduck] Hosch250 pushed commit ad8e1e89 to next: Tests for remove presenter and factory
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 8db3c371 to next: Fix bug, add more remove tests
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 3e10f874 to next: Fix test
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 20edeb7f to next: Cover Reorder presenter and factory
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 99764c33 to next: Reorder tests
[rubberduck-vba/Rubberduck] Hosch250 pushed commit a5b1992d to next: Use .Reverse() in reorder as available.
[rubberduck-vba/Rubberduck] Hosch250 pushed commit d5e6b645 to next: Remove expected values identical to input values
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 2610366b to next: More interface test
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 12c15bd5 to next: Add more event tests
[rubberduck-vba/Rubberduck] ckuhn203 pushed commit 38ac4350 to next
Merge pull request #704 from Hosch250/next

Fix bugs, more tests
Hosch250
Hosch250
Thanks, @RubberDuck.
Anything else for me to test?
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 38ac4350 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 38ac4350 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] ckuhn203 commented on issue #703: Option to sort Code Explorer alphabetically
> Far too lazy to go find it right this second, but I think this might be a dupe.
Hosch250
Hosch250
@RubberDuck github.com/rubberduck-vba/Rubberduck/issues/267?
RubberDuck
RubberDuck
01:31
Good look @Hosch250!
Hosch250
Hosch250
github.com/rubberduck-vba/Rubberduck/issues/698
I'm taking that on ^
It actually affects all the grid views.
And, that specific instance is fixed.
Duga
Duga
[rubberduck-vba/Rubberduck] ckuhn203 commented on issue #703: Option to sort Code Explorer alphabetically
> I was thinking of #267, but I thought that was done already. Did we lose something along the way, or am I just hopelessly confused?
Duga
Duga
01:44
[rubberduck-vba/Rubberduck] Hosch250 commented on issue #698: Code Inspections sort order not maintained on refresh
> Issue also applies to todo and test explorers.
[rubberduck-vba/Rubberduck] Hosch250 created pull request #705: Closes issue #698 to merge Hosch250/Rubberduck/next into rubberduck-vba/Rubberduck/next
RubberDuck
RubberDuck
That was fast @Hosch250. Lol
Hosch250
Hosch250
Only one itty bitty problem here - there is a bit of a flicker because the data is refreshed and sent to the screen, and then I refresh it.
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit b5900f81 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit b5900f81 on ???: AppVeyor build succeeded
Hosch250
Hosch250
02:01
I wish the dishes could go do themselves.
BBL.
Phrancis
Phrancis
02:17
@Hosch250 Where, there are things like dishwashers...
 
1 hour later…
Hosch250
Hosch250
03:20
@Phrancis We don't have one - our last one leaked all over the floor, and we put a cabinet in.
Also, they don't work very well - we would wash them in the washer, then have to wash them by hand to get the rest of the stuff off.
 
3 hours later…
Gotalove
Gotalove
06:45
hi guys
whats with the build for commit comments?
 
3 hours later…
RubberDuck
RubberDuck
10:09
@Gotalove the bot is hooked into our github repo and notifies us when the build completes. We use this room to coordinate development of our VBE addin.
It's also for general discussion of VBA though.
RubberDuck
RubberDuck
10:21
You know, the worst part is that I know these things. What I don't know is why do I still write code like that. — Mat's Mug 20 hours ago
@Mat'sMug just saw that and can't stop laughing. We all do it. Thank the Gods CR is here.
 
3 hours later…
FreeMan
FreeMan
12:59
Well done, lads! Every. Three. Hours.
RubberDuck
RubberDuck
13:30
Lol. Yeah. Everyone's been kinda busy lately.
FreeMan
FreeMan
Stupid jobs
FreeMan
FreeMan
14:22
Very odd... I've opened both an Access DB and an Excel Workbook, both with macro code. I opened Access first, and it shows RubberDuck in the IDE menu. I opened Excel second, and it does not show RubberDuck in the IDE menu.
user image
That's the Access IDE in the background, and the Excel IDE in the foreground.
Running 1.4.3. Don't recall ever having had this issue before...
Duga
Duga
[rubberduck-vba/Rubberduck] daFreeMan opened issue #706: Rubberduck has disappeared from Excel - remains in other app IDEs
> I've opened both an Access DB and an Excel Workbook, both with macro code. I opened Access first, and it shows RubberDuck in the IDE menu. I opened Excel second, and it does not show RubberDuck in the IDE menu.

![rd access excel](https://cloud.githubusercontent.com/assets/11889733/8620491/e3687d9a-26ed-11e5-933f-6ffb378b90b7.PNG)

That's the Access IDE in the background, and the Excel IDE in the foreground.

Running 1.4.3.

Closing & reopening Excel had no effect.
Close Excel then Ac
FreeMan
FreeMan
I'm having a bit of a crisis here, even though I'll primarily be in Access today...
Hosch250
Hosch250
14:40
@FreeMan No repo here. Sounds like your installation of Office, maybe?
FreeMan
FreeMan
could be... never had this issue before, and have had multiple XLSM files open and had Excel & Access open with their IDEs at the same time.
Mostly, as I mentioned in the issue, I think a RD reinstall will probably fix it, but are there any logs that would help before I do that?
Hosch250
Hosch250
I think there are some in AppData/Roaming/Rubberduck/logs
Oh wait, that is just a parser log.
@all There are a couple crash-causing use cases in Remove and Reorder params that I fixed with the help of the unit tests. Specifically, rejecting the prompt to reorder/remove params from an interface.
Also, trying to remove from an event doesn't always pick up the parameters.
I did push patches for this that were merged, so it is fixed for the next release.
FreeMan
FreeMan
TTGBTW - ping me if you need any more details on #706.
Mat's Mug
Mat's Mug
15:14
@Hosch250 yay unit testing!
FreeMan
FreeMan
I've noticed that reparsing seems to take a while after clicking the Fix button on the Code Inspections panel. Would it be reasonable/possible to reparse just the code module that was edited by the fix instead of the whole project?
It does seem to take as long to do the parse after clicking Fix as it does after clicking the Reparse button.
no official timings have been made to support this assertion, just a general 'feeling'
Mat's Mug
Mat's Mug
16:06
@FreeMan it's doing exactly that. But identifier references need to be re-resolved for all modules, no way around that
FreeMan
FreeMan
Reasonable = True, Possible = False. sigh... :/
Is that required for all fix types? for example Parameter {x} could be passed ByVar
either that, or hurry up with
github.com/rubberduck-vba/Rubberduck/issues/651
;)
@Duga also, since you're here, any thoughts or input on this one?
Duga
Duga
16:36
[rubberduck-vba/Rubberduck] daFreeMan opened issue #707: Code Inspection for "Procedure {x} is never used" doesn't check form events
> In my Access project, I have a form with a lot of buttons with events attached. Each one of the procedures called by an event is flagged as "never used" by the _Code Inspector_.

Also, `Form_Load` is flagged as "never used".
Duga
Duga
17:08
[rubberduck-vba/Rubberduck] daFreeMan opened issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
> In Access:
~~~
Dim XLObj As Excel.Application
Set XLObj = New Excel.Application
XLObj.Calculation = xlCalculationManual
~~~
Generates a `Variable XLObj is never used` item in the _Code Inspections_

![rd never used 2](https://cloud.githubusercontent.com/assets/11889733/8624281/b859e6c2-2704-11e5-934b-ea5f60f39dad.PNG)
FreeMan
FreeMan
He's Mister Sunshine And Roses today, isn't he?
Hosch250
Hosch250
17:27
@FreeMan I have a feeling that is one bug causing many problems.
FreeMan
FreeMan
17:53
could be... Don't know if it's due to the fact that these are appearing in Access vs Excel where I've been working the past couple of weeks...
Mat's Mug
Mat's Mug
@FreeMan if you declare a variable As Collection, and later use it, does it pick up usages?
oh nevermind
FreeMan
FreeMan
@Mat'sMug Yes, it is correctly identified as being used (in Access)
@Mat'sMug oh nevermind...
Mat's Mug
Mat's Mug
lol
Duga
Duga
18:11
[rubberduck-vba/Rubberduck] retailcoder commented on issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
> The resolver is working as expected - the type Excel.Application is unresolvable ("Excel" not having a DeclarationType.Project built-in declaration - see VbaStandardLib.cs) - we could (and probably should) add these Declaration objects though, and "model" the (gulp) entire Office object model, so that the resolver knows how to deal with thos
[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
[rubberduck-vba/Rubberduck] retailcoder added label critical to issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
[rubberduck-vba/Rubberduck] retailcoder added label code-parsing to issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
Mat's Mug
Mat's Mug
@Duga edited. removed the "The resolver is working as expected" part
wait a minute...
ok. (closing Word, Excel, ..uninstalling RD 1.3, installing RD 1.4.3)
Duga
Duga
[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
[rubberduck-vba/Rubberduck] retailcoder removed label code-parsing from issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
[rubberduck-vba/Rubberduck] retailcoder removed label critical from issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
[rubberduck-vba/Rubberduck] retailcoder commented on issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
> This isn't a resolver issue - references to the `XLObj` variable are correctly resolved, at least in this repro:

![image](https://cloud.githubusercontent.com/assets/5751684/8625808/fa34b64e-270e-11e5-9e97-7661cfb7a1e2.png)

But the inspection doesn't agree: the bug is with the inspection.
Mat's Mug
Mat's Mug
user image
@FreeMan ^^ repro
if you run find all references on XLObj, it picks them up correctly?
right?
Duga
Duga
[rubberduck-vba/Rubberduck] retailcoder unassigned retailcoder from issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
Mat's Mug
Mat's Mug
@Hosch250 I've removed myself from issue #708 as it's not a resolver bug - feel free to fix & PR :)
FreeMan
FreeMan
18:25
@Mat'sMug I get quite a list
Hosch250
Hosch250
@Mat'sMug Is that an order?
2
Mat's Mug
Mat's Mug
lol
Hosch250
Hosch250
I'm working on removing the flicker in the refreshed gridviews.
Mat's Mug
Mat's Mug
all good, it's just I had #708 marked as a resolver bug, assigned to myself and scheduled for 2.0; turns out it's a false positive with the inspection itself, so it can ship as part of a bugfix release within 1.4.x
user image
Duga
Duga
18:41
[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #705: Closes issue #698
Hosch250
Hosch250
There's the patch, and that should be good to go.
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit a1235b77 on ???: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit a1235b77 on ???: AppVeyor build succeeded
 
1 hour later…
Duga
Duga
19:52
[rubberduck-vba/Rubberduck] daFreeMan commented on issue #708: Application objects in Access generate false positive "Variable {x} is never used" inspection
> Update:

I just realized that I've defined `XLObj` in two different places:

1. It is a `Module` **global** in one module - references within this module are correctly identified, and I do _not_ get the `never used` inspection triggered
1. It is a `Sub` **local** in another module - this is the one that caused the false positive originally reported.

Both instances are `Dim XLObj as Excel.Application`
Mat's Mug
Mat's Mug
@Rossco hi! Question: if someone installed 1.4.x and wants to update to the latest version, do they need to manually uninstall or the inno script handles it?
FreeMan
FreeMan
@Mat'sMug I installed 1.4.3 & 1.4.2 on top of 1.4 - both without uninstalling.
Not sure if that's the cause of any issues... we'll wait to hear from @Rossco
Hosch250
Hosch250
The instructions said to uninstall.
FreeMan
FreeMan
hrm... missed seeing that.
Hosch250
Hosch250
28 seconds!
FreeMan
FreeMan
20:00
I'll ask again, then uninstall: Are there any logs that might be pertinent to the RubberDuck disappearing from Excel IDE issue I reported earlier?
@Mat'sMug, @RubberDuck ^^^ ?
Elections!
Mat's Mug
Mat's Mug
@Hosch250 only as a safety measure, knowing most users will be upgrading from 1.22
FreeMan
FreeMan
I did do a clean install of 1.4
Duga
Duga
20:41
[rubberduck-vba/Rubberduck] daFreeMan closed issue #706: Rubberduck has disappeared from Excel - remains in other app IDEs
FreeMan
FreeMan
And, I've closed my first issue! :D
TTGT4H - have a great weekend, y'all!
Mat's Mug
Mat's Mug
20:55
later!
 
3 hours later…
Rossco
Rossco
23:57
@Mat'sMug I'm not 100% myself. But looking at this page seems to show we need to add a couple of lines to prevent users from being able to change install directories.
Hosch250
Hosch250
@Mat'sMug I just implemented Fix All.
Rossco
Rossco
Unless you really think that the previous version needs to be uninstalled. In which case this page seems to have some useful code to add.
Hosch250
Hosch250
The best part about it is that it refreshes between every single fix, so it goes into a long loop of refreshes before it finishes. </sarcasm>
Rossco
Rossco
Really just need to decide on the desired behaviour and then we can make it conform to that.

« first day (399 days earlier)      last day (2781 days later) »