« first day (360 days earlier)      last day (2820 days later) » 
00:00 - 13:0013:00 - 00:00

12:00 AM
The QualifiedName of the selection passed is "Class4", not method "Foo"
 
RELOAD!
[Cardshifter/Cardshifter] 32 commits. 1 opened issue. 5 closed issues. 6 issue comments.
2
[retailcoder/Rubberduck] 19 commits. 4 opened issues. 2 closed issues. 11 issue comments.
 
Not as easy as it looks.
RD lost :(
Good job, Cardshifters.
 
@Duga Is this an issue, or a bad title?
 
12:24 AM
@RubberDuck @Mat'sMug Do you ever do any 'snapshot' releases?
 
12:35 AM
What's a snapshot release?
 
12:47 AM
@RubberDuck a kind of 'inofficial' release I would say. For a certain group of people to try things out before an official release.
snapshots can be daily, weekly, or just from time to time
 
No. We've only released releases really.
 
Sometimes we'll make a pre-release though.
I imagine 2.0 will go into a pre-release for at least a couple of weeks.
 
yeah
and when you do that pre-release, will you merge master into that or not?
 
1:17 AM
I say yes, because we only release from master... oh wait
...
IDK
Oh I think I get it. Like some "nightly build" type of thing
That wouldn't be in master
But no, we don't do that
 
I think it is a "hip" term for a beta release ;)
I've got to get my refactorings refactored so I can start another.
@Mat'sMug Should we have a localization label?
We probably won't need it after we get localized, but we have at least three localization-related issues right now.
Hmm, so you don't want me to start refactoring just yet?
 
1:39 AM
I just want to make sure IRefactoring is solid.. I think with only a Refactor(Declaration) overload it will be good.
@Hosch250 good idea. There will be more localization issues in the future... new UI == new things to localize
 
Do you have a specific color pattern you use?
 
DEDEDE
(IIRC)
 
DEDEDE?
 
Light gray
Like SE tags basically
 
1:44 AM
Oh, that.
You can use other colors, you know.
 
The white is for meta stuff
Red for statuses
 
I initially had it a teal, but DEDEDE it is.
Have you seen the feature?
 
Which?
Booting in 5 minutes
Coffee's brewing :)
 
So the tree nodes need localized
Oh
Wtf?!
 
1:50 AM
It gets them all.
 
That's been annoying me for a while. I think inspections should have a name, and what we have as a name would be the message
You're looking into it or want me to take a look?
 
I looked, I don't know how to fix it.
I could look harder.
 
lol
 
I did find the offending method.
 
Got a link?
 
1:52 AM
Lost it.
I'm finding it again.
        public IList<IInspection> GetImplementedCodeInspections()
        {
            var inspections = Assembly.GetExecutingAssembly()
                                  .GetTypes()
                                  .Where(type => type.GetInterfaces().Contains(typeof(IInspection)))
                                  .Select(type =>
                                  {
                                      var constructor = type.GetConstructor(Type.EmptyTypes);
                                      return constructor != null ? constructor.Invoke(Type.EmptyTypes) : null;
 
@Hosch250 yeah well in the early days we tried some color-coding.. it quickly got confusing, and then I thouht hey, what if we treated labels like SE tags? - ...and I liked it :)
 
I think it has something to do with that.
 
I think that only returns the IInspection implementations. The offending code must be in the code calling that..
 
On further inspection, it doesn't.
 
@Hosch250 lol. We redactor refactorings and inspect inspections :)
 
1:57 AM
Lol.
It has to be here:
public CodeInspectionSetting[] GetDefaultCodeInspections()
{
    return GetImplementedCodeInspections()
            .Select(x => new CodeInspectionSetting(x))
            .ToArray();
}
 
Coffee's ready. Booting.
 
I set a break point, but it never got hit.
NVM, that is just the default.
 
That only gets called when .. ^^that
 
It might be there too, but it has to be in the stored ones.
Where's that?
 
I meant.. oh wait a minute..
Look at your rubberduck config file
I think Chris is serializing the name
So if you toggle language...
That's the bug.
 
2:03 AM
<?xml version="1.0" encoding="utf-8"?>
<Configuration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <UserSettings>
    <ToDoListSettings>
      <ToDoMarkers>
        <ToDoMarker Text="NOTE:" Priority="Low" />
        <ToDoMarker Text="TODO:" Priority="Normal" />
        <ToDoMarker Text="BUG:" Priority="High" />
      </ToDoMarkers>
    </ToDoListSettings>
    <CodeInspectionSettings>
      <CodeInspections>
        <CodeInspection Name="Parameter is passed ByRef implicitly" Severity="Warning" InspectionType="Code Quality Issues" />
 
Inspections are retrieved by their name
 
Those are all the ones I've changed?
 
Hmm something's off
I expected to see the two translations
 
It isn't just the ones I've changed, it is all of them.
 
Sure? There should be about 20 of them
 
2:06 AM
Sure.
I looked through all windows.
 
I see 6
Only CodeQualityIssues
 
Also, the strange thing is that the Code Inspections work.
 
Ladies and gentlemen, we have a configuration bug
 
Look at my pic - six each.
 
Yes but there are about 20 inspections. Where are the readability and language opportunity ones?
 
2:08 AM
Oh, I've just changed most of them.
And even when I change it back to the default, it remembers.
You should give me a reset button.
        private List<CodeInspectionSetting> MergeImplementedInspectionsNotInConfig(List<CodeInspectionSetting> configInspections, IList<IInspection> implementedInspections)
        {
            foreach (var implementedInspection in implementedInspections)
            {
                var found = false;
                foreach (var configInspection in configInspections)
                {
                    if (implementedInspection.Name == configInspection.Name)
                    {
                        found = true;
That is it.
Look at this line:
> if (implementedInspection.Name == configInspection.Name)
 
@Hosch250 that
we need to change that
 
Testing this:
> if (implementedInspection.InspectionType == configInspection.InspectionType)
 
that's not localization-friendly
@Hosch250 that's not specific enough to match 1 inspection... you're testing a bug
 
OK.
 
what we need is a culture-independent name that can be used internally
and a culture-specific description that we can use in the UI
 
2:13 AM
Why not - a name?
 
basically the IInspection interface needs to change
 
Each inspection could have a name and a result
 
result would be confusing
 
The name could be "Generic project name inspection"
The result would be "Project '{0}' contains 'VBAProject'"
Or something like that.
Oh, I get it, NVM.
 
but call it description, not result - result would be confusing because InspectionResult
 
2:15 AM
Yeah.
 
so "Generic project name" ("inspection" would be redundant) can be hard-coded into the implementation
 
Sure.
 
I'm not convinced the description needs to be serialized
actually I'm pretty sure it doesn't
we serialized it only because it's how we could know which XML node was for which inspection instance
let's serialize the name instead, and use that.
ooh I have this "Get Windows 10" icon
not sure I want to upgrade this laptop though
 
They are already pushing it?!
 
no, just letting you reserve a free download when it's available
 
2:21 AM
I've not gotten it.
 
I'm on Win7 Pro
 
I'm in Win10.
Lol, that's why.
 
lol
 
Dishes time, will finish fixing the inspections later.
If you want me to break Next, I can push my changes.
 
awesome
lol nah not yet :)
so, you take the inspections, I'll finish the refactorings
> and this is why we haven't released yet
@ticker ...
> Filename = Dir(path & "database.xlsx")
...a file named database.xlsx cannot be right
2
ok so IRefactoring.Refactor() will not have an IRefactoring.Refactor(Declaration) overload
because ExtractMethod works off a selection, not a Declaration
and since a Declaration can be acquired from a QualifiedSelection, I'm adding a IRefactoring.Refactor(QualfiiedSelection) overload to the interface, and there won't be any NotImplementedException to throw anywhere
I'm adding a QualifiedSelection.Select() method to facilitate this.
basically all IRefactoring.Refactor(QualifiedSelection) might look like this:
        public void Refactor(QualifiedSelection target)
        {
            target.Select();
            Refactor();
        }
hey @RubberDuck
 
2:52 AM
Hey buddy. Just popping in.
 
pop!
so you caught up?
IInspection interface needs to change a bit
we're serializing the localized description
 
3:04 AM
ah-ha! closing in:
@Hosch250 is correct, the only Project declaration in the parse result, is the built-in "VBA" project
 
3:33 AM
fixed
 
[retailcoder/Rubberduck] retailcoder pushed commit f5767dfc to next: added IRefactoring overloads needed to make refactorings work off current selection, specified selection, or specfied Declaration object; fixed rename project from Code Explorer
 
now localization fixes
but first, cigarette
 
Found a reasonable C# tutorial here:
Going through some of it is painful, since I learned it 30 years ago, some of it is good as it's showing how the basic concepts work in C#
TTGTB, though. g'night!
 
Night.
 
@Hosch250 I'm renaming a couple of issues... please try to make issue titles expressive of the actual issue ;-)
'night @FreeMan
 
@Mat'sMug I just copy/pasted the name.
After all, we can't use it in the UI because it is hard-coded.
I figured that would be the easiest.
Is there a way to clear my .config file?
Or reset it?
 
delete the file ;)
 
OK.
That is working now.
 
ah, that's the one I was looking for!
thanks!
oh gosh, I just noticed the stupid phone typo
2 hours ago, by Mat's Mug
@Hosch250 lol. We redactor refactorings and inspect inspections :)
s/redactor/refactor
 
Actually, "redactor" works too - I looked it up.
 
lol
 
Clear the star and repost it.
I'll restar it.
Anyway, I've got it working - sort of.
 
4:03 AM
so.. we refactor refactorings.. and inspect inspections
@Hosch250 for some values of "working"? ;)
 
Yup.
 
uh
 
I can't make heads or tails of it.
 
right
 
Want my changes?
All I did was add Name and change the one place...
 
4:06 AM
wtf
where's the code that's getting the descriptions?
 
I don't know.
I don't know this part of the project.
 
hmm
 
On a nicer note:
 
where's the code that's getting the inspections then - the ones being displayed?
(we know the inspections gathered through reflection are ok)
 
I have no idea.
I need to change the description there, don't know why it is displayed like that.
 
4:08 AM
...what am I not seeing?
what's wrong with the descriptions?
oh the first one
 
Oh, I know.
When I renamed them, I used the Rename tool.
This was commented out.
 
R# would have picked it up ..just sayin' ;-)
 
VS picks things in comments up too.
I had the entire inspection commented because it didn't work.
So, there was no reference to it.
Found it.
 
posted on May 31, 2015

Three sisters from a poor family petitioned the abbot of the Laughing Monkey Clan for admission to the Temple as developers. “I cannot hire any of you,” said the abbot after he looked at their résumés. “You do not have the necessary experience.” “But it is the same complaint everywhere we go!” protested one of the sisters. “How are we to acquire experience if we are refused entrance to

 
anyway, so I was going to start working on the last few missing translations, but there will be merge conflicts in RubberduckUI and RubberduckUI.fr if you don't push your changes first. So yeah, go ahead and push, I'll see what I can do to that settings dialog.
 
4:17 AM
[retailcoder/Rubberduck] Hosch250 pushed commit 12dfd863 to next: Uncomment GenericProjectNameInspection working and add Name property to IInspection
 
1 away:
9
A: Preventing duplicate numbers from being entered

Hosch250Naming Yes, naming is hard. However, bad naming is going to make your code prone to bugs (what does k stand for again?), hard to maintain, hard to read, and all sorts of other things. Style Poor indentation (which scope does this snippet have?): if(k==0) { query = "DELETE FROM `voters`.`v...

 
^^ doesn't stop R# from seeing it (renaming IInspection to IInspectionFoo)
 
Cool.
I really like R# for refactoring code, but I find it a nuisance when writing it.
 
if it's just because of that little popup when a signature is off-screen, .... I just don't get it
 
No, not that.
 
4:21 AM
@Hosch250 already has my vote ;)
 
There are popups popping as I type too.
 
autocomplete is a nuisance??
 
Yeah.
In VS, it isn't so shovey.
 
vanilla IntelliSense is dumb IMO
R# just guesses what I want to name things
and it guesses it right 99% of the time
 
I don't like it guessing.
 
4:24 AM
pr[tab] -> private
 
Some of them aren't even "pri"s, and even more don't start with "pri"
I can turn it to just keywords, which is nice.
And the second I define a variable, it tells me it isn't used.
Of course it isn't used, does it think I use it before I define it?
 
you could
 
Why, so it crashes when I forget I haven't defined it?
Or to be told that I haven't defined it yet?
I'd rather have one warning than a trillion...
 
you're confusing things
hints and suggestions are not warnings
and if you define a variable that's not used, well, it's not used is it?
 
Of course not.
 
4:31 AM
so, what's wrong with R# telling you that an unused variable is not used?
 
Maybe it could wait until I ask it?
 
what's the point?
the whole advantage of real-time inspections is that you don't have to build to capture stuff
 
I use it on my code after I write it to help clean it up.
 
I only build my project when I'm ready to run it
and I know it builds when I build it
 
And, in the build, it is all in a nice, neat row, and it only takes a second or so anyway, with how much VS caches the old builds.
 
4:34 AM
not to mention navigating the code
Ctrl+T has to be the most used feature I use
and Alt+Shift+L
 
Oh, talking about navigating, it busted all my shortcuts, even though I told it not to.
And, it won't let me paste.
 
that's "goto anything" and "locate in solution explorer"
you can reset the shortcuts anytime
did you even look at the R# options?
 
And it messed my right-click menu all up.
Yeah, I tried turning things off, but they wouldn't turn off.
 
so basically you're using 1% of the features and don't want to be bothered with the other 99%
 
What irked me the most was the way it busted the Paste.
Something.
 
4:37 AM
that paste thing, I have no idea what you mean
 
What I do is after I get my code working, I turn R# on and clean up all the errors.
 
that's what I'm saying, it's like 1% of what the thing does
 
I copied from one file and went to paste in another with R# on, and it wouldn't let me.
I turned R# off, and it worked.
I don't know what happened.
 
weird
 
It might be because I selected and deleted another LoC before trying to paste in the other file?
I don't know, it really surprised me.
 
4:38 AM
I don't think it has anything to do with R#
could you have accidentally Ctrl+C an empty line after you copied the code?
 
No, the paste option was disabled in the right-click menu.
 
again, nothing to do with R#
 
And it worked as soon as I turned R# off, without restarting VS.
 
R# doesn't do anything to clipboard stuff
 
[retailcoder/Rubberduck] Hosch250 pushed commit fbd74f22 to next: R# App.cs
 
4:41 AM
I don't know what happened, but it worked in Vanilla without restarting R#.
Maybe VS is busted when addins are loaded?
I have no idea.
But, it busted.
 
What's that?
 
the dependency graph for the Rubberduck project
 
Cool. Shouldn't more go back to App.cs?
 
the arrow means "depends on"
so no.
 
4:50 AM
I deleted Rubberduck.config, but my settings weren't reset.
 
lol
RD is reading your settings from that file. if you deleted it and settings aren't reset..... you didn't delete the right file...
 
It was in Resources.
And it was the only Rubberduck.config file.
 
%APPDATA%/Roaming/Rubberduck
 
Oh.
Uh oh.
Got that one back.
Wow. Just wow.
 
4:55 AM
Wait for it...
 
beautiful
 
Lovely, isn't it?
All the ones with text before were the ones I changed.
Once we get them displaying, they might work, though.
We'll see.
I have it!
 
ugh "designer" in French.... ....
 
Reading data from the wrong property.
Pushing change.
 
got it. "Mode création"
 
4:59 AM
[retailcoder/Rubberduck] Hosch250 pushed commit 53270dc6 to next: Fix "beautiful"
 
Weird.
I changed my language, and they are in there a zillion times.
They were in there like three times each, or something.
 
still serializing the description?
 
Nope.
var found = configInspections.Any(configInspection => implementedInspection.Name == configInspection.Name);
OK, I need to get to bed before I bust something.
See you.
 
ok
'night!
 
5:45 AM
[retailcoder/Rubberduck] retailcoder pushed commit e9d5729d to next: added 'new' resource string, translated 'z' strings
[retailcoder/Rubberduck] retailcoder pushed commit 031b1217 to next: code explorer docked presenter calls base implementation for proper disposal
 
I don't understand... resources don't seem to update
and that "proper disposal" didn't fix the "excel is restarting" thing
 
6:12 AM
[retailcoder/Rubberduck] retailcoder pushed commit 46be5da8 to next: modified CodeInspectionSettings to no longer serialize the description as an XmlAttribute, and ConfigurationLoader to get the description from runtime instance instead of XML config.
 
http://t.co/rKWzViFPoL
 
6:46 AM
> Eh, our grammar has issues, some of which we have no idea how to fix ...other than rewrite the entire grammar from scratch. Might not be as awesome as a parser that accepts everything the VBA language does, but next release will report ANTLR parser exceptions in a dockable toolwindow:

The only thing is that these *can* sometimes be confusing:

![invalid-input](https://cloud.githubusercontent.com/assets/5751684/7907413/f1bbb61a-0806-11e5-843a-b02624038213.png)

..but it *does* indicate t
 
6:58 AM
Our grammar has issues. Instead of pretending it doesn't, we'll show you what's wrong. Is this a viable alternative? http://t.co/udQipzsJ53
 
 
2 hours later…
9:30 AM
Just implemented a diagnostic that changes if(x is Y) { var xAsY = x as Y; } into var xAsY = x as Y; if(xAsY != null) { }
Anyone interested in testing it or thinking about scenarios I haven't thought of in my tests yet? github.com/Vannevelj/VSDiagnostics/blob/master/VSDiagnostics/…
oh, this is the rubberduck room
 
 
3 hours later…
12:09 PM
monking all!
Nice to start the morning with two silveryish new badges in and !
2
 
@JeroenVannevel question for you when you have a moment. How do I debug a unit test in that project. I was trying to implement the issue I submitted, but the debugger wants to skip over the code.
@FreeMan Nice! Grats!
 
thanks!
 
@Mat'sMug pretty pretty flowchart. =)
 
@RubberDuck #OnlyWithResharper
...and it's a dependency graph ;-)
 
Potato/Pah-taht-oh
I know a flow chart when I see one. =;)-
 
12:23 PM
lol
 
@Rubberduck203 @Unihedro @StackCodeReview LOLCODE eh? whistles...
 
00:00 - 13:0013:00 - 00:00

« first day (360 days earlier)      last day (2820 days later) »