12:00 AM
1 hour later…
17 hours later…
6:35 PM
[rubberduck-vba/Rubberduck] mccordscvs added label bug to issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
[rubberduck-vba/Rubberduck] mccordscvs opened issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
> **Rubberduck version information**
Version 2.5.0.5524
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5026.1000
Host Executable: EXCEL.EXE
**Description**
When pressing the tab key after preforming a search in Add/Remove references a "Null Reference" error occurs. Pressing tab in other locations will also cause this error. Also, when pressing ENTER while the cursor is in the search textbox closes the references Dialogue.
**To
Version 2.5.0.5524
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5026.1000
Host Executable: EXCEL.EXE
**Description**
When pressing the tab key after preforming a search in Add/Remove references a "Null Reference" error occurs. Pressing tab in other locations will also cause this error. Also, when pressing ENTER while the cursor is in the search textbox closes the references Dialogue.
**To
[rubberduck-vba/Rubberduck] mccordscvs created comment on issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
> Wow! Thanks for this amazingly extensive report!
Looks like some temporal coupling is going on, probably code in the ViewModel making assumptions about the state of things. Without looking at the code in question, the provided stack trace makes it seem an easy fix. Obviously the ViewModel will need a number of additional unit tests, too.
Looks like some temporal coupling is going on, probably code in the ViewModel making assumptions about the state of things. Without looking at the code in question, the provided stack trace makes it seem an easy fix. Obviously the ViewModel will need a number of additional unit tests, too.
7:05 PM
[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
> Here:
https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-27
Removing the assumption that there *is* a selected item should fix the NRE.
https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-27
Removing the assumption that there *is* a selected item should fix the NRE.
[rubberduck-vba/Rubberduck] retailcoder added label difficulty-01-duckling to issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
[rubberduck-vba/Rubberduck] retailcoder edited comment on issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
> Here:
https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-L27
Removing the assumption that there *is* a selected item should fix the NRE.
https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-L27
Removing the assumption that there *is* a selected item should fix the NRE.
[rubberduck-vba/Rubberduck] retailcoder edited comment on issue #5553: Null Refrence Exception when tabbing in Add/Remove Refrences and related issues.
> Here:
https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-L27
Removing the assumption that there *is* a selected item should fix the NRE. Actually the fix should probably be to assign the `.Text` to `cs?.SomeProperty ?? string.Empty`.
https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-L27
Removing the assumption that there *is* a selected item should fix the NRE. Actually the fix should probably be to assign the `.Text` to `cs?.SomeProperty ?? string.Empty`.
7:51 PM
8:02 PM
[rubberduck-vba/Rubberduck] mccordscvs opened issue #5554: The description in Add/Remove refrence dialogue is offset.
> ###**Rubberduck version information**
Version 2.5.0.5524
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5026.1000
Host Executable: EXCEL.EXE
**Description**
The short description and path at the bottom of the Add/Remove Reference dialogue is not in sync with the item selected in the list when scrolling with the arrow keys.
**To Reproduce**
- Open the RubberDuck Add/Remove references Dialogue Box.
- Select any item in the
Version 2.5.0.5524
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5026.1000
Host Executable: EXCEL.EXE
**Description**
The short description and path at the bottom of the Add/Remove Reference dialogue is not in sync with the item selected in the list when scrolling with the arrow keys.
**To Reproduce**
- Open the RubberDuck Add/Remove references Dialogue Box.
- Select any item in the
[rubberduck-vba/Rubberduck] mccordscvs added label bug to issue #5554: The description in Add/Remove refrence dialogue is offset.
« first day (2258 days earlier) ← previous day
