Discussion on question by Tyler: Is it appropriate for a professor to require students to sign a non-disclosure agreement before being taught?

Imported from a comment discussion on https://academia.stackexchange.com/questions/135842/is-it-appropriate-for-a-professor-to-require-students-to-sign-a-non-disclosure-a