Discussion on question by Stankar0x: Code readability, conventions and should I let go

Discussion on question by Stankar0x:

Imported from a comment discussion on https://workplace.stackexchange.com/questions/102453/code-readability-conventions-and-should-i-let-go
2659d ago – Chris
21
1

export all events for this room

Starred posts

Nov 13, 2017 22:24
You don't have peer-reviewed pull requests? I think that is a bigger concern than what you did.
Nov 13, 2017 22:24
Drive-by code fixing without talking to the person who will maintain your changes is very impolite. All other things aside, this is the crux of the problem.
Nov 13, 2017 22:24
@terdon It should be pretty easy to tell that he meant to say he brought it closer but not perfectly in line, which is still more compliant rather than less.