Starred posts

rolfl

Aug 20, 2014 16:42

One day I will get involved in 'easy' discussions.

3

rolfl

Aug 19, 2014 20:41

11

Q: Questions about interfaces, protocols, and APIs

Are questions about interfaces/protocols and APIs on-topic for Code Review? And when I say "protocol", I mean this in the Objective-C/Swift (and potentially other languages) version of the word, which is basically the same as a Java interface. There is this meta discussion: “Code not yet writ...

3

rolfl

Aug 18, 2014 16:52

(and, apparently, I upvoted it at some point, sorry).

3

200_success

Aug 18, 2014 14:59

Buses have WiFi? Wow.

3

rolfl

Sep 7, 2014 00:38

But, my attitude, at the moment, is that we can't make every question on code review a great question.

2

200_success

Aug 31, 2014 17:14

Probably too subjective for Stack Overflow's tastes. Followed by an obligatory comment to repost/migrate to Code Review.

2

rolfl

Aug 31, 2014 12:19

On the other hand, these questions by current agreement, are on-topic, and the code can be reviewed for what it is, not what it should be.

2

Simon André Forsberg

Aug 26, 2014 14:03

@RubberDuck you could just review the code even though he doesn't explicitly ask for one

2

Simon André Forsberg

Aug 22, 2014 12:32

*sigh*

2

nhgrif

Aug 21, 2014 21:42

I don't like that we're putting so much weight on the way users are phrasing the plain-English parts of their questions. All other reasons aside, it puts non-native-English-speakers at a significant disadvantage.

2

vnp

Aug 20, 2014 22:23

When reviewing code at work I am supposed to point to better ways of doing things. In some sense a question of better way is always present, even when it is not explicitly asked. The line I guess is in the code itself.

2

rolfl

Aug 20, 2014 17:23

0

Q: Code Review vs. Help me solve my problem

A question that asks: I don't know how to best solve problem X, can you suggest a way? ... is clearly off-topic on Code Review. A question that asks: I have solved problem X, and this is how I did it. Is it a good solution? ... is clearly on-topic on Code Review. There is a grey are...

discussion scope

2

Simon André Forsberg

Aug 20, 2014 15:54

@rolfl Amen

2

ckuhn203

Aug 20, 2014 15:50

@rolfl Those questions are bad questions and should be downvoted, but that doesn't necessarily make them off topic.

2

rolfl

Aug 20, 2014 15:40

requesting a rewrite is off, giving a rewrite is on.

2

Vogel612

Aug 20, 2014 13:12

and that's imo one of the biggest points of a CodeReview.

2

rolfl

Aug 19, 2014 20:13

@ckuhn203 - I appreciate your participation as a 'dummy' we can poke spears at!

2

Simon André Forsberg

Aug 19, 2014 20:00

Metthod signatures = how it does it

2

Vogel612

Aug 18, 2014 16:26

@200_success make it an UML then. The problem stays the same...

2

rolfl

Aug 18, 2014 15:37

and it's the stuff that's not there, that is reviewable.

2

200_success

Aug 18, 2014 15:08

You could also say that all of our answers are opinionated.

2

Simon André Forsberg

Aug 18, 2014 14:44

@200_success Helps, yes. Necessary to make it on-topic, no.

2

rolfl

Sep 11, 2014 18:11

What will benefit you most is understainding why your attempts so far have failed.

nhgrif

Sep 6, 2014 21:21

If English isn't your first language, you may struggle to see the subtle differences in the phrases we consider on or off-topic, and as you'd rather have your question open and not closed, posting a code-only question is the "better safe than sorry" approach.

rolfl

Aug 26, 2014 20:51

So, if the other stuff is on topic, but not great, I can alsways just downvote the folk who I think are lazy, and answer and help the folk I think are trying, and are 'worth it'.

rolfl

Aug 26, 2014 20:49

I don't want to become that place on SE where lazy people go to get their work and thinking done for them.

Simon André Forsberg

Aug 22, 2014 12:28

@RubberDuck With emphasis on thinking of doing this. I.e. he hasn't done it that way yet.

rolfl

Aug 22, 2014 11:57

Argh, I am getting more convinced..... that I may be wrong.

nhgrif

Aug 22, 2014 11:34

Yea. Plain English part differentiates mediocre on topic questions from great on-topic questions, but given that a chunk of code with very little plain English is on-topic, it's weird that some non-code phrases make it off-topic.

nhgrif

Aug 22, 2014 11:34

Better to be mediocre and on-topic than to be off topic.

RubberDuck

Aug 22, 2014 11:29

Well, it's like I said earlier. If the way a question is stated is the issue, it can be edited to be on topic.

Vogel612

Aug 21, 2014 16:59

> Although this is compressing a twelve-hundred-and-some-odd-word long post into a single sentence, I think the message is rather clear: The difference between a question and a discussion or poll is that a real question is seeking to discover some particular truth. The other type of "question" is merely seeking to learn what other people think.

rolfl

Aug 21, 2014 15:34

I find the unicorn blood is rejuvenating for the skin, and leaves a fresh lustre in my hair!

Simon André Forsberg

Aug 21, 2014 15:27

@Vogel612 I think those questions "Is there a better way?" are both SO and CR. It might be on-topic on SO, but I would not say it is off-topic here.

Simon André Forsberg

Aug 20, 2014 15:58

lol ^^

rolfl

Aug 20, 2014 15:53

if they do materialize, I can say "told you so.... ;-)".

rolfl

Aug 20, 2014 15:53

if they don't, you can do that to me.

ckuhn203

Aug 20, 2014 15:46

That's an awful lot of awfully fine semantics...

Vogel612

Aug 20, 2014 15:35

@SimonAndréForsberg I think here's again where the difference between refactor and rewrite comes in.

Vogel612

Aug 20, 2014 15:27

So in short:
Is this a good way? --> on
What is a good way? --> off

Simon André Forsberg

Aug 20, 2014 15:25

@rolfl Please use "reply to message" for such markings (when there are new chat messages appearing all the time)

Simon André Forsberg

Aug 20, 2014 15:21

@Vogel612 You still end up calculating probabilities in Minesweeper. You can still achieve the same results, only in different ways.

Vogel612

Aug 20, 2014 15:20

@SimonAndréForsberg but how is method signatures part of the how then?

Vogel612

Aug 20, 2014 14:59

@SimonAndréForsberg I'd have never formulated it that way, but I think in essence you are right..

Simon André Forsberg

Aug 20, 2014 14:41

Not all things that are up for review has to be "finished". In fact, if things ever was finished then the whole point of this site would be gone. "Sorry, there's no point in reviewing your code, it's finished already because you put it up for review. We can only review code that is finished.".

Simon André Forsberg

Aug 20, 2014 14:39

this.knownWords.add("asinine");

ckuhn203

Aug 20, 2014 14:26

And, even if OP does, there's still something to be learned from reviewing the rest of the code.

Simon André Forsberg

Aug 20, 2014 14:21

@Vogel612 It's called refactoring or rewriting and programmers do it all the time

ckuhn203

Aug 20, 2014 13:48

So, here's my question fellas. What is it about design questions (with implementation) that hurt the site?

Vogel612

Aug 19, 2014 20:15

The cool thing is probably: if we could understand @rolfls point and he'd understand ours, we probably wouldn't even realize what @Simon said

Code Review - Discussion about help vs. review

Code Review - Discussion about help v…