Conversation started Jun 10, 2014 at 2:39.
Dagg Nabbit
Dagg Nabbit
Jun 10, 2014 02:39
@Mat'sMug why are we reviewing broken code =/
maybe i'm not familiar enough with the way stuff works here yet
but
i thought that was explicitly OT
Mat's Mug
Mat's Mug
you're right, but it was migrated 10 hours ago, if we wanted to reject migration, I think we should have done so 9-10 hours ago; moving the question back and forth across sites won't make a very good impression to this new SE user. And OP isn't specifically asking to fix any issues with their code, and the issue in question is trivial - normally we'd close and let the OP edit/fix before reopening, but on migrated questions it's a little bit different.
@Jamal please correct me if I'm wrong here
Jamal
Jamal
@Mat'sMug If the OP were unaware of errors beforehand, then this may be allowed.
Dagg Nabbit
Dagg Nabbit
it's a syntax error
there's no way he even ran the code if he's not aware of it
the parser will throw that right out
if this kind of thing can be excused as "maybe he didn't know" then the working code rule is essentially useless
i could just write asfdkijs;dkilfaiosgj;aksdgj;aksifhiuhfsfh <- please review that code
to the best of my knowledge it works since i haven't tested it
Mat's Mug
Mat's Mug
Jun 10, 2014 02:55
@Jamal how long can a migrated post be bounced back to the original site?
Jamal
Jamal
I think it can be done at any time.
Mat's Mug
Mat's Mug
so we should just close it then
I find 10 hours to reject makes us look somewhat sloppy. it just hit the close queue.
Jamal
Jamal
I'd lock it instead, but that would also reject the migration.
Dagg Nabbit
Dagg Nabbit
how much trouble would it be to amend the FAQ slightly
instead of "To the best of my knowledge, does the code work?"
it could be
"To the best of my knowledge, does the code work? Have I made a reasonable effort to ensure that it works?"
or something
that would leave no room for doubt in cases like this
Mat's Mug
Mat's Mug
"My code compiles and when it runs, it does what it's meant to be doing"?
Dagg Nabbit
Dagg Nabbit
Jun 10, 2014 03:03
i just think there should be something paired with "as far as i know it works"
along the lines of "and i actually tested it"
Mat's Mug
Mat's Mug
user image
Dagg Nabbit
Dagg Nabbit
although maybe "real code from a project" covers that?
Mat's Mug
Mat's Mug
related:
8
Q: Make the help center more explicit about what CR is NOT

Mat's MugThere has been discussion recently, about how lots of Stack Overflow users carelessly refer OP over here (CR) whenever the question roughly looks like a wall of code and OP is asking for help nailing down a specific bug. Currently our help/on-topic words it as follows (emphasis mine), under a la...

feature-request off-topic help-center
 
Conversation ended Jun 10, 2014 at 3:06.