« first day (478 days earlier)      last day (2702 days later) » 

Duga
Duga
12:02 AM
RELOAD!
[Cardshifter/Cardshifter] 6 commits. 3 opened issues. 2 issue comments. 76 additions. 39 deletions.
[Cardshifter/HTML-Client] 4 commits. 1 opened issue. 3 closed issues. 3 issue comments. 8 additions. 13 deletions.
[Hosch250/VSDiagnostics] 7 commits. 3417 additions. 132 deletions.
[Phrancis/GroovyDatabase] 1 commit. 301 additions. 141 deletions.
[retailcoder/Rubberduck] 10 commits. 16918 additions. 16220 deletions.
[rubberduck-vba/Rubberduck] 35 commits. 14 closed issues. 18 issue comments. 35301 additions. 29066 deletions.
[skiwi2/ROVControlSoftware] 5 commits. 235 additions. 62 deletions.
[Vogel612/TranslationHelper\‌​] 4 commits. 2 closed issues. 664 additions. 577 deletions.
[Zomis/Brainduck] 1 closed issue. 1 issue comment.
[retailcoder/Rubberduck] retailcoder pushed commit 65b74f9c to next: fixes #725
[rubberduck-vba/Rubberduck] retailcoder pushed commit 65b74f9c to next: fixes #725
Merge pull request #792 from retailcoder/next

fixes #725
 
Duga
Duga
12:29 AM
> Yup, fixed.
> I'm closing this issue, since I couldn't get a repro with 1.4.x, #732 and #744 have been dealt with, and v2.0 introduces a completely different startup paradigm.
 
Duga
Duga
12:46 AM
 
 
2 hours later…
Duga
Duga
3:11 AM
[rubberduck-vba/Rubberduck] build for commit 8f35f517 on next: AppVeyor build failed
BUILD FAILURE!
 
 
10 hours later…
Duck Review
Duck Review
1:17 PM
0
Q: Learning by translating - Follow the Rubberduck - Part 2: Beta

Vogel612This project is my learning place for a few things: MVP (model view presenter) XML (parsing, editing and leveraging) deeper swing functionality Concerning the XML part I have already recieved a very nice review by rolfl on my previous question. Since then quite a lot of things have changed a...

java xml swing i18n rubberduck
 
 
4 hours later…
Mat's Mug
Mat's Mug
4:59 PM
@Duga 22 tests failed. Gotta fix that.
 
 
2 hours later…
Mat's Mug
Mat's Mug
6:56 PM
great, rename refactoring is borked.
 
 
4 hours later…
Mat's Mug
Mat's Mug
11:04 PM
down to 6 failing tests
 
Duga
Duga
 
Hosch250
Hosch250
Gave myself away :P
 
Duga
Duga
[Hosch250/Rubberduck] Hosch250 pushed 1 commit to next
 
Mat's Mug
Mat's Mug
hellow
 
Duga
Duga
[Hosch250/Rubberduck] Hosch250 pushed 58 commits to next (only showing some of them below)
[Hosch250/Rubberduck] retailcoder pushed commit edea056e to next: implented UntypedFunctionUsageInspection (#407)
[Hosch250/Rubberduck] retailcoder pushed commit f28c7fc2 to next: fixed resolver bug with global built-in variable usages.
Merge pull request #789 from retailcoder/next

UntypedFunctionUsageInspection
[Hosch250/Rubberduck] retailcoder pushed commit 8dc515a7 to next: Added WriteOnlyPropertyInspection. fixes #14.
 
Hosch250
Hosch250
11:06 PM
Got any specific commands to be written? I'm going to splurge for the rest of the day.
 
Duga
Duga
Merge pull request #790 from retailcoder/next

Added WriteOnlyPropertyInspection. fixes #14.
[Hosch250/Rubberduck] retailcoder pushed commit cbcc5837 to next: fixed resolver bug. fixes #727
Merge pull request #791 from retailcoder/next

fixed resolver bug. fixes #727
[Hosch250/Rubberduck] retailcoder pushed commit 65b74f9c to next: fixes #725
Merge pull request #792 from retailcoder/next

fixes #725
 
Mat's Mug
Mat's Mug
@Hosch250 how about #763 and #764? :)
 
Duga
Duga
Merge pull request #1 from rubberduck-vba/next

pull
 
Hosch250
Hosch250
764 is going.
 
Mat's Mug
Mat's Mug
1 test failing
428 tests passed
 
Duga
Duga
11:14 PM
[Hosch250/Rubberduck] Hosch250 pushed commit b8ffd8d2 to next: Closes #764
 
Mat's Mug
Mat's Mug
2 skipped
@Duga already?!
 
Hosch250
Hosch250
I can't build, for some reason :(
@Mat'sMug You know how fast I work ;)
 
Mat's Mug
Mat's Mug
does it work?
 
Duga
Duga
[retailcoder/Rubberduck] retailcoder pushed commit a437a783 to next: change log fix
[retailcoder/Rubberduck] retailcoder pushed commit 4fa4dc2e to next: fixed DeclareAsExplicitVariantQuickFix
 
Hosch250
Hosch250
That is the copy/paste solution, and the files say they are alright.
 
Duga
Duga
11:15 PM
[retailcoder/Rubberduck] retailcoder pushed commit 4f911bfb to next: fixed NRE in rename refactoring
[retailcoder/Rubberduck] retailcoder pushed commit 7bdab14d to next: fixed NRE's in RenameRefactoring. All tests pass!
 
Hosch250
Hosch250
The Source Control solution build failed.
Oh, now it is just the main Rubberduck project.
R# thinks everything is fine, though. I'm not sure why my tests aren't running.
 
Mat's Mug
Mat's Mug
weird
everything A-1 here
 
Hosch250
Hosch250
LOL. I forgot to run as admin.
Just checked my error list.
 
Duga
Duga
 
Mat's Mug
Mat's Mug
might want to pull that
 
Duga
Duga
11:17 PM
[rubberduck-vba/Rubberduck] retailcoder pushed commit a437a783 to next: change log fix
[rubberduck-vba/Rubberduck] retailcoder pushed commit 4fa4dc2e to next: fixed DeclareAsExplicitVariantQuickFix
 
Hosch250
Hosch250
Will as soon as I run my tests.
 
Duga
Duga
[rubberduck-vba/Rubberduck] retailcoder pushed commit 4f911bfb to next: fixed NRE in rename refactoring
[rubberduck-vba/Rubberduck] retailcoder pushed commit 7bdab14d to next: fixed NRE's in RenameRefactoring. All tests pass!
Merge pull request #793 from retailcoder/next

bug fixes. all tests pass!
 
Hosch250
Hosch250
What in the world?! Every single test is failing!
 
Mat's Mug
Mat's Mug
breathe, pull ;-)
 
Hosch250
Hosch250
> System.InvalidCastException: Unable to cast object of type '<>c' to type 'Rubberduck.Parsing.Symbols.Declaration'.
 
Duga
Duga
11:19 PM
 
Mat's Mug
Mat's Mug
what's the stack trace?
 
Duga
Duga
[Hosch250/Rubberduck] retailcoder pushed commit a437a783 to next: change log fix
[Hosch250/Rubberduck] retailcoder pushed commit 4fa4dc2e to next: fixed DeclareAsExplicitVariantQuickFix
 
Hosch250
Hosch250
> at System.Linq.Enumerable.<CastIterator>d__1`1.MoveNext()
at Rubberduck.Parsing.VBProjectParseResult..ctor(VBProject project, IEnumerable`1 parseResults) in VBProjectParseResult.cs: line 24
at Rubberduck.Parsing.VBA.RubberduckParser.Parse(VBProject project, Object owner) in RubberduckParser.cs: line 83
at RubberduckTests.Refactoring.ReorderParametersTests.ReorderParams_SwapPositions() in ReorderParametersTests.cs: line 44
 
Duga
Duga
[Hosch250/Rubberduck] retailcoder pushed commit 4f911bfb to next: fixed NRE in rename refactoring
[Hosch250/Rubberduck] retailcoder pushed commit 7bdab14d to next: fixed NRE's in RenameRefactoring. All tests pass!
Merge pull request #793 from retailcoder/next

bug fixes. all tests pass!
Merge pull request #2 from rubberduck-vba/next

pull
 
Hosch250
Hosch250
Same issue in Remove.
What did you do now? I had those tests passing!
 
Mat's Mug
Mat's Mug
11:21 PM
I have 428 passing tests here, none failing
 
Hosch250
Hosch250
I wonder if it is the CodePane wrapper.
 
Mat's Mug
Mat's Mug
likely
 
Hosch250
Hosch250
No, that is accounted for.
Should I PR it and let you run them?
 
Mat's Mug
Mat's Mug
> Test Passed - ReorderParams_SwapPositions 71ms
 
Hosch250
Hosch250
Huh.
 
Mat's Mug
Mat's Mug
11:24 PM
are you up-to-date with the main repo? I'm not sure I understand what's going on here
 
Hosch250
Hosch250
I just pulled from Next - and synced too.
 
Duga
Duga
 
Hosch250
Hosch250
Let's see you run them.
Are you up to date with Next?
Or is Next up to date with you, I mean?
Now RD isn't loading in Excel :(
What's up this time?
 
Mat's Mug
Mat's Mug
missing reg keys?
 
Hosch250
Hosch250
I can see it in the Add-ins window.
But when I load it, it fails.
All 5 solutions build.
 
Mat's Mug
Mat's Mug
11:28 PM
is it the VBE failing to load it, or you're getting an exception at startup?
you're running the "debug" configuration?
 
Hosch250
Hosch250
Yeah.
@Mat'sMug It has an exception.
I'm checking my reg keys again.
 
Mat's Mug
Mat's Mug
what's the exception?
 
Hosch250
Hosch250
There isn't one.
Reg keys alright.
At least, it isn't throwing in RD, it just closes.
 
Duga
Duga
 
Hosch250
Hosch250
OK, I won't do that anymore.
 
Mat's Mug
Mat's Mug
11:40 PM
do what?
 
Hosch250
Hosch250
Change the reference.
Like where you just commented.
I just saw you had changed the Remove there, so I changed Reorder.
 
Mat's Mug
Mat's Mug
oh, it was a good idea - it's just that both RubberduckMenu and RefactorMenu are officially decommissioned ;-)
 
Hosch250
Hosch250
OK.
 
Mat's Mug
Mat's Mug
expands the few lines below that ...dang, you're right! :)
 
Duga
Duga
[Hosch250/Rubberduck] Hosch250 pushed commit fefc1a6a to next: Closes #763
[Hosch250/Rubberduck] Hosch250 pushed commit d75c13e3 to next: Merge branch 'next' of github.com/Hosch250/Rubberduck
 
Hosch250
Hosch250
11:50 PM
Check that out. I'm not sure if I split the two versions right.
 
Duga
Duga
 
Mat's Mug
Mat's Mug
what am I looking for?
 
Duga
Duga
Merge pull request #1 from rubberduck-vba/next

pull
[rubberduck-vba/Rubberduck] Hosch250 pushed commit b8ffd8d2 to next: Closes #764
Merge pull request #2 from rubberduck-vba/next

pull
[rubberduck-vba/Rubberduck] Hosch250 pushed commit fefc1a6a to next: Closes #763
Merge pull request #794 from Hosch250/next

Closes #764
 
Hosch250
Hosch250
Did I handle that if right? What about when we want a QualifiedSelection, or whatever?
Should we add that as needed, or have it ready-to-go?
 
Mat's Mug
Mat's Mug
a Declaration has a QualifiedSelection
passing the target as the command parameter looks like the cleanest thing to do, no?
 
Hosch250
Hosch250
11:58 PM
I'm pretty sure we have a Refactor(QualifiedSelection) method.
@Mat'sMug Yeah, that's what I thought.
 

« first day (478 days earlier)      last day (2702 days later) »