Hey I'm still a random guy on the internet :P it's easy to understand! And even if it would be in person I understand that people don't want to share this!
Darn. I just finished writing an answer and after I posted it, I just realized that someone else had already posted an answer 10 minutes ago that already had 3 votes and an accept.
> Before you can install Node, you’ll need to install two other applications. Fortunately, once you’ve got these on your machine, installing Node takes just a few minutes.
XCode. Apple’s XCode development software is used to build Mac and iOS apps, but it also includes the tools you need to compile software for use on your Mac. XCode is free and you can find it in the Apple App Store. Homebrew. Homebrew is a package manager for the Mac — it makes installing most open source sofware (like Node) as simple as writing brew install node. You can learn more about Homebrew at the Homebrew website…
You know, I've been thinking about cimmanon's suggestion to not use tables for the layout (on that lobby question)... and the more I think about it... The more I tell myself: It looks and behaves exactly as intended... Do we really need to go back to the drawing board?
I was wondering the same exact thing after reading DanPantry's answer: according to him, I've basically messed up on every aspect of AngularJS in my code. Am I going to change that now? Or course not: that's a complete waste of time. However, once a full playable client is up and running and I no longer have to worry about trying to match the Java client, I can then go back and begin to correct the AngularJS.
@SirPython at your convenience could you add a message similar to the "No player / Mod" selected, but for the "Deck Builer" button in Lobby that only checks for a mod (and informs accordingly)?
> In various scenes in the code, there are places where there a button-like figures with a radio button circle inside. One example of this is the mod section of the lobby.
Often times I find myself trying to click the button-like figure around the radio button, but instead I have to aim my mouse at this tiny circle on the button-like figure. It would be much easier if I could just click the button-like figure itself.
@Duga @SirPython I'm hoping to get rid of the radio button itself at some point in favor of something that looks more like a game UI, rather than a HTML4 form :)
(e.g., just highlighting the value/thing with different CSS colors and such)
@Phrancis I'm getting an error from the server whenever I try to send the picked cards from the deck builder. Do you think you could help me out if I gave you a server log?
at com.cardshifter.server.clients.ClientWebSocket.handleMessage(ClientWebSocket.java:107)
at com.cardshifter.server.model.ServerWeb$InnerServer.onMessage(ServerWeb.java:77)
at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:469)
at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:368)
at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:157)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:657)
hey @Phrancis, i just found this game for iOS called Loot & Legends. its free to play so you should check it out when you get a chance. its kind of hard to explain, but it has a collectible card mechanic that is very unique
<!-- LIST OF ALL CARDS - Displays one full row below for every card -->
<table>
<tr data-ng-repeat="card in cards">
<!-- Creature Type -->
<td>
<!-- TODO: Talk to @SirPython about why this {{card.properties.type}} is not showing anything inside the table cell. -->
{{card.properties.type}}
</td>
<!-- Card name and link to see card info. -->
<td>
<a data-ng-click="showDetails(card)">{{card.properties.name}}</a>
^^ @SirPython See the empty cells to the left of the card name re: above TODO
not sure how fun you will find the game. the combat is based on tabletop D & D and is somewhat repetitive. what is interesting about the game is the way that you collect gear for your characters, and how each piece of gear adds cards to the deck of cards you use for that character during battle
@SirPython personal preference but I see no use in ever using $scope directly. The only exception is in the link function of directives when you want to use $watch. You can, of course, use $scope if you want, but I think the controllerAs syntax is much cleaner, and you need to use objects in the scope anyway otherwise you run into prototypical inheritance issues inside isolate scope
@Phrancis some packages use native compilation so -shrug-
worth it though
webpack-dev-server is one of those, and karma. sorry. :-(
it could be worse, I had to install visual studio 2013 for it
> it would be useful to have a develop branch on this repository for potential contributors to pull from and point PRs at. That way we don't end up breaking working, released code (master) with development code (develop). All branches would branch off of the develop branch and be merged back into develop until a new release is ready, at which point it would be merged into master and tagged
@SirPython It would be useful to have unit tests to help facilitate this. ;-) Don't worry about saying you've 'messed up on angular'. It is better to have things work than have them be pretty.
My answer wasn't to make you feel like you've messed up on angular, but to point out potential improvements. You haven't done anything wrong, you just haven't necessarily done it how I would have. But that's the point of code review :-)
btw, install packages using npm. ng-FitText is on npm. npm i ng-fittext --save and then require('ng-fittext'); angular.module('foo', ['ngFitText']);
@Phrancis this is my fault. I think it would make sense to have the default name be template.html but you can really name it whatever you want as long as the intent is clear. I don't think it makes sense to name a file deck_builder.html inside of the deck_builder folder as its already clear that I'm looking at deck builder
If I have a game server running as well as npm run develop together, every time I make a change to the client and the app refreshes, the game server crashes with a StackOverflowException
I have a server log and want to file an issue to report but I'm not sure if I should file it as a server issue in the main repo, or a client issue in the HTML one
> I've been noticing this issue lately and has been particularly frustrating now that the web client runs with `npm` where every change it the client source code causes an app refresh, which then causes the error and requires restarting a game server to continue.
I've copied a [full server log](http://pastebin.com/psrpZnVH) and below are the lines where the error occurs.
> Note that you can opt-out of the auto refresh by just going to http;//localhost:8080 instead of http://localhost:8080/webpack-dev-server. This doesn't fix the issue obviously.
> Was `card_model/` meant to be included in this commit? I don't think it should be on the master branch, it looks like demo code. I would personally have expected this to be in a feature branch. If it's on the master branch then any contributors get it when we update.
> Also, as for data-* prefixes, we can do this in a post-processor because we are now using a build step. See here for a tool we could use. If we are going to take this approach we may also want to add a build step for validating HTML5?
> Put this on the back burner until I can figure out how to neatly replace assets with externals at build time with webpack. Until then this will only result in performance degradation
@SirPython @jacwah FYI my changes didn't alter the server interface so any functionality it had should be intact
@SirPython the problem with the PR I had for the uglification is that I can't find a nice way that works on windows to choose to use 'externals' in production build and the vendor chunk in the dev build
I'll have to wait until I get home for that, but it should be pretty simple using environment variables
During testing, I accidently attempted to log in without a username and I logged in with success (which is not a good thing). Now, the client will block you from logging in if you have not yet entered a username.
Ideally both. The client should do validation for UX, but ultimately the server has to be safe when run from any client (even a modified or malicious one)
In this case it's not a big security issue, but might still cause problems
> A closely related issue is that a client can log in with an empty user name. It's also possible to choose user names like " " (only space) and other problematic ones. We need to lay down some rules on what names are valid. I'll leave a suggestion below.
A user name... - is unique. Two clients can not connect with the same name simultaneously. - is at least 1 character and at most 20 characters long. - contains only ASCII letters, spaces, underscores and decimal numbers. - does not begin
VS is downloading @skiwi for right now I'm actually setting up Outlook rules because I get some many (hundreds per day) Sql error emails. Setting up an error dump directory
@jacwah I think the libGdx client uses encoded or serialized messages of some sort, that may be why this is there; perhaps @bazola can shed some light?
@SirPython I have a question; I saw in deck builder you used {{card.properties.name}} in one place, and {{card.max}} another place. How do you differentiate which properties are part of which set? I'd like to document that as I will need to be able to query these fields in several areas of the client
(in particular for the card models where this will be crucial)
[Cardshifter/HTML-Client]Phrancis pushed commit c2c12f94 to sections-layout: Added ngFitText directive to www/index.html as this will be needed in some sections of the client. The code related to this directive is located in `/ngFitText/ng-
@jacwah sorry if its already answered but yes, the GWT version of the libGDX client uses web sockets, and the mobile and desktop versions use regular sockets. And it does also crash for me as well when trying to use the websocket version with the cardshifter server
for me, it is possible to connect to the server with the GWT version of cardshifter, and it is possible to start a game, but after a while it causes the server to crash and it stops working
The HTML is the new client that the relatively new guys here are building, the GWT client is the same client as our existing desktop client but then uses a library/framework/tool to be able to host it on a website
So if the GWT client sends base64 encoded messages through WebSocket and the HTML client doesn't encode its messages, how can they both work? They don't on my computer, but obviously on other's.
> You could use `catch( InvalidUserNameException | UserNameAlreadyInUseException e) { client.sendToClient(new WelcomeMessage(0, false, ex.getMessage()));` and just create the message with the exception. It would remove the if construct.
