The Loop

toscho

1:10 AM

Today’s Wooxplosion requires more drastic actions. This is not acceptable anymore.

Sisir

4:58 AM

Can I have php storm ignore .git directory if I drag and drop a whole directory to remote for uploading?

Ionică Bizău

8:44 AM

Hi, is there anybody that can answer this question? Thanks!

toscho

@IonicăBizău the plugin’s support forum

Ionică Bizău

9:00 AM

@toscho That's a good idea. Thanks!

G. M.

1:13 PM

See something strange here? core.trac.wordpress.org/browser/tags/3.8.3/src/wp-includes/…

Tom J Nowell

1:26 PM

WordCamp Manchester

@wcmcr, Manchester, UK

Saturday 28th June 2014 @ Manchester Metropolitan University

1 tweets, 13 followers, following 0 users

Rarst

1:44 PM

@toscho we can do scrub event... I want to do one when their site finally launches really, but they are still not releasing it

Rarst

4:46 PM

Have a topic or speaker you want to see at WordCamp NYC, fill out the reverse call for speakers: http://2014.nyc.wordcamp.org/call-for-speakers-now-open/

Tweeted by aaronjorbin on April 16, 2014 at 4:44 PM

cool idea

Christine Cooper

6:06 PM

The thing about Hostgator's continuous server outages is that I used to be quite happy about it because we would get the next month's of server costs for free (for 1-2 hours of downtime) but nowadays when site traffic is high, it is not cool at all.

Anyway, server down for 1+ hour so far.

Rarst

morale of the story — use hosting that doesn't suck

Christine Cooper

I know, I have been recommended to change many many times.

@Rarst Did I tell you I finally finished watching Attack on Titan?! Great anime. Must wait ages for the next episode though :'(

Rarst

yeah, I hope they make another season later :)

Christine Cooper

They will, just that it will take a year or two. Thinking about just reading the manga to find out what's going on.

Rarst

I am reading manga, some more action but then it gets internal/political

it's not weekly so slow moving

Christine Cooper

6:13 PM

Political sounds good to me.

There are actually some hilarious panic tweets about hostgator atm: twitter.com/search?q=hostgator&src=typd&f=realtime

Rarst have you watched this anime named "Monster"? It is next on my watchlist- I've heard great things about it, apparently the thriller quality of Death Note...

Rarst

it's better than death note :)

Christine Cooper

In what way? Are you a big fan of Death Note though?

Rarst

Death Note is a little too reliant on mystical premise, Monster is purely psychological and plays out over much longer period

Christine Cooper

I can't wait to watch it! Do you have any recommendations of great anime for someone who loved Death Note? :D

Rarst

Code Geass

Christine Cooper

6:23 PM

I will download. I've heard about it many times.

Rarst

I am squeeing about No Game No Life today, just started — heavy on game theory and hilarious on top :) maybe overdoing it with fan service though

Christine Cooper

Never heard about it. Let me google.

Rarst

if you like game theory stuff (with less thriller/detective) as well watch Gyakkyou Burai Kaiji, it's fantastic

Christine Cooper

This?: imdb.com/title/tt1202625

Rarst

anidb.net/perl-bin/animedb.pl?show=anime&aid=8242

Christine Cooper

6:29 PM

Nice! I like the synopsis, added to watchlist.

Just quick question, did you watch the sub or Eng dub of Monster? The copy I have is dual audio. I wouldn't mind watching the eng dub if it is actually good voice-acting (which it rarely is with english dubs)...

Stack Exchange

WordPress News: WordPress 3.9 “Smith”

posted on April 16, 2014 by Matt Mullenweg

Version 3.9 of WordPress, named “Smith” in honor of jazz organist Jimmy Smith, is available for download or update in your WordPress dashboard. This release features a number of refinements that we hope you’ll love. A smoother media editing experience Improved visual editing The updated visual editor has improved speed, accessibility, and mobile support. You can paste into the…

Chip Bennett

Anyone interested in giving me feedback on my draft breadcrumb function that I'm trying to work up for a core patch? gist.github.com/chipbennett/10013478

toscho

6:47 PM

function wp_nav_breadcrumb_front_page( $base_link ) {
	return apply_filters( 'wp_nav_breadcrumb_front_page', array(
		'hierarchy' => false,
		'current_location' => $base_link
	) );
}

@ChipBennett WTH will that do?

Chip Bennett

follow the function to the end :)

toscho

That is where the function ends

Chip Bennett

And what calls that function?

toscho

no idea

This is callback hell. Please don’t.

you have one very long function that does too much and some shorter functions which are impossible to understand without knowing the super function

Chip Bennett

Oddly, it was @kaiser who asked me to make it a bunch of callbacks, instead of self-contained

toscho

6:53 PM

OMG, never listen to @kaiser

5

Chip Bennett

How would you propose doing it? Keep it self-contained?

toscho

I would separate the output from the logic

and put both in separate classes, so you can replace both implementations during run time

Chip Bennett

So you think I should turn all of this into a class?

Wyck

toscho

@ChipBennett three classes actually: one for the items, one for the strings and one for the actual HTML output

Rarst

7:02 PM

...and one that will dig a hole for chances of core inclusion :)

Chip Bennett

@Rarst what do you see are the issues that would prevent core inclusion?

Rarst

my sarcastic guess would be that multi-class, semi-templated solution will get discussed right to its death

Chip Bennett

@Rarst and what of the current approach?

Rarst

no on callback hell

toscho

@ChipBennett most core contributors are rather … OOP agnostic

Rarst

7:05 PM

I use Hybrid breadcrumbs, usd to be a super-function, now a class

Chip Bennett

@Rarst so if I pulled all of the callbacks back into the main function?

Rarst

I don't think this is going to work as a function(s)

hybrid-core / extensions / breadcrumb-trail.php

breadcrumbs are pain because there is too much crap to support for generic use

Chip Bennett

@Rarst so it's better for Themes to keep reinventing the breadcrumb wheel?

That's the real issue here: I see tons of Themes that all create their own breadcrumb functions

Rarst

it's their funeral that they don't feel like reusing existing solutions :)

I mean this would be nice in core, but core tends to run things like this into a ground

see: widgets, menus

Chip Bennett

@Rarst what existing solutions? That's the point: there are no "existing solutions"

Rarst

7:12 PM

you just said that people keep inventing it? how can people invent and not produce solutions?

I just linked you one from Hybrid :) it's not the fanciest but battle-tested and not theme-specific

Chip Bennett

@Rarst "not theme-specific" is a key point: it's template-specific output that should have at least a basic core implementation.

Heck, pull the Hybrid class into core for all I care

but core needs something

Rarst

I gave up on "core needs" because whatever I think isn't what core people think, so why bother?

Chip Bennett

@Rarst because I have a vested interest in what mutually benefits Theme developers and end users

Rarst

by all means, honestly good luck :) personally I am just burnt out on core perspective/contribution/whatever, I just do whatever I want

maybe that's part of explanation for theme vendors inventing wheels :)

Chip Bennett

@Rarst then why have any core template functions at all?

let's get rid of paginate_links(), posts_nav_links(), etc.

Rarst

7:20 PM

I don't know and don't care :) quoting myself "Innovation in WordPress templating is dead"

I love the idea of breadcrumb function in core, but I am pretty sure core priorities would twist it into a monster I would hate

toscho

@ChipBennett this is how I would try to solve that, just a concept, you can reuse your existing logic: gist.github.com/toscho/10922906

wp_nav_breadcrumb() acts as a very simple controller now, nothing else

Rarst

WP core templating excels at lines, is very good at lists, starts to crumble on nested lists, and horrible for anything more complex

Chip Bennett

I'll take a look at making it a class

toscho

The dependency on interfaces makes it easy to use custom implementations for the logic, the text strings and the HTML. and unit tests are simpler too

G. M.

7:46 PM

@ChipBennett look at this... just conceptual completely untested gist.github.com/Giuseppe-Mazzapica/965681cbfa4f37e333cc

but I think it needs some explaination on how it works...

Chip Bennett

Yeah, I just see lots of complexity

Side note: is this a bug or a feature? svn.automattic.com/wordpress/tags/3.8/wp-includes/template.php

get_query_template() applies a filter: apply_filters( "{$type}_template", $template )

Front page template passes front_page as $type

return get_query_template( 'front_page', $templates );

But if you try add_filter( 'front_page_template', $callback ), it doesn't wok

But add_filter( 'frontpage_template', $callback ) does work

get_query_template() does this to $type:

$type = preg_replace( '|[^a-z0-9-]+|', '', $type );

I see no underscore there

so what's going on?

Sisir

pretty good explanation of heartbleed bug :)

G. M.

I have to change this line 'front_page' => array ( 'front_page' ), to 'frontpage' => array ( 'front_page' )

as said completely untested

and written so quickly ;)

boscho

@ChipBennett that regex doesn't list the _ character but that caret is negating the character class... It's removing anything that isn't an alphanumeric character or a dash, so get_query_template( 'front_page' ) and get_query_template( 'frontpage' ) both invoke apply_filters( 'frontpage_template', $template )

Chip Bennett

@boscho so that's a bug then, right?

how would the regex be constructed to allow for the underscore that is intended to be passed?

This is pretty explicit intent to have a front_page_template filter name: return get_query_template( 'front_page', $templates );

Would it be this? $type = preg_replace( '|[^a-z0-9-_]+|', '', $type );

boscho

8:02 PM

I totally get what you're saying, but I haven't stared at it long enough to determine whether or not that's a bug... it could well have a purpose, but I would need to roll up my sleeves and really dig to work it out!

@ChipBennett That regex would indeed maintain any underscores in $type

Chip Bennett

I think I'll patch it up and submit it. Thanks!

boscho

It occurs to me that WP might expect you to format your $type strings with hyphens instead of underscores: get_query_template( 'front-page' ). Taking a glance at the Coding Standards Handbook, this may be because $type refers to a template file, and the standard states that filenames should be hyphen delimited...

Although it would be really nice if the codex mentioned all that somewhere, if it is the case.

G. M.

The whole things works in this way:

a breadcrumps navigation is made by some 'crumbs'.

Every crumb can be of different crumb type. We have a 'category' crumb, 'home' crumb, 'parent' crumb, and so on...

Actually I have written 18 crumb types, but is also possible create custom crumb types, registering them (i.e. attaching a callable to a specific crum type slug).

However, a set of crumbs is a breadcrumb template.

One register a specific crumb template, for specific query types, using template hierarchy:

you can register a template for 'page' one for 'page-$id' and one for 'page-$slug'.

or a template for 'taxonomy', 'taxonomy-$taxonomy', 'taxonomy-$taxonomy-$term'... and so on.

Note that the crumb template follow the template hierarchy no matter for the template file is loaded by WordPress: if you have only a 'taxonomy.php', but you register a breadcrump template to be used for 'taxonomy-$taxonomy-$term' this template is used when you call wp_nav_breadcrump inside 'taxonomy.php'.

This gives you flexibility to show whatever template you want, for every query template type.

After that, you call wp_nav_breadcrump passing some args to customize output and/or set a custom query, and the function output a breadcrumps using the template registered and the current query object.

Is also possible to pass to function a specific template name, or even a specific template array (to output custom breadcrump templates without registering them).

@ChipBennett

Chip Bennett

@boscho there's already a ticket/patch for the issue - 21 months old, of course: core.trac.wordpress.org/ticket/21213

Not getting fixed, because some Plugins might break :/

boscho

@ChipBennett Lol, of course.

Chip Bennett

8:18 PM

@G.M. I think that's WAY too complex for what I'm trying to get into core

G. M.

8:45 PM

@ChipBennett yes, probably, but any other way is so inflexible that IMHO make no sense to have it in core

Chip Bennett

@G.M. and that level of flexibility would be debated for five years as a core patch

G. M.

I assume so... But a lower level I bet it will be discarded immediately as unuseful or 'maybe later'

Chip Bennett

That's why I'm trying to find the balance

boscho

We've put an end to dreaming about WordPress forks, right? I mean... that's not something we allow ourselves to do anymore. For health reasons. Right?

Rarst

yes

toscho

8:58 PM

what do you want to reuse? the line numbers?

boscho

Mostly the title.

Rarst

seriously, only to find a way to deal with hardcoded to hell wp-settings.php and so many opportunities will open up...

Transcript for