« first day (2048 days earlier)      last day (2896 days later) » 

11:01 AM
You don't want to track and update a counter on every page hit, it'll have performance problems, won't work on cached pages, and the data will be prone to race conditions
I've done it in the past using Google Analytics
 
11:16 AM
 
 
1 hour later…
12:28 PM
@gmazzap could you please check, I think apostrophe is 26, not 27? gist.github.com/Giuseppe-Mazzapica/…
 
1:12 PM
@gmazzap also you are breaking queries, ?foo=bar turns into ?bar
 
1:25 PM
@TomJNowell wow.. dude you've done a lot. Maybe one day Ill get there, too.
 
 
5 hours later…
5:57 PM
@Rarst apostrophe is 27 3v4l.org/ImI4s I'll look at queries
 
6:15 PM
@Rarst you right, when I cleaned up it to share... I cleaned too much. Fixed, should work now. See 3v4l.org/ldfgo
 
6:53 PM
@gmazzap I wrote a different take today, with just some parts, not bothering recoding whole damn URL github.com/Yoast/wordpress-seo/pull/4653/files
apparently this is way easier in current PHP versions, which are up to date on 3986 thing
 
 
2 hours later…
8:43 PM
@Rarst that filter_var on top may produce some unwanted result... E.g. any URL that contains unencoded & in the path or in the query string will be just returned as is, which I think is not ok for your purpose...
 
I don't care at the moment, the PR is primarily to fix file names with UTF-8 chars
can always improve later. it's no worse than what's already in place for all other cases
 
9:16 PM
@Darth_Vader pull requests welcome ^_^
 

« first day (2048 days earlier)      last day (2896 days later) »