French Conjugation

One part should be merged: if ($auxiliaire->getValue () === Auxiliaire::Etre || $voice->getValue () === Voice::Passive) { I have this condition twice, once for composite und once for !composite, but it works for both

Nobody

then you should invert the order of the ifs

Grischa

lines 857-867 and 984-994

I would add this rules before if (isComposite ( $mood, $tense )) {

Nobody

you could also put it into its own function and call that function in the appropriate cases

Grischa

you mean also in case a composite and case b non-composite?

Nobody

12:45 PM

you just extract the code that is the same into a function

that would be the code on the lines that you described

Grischa

function participe_ending_suffix_passive_etre(Auxiliaire $auxiliaire, Voice $voice, Gender $gender, Person $person) {
if ($auxiliaire->getValue () === Auxiliaire::Etre || $voice->getValue () === Voice::Passive) {
if ($gender->getValue () === Gender::Masculine && (isPlural ( $person ))) {
$participe_passe .= 's';
}
if ($gender->getValue () === Gender::Feminine && (! isPlural ( $person ))) {
$participe_passe .= 'e';
}
if ($gender->getValue () === Gender::Feminine && (isPlural ( $person ))) {
$participe_passe .= 'es';

Nobody

the variable $participe_passe has to be passed to this function as well

if you want to keep the code as it is you should pass it as a reference parameter

Grischa

ok, should it be a static function in abstract class ConjugationPhrase?

Nobody

yes

Grischa

I can call the function with: ConjugationPhrase::participe_ending_suffix_passive_etre( $auxiliaire, $voice, $gender, $person, $participe_passe) ?

because participe_ending_suffix_passive_etre( $auxiliaire, $voice, $gender, $person, $participe_passe); is unknown for the script

Nobody

12:56 PM

is the code on github?

Grischa

no

I have pushed it now, but with unknown function error

Nobody

1:23 PM

@Grischa okay, you can call the function that way

however, you need to define the parameter $participe_passe as reference parameter

secure.php.net/manual/en/language.references.pass.php

Grischa

you mena adding a & to the reference parameter?

it is working for the first case ...

Nobody

@Grischa yes

Grischa

the script is very slow now, is it because of the many long arrays?

Nobody

maybe

you would have to profile to know for sure

Grischa

I have add a something for the whole script

Nobody

1:32 PM

which something?

Grischa

$time = microtime(TRUE);
$mem = memory_get_usage();

print_r(array(
'memory' => (memory_get_usage() - $mem) / (1024 * 1024),
'seconds' => microtime(TRUE) - $time
));

see results in the bottom at lern-online.net/franzoesisch/grammatik/konjugation-beta/a/…

or lern-online.net/franzoesisch/grammatik/konjugation-beta/d/…

Nobody

that gives you an overall look but you need more detailed information

200

A: Simplest way to profile a PHP script

You want xdebug I think. Install it on the server, turn it on, pump the output through kcachegrind (for linux) or wincachegrind (for windows) and it'll show you a few pretty charts that detail the exact timings, counts and memory usage (but you'll need another extension for that). It rocks, seri...

Grischa

I have read this already.

I do not run the script in localhost like you.

Nobody

I don't as well and the description is about running it on a remote serevr

Grischa

I don't think, I can use Xdebug on the server

Lets finish the last error

I need to replace the the last ending letter if it is an 'e' to 'é' for [Mood::Indicatif][Tense::Present][Person::FirstPersonSingular] for $sentencetype->getValue () === SentenceType::InterrogativeSentence

should I add this in ending.php?

Nobody

1:47 PM

is it part of the conjugation?

Grischa

yes, is a a rule only for InterrogativeSentence

Nobody

okay, is that independent of the infinitive ending?

Grischa

important is only, if the ending is 'e'

aime -> aimé , finis -> finis

Nobody

the ending of the infinitive or of the conjugated verb

Grischa

conjugated verb

Nobody

1:58 PM

okay so it depends on the result of the ending function, right?

Grischa

yes

Nobody

then you should use the function ending to add that

also, the monstrous switch is a bit unnecessary

Grischa

How to improve it?

Nobody

secure.php.net/manual/en/function.call-user-func.php

Grischa

could you push one example?

Nobody

2:12 PM

you only need one example

you replace the whole switch by something like:

call_user_func('ending_'.$exceptionModel->getValue (), array(/*parameters*/));

there are some functions that would have to be renamed though

e.g. ending_passe_subjonctif_changes_re -> ending_vivre

you could add definitions of forwarding functions that deal with that

Grischa

call_user_func('ending_'.$exceptionModel->getValue (), [ExceptionModel::strtoupper($exceptionModel->getValue ())]);

ending_passe_subjonctif_changes_re, ending_ire_with_iss and ending_ire should be using not only for one array

Nobody

as I said you can write functions like ending_vivre that internally just call ending_passe_subjonctif_changes_re

I don't see why you would need strtoupper

Grischa

2:28 PM

@Nobody I don't understrand this part

Nobody

as I said, you would use the call_user_func as I wrote and for those functions that are used multiple times you would write forwarding functions like this:

function ending_vivre($person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb) {
    return ending_passe_subjonctif_changes_re ( $person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb );
}

Grischa

do I have to change here: ExceptionModel::ETRE_IRR :
return ending_etre

to ExceptionModel::ETRE (without _IRR)

Nobody

no

you would just write another forwarding function name ending_etre_irr that forwards to ending_etre

Grischa

but the array is called $aller_irr

Nobody

so?

Grischa

2:36 PM

the function should be called ending_aller_irr

not ending_aller

Nobody

if there is only one call to this function you can rename it directly

otherwise you should add a forwarding function

Grischa

2:48 PM

Fatal error: Uncaught Error: Access to undeclared static property: IrregularExceptionGroup::$exceptionModel

call_user_func('ending_'.$exceptionModel->getValue (), [IrregularExceptionGroup::$exceptionModel->getValue ()]);

from conjugate.php : $irregularExceptionGroupArray = [
ExceptionModel::ALLER => IrregularExceptionGroup::$aller, ...

Nobody

why did you prefix that with IrregularExceptionGroup::?

try: call_user_func('ending_'.$exceptionModel->getValue (), $person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb);

Grischa

I would get Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 4096 bytes) in Enum.php line 35

Nobody

um that is bad

Grischa

, $person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb isn't an array ... or?

Nobody

I think it does not need to be an array

Grischa

2:58 PM

should I pushed my changes?

Nobody

yes

Grischa

pushed it

Nobody

I get an endless recursion in ending_re

ah, I see the problem

the previous code returned when it found the correct function

the current code does not

it would need to check if a function with the name exists and if so return its result, else it should go on with the second (now first) switch

Grischa

could you pushed it?

Nobody

yes, there are many errors

I believe some forwarding functions are missing

Grischa

3:10 PM

because ending_ir is used often at the end of the ir-exceptions?

Nobody

pushed

you would have to go through the old switch code and write a forwarding function for each case where the function does not end in the case name

Grischa

did you sync your changes?

Nobody

yes

Grischa

I think the only functions are ending_ir_with_iss and ending_ir_without_iss

I don't know, what forwarding functions are

could you add it for this 2 function here:

case EndingWith::IR :
return ending_ir ( $person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb );

Nobody

that is a forwarding function:

54 mins ago, by Nobody

function ending_vivre($person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb) {
    return ending_passe_subjonctif_changes_re ( $person, $tense, $mood, $endingwith, $exceptionModel, $infinitiveVerb );
}

it forwards the call to ending_vivre to ending_passe_subjonctif_changes_re

Grischa

3:26 PM

I thought I have written all forwarding functions ..

I only had such cases for verbs not ending with -IR

github.com/GrischaK/french_conjugation/blob/…

Nobody

I pushed some more changes

now I only get failures and no errors in the test

Grischa

I see, I found only one mistake in the name of a forwarding function

naitre instead of naitre, but I have 111 failures