Discussion between Grischa and Nobody

In object-oriented programming, a class is an extensible program-code-template for creating objects, providing initial values for state (member variables) and implementations of behavior (member functions, methods). In many languages, the class name is used as the name for the class (the template itself), the name for the default constructor of the class (subroutine that creates objects), and as the type of objects generated by the type, and these distinct concepts are easily conflated. When an object is created by a constructor of the class, the resulting object is called an instance of the class...

Using many functions is not an improvement on its own

A usual rule is: A function should do only one thing (single responsibility principle) and be rather short

if it becomes longer, subtasks of the function should be moved into own functions

this makes it easier to read, understand and reason about the code

Grischa

So, could you explain what is hard to read in konjugator.php?

Nobody

take for example array_wlk

Grischa

;-) That isn't my code ( only some if conditions)

Nobody

1:50 PM

in the pastebin I can't even find where the function ends

okay, I cannot see what is yours and what isn't

Grischa

no problem

Nobody

should I concentrate on the code you posted in the question?

Grischa

no

Nobody

so what should I write about? is anything from konjugator.php okay, despite not being your code?

Grischa

You mean in the answer or here in chat?

only the idea for array_wlk and many parts from index.php isn't my code

Nobody

1:56 PM

here in chat. you asked "could you explain what is hard to read"

Grischa

I thought we are talking here for improve the whole system not this excetion part form the question ...

Nobody

we are, I just thought you objected when you said "That isn't my code"

but lets get back to konjugator.php

and specifically array_wlk

it is a prime example for a far too long function

each gruppe should probably be separated into its own function

Grischa

pastebin.com/BLgt3Sg6

this is my code for the german verb conjugation (without excetions, only some addition changes for Konditiv II Futur I and II is missing)

example verb 'spielen': lern-online.net/deutsch/grammatik/verb/konjugation-alpha/s/…

Nobody

short question: do you use source control?

Grischa

you mean putting files in pastebin.com Paste Exposure: private?

Nobody

2:09 PM

no

I mean csv, svn, git, mercurial, ...

Grischa

I use CSV for some vocabulary translations ...

Nobody

sry type, I mean CVS

Grischa

not for this script

Nobody

not comma separated values

Grischa

no

This is for saving each version of a script?

Nobody

2:11 PM

yes

to get a backlog

I would recommend you start using something like git

hell, even CVS is better than doing it by hand

Grischa

how to use it?

over github.com?

Nobody

if you don't have a problem with making your code public you can use github

there are alternatives

like bitbucket

and using git you can simply have a local repository

Grischa

I don't understand how to see the result, when using such a plattform

Nobody

github (and the likes) is no platform for hosting a website

it just stores/backs up the code for you

Grischa

what is the difference to backup the files by hand, or upload by hand the files to github or bitbucket?

Nobody

2:18 PM

Revision control

A component of software configuration management, Revision control, also known as version control or source control, is the management of changes to documents, computer programs, large web sites, and other collections of information. Changes are usually identified by a number or letter code, termed the "revision number," "revision level," or simply "revision." For example, an initial set of files is "revision 1." When the first change is made, the resulting set is "revision 2," and so on. Each revision is associated with a timestamp and the person making the change. Revisions can be compare...

the german wiki has a novice friendly section

using (automatic) version control is by far superior to doing backups by hand. it also is orthogonal to backups

Grischa

for example you and I changing konjugator.php on github, I have to copy all code to my real konjugator.php to check it?

Nobody

I am not sure if I understood you correctly:

using git and github we could both work on the code in parallel, later merging together the results

if we did a good job of splitting the work, the merging process is automatic

if not, it requires some manual work

however, it is far less work than having worked in parallel and then tried to merge everything by hand

or even worse: say we both worked on it and had access to the server where it is hosted

Grischa

So, you will say you would work on the code?

Nobody

we are done with our change and upload it

I would work on it as far as the review process here is concerned

just to finish my example: we don't know the other worked on it and uploaded it, so the last to upload his changes overwrites the changes from the other

Grischa

which plattform do you use?

I understand your example already ;-)

Nobody

2:25 PM

Use for what?

for source control

I use git

on github.com?

yes, for some projects

for others I have my private server

github.com/NobodyOnSE

Grischa

can I use github for free, if I had not much files?

Nobody

2:30 PM

for open source repositories github is fully free, private repositories require a subscription fee

at least that is my current knowledge

Grischa

that is correct

I don't understand, how to upload a example file on github

Nobody

help.github.com/categories/bootcamp

I think you have not yet understood the principle of git

Grischa

2:48 PM

github.com/GrischaK/example/blob/master/example-code.php

Nobody

Congrats for your first commit :)

Grischa

could you correct the code?

Nobody

I could but I think that would be too localized

btw. what editor do you use for writing it?

Grischa

notepad++

Nobody

the indentation looks a bit off sometimes

there are several errors in the code

you should at first get the code to a working stage

Grischa

3:00 PM

it works now

now all 4 variantes working

Nobody

okay, the code is still missing <?php ?> but it is working with them

Grischa

3:20 PM

no all 6 variantes works

Nobody

hmm

that is rather hackish

Grischa

"poorly designed workarounds" yes ;-)

Nobody

lets see

first of all there are too many magic numbers

you should replace this at least by enums

and rename the variables

Grischa

you mean the echo part or the foreach part?

Nobody

$test -> $zeit (form)

@Grischa both

Grischa

3:26 PM

test and www was random words

Nobody

obviously

naming things right contributes to a better understanding of the code

Grischa

what are magic numbers?

Nobody

Magic number (programming)

In computer programming, the term magic number has multiple meanings. It could refer to one or more of the following: A constant numerical or text value used to identify a file format or protocol; for files, see List of file signatures Distinctive unique values that are unlikely to be mistaken for other meanings (e.g., Globally Unique Identifiers) Unique values with unexplained meaning or multiple occurrences which could (preferably) be replaced with named constants == Format indicator == === Magic number origin === The format indicator type of magic number was first found in early Seve...

Grischa

you mean to rename the arrays ?

Nobody

those too

but lets take for example:

$werden_array[0][1]

Grischa

3:33 PM

$werden_array[indikativ_futur1][1] ?

Nobody

yes

and the second number as well