Duga sure produces a lot of false positives since our name change.

one more delete vote please: softwareengineering.stackexchange.com/questions/337442/…

@Servy: The Extension Method problem arose in this method:

    /// <summary>
    /// Performs a case-insensitive Contains check.
    /// </summary>
    public static bool Contains(this string haystack, string needle)
    {
        return haystack.ToLower().Contains(needle.ToLower());
    }

Which will clearly fail if either string is null. At the time, I didn't have time to fix the extension method properly (it was in a library that would have required a redeploy), and I wound up with a local function:

        /// <summary>
        /// Performs a case-insensitive, null-tolerant Contains check.
        /// </summary>
        public bool Contains(string haystack, string needle)
        {
            if (haystack == null || needle == null)
                return false;

            return haystack.ToLower().Contains(needle.ToLower());
        }

Which clearly won't fail, even as an extension method.

The environment that we're working in has some constraints. It uses CSScript, which doesn't understand things like object?.Property, which would have come in really handy here.

Extension methods suddenly seemed like a risk, even though they probably aren't.

@RobertHarvey Makes sense. There's a reason I mentioned a NRE bubbling up from internally first, and twice, it seemed the most likely

I assume Contains is static, btw

Yep, static.

Also note that ToLower isn't a reliable way of performing a case insensitive search in many non-English languages

so if that code is for an international application you'd want to actually use a case insensitive string comparer

Most of what we're currently doing in the way of string comparisons is Invariant Culture. When we go multi-lingual, I'll probably switch to a base class strategy.

Or a factory. But each country has its own specialized services anyway.

I like Jeff's post on the subject: blog.codinghorror.com/whats-wrong-with-turkey

(Jon Skeet also has a number of blog posts on the subject)

Yeah, I like the Turkey problem. My favorite Jon Skeet post is this one.

yep, classic post

that comment was deleted!!

:(

One of the perks of being a mod. You get to see massively upvoted, deleted comments. Alas, I can't undelete a comment some other mod deleted.

Fun fact: about 90% of the posts Duga finds are closeable under the current SO rules.