« first day (295 days earlier)      last day (2885 days later) » 

12:00 AM
RELOAD!
[retailcoder/Rubberduck] 3 commits. 2 opened issues. 2 closed issues. 4 issue comments.
 
@Duga We certainly are CR's most active OSS project :)
 
 
2 hours later…
2:29 AM
useful:
Public Sub FindMenuCommand(ByVal caption As String)
    Dim cmd As CommandBar
    Dim ctl As CommandBarControl
    For Each cmd In Application.VBE.CommandBars
        For Each ctl In cmd.Controls
            If ctl.caption = caption Then
                Debug.Print "Found '" & caption & "' at CommandBar '" & cmd.Name & "', index " & cmd.Index & "; control #" & ctl.Index & "."
            End If
        Next
    Next
End Sub
ThisWorkbook.FindMenuCommand "Last Positio&n"
Found 'Last Positio&n' at CommandBar 'Code Window', index 9; control #13.
so the code window's context menu is the "Code Window" commandbar, index 9.
 
2:44 AM
and...
ta-da!
 
3:22 AM
> added refactor code window context menu; fixed #342
 
added Rename button to Code Explorer context menu too, but kept it hidden - I need to think about that one a bit
 
I'm out
 
 
8 hours later…
11:06 AM
hey
 
@skiwi Monking.
 
What time is over there it?
 
It's about 07:10
 
Ah right, I forgot it's 12:10 here
 
 
3 hours later…
2:33 PM
Coming next release: right-click #refactor in the #VBA #IDE!
 
2:44 PM
@RubberDuck I think we should release 1.3 as soon as SC is completed - I'll work on cleaning up in the meantime, instead of adding other features. The Declarations API needs to replace tree listeners just about everywhere. That should speed up a number of inspections...
Refactor/extract-method desperately wants to use that API too
We might also want "Source Control" > "Undo" / "Commit" buttons in the code explorer context menu
 
3:01 PM
Okay. Sounds right to me @Mat'sMug.
I'm almost there with the branches view. Need to finish up the "new branch" functionality and merge yet.
That should be done today.
Then... Settings and ?
...and the actual config that stores project/repo information.
 
Awesome!
> 41 + 18 downloads
 
Okay. 1.3 was going to stuff way too many things. How about we ship source control and refactor/rename, and the rest goes to 1.4?
 
@StackExchange Then 1.4 is going to stuff way too many things!
 
3:17 PM
@Mat'sMug Then put the rest in 1.5
 
#GoWithTheFlow
@RubberDuck We're looking at something like a 2 weeks ETA then, right?
 
Something like that. About 2 I think.
 
If you need help with something, just push what you have into 'next' :)
 
I also think we might want to consider it 2.0 just because the features are huge..
 
They are.
 
3:31 PM
I might actually. I want to make a big change before I "share" it.
Easier merging.
 
Merge next into your branch first, then it should be easier to do the other way around
I'll want a bit more polish if it's going to be 2.0 though
Oh, 32 followers now!
Although... lots can happen in two weeks lol ...we'll see
 
Yeah. Play it by ear.
 
4:22 PM
Relevant, @RubberDuck
> Now, I see you shaking your heads, thinking “Well, some Dutch do this, but NOT all of us!” Well folks, this year it is estimated that nearly 4 million Dutch people will pack up their tents and take the highly exotic camping vacation described above. That is a hell of a lot of caravans —and trust me, the local Dutch Albert Heijn’s will be busy before they leave!
 
lol
 
> Well technically it does. The issue is that the token we intend to rename sometimes only span a single character. This has been observed especially on parameter declarations (parameter usages seem to work as expected) - consider the below code, where | represents the position of the caret on the foo parameter: Public Sub DoSomething(ByRef fo|o As String) foo = "abc" End Sub The rename refactoring will prompt for a new name for the DoSomething procedure. However in this case: Public...
Sub DoSomething(ByRef foo As String) fo|o = "abc" End Sub The rename refactoring will prompt for a new name for the foo parameter. This is annoying. Not a major issue, but annoying. The same behavior has been observed with Const declarations (usages work fine, local variable declarations work fine too). The glitch is not with the rename refactoring code - further investigation is needed to determine if it's with the tokens in the ANTLR syntax tree, or somewhere between the token and...
the Selection struct that's created out of the token's position and length; fixing this issue may also fix an issue with navigation not always making a selection that matches what the IDE is displaying (can't find the issue#, not sure it's documented).
 
4:54 PM
Well there's a problem I hadn't thought about yet.
51
Q: Which characters are illegal within a branch name?

lunohodovWhich characters are illegal within a branch name?

 
Would that throw an exception?
 
> Give feedback to the user as soon as possible.
Disable the "OK" button and warn the user about invalid branch names.

[Valid/Invalid branch names](https://www.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html).
Also, on [SO](http://stackoverflow.com/questions/3651860/which-characters-are-illegal-within-a-branch-name).

May or may not happen for the first version of the integration.
 
Best just handle it than try to validate it ourselves - that's out of our control..
 
Yeah. I can handle it, but why not give a better UX? Not a day 1 requirement.
 
4:59 PM
Yeah
You're right
Suggestion: use the "X" icon I've been using for name validation in refactorings UIs ..#consistency-ftw
 
Not doing it right now, but I'll keep that in mind.
Just created a branch from the IDE. =)
 
5:28 PM
> Added Create New Branch functionality
 
5:57 PM
> With the rename refactoring now implemented, method extraction has no reason not to allow renaming the extracted parameters.
> The DeclarationType enum doesn't have a Project member; identifiers referring to a VBProject are currently being ignored. This needs to be changed so that the rename refactoring can be used to rename a project and all its explicit references in a VBA code base.
 
6:30 PM
> You've earned the 'excel-vba' tag badge (Stack Overflow)
 
6:46 PM
hmm... looking at the #vsAssign grammar rule, which is the only place the ASSIGN (:=) operator token is used in the grammar.... I'm not sure named parameters are correctly picked up by the parser at all....
oooh valueStmt is recursive... it works!!
now, how do I get the procedure's name from the procedure call statement's valueStmt
#ParsingIsHard
ah, got it.
refactor/rename will work with named parameters by the end of the day!
gotta go for now though
 
7:24 PM
Oh nice, find all references will return named parameter usages in procedure calls when used on a parameter identifier!
 
7:52 PM
Nice! Well done.
 
8:51 PM
ready for testing :)
drumroll...
IT WORKS!
2
 
> fixed some resizing issues
> Should be able to "Publish" and "Delete" from a right click context menu.
"Publish" should only be enabled for Unpublished branches.
Delete should ask for confirmation.
> changed IdentifierReferenceListener to pick up named arguments as parameter usages - closes #345
 
@RubberDuck I have to hold myself back with both hands to not implement find all references ;)
 
Then just do it? Why you holding back?
What do we have slated for 1.3 anyway? I have no idea.
 
lol you're assigned to it ;)
 
All I know right now is source control.
Oh. Well, I'm busy.
lol
 
9:01 PM
@RubberDuck you're not going to tell me that twice. watch.
 
:)
I hope to push that one tonight... but I might be forced to watch TV
 
@Mat'sMug, do we have a right arrow in the resources anywhere?
> Forced to watch tv
I know the feeling.
 
@RubberDuck you didn't download the Fugue icons set yet?
 
I did, but I wasn't sure if you had used one someplace else. Consistency
 
9:14 PM
lol I'm not sure either
 
9:36 PM
I found one. Some of this might need an extra touch of sexy when I'm done.
 
9:52 PM
@RubberDuck I sent you emails I got from the website form, fyi
 
When? I just checked my email and don't see them...
 
> Yep, 32 bit version of office. My bad!
@RubberDuck Oh crap. I have your email @gmail.co ....
Nope. Not that. I sent it to the one with your full name
 
...shouldn't matter. That one forwards to the one I check. Weird.
Just got it.
 
you should have 3
fwd delays I guess
 
I'll get the laptop out. Maybe it got caught in that account's spam filter.
 
10:04 PM
hey, it's still faster than traditional mail ;)
 
Word. So did x64 guy get worked out?
 
11 mins ago, by Mat's Mug
> Yep, 32 bit version of office. My bad!
I guess we have a new happy customer :)
> 44 + 18 downloads in 12 days
1.2 had 65 downloads in 13 days
1.3 will crush these figures
the website's front page will need to make sure GitHub integration is here :)
 
10:20 PM
Gotta get it done first.
> brewing coffee
LOL. That's awesome. Poor guy.
Okay @ducky, let's make this actually do something.
 
10:40 PM
FormBorderStyle => FixedSingle
@RubberDuck looks good!
 
Thanks! What's Fixed Single do @Mat'sMug?
 
(I'll change it a bit though)
it makes the window non-resizeable
 
Ahh. Okay.
 
and then you need to remove the minimize & maximize boxes
and the ducky icon ;)
 
Yeah! How'd you do that anyway?
Found it!
 
10:45 PM
just set the Icon property! IIRC the ducky.ico is ... yay!
story time, then kids.beginbedtime
(they didn't nap today)
I'd add top (white) & bottom (control dark) panels, too... or would that be overkill?
 
It'd be consistent.
But it's not a very big form. Idk.
 
lol.. it has twice as many controls as the "rename" box ;)
I'll do it if you're not comfortable with UI works, no worries
 
I had to dive into the depths of SO :(
I'm surprised how you guys manage to keep up a project with two persons only, that requires perseverance
3
Often people lose interest every once in a while
 
11:01 PM
@skiwi I do though!
But then I'll be at work and think
> Man..... I really wish I had an easy way to put this code in a git repo...
And then I'm back here working on RD again.
 
@RubberDuck Haha, nice ;)
That's maybe the 'problem' with my projects, I'll never miss them if I don't finish them
 
Very likely.
I'm also on a deadline with what I'm working on right now.
I have about 9 days to get a working prototype together. Then I have a class starting and shortly after a week long conference.
I won't be making many commits in April.
 
> Added IMergeView and MergeForm
> Tweaked some GUI settings
 
ugh. a named parameter usage /reference isn't picked up as a rename target
            // bug: doesn't acquire named parameter usage
            var targets = _declarations.Items.Where(declaration =>
                declaration.QualifiedName.QualifiedModuleName == selection.QualifiedName
                && (declaration.Selection.Contains(selection.Selection))
                || declaration.References.Any(r => r.Selection.Contains(selection.Selection)))
                .ToList();
@RubberDuck isn't that lovely?
 
11:17 PM
That I won't be making commits in April?
No. It's terrible.
 
IKR
gotta fix that
but now I'm getting the evil eye
 
Go brother. I'll talk to you later.
I'm gonna take a quick break myself.
 
[hopefully]bbl
 
11:33 PM
When I work out all the little kinks, I'm going to loooove this feature! #refactor #vba http://t.co/oqmzKxipmD
 

« first day (295 days earlier)      last day (2885 days later) »