AutoReviewComment script devel

« first day (15 days earlier) ← previous day next day → last day (352 days later) »

6:38 AM

@OliverSalzburg, made a new icon, but I can't get it to compile again. The "@ant-sites-chrome-list@" in manifset.json just gets replaced with ${sites-chrome-list}

Does that ring a bell?

Derek 朕會功夫

7:10 AM

@Benjol Hi.

Benjol

@Derek朕會功夫, hello

Caleb and Oliver finally pushed me into paying the $5 to create a chrome developer account :)

The idea is I also push the extension up there, so yeah, if you could modify yours to point to mine, that would be cool.

See this comment: chat.stackexchange.com/transcript/message/14216327#14216327

Also, if you could send me your original screen shots, that would save me re-doing them myself :)

Hope you don't mind ...

2 hours later…

Oliver Salzburg

9:08 AM

@Benjol I guess that would indicate that sites-chrome-listis never filled. What system are you building on with what command line?

Benjol

@Oliver Windows/build.sh

The weird thing is it worked the other day. I thought I'd fixed everything with autocrlf, but apparently not

(btw The other things do get filled)

Oliver Salzburg

What branch are you using?

Benjol

@OliverSalzburg, devel...

hmm, I guess that might explain things,.

I should be on hotfix, I think

Oliver Salzburg

Works great here

I always check out as-is and commit as-is though. I never autocrlf

But I also can't imagine that this is the source of a problem with ant :\

Benjol

@OliverSalzburg, yeah, well I turned that off the other day, so that shoudl'nt be the problem anymore

hm, same problem off auto-fixes, so it's not that...

weird

Oliver Salzburg

9:16 AM

Are there any errors at all in the build log?

Benjol

@OliverSalzburg, nope

I think I'll check line feeds again :(

it's not that: autocrlf = false

Oliver Salzburg

All files on my end have UNIX line endings, in case you want to double-check that

Try adding the following as the last directive in the sites-chrome task

<echo message="${sites-chrome-list}"/>

Then run that task with ant sites-chrome

It prints the correct list for me

Benjol

9:33 AM

@OliverSalzburg even build.xml?

@OliverSalzburg empty for me

I'm going to try a hard reset

@OliverSalzburg, hm, that's better

So yeah, it was line endings, again, but I'm not sure how that happened...

@OliverSalzburg, thanks. Re-submitted to Opera

Not sure where to commit my icon change to though. Any preferences?

Oliver Salzburg

@Benjol devel, I guess. I'm not 100% up-to-date on the branches :)

Benjol

@OliverSalzburg, well, by the look of things, build.xml has windows line endings in devel

either that or there's a problem with me switching brances

very strange

@Caleb, I've pushed a commit onto devel with modified icon16.png (for opera)

Oliver Salzburg

9:52 AM

@Benjol I just fetched a fresh copy from GitHub. No CRLF for me

Benjol

@OliverSalzburg, weird

Oliver Salzburg

Either way, this shouldn't be an issue. It's a bug if it is

Benjol

@OliverSalzburg, do you want me to create an issue on github?

Oliver Salzburg

I just converted my build.xml to Windows EOL, still works

A-ha!

CRLF in build.sites breaks it

@Benjol Yeah, create one, please :)

OliverSalzburg@OLIVER-PC /c/p/SE-AutoReviewComments ((4a4369c...))
$ ant sites-chrome
Buildfile: c:\p\SE-AutoReviewComments\build.xml

sites-chrome:
     [echo] ${sites-chrome-list}

BUILD SUCCESSFUL
Total time: 0 seconds

There's that's with CRLF EOL

Benjol

@OliverSalzburg, Done #35

« first day (15 days earlier) ← previous day next day → last day (352 days later) »

all rooms