Charcoal HQ

Cerbrus

12:02 AM

@JF: Fixed those anchor hovers :D Thanks for the report!

quartata

github.com/Charcoal-SE/metasmoke/issues/139

@Undo

J F

12:45 AM

@Cerbrus Thanks!

quartata

12:59 AM

@ArtOfCode Replied

quartata

1:23 AM

@ArtOfCode Which do you think would be better: user time or wall-clock time?

ArtOfCode

...what

quartata

...ah

ArtOfCode

What's user time? In what scenario?

quartata

$ time sleep 1

real	0m1.002s
user	0m0.001s
sys	0m0.002s

So user here is how much time was spent in the program itself

sys is how much time was deferred to the kernel doing syscalls

and real is the wall-clock i.e how much time actually passed

The reason why real is so much bigger is because since it slept the process was blocked

which isn't included in either user or sys

If this was multi-threaded I'd do wall-clock since user would count the time spent on each core together. But I'm not sure for this one, honestly.

ArtOfCode

Real, then, since that's the timing that we're actually going to be affected by (i.e. taking longer before the report hits chat)

quartata

1:26 AM

It depends on what the rules are doing.

@ArtOfCode Fair enough.

That's easier anyways

SmokeDetector

[ SmokeDetector | MS ] Repeated URL at end of long post: Exported DXF from QGIS won't open in AutoCAD by David Zheng on gis.SE

tpu- by quartata

quartata

Weird, Git is taking its sweet time on one of these objects...

What indentation are you using? Don't want Vim to accidentally expand all of your tabs here or anything.

ArtOfCode

@quartata Smokey?

quartata

I figured it out, it's 4 spaces. But yes.

ArtOfCode

yeah

and 2 for metasmoke

quartata

1:38 AM

Should !!/test output the times?

Or at least just the total?

Andy

Have you considered just running the built in profiler? stackoverflow.com/a/582337/189134

quartata

A full-blown profiler would have massive overhead.

That would make any potential problem worse :P

Thomas Ward

lurks

quartata

Just a quick time.time() is sufficient for this, we're not trying to be std::chrono over here or anything

Andy

Well, as proposed, this seems like a solution in search of a problem

Thomas Ward

1:43 AM

blurgh evil Internet is evil

quartata

@ArtOfCode Do I need to worry about Python 2?

ArtOfCode

uhhh yes

the entire thing is python 2

quartata

OK. It's not a massive deal, I just need to do .itervalues()

Returns a generator of the values instead of a giant list

> if 0 < len(test):

help

I'm doing git blame on that one

That just gave my brain a total workout reading

Thomas Ward

@Andy This breaks self.* calls by the way

quartata

OK, this confuses me a little bit:

                is_spam, reason, why = check_if_spam_json(a)
                t = Thread(name="bodyfetcher post enqueing",
                           target=GlobalVars.bodyfetcher.add_to_queue,
                           args=(a, True if is_spam else None))
                t.start()

If I'm understanding this right

it's checking the username title first

Then if that's not spam it fetches the body and tests it?

Andy

1:51 AM

@ThomasWard eh? It's a class. How would that break self.*

Seth

hey, does anyone here have a mass editing script by any chance?

Thomas Ward

bleh i'm tired, @Andy. It didn't want to behave. And I think we'll have to refactor at other places...

ArtOfCode

@Seth can't say I do, but I suspect it wouldn't be too difficult to compose one

depends what you need it to do

Thomas Ward

2:06 AM

@Undo @ArtOfCode I'm confused, why do we print the config information in GlobalVars, and not as part of ws.py?

ArtOfCode

@ThomasWard because that piece of code is 3 years old and was never designed to support a project this huge?

Thomas Ward

ah

mind if I move it?

ArtOfCode

refactor away

if it works the same before and after, I'm happy

quartata

@quartata Can anyone confirm this?

Seth

@ArtOfCode I just need something that can change a given URL to another given URL. I can provide an input csv of links to work on. Fairly simple. I was hoping to put it on a timer and do ~20 a day.

Thomas Ward

2:18 AM

@ArtOfCode I just want the print statements to go somewhere else lol

Seth

But don't bother building something, there are other options.

quartata

What's the URL? I think you could make a feature request to make Community do it if it's SE-related

SmokeDetector

[ SmokeDetector | MS ] Manually reported answer: Real Time personalized videos by George Jones on video.SE

tpu- by quartata

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body: About recently added FIFA Coins PS3 by Evangeline on aviation.SE

quartata

@Cerbrus I think something's wrong with FIRE -- when I tpu- something it opens up the homepage of the SE site rather than flagging (even when I have an account there)

SmokeDetector

tpu- by quartata

Andy

2:22 AM

@ThomasWard that's why I nicely labeled it a major effort :)

Thomas Ward

well I have a prototype "post" object here

and the parsing capacity to parse JSON or API response data directly

so we don't need separate check_if_spam_json or check_if_spam

so we can create it as Post(api_response=blah) or Post(json=blah)

and then it inits the object itself

but it's still a prototype and not functional. Yet.

(I have a lot of raise NotImplemented in it :P)

Thomas Ward

2:35 AM

@Andy The preliminary object for Post is here: github.com/Charcoal-SE/SmokeDetector/tree/classes_refactor

in that branch

@Undo @ArtOfCode ^ based on the check_if_spam args.

no other code has really been touched though

my head hurts. provided we don't lose power tomorrow due to the snow storm i'll work more on it, since campus is closed and what not.

SmokeDetector

Restart: API quota is 7994.

Thomas Ward

3:05 AM

do we have an example of an API response for a new question or answer?

Undo

3:19 AM

I can probably get you one

We always take the whole question, which is why we sometimes detect answers with no recent activity.

https://api.stackexchange.com/2.2/questions{q_modifier}?site={site}&filter=!)E0g*ODaEZ(SgULQhYvCYbu09*ss(bKFdnTrGmGUxnqPptuHP&key=IAkbitmze4B8KpacUfLqkw((

Thomas Ward

indeed.

@Undo actually, I think i'm gonna need some help refactoring the tests

Undo

k

Thomas Ward

Also note that I have an evil added to the CI tests for that branch - I'll have to process classes/* separately, because of the evil of Importing shit.

from classes import Post won't work unless from Post import Post is in the classes package's init. and that errors badly

Undo

man that's a horrid URL

https://api.stackexchange.com/2.2/questions/41755016?site=stackoverflow&filter=!)E0g*ODaEZ(SgULQhYvCYbu09*ss(bKFdnTrGmGUxnqPptuHP&key=IAkbitmze4B8KpacUfLqkw((

Thomas Ward

I can use it still :P

I just need a response so I know what it looks like :)

make sure I parse things right :P

Undo

3:23 AM

yeah, you can curl that or whatever

Hey, 8k spam flags

Andy

@quartata, I want to make it clear that I'm not trying to shoot down your idea on GitHub, but I want to make sure we aren't doing things just because we can. Performance improvements are always welcome, but I think you may be trying to optimize (or even measure efficiency) the wrong things.

@ThomasWard Errors in CI?

SmokeDetector

3:46 AM

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, pattern-matching product name in body, pattern-matching product name in title, +2 more: maleenhancementshop.info/alpha-prime-elite/ by kassierilson on apple.SE

Thomas Ward

@Andy Yep.

@Andy note CI is now breaking on that branch hard with the tests, because that isn't refactored to create post objects to test with

Andy

That's not surprising, I was more interested in how it's failing on the imports

Thomas Ward

@Andy "Unused import"

hang on

i'll pull a CI log

oops i have to fix something first I failed

Andy

@ThomasWard cough stupid error cough

:)

But, I suppose that makes sense at this point too

Thomas Ward

@Andy circleci.com/gh/Charcoal-SE/SmokeDetector/4983 - note the F401 notice.

I want that to be OK for 'classes' with its init file, because that way we can from classes import Post proper without doing from classes.Post import Post

but, this isn't unlike us splitting the Flake8 off for 'tests' in the CI either

special-case handling can be easy xD

@Andy now, of course, you can see it's going to error HARD on the tests

Unfortunately I'm not as well versed in the tests thing to refactor those

... though that one looks like a 'cannot import' failure

Undo

3:51 AM

Looks like a circular import?

Thomas Ward

... ah, right.

hmm.

@Undo before I had parsing in it gave failure because spam checks now need a Post object

Undo

Yeah. chatcommunicate imports parsing, then it goes down the chain until Post tries to import parsing

@ThomasWard Yeah, that shouldn't be a hard refactor

Thomas Ward

@Undo yeowch, that's an evil test failure output

@Undo well, that branch can use some refactoring of the tests independently from Master

and then we can test-run it on a Smokey instance

Undo

Yep, that'll be fixable

Andy

> Your build output is too large to display in the browser. Only the first 400000 characters are displayed.

Thomas Ward

3:53 AM

I literally have nothing to do all day tomorrow

Andy

heh

Thomas Ward

@Undo @Andy I made it 'easy' to either be an API response or a JSON response, depending on what arg. you use to init the Post object. Post(json_data=<JSON>) will do a JSON parsing, Post(api_response=<APIRESPONSE>) will do API response parsing.

it sorta takes the fun out of some of the parsing, but made a little more sense to me in terms of code repetition, etc.

note: untested, I am a little tired after all :P

Undo

github.com/Charcoal-SE/SmokeDetector/blob/classes_refactor/… does look a little off ;)

Thomas Ward

wow i'm tired

Undo

and surrounding methods

Thomas Ward

3:56 AM

@Undo that's real easy to fix

Undo

Yeah. I just figured you were stubbing it in for later

Thomas Ward

@Undo yep pretty much

Also fixed now.

And I discovered some errors in __repr__ :P

(that's what str(Post_Object) or print Post_Object would call by default)

Undo

Yep, like description in Cocoa

Thomas Ward

I basically stole the argparse.Namespace class style of outputting the post object, but eh.

that's just a specialized __repr__ but works better for this case, IMO.

@Undo in theory, this is ready for a 'test' but it'll need the tests refactored.

if it passes testsuite then it's up to you guys whether to test run it realtime or not.

Undo

Heck, why not test it in prod

Testing on my Pi

SmokeDetector

4:04 AM

[ SmokeDetector ] SmokeDetector started at rev e2ea048 (Thomas Ward: Properly do property returns, and repr str conversions.) (running on Undo's Raspberry Pi)

Thomas Ward

lol it improperly formats xD

Undo

AttributeError: Post instance has no attribute 'site'
Traceback (most recent call last):
  File "ws.py", line 283, in <module>
    is_spam, reason, why = check_if_spam_json(a)
  File "/media/sda1/SmokeDetector/spamhandling.py", line 61, in check_if_spam_json
    is_spam, reason, why = check_if_spam(post)
  File "/media/sda1/SmokeDetector/spamhandling.py", line 34, in check_if_spam
    test, why = FindSpam.test_post(post)
  File "/media/sda1/SmokeDetector/findspam.py", line 921, in test_post
    matched_body, why_body = rule['method'](body_to_check, post.site, post.user_name)

Thomas Ward

oops?

oh.

that's my fault heh.

Undo

Yeah, could just alias site to post_site

Unless there's no reason to have the former

Andy

please don't alias. Let's just fix it

Undo

4:06 AM

Or that

Thomas Ward

@Undo literally a one-line change. Everywhere, it's referred to post_site as part of the spam checks, so I just used that.

Undo

Great

Thomas Ward

post.site has become post.post_site

and pushed up to that branch

Undo

And trying again

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 247683f (Thomas Ward: post.site should be post.post_site) (running on Undo's Raspberry Pi)

Restart: API quota is 9997.

Thomas Ward

4:07 AM

I mean, we could make a property called site in the Post object, but... like, why?

Undo

yeah, if it's not used anywhere else then there's no reason to

So far, it seems to be 'not broken'

Not throwing errors, at least

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching website in body: Ocean Eye Serum by mancefog on meta.SE

Thomas Ward

(yay!)

was that picked up on your RPi, @Undo?

Undo

I have no way to know, actually

Thomas Ward

!!/location

SmokeDetector

4:09 AM

@ThomasWard ArtOfCode/EC2

@ThomasWard Undo's Raspberry Pi

Undo

well, I could go look in metasmoke logs

Thomas Ward

i do.

!!/standby ArtOfCode

SmokeDetector

ArtOfCode/EC2 is switching to standby

Undo

That works

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev 158e861 (Thomas Ward: Slight refactor of chat logon handling.) (running on ArtOfCode/EC2)

Thomas Ward

4:10 AM

@Undo I'd still be curious to see what MS says reported that since we have two instances up heh

@Undo oh, is your RPi in CHQ only mode?

Undo

No

@ThomasWard Reported by Art's instance

Thomas Ward

figures.

Undo

Well here's one way

!!/location

SmokeDetector

@Undo Undo's Raspberry Pi

Thomas Ward

@Undo let's wait to see if anything else is captured, if not, then we know it's "not working"

Undo

4:12 AM

!!/report softwarerecs.stackexchange.com/q/40052/46

Thomas Ward

explosions!

kablam!

Undo

TypeError: handle_spam() got an unexpected keyword argument 'title'
2017-03-14 04:12:12.766868 UTC
  File "/media/sda1/SmokeDetector/excepthook.py", line 48, in run_with_except_hook
    run_old(*args, **kw)

  File "/usr/lib/python2.7/threading.py", line 505, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/browser.py", line 714, in _runner
    self.on_activity(json.loads(a))

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/rooms.py", line 85, in on_activity

Failover triggered

Thomas Ward

oh wow i'm blind lol

hang on

SmokeDetector

ArtOfCode/EC2 received failover signal.

Restart: API quota is 7697.

[ SmokeDetector | MS ] Mostly non-Latin answer: Convert Spreadsheet/ Excel English data in Marathi by user7706502 on stackoverflow.com

Thomas Ward

hrm

Undo

4:16 AM

translate: એક્ષેલ માં નંબર કે રકમને ગુજરતી શબ્દોમાં લખવા માટે

'ello?

I'll say NAA

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body: At this you may shift to train by Judeorr on meta.SE

tpu- by Undo

[ SmokeDetector | MS ] Few unique characters in answer, no whitespace in answer: Angular 2 Dependency Injection with Interface Scenario by metulburr on stackoverflow.com

SmokeDetector

4:31 AM

[ SmokeDetector ] SmokeDetector started at rev adaa37f (Thomas Ward: Refactor test chat commands and !!/report check.) (running on Undo's Raspberry Pi)

[ SmokeDetector | MS ] URL-only title, bad keyword in body, blacklisted website in body, blacklisted website in title, link at end of body: fornatgaex.com/testo-edge-ex/ by dcghnjsd on askubuntu.com

Andy

@ThomasWard, in _parse_json_post, which json.loads should be there? github.com/Charcoal-SE/SmokeDetector/blob/classes_refactor/…

If the first succeeds, the second fails with a Type Error (because it's now a dict instead of a string)

Undo

KeyError: 'site'
2017-03-14 04:32:00.414857 UTC
  File "/media/sda1/SmokeDetector/excepthook.py", line 48, in run_with_except_hook
    run_old(*args, **kw)

  File "/usr/lib/python2.7/threading.py", line 505, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/media/sda1/SmokeDetector/bodyfetcher.py", line 93, in add_to_queue
    self.check_queue()

  File "/media/sda1/SmokeDetector/bodyfetcher.py", line 110, in check_queue
    self.make_api_call_for_site(site)

  File "/media/sda1/SmokeDetector/bodyfetcher.py", line 265, in make_api_call_for_site

Andy

I'm not sure what the first one is doing. What's the hb test value from?

Undo

The socket sends heartbeat messages

Andy

ah

just the wrong variable in the second one then

Thomas Ward

4:36 AM

@Undo ahead of you

just pushed that fix

Undo

Pulled

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 09ec5e7 (Thomas Ward: Refactor so that 'site' becomes a parameter of API post items.) (running on Undo's Raspberry Pi)

Restart: API quota is 9981.

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, pattern-matching website in body: What is Vlamorous and how can it function? by user665088 on askubuntu.com

Thomas Ward

@Andy Then how did this work in the first place?

the JSON parsing is basically verbatim from that

also, JSON and Dict are pretty much interchangebale

a basic dict is valid JSON

SmokeDetector

tpu- by Undo

Thomas Ward

and in fact over on CR we keep recommending "If you are importing a dict from a file, use the json lib to load the data from the file."

Andy

4:39 AM

@ThomasWard They are, but that second call to loads is expecting a string.

Does that code work?

Because it shouldn't. The first .loads() changes a string to a dict. The second is trying to change a string to a dict, but we are passing a dict

Thomas Ward

@Andy I'd need a sample JSON to test with.

Which I don't have.

Undo

Pulling one more time for a test

Thomas Ward

this is part of our "test in production" thing :p

Undo

After that I need to go to bed

Thomas Ward

OK

SmokeDetector

4:41 AM

[ SmokeDetector ] SmokeDetector started at rev 850e874 (Thomas Ward: 'site' is now part of the Post object.) (running on Undo's Raspberry Pi)

Restart: API quota is 9970.

Thomas Ward

@Andy best way to test would be to generate a JSON object like the json part of the tests do. Problem is, that test suite needs a refactor to use a Post object

if you can get that refactored, we can know better whether JSON fails here or not. That said, the code that existed worked, so since the code is identical for the most part, we shouldn't have any failures.

@Andy unless, json.loads(json_data)["data"] is actually a JSON object in a string, which is entirely possible.

because "data" might return a JSON object inside a string quote, but I don't know.

My basis of that is the if statement beneath it

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching website in body: ANTI-AGING SKIN CARE! by seanashton on meta.SE

Andy

JSON:
	    {"action":"155-questions-active","data":"{\"siteBaseHostAddress\":\"wordpress.stackexchange.com\",\"id\":259939,\"titleEncodedFancy\":\"woocommerce displaying products of a specific page\",\"bodySummary\":\"First sorry for my english, is not my first language. \\n\\nSo what I want to do is to get the products of a particular page, using the get variable, so this is my current code...\\n\\n$page = 0;\\nif(isset($...\",\"tags\":[\"woocommerce\"],\"lastActivityDate\":1489466616,\"url\":\"http://wordpress.stackexchange.com/questions/259939/woocommerce-displaying-products-of-a-specifi…

That formats very poorly in chat, but that's from the real time tab

Thomas Ward

@Andy yeah, Data is a string object that contains a JSON-parseable item

note that first quote right at "data":"

and all the other " being escaped inside it.

So the use of loads is proper in both cases here.

since text_data holds the string-formatted "data" result

(and not a dict or JSON object0

SmokeDetector

tpu- by Undo

Thomas Ward

4:48 AM

@Andy that is, if I did type(text_data) it would return me a str data type, because it's not a dict, it's a dict stored in a string with quotes/etc. escaped in it so it can be parsed as string. For some reason.

so nothing is wrong here :)

o/ @angussidney

angussidney

\o

Thomas Ward

how's things, @angussidney

angussidney

It's hard to type a return wave on a phone keyboard

Thomas Ward

heh

angussidney

@ThomasWard good

I see you're doing the long and hard job of refactoring the post object. Thanks

Thomas Ward

4:51 AM

well not "long"

but definitely "hard"

angussidney

When I get home I'll see if I can help out

Thomas Ward

@angussidney biggest issue I need fixed right now is the testsuite

since I don't know exactly how that works I didn't refactor it

and just littered it with "TODO" items :P

it also needs an actual test, like a !!/report call or something

angussidney

I don't know how it works, but I can learn

Thomas Ward

but eh, it's not in prod yet :)

angussidney

That's how you learn things after all

Undo

4:52 AM

!!/standby art

SmokeDetector

ArtOfCode/EC2 is switching to standby

[ SmokeDetector ] SmokeDetector started in standby mode at rev 158e861 (Thomas Ward: Slight refactor of chat logon handling.) (running on ArtOfCode/EC2)

Thomas Ward

oh hey, @Undo is still here :)

Undo

Off and on

!!/report softwarerecs.stackexchange.com/a/28108/46

AttributeError: PostData instance has no attribute '__setitem__'
2017-03-14 04:52:34.364789 UTC
  File "/media/sda1/SmokeDetector/excepthook.py", line 48, in run_with_except_hook
    run_old(*args, **kw)

  File "/usr/lib/python2.7/threading.py", line 505, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/browser.py", line 714, in _runner
    self.on_activity(json.loads(a))

  File "/media/sda1/SmokeDetector/ChatExchange/chatexchange/rooms.py", line 85, in on_activity

angussidney

Anyway, phone low on battery, I'll be back in about 30mins

Thomas Ward

wat

OH

angussidney

4:53 AM

Also, night @undo, since you'll probably be gone before I come back

Thomas Ward

wow that's...

SmokeDetector

ArtOfCode/EC2 received failover signal.

Undo

'night!

SmokeDetector

Restart: API quota is 7541.

[ SmokeDetector | MS ] Bad keyword in body, blacklisted username, blacklisted website in body, link at end of body, repeated URL at end of long post: Quantities of ingredients are made available to view earlier than buy by nroejuriya on gaming.SE

Undo

Okay, I'm actually going to bed now. Night y'all :)

SmokeDetector

4:57 AM

[ SmokeDetector ] SmokeDetector started in standby mode at rev 158e861 (Thomas Ward: Slight refactor of chat logon handling.) (running on Undo's Raspberry Pi)

tpu- by Jan Dvorak

Thomas Ward

@Undo good night. (I've fixed that issue, by the way... I might have to stab PostData in the future to refactor)

Jan Dvorak

@Cerbrus why did FIRE just ask me to join a community where I already am?

Thomas Ward

because it doesn't like you, @JanDvorak

Andy

@ThomasWard I'm poking at it.

Thomas Ward

@Andy OK

@Andy make sure you pull in latest code from the branch, I've been fixing the little evil errors I've introduced :P

SmokeDetector

5:11 AM

[ SmokeDetector | MS ] Bad keyword in body, link at end of body, pattern-matching website in body: Is This manhoodEnlarger Any Perfect by jellijollen on superuser.com

tpu- by teward

[ SmokeDetector | MS ] Bad keyword in link text in body: YouTube Streaming with Raspberry Pi 3 by Daniel Wolfe on raspberrypi.SE

[ SmokeDetector | MS ] Link at end of body, pattern-matching product name in body, pattern-matching website in body, repeated URL at end of long post: Test X Core à la fois continuer à fonctionner by Thession72 on superuser.com

fp- by Yvette on YouTube Streaming with Raspberry Pi 3 [MS]

Andy

@ThomasWard, I'm off for the night. I believe I've fixed the test_check_if_spam test in test_spamhandling. The two tests that are skipif'd I haven't touched yet. They need a JSON object too. There are still a lot of test_post calls that are taking more than 1 parameter. Those need to be fixed.

We also need to test an API response, not a JSON response

Hm, I also seem to have merged into the branch on Charcoal-SE instead of my own repository. Sorry about that. I've fixed my upstream end point so that won't happen again

SmokeDetector

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, pattern-matching website in body, pattern-matching website in title: bettercoloncleansingguide.com/testo-ultra-es/ by Rich Clark on apple.SE

tpu- by Jan Dvorak

Andy

If you're curious, I'm building the JSON object from the test parameters by doing this

Jan Dvorak

@Cerbrus fix pls

Andy

We'll need to do the same type of thing for API calls.

Basically, each test will need to be a JSON call and an API call

But, it's much to late for me to look at that now

It looks like a lot of the remaining failures are due to test_post calls not being updated.

SmokeDetector

5:28 AM

[ SmokeDetector | MS ] Bad keyword in title, blacklisted website in body, link at end of body: Tips Regarding How To Build Muscle Mass by snnaqwm on askubuntu.com

tpu- by Jan Dvorak

[ SmokeDetector | MS ] Bad keyword in body, pattern-matching website in body, repeated URL at end of long post: Attempt to maintain a strategic distance by colorisex on apple.SE

tpu- by Jan Dvorak

Thomas Ward

@Andy Right, but we have two separate tests, one that calls the JSON tests and one that simply calls the test_post call. We need to construct a fakepost item, like I've been doing for commands, for each post call.

In either case, a Post() object needs constructed - JSON object tests are Post(json_data=JSONOBJECT), API response tests are Post(api_response=APIDATAOBJDICT)

in a nutshell

And, fun fact, I've had to implement an as_dict property to 'recreate' the API response dict... :/

this is painful xD

anyways, I too am going to bed. Shortly.

SmokeDetector

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, link at end of body, pattern-matching website in body, +1 more: supplementq.org/nuriva-serum/ by user66046 on workplace.SE

tpu- by Magisch

SmokeDetector

5:50 AM

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, pattern-matching website in body, pattern-matching website in title: megacleanseradvice.com/viatropin/ by Heupylk on graphicdesign.SE

[ SmokeDetector | MS ] URL in title, blacklisted website in body, blacklisted website in title, repeated URL at end of long post: fornatgaex.com/testo-edge-ex/ by Uyszsloi on graphicdesign.SE

angussidney

@DavidPostill it may be worth mentioning your contributions to Charcoal as part of your mod nomination

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, link at end of body, pattern-matching website in body, repeated URL at end of long post: Industry isn't represented by government by colorisex on askubuntu.com

New metasmoke user 'Tetsuya Yamamoto' created

[ SmokeDetector | MS ] URL in title, pattern-matching product name in body, pattern-matching website in body, pattern-matching website in title, repeated URL at end of long post: dietasrevisao.com/testx-core/ by mazac24 on graphicdesign.SE

tpu- by Jan Dvorak

[ SmokeDetector | MS ] Few unique characters in answer, repeating words in answer: Find the length of the diagonal of a parallelogram by user425369 on math.SE

tpu- by tripleee

tpu- by tripleee on Industry isn't represented by government [MS]

tpu- by tripleee on http://fornatgaex.com/testo-edge-ex/ [MS]

tpu- by tripleee on http://megacleanseradvice.com/viatropin/ [MS]

tpu- by tripleee on Test X Core à la fois continuer à fonctionner [MS]

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, pattern-matching product name in body, pattern-matching product name in title, +3 more: supplementlab.org/muscle-boost-x-and-testo-boost-x/ by bdlventaz on graphicdesign.SE

[ SmokeDetector | MS ] Link at end of body, pattern-matching website in body: Cette chose test x core by loiserish on drupal.SE

tpu- by tripleee on http://supplementlab.org/muscle-boost-x-and-testo-boost-x/ [MS]

tpu- by tripleee

Thomas Ward

6:15 AM

@Andy @Undo I got tests working with Post objects, and the !!/test commands are properly using Post objects now. As well, I had to do some refactoring for the init to make sure all expected items actually exist in the response, because in the fakeposts we're 'testing with' it doesn't actually populate all fields. Better to just cover our butts this way xD

@Andy but yes, all the test suites pass, at least locally. CI should not explode either, hopefully.

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching product name in body, pattern-matching product name in title, +1 more: Pure Nitro Max - It intensifies your muscle mass and endurance by user353546 on meta.SE

Thomas Ward

just cleaning up some more code evils now

SmokeDetector

tpu- by tripleee

Cerbrus

@quartata , @JanDvorak: Oooh, looks like I forgot sites caching: delete localStorage["fire-sites"] if FIRE is opening sites you've got an account at.

Jan Dvorak

How was that not caught while testing? ;-)

Cerbrus

6:24 AM

Cause I regularly clear that while testing :P

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body: When ordering from the? by gawee nally on drupal.SE

tpu- by Cerbrus

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, repeated URL at end of long post: Helps to burn extra electricity by faordjuri on stackoverflow.com

Cerbrus

FIRE bug workaround: If FIRE is opening sites you try to flag posts at, run delete localStorage["fire-sites"] in your console and reload the page.

4

^ ~~Pin please (@ThomasWard?)~~ (Done --ThomasWard)

SmokeDetector

tpu- by tripleee

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, link at end of body, pattern-matching website in body, repeated URL at end of long post: RenuGlow Advanced Serum Does RenuGlow Remove Your Face Wrinkles? by Malisado Miser on drupal.SE

tpu- by Cerbrus

Thomas Ward

@Andy @Undo so... I think I fubar'd some tests, if you could poke in and see what I broke that'd be great.

because now they're failing :(

Jan Dvorak

@Cerbrus Deleted and reloaded. It still opened Drupal.se when I tested on the last post.

SmokeDetector

6:31 AM

[ SmokeDetector | MS ] Blacklisted username, blacklisted website in body, repeated URL at end of long post: Side outcomes may occur, no matter the company's claims to the contrary by nroejuriya on stackoverflow.com

tpu- by Jan Dvorak

Cerbrus

@JanDvorak I'll quickly disable that...

Jan Dvorak

Same for SO now

Thanks

Cerbrus

Disabled that (0.7.10)

angussidney

@ThomasWard if you give me a few mins I'll finish what I'm doing then boot into ubuntu and have a look at it

Thomas Ward

@angussidney no rush.

i have to fix a gitignore evil anyways heh

SmokeDetector

6:36 AM

CI on 6ca56bc succeeded.

Thomas Ward

^ minor thing we can otherwise ignore, no need to pull it in now

SmokeDetector

[ SmokeDetector | MS ] Blacklisted website in answer: Samsung Galaxy A5 screen has broken, want to retrieve data by Ilyas Fahrudeen on android.SE

Thomas Ward

@angussidney if you have no idea, then @Andy and @Undo can look at it when they're around again. I'm going to sleep now.

SmokeDetector

[ SmokeDetector | MS ] Username similar to website in answer: magento show "Sign up to get notified when this product is back in stock" link for simple-associated products by BIGPROFITBUZZ on stackoverflow.com

tpu- by tripleee

angussidney

@DavidPostill I've left a comment on your nomination, good luck!

SmokeDetector

6:51 AM

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title: Rapid Ageless Serum Don't forget to address by Ray Utter on drupal.SE

tpu- by Jan Dvorak

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, pattern-matching product name in body, pattern-matching website in body: crazybulkstacks/nuvella-serum/ by mazaaagya on graphicdesign.SE

[ SmokeDetector | MS ] URL in title, bad keyword in body, blacklisted website in body, blacklisted website in title, pattern-matching website in body, +1 more: brainfireadvice.com by valeriearnold on apple.SE

tpu- by tripleee on crazybulkstacks/nuvella-serum/ [MS]

tpu- by tripleee

Transcript for