Conversation started Dec 11, 2012 at 16:47.
Rarst
Rarst
Dec 11, 2012 16:47
@toscho if I am echoing same localized string as core ('Your comment is awaiting moderation.' for example) should I omit theme text domain or not?
toscho
toscho
@Rarst Don’t. Core string changes may not be in sync with your code updates.
Rarst
Rarst
but I suppose it won't fallback to core if it's not translated in theme yet? or will it?
toscho
toscho
Not sure I understand
Do you want a partial translation?
Rarst
Rarst
I am overriding core code and I want translations to come from core, since it's nothing specific to my theme
Tom J Nowell
Tom J Nowell
and 3.5 is being pushed out on the internal wordpress updater
toscho
toscho
Dec 11, 2012 16:54
@Rarst If core changes the string your users will get untranslated output. Not good.
Tom J Nowell
Tom J Nowell
wordpress.org/download/counter
Rarst
Rarst
@toscho good point...
but it's "users don't get translation unless I translate" versus "users get translation until possibly core changes string"
kaiser
kaiser
@Rarst Just. Do. It.
Rarst
Rarst
@kaiser just do what?
kaiser
kaiser
I do that with some of my code too. Place some @TODO comments for those strings.
You'll anyway go through it when updating.
toscho
toscho
Dec 11, 2012 16:56
@Rarst Then don’t override core strings.
Rarst
Rarst
@toscho it's not my intention, but sometimes it's all or nothing with modifying core code
toscho
toscho
sometimes is not specific enough. :) What exactly is your use case?
Stephen Harris
Stephen Harris
And 3.5 is out...
Rarst
Rarst
@toscho right now - comments templating, but I have few more places
I either use callback and completely control output or let WP completely control it - no middle ground 
		if ( !empty($args['callback']) ) {
			call_user_func($args['callback'], $comment, $args, $depth);
			return;
		}
toscho
toscho
There is no new string?
Rarst
Rarst
Dec 11, 2012 17:00
@toscho meaning?
toscho
toscho
in your code snippet – where do you replace a core string?
Rarst
Rarst 
<?php if ($comment->comment_approved == '0') : ?>
		<em class="comment-awaiting-moderation"><?php _e('Your comment is awaiting moderation.') ?></em>
		<br />
<?php endif; ?>
I need to echo essentially same thing with my markup in template
toscho
toscho
Oh, okay. This is wrong.
Rarst
Rarst
what is?
toscho
toscho
the missing text domain
Rarst
Rarst
Dec 11, 2012 17:02
this is from core, not my code... but the point is I have to use domain and translate?..
toscho
toscho
yes
Rarst
Rarst
ok
toscho
toscho
they renamed even the damn HTML editor
kaiser
kaiser
So it will work until 3.6 - then you have to go through it again.
 
Conversation ended Dec 11, 2012 at 17:03.