I want to fix the unhandled exception due to RCW disconnect on exits. Fortunately, we have CommandBase so I only need to implement it once. Unfortunately we kind of new commands all over the place and I have to add a new ctor injection basically everywhere. I considered just sticking in a static property but that would destroy the testability. I think the best way forward is to either change all those news into a factory call or just suck it up and pass a new ctor parameter along. Other ideas?
> Refresh Todo Explorer to match other UI elements, refactor grouping to get rid of duplicated grid control. For those of us who have difficultly reading raw PNG data, it looks like this: !screenshot from 2019-02-25 18-06-15 Not much to it, just added the expand and collapse commands to match similar controls and changed the grouping to toggle buttons instead of a dropdown. Feel free to...
suggest different icons for the marker grouping and remove (or in the case above - "complete") icons. Sticky notes were a first thought, but I'm not sure if I'm sold on them. WIP pending some fixes to a couple other things that I found broken.
@this Some of the stuff we're newing up is specific to individual views - I'm not sure a factory is the best way to approach it generically.
I.e.:
CollapseAllCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteCollapseAll);
ExpandAllCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteExpandAll);
If I'm using a program that defaults to a gobble-gocky that I don't understand, the first thing I'm gonna to do is go to the settings/language, not muck around with refactorings or inspections, right?
Yeah, I think that's OK.
FWIW, it's not unprecedented, either - we have GUIDs and ProgIDs there.
@this just asking could we make null a new Rubberduck type so we know which kind of null irrespective of Access or SQL or Excel emptycell null and handle this better.
Public Function IsNoData(InputData As Variant) As Boolean
Select Case True
Case IsObject(InputData)
IsNoData = (InputData Is Nothing)
Case IsArray(InputData)
Dim l As Long, u As Long
On Error Resume Next
l = LBound(InputData)
u = UBound(InputData)
If Err.Number Then
l = 0
u = 0
End If
On Error GoTo 0
IsNoData = ((l = 0) And (u = 0))
Case Else
Case IsArray(InputData)
Dim l As Long, u As Long
On Error Resume Next
l = LBound(InputData)
u = UBound(InputData)
IsNoData = (Err.Number)
On Error GoTo 0
As pointed out in the comments, there isn't a native way to determine if an array is uninitialized in VBA. However, you can examine its memory footprint to see if its variable contains a null pointer. Note that VarPtr throws a type mismatch for arrays, so it needs to be wrapped in a Variant fir...
:+1: That is more thorough. I know that the function above was written to avoid using APIs originally hence the loosey-goosey checking abusing VBA's voodoo conversions.
ok, i need a reality check. I'm updating the mocked code explorer & associated tests
those now are ComCommandBase-derived, so they need a Mock<VbeEvents> passed into it.
The thing is that several tests either 1) new them directly or 2) use reflection to new it up.
I could cheat and just pass in null, since none of those tests rely on the VbeEvents but I was worried that if I do this, then it makes any future modifications harder.
but also consider the AddsTestModule as an example (in UnitTestCommandTests)
that's what I'm looking at ATM
[Category("Commands")]
[Test]
public void AddsTestModule()
{
var (vbe, state) = ArrangeAndParseTestCode(ComponentType.StandardModule, "Module1", string.Empty);
using (state)
{
var addTestModuleCommand = new AddTestModuleCommand(vbe.Object, state, ArrangeCodeGenerator(vbe.Object, state));
addTestModuleCommand.Execute(null);
var expectedModule = $"{TestModuleBaseName}1";
var generated = state.DeclarationFinder.AllUserDeclarations.SingleOrDefault(test => test.Id…
I don't remember (don't think, either) that installer sets the localization for RD automatically
so that would be a bigger problem for one who doesn't know enough English. OTOH, that same person is screwed because they have to mouse around to find the language.
FWIW, VarPtr(TestPrint2("Hello World!")) will give you the memory address of the return value (on the stack if you call it like that), not a function pointer. — Comintern20 secs ago
Seriously, if it doesn't anything that's in fact different from the AddTestModuleCommand, it's probably better out of the codebase until someone implements one that actually does add stubs
because otherwise it's just adding noises to the unit tests
var (vbe, state) = ArrangeAndParseTestCode(ComponentType.StandardModule, "Module1", string.Empty);
using (state)
{
var addTestModuleCommand = ArrangeAddTestModuleCommand(vbe, state);
var addWithStubsCommand = ArrangeAddTestModuleWithStubsCommand(vbe, addTestModuleCommand);
the problem, though is that all 3 Arrange* there will create their own mocked VbeEvents. Not good
var results = _resultsByDeclaration?.FirstOrDefault(f => ReferenceEquals(f.Key, SelectedItem.Declaration)); faceplants when there isn't a selected item.
Any other locales with cropping issues in the Settings window?
> Thanks very much for your replies @bclothier and @retailcoder
As I recall, before taking the screenshot I clicked refresh and then semi-randomly used an open code window to demonstrate the issue. I'm pretty certain I didn't change the code, particularly to such a significant extent as changing from a function to a sub.
So if I understand correctly, after the initial refresh, Rubberduck needs to keep refreshing in response to changes in the code. Mostly it does this automatically in the
> To clarify, after adding the additional code, did you click the refresh button? RD does not parse on keypress. Although we only reparse the modules that have been modified, the process takes too long to do it on keypress. Moreover, RD does not reparse periodically.
There are a few times an automatic reparse happens, though. E.g. After adding, removing or renaming a module an automatic parse is triggered. The same it true after executing a refactoring.
> The initial parse will usually take the longest because Rubberduck has to know everything about the entire project.
After that, we try to minimize the updates we require, but due to how VBE works, we can only refresh at a per-module level. One ramification of that is that if you edit a public procedure's signature in a module that is referenced by 10 different modules, then Rubberduck must refresh those 11 modules.
To confirm are you saying that even after the initial parse, it still t
@Duga I looked at the wiki but I'm a bit fuzzy whether editing inside procedure will still require refreshing the referenced modules. I would hope no but ? - 2 minutes on a reparse is kind of excessive.
As pointed out in the comments, there isn't a native way to determine if an array is uninitialized in VBA. However, you can examine its memory footprint to see if its variable contains a null pointer. Note that VarPtr throws a type mismatch for arrays, so it needs to be wrapped in a Variant fir...
VBA Rubberducking
VBA Rubberducking