« first day (473 days earlier)      last day (1714 days later) » 

12:01 AM
RELOAD!
[Cardshifter/Cardshifter] 1 opened issue. 3 issue comments.
[retailcoder/Rubberduck] 1 commit. 327 additions. 87 deletions.
[rubberduck-vba/Rubberduck] 10 commits. 3 closed issues. 2 issue comments. 3215 additions. 185 deletions.
[ShearOfDoom/CactusReborn] 1 commit. 3 deletions.
[Vannevelj/RoslynTester] 1 issue comment.
[Vannevelj/VSDiagnostics] 2 commits. 1 opened issue. 1 closed issue. 3 issue comments. 488 additions.
 
 
3 hours later…
3:10 AM
[retailcoder/Rubberduck] retailcoder pushed 21 commits to next (only showing some of them below)
Merge pull request #779 from INOPIAE/#778

Replaced "Menu Bar" by index number of the control bar so it should w…
Merge pull request #780 from INOPIAE/#translation

small adjustments and typo fix
[retailcoder/Rubberduck] Vogel612 pushed commit 06ab8c0e to next: Replaced String-Based access with named integer constants, as per #778
[retailcoder/Rubberduck] Vogel612 pushed commit 21e5db1f to next: Corrected spelling error in German locale, removed duplicate entry in English locale
Moved ExtractMethod out of the RefactorMenu into it's own Command
, see #761
[retailcoder/Rubberduck] Vogel612 pushed commit 4ca8758f to next: Moved RemoveParameters from the RefactorMenu into a Command class, see #762
Merge pull request #782 from Vogel612/LocaleIndependence

Locale independence
Merge pull request #783 from Vogel612/Refactorings

Refactorings
[retailcoder/Rubberduck] retailcoder pushed commit 86be7863 to next: merge commit
[retailcoder/Rubberduck] retailcoder pushed commit 342721bc to next: removed source control junk in .csproj file
 
I seem to have lost the regex search & replace stuff along the way
or, at least, parts of it
 
Let's see, do I still have it?
You still have it.
 
except merging that one was a PITA, because your fork was pre-#606
 
Just move the stuff you lost in.
And you should have updated the fork, then.
 
was only missing RegexSearchResult and RegexSearchReplaceScope. done.
 
3:18 AM
[retailcoder/Rubberduck] retailcoder pushed commit 4b9423b0 to next: fixed compile errors.
 
PermissiveAssertClass has an official GUID now :)
 
[retailcoder/Rubberduck] retailcoder pushed commit 7c8130c4 to next: moved files where .csproj expected them
[retailcoder/Rubberduck] retailcoder pushed commit 7d5857af to next: removed unused usings in RefactorMenu; marked class as obsolete
 
RefactorCommandBase is screwing up the IoC config
ugh. ICommand won't resolve in RefactorExtractMethodCommandMenuItem(ICommand)
too tired for this.
tomorrow
'night
 
4:04 AM
[retailcoder/Rubberduck] retailcoder pushed commit c55aa6c5 to next: fixed baseCommandTypes bindings
 
4:19 AM
[retailcoder/Rubberduck] retailcoder pushed commit bcd4997c to next: disabled unimplemented RegexSearchReplaceView; RefactorExtractMethodCommand.Execute runs twice for some reason.
 
5:09 AM
still no idea. gotta sleep, I'll figure it out tomorrow
 
 
1 hour later…
6:12 AM
> When I try to compile the next branch (sha-1: 49ae39383d7cbb0f30b65155fe3578192147eda) I run into these two errors:
"'Rubberduck.Unit.Testing.PermissiveAssertClass.AreEqual()': cannot override inherited member 'Rubberduck.Unit.Testing.AssertClass.AreEqual()' because it is not marked virtual, abstract, or override"
"Rubberduck.Unit.Testing.PermissiveAssertClass.AreNotEqual()': cannot override inherited member 'Rubberduck.Unit.Testing.AssertClass.AreNotEqual()' because it is not marked virtu
 
 
4 hours later…
9:55 AM
> @INOPIAE oh yes.. that one's my (or maybe mono's) fault. I wrote that class and at least that class compiled fine. 4b9423b0d35878d950b903d8b8f5930fdc9e38b2 fixes these compile errors, thanks to @retailcoder
 
 
2 hours later…
12:11 PM
[Vogel612/TranslationHelper]‌​ Vogel612 pushed commit 272bf06d to develop: Inlined TranslationPresenter, removed .impl package
[Vogel612/TranslationHelper] build for commit 272bf06d on develop: The Travis CI build passed
[Vogel612/TranslationHelper]‌​ Vogel612 pushed commit 4bef29d7 to develop: Inlined OverviewModelImpl
[Vogel612/TranslationHelper] build for commit 4bef29d7 on develop: The Travis CI build passed
 
12:31 PM
[Vogel612/TranslationHelper]‌​ Vogel612 pushed commit 3ce5f9e8 to develop: Inlined OverviewPresenterImpl
[Vogel612/TranslationHelper] build for commit 3ce5f9e8 on develop: The Travis CI build passed
 
 
3 hours later…
3:33 PM
> I'm trying to run tests with late-binding. I switched from `New Rubberduck.AssertClass` to `CreateObject("Rubberduck.AssertClass")`. I can remove the reference to the Rubberduck type library and the project compiles. Everything's good so far.

When I run the tests from the Test Explorer, though, the reference to the Rubberduck type library is being re-added to my project without warning. It's just an annoyance, but I don't want to ship out a production version of my Access app with a lib
 
4:16 PM
> It looks like this may have already been fixed on August 22 in revision ff60ef93f231b50c8956853819df620b0c781d05.

The following lines were removed from \RetailCoder.VBE\UI\UnitTesting\TestExplorerDockablePresenter.cs:

public void RunTests(IEnumerable<TestMethod> tests)
{
try
{
_view.ClearResults();

var testMethods = tests as IList<TestMethod> ?? tests.ToList(); //bypasses multiple enumeration
 
 
2 hours later…
6:37 PM
> "Fixed" is a big word, the whole feature was pretty much rewritten! I'm creating an issue to make sure I remember to make a checkbox for this in the Rubberduck Settings dialog.
 
6:49 PM
> Let's add a "Unit Testing" page to the settings dialog, and make the following configurables:

- [ ] **Early-bind the Rubberduck type library** - when this option is checked (checked by default), running Rubberduck tests will ensure the VBA project has a reference to the Rubberduck type library. Unchecking this box can cause runtime errors if unit tests require early binding (e.g. if `AssertClass` is being instantiated directly).

...what else?
 
ah, you're right
 
> If #291 is implemented, then this setting should also determine whether a new test module gets created with a late or early bound `AssertClass`.

Also:

- [ ] **Use permissive equality asserts** - when this option is checked (unchecked by default), creating a new test module will declare a `Private Assert As New Rubberduck.PermissiveAssertClass` instead of a `New Rubberduck.AssertClass`. Also consider sync'ing test modules with the status of this option - i.e. if it's checked, *change exi
> Let's go with #785 instead.
 
now all we need is a refactoring of the settings dialog, so that we can implement a command that brings it up on a specific page
I'd like to add a "Unit Testing settings" button in the test explorer toolbar
 
7:05 PM
> I'm closing this issue, @Vogel612 implemented the thing - now we need unit tests for it :stuck_out_tongue_winking_eye:
> Dim foo = New Bar is valid in VB.NET, but not in VBA. Rejecting this issue.
> Detecting unreacheable code implies simulating the compiler... which is a little bit beyond the scope of this project.
> This has non-obvious side effects:

Private Sub Foo()
Dim c As New Collection
Set c = Nothing
c.Add "123" ' error? nope!
End Sub

Rejecting this quickfix.
> This inspection + quickfix requires implementing a specialized If block analyzer.
> This inspection + quickfix requires implementing a specialized If block analyzer.
> This inspection + quickfix requires implementing a specialized If block analyzer.
> This inspection + quickfix requires implementing a specialized If block analyzer.
> Let's make a first iteration of this inspection as a mere little "Runtime errors suppressed" warning that triggers when On Error Resume Next is used without being followed by an On Error GoTo 0 statement.
> Too much effort for such little gain. Declined.
> @ckuhn203 is the above checklist up-to-date as of 1.4.3?
> We're not using homebrewn Node classes since v1.22, and indentation will be handled by SmartIndenter. This issue is moot.
> @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?
> Same here; @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?
> Again (sorry for all the notifications!), @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?
> Outlook will not work. Removing from the check-list.
> Yes. Absolutely. It's implemented through VBE extensions. IIRC it's even located in the VBE project.
> Yup. See #52
 
7:50 PM
To learn how a given API works, yes. To learn how to write clean, flexible and reusable code, no. #Excel #VBA https://twitter.com/ExcelEasy/status/646385372491030528
 
> @ckuhn203 Awesome! I'm making a new issue to coordinate these features.
 
8:07 PM
> It's all implemented in the code @retailcoder, but not all of it is implemented in the GUI yet.
I just updated to reflect what is and isn't done in the GUI.
> Sounds like a plan!
 
8:46 PM
> There are a number of opened issues that have been around since 0.x:

- [ ] #52 toggle default instance attribute
- [ ] #53 toggle default member attribute
- [ ] #54 edit procedure description attribute
- [ ] #55 toggle iterator getter attribute

2.0 is going to have to make them happen. I'm tagging with [code-parsing], but really this isn't about the parser - it's *purely* about *parsing*: the VBE doesn't support member attributes, but honors them.

This feature will work off the cur
 
9:04 PM
> This could also be implemented the VB6 way:

![](http://i.stack.imgur.com/4W9OZ.png)

But that requires the user to know what `VB_UserMemId` values to use. I'd prefer to use checkboxes. Actually, the different `VB_UserMemId` values are mutually exlcusive, so they should be radiobuttons.
 

« first day (473 days earlier)      last day (1714 days later) »