To remove one level of nested if's you can negate first condition and return empty list if (! ListItems.Any()) return nodes; One more thing which wasn't mention yet is if (item.key.Equals(initialCrs)) { child.Children.Add(grandChild); } else { initialCrs = item.key; parent....

Great answer by @Malachi. Let's talk about performance. Variables You have lots of variables and this can slow it down. I see at least two that could be completely eliminated: SET @Now = getdate() SET @Today = DATEADD(dd, 0, DATEDIFF(dd, 0, @Now)) There is not really a point in setting a va...

What materials have you read (or in another way learned from) that make you a better reviewer? 1 item per answer, please. Let the good ones get the votes.

I've noticed a tendency towards two styles of conditionally executing methods: Conditional before the call def foo(thing) puts thing end if thing foo(thing) end Conditional within the call def foo(thing) return unless thing puts thing end foo(thing) Pros of 1: Method is concis...

Let's suppose I have some sort of form that automatically performs a copy procedure when the user either focuses on a textbox, or highlights some text. Let's suppose that the user has a preference of copying on focus or copying on highlight. By default, it copies on highlight... which leads us t...

Let's say I'm writing a method which can return two very different things based on parameters. I could write that bit of code like this: function getMyThing(a) { if (a == 0) { // Do some stuff return b; } else { // Do some stuff return c; } } This pi...

I'll start by breaking the code down into different files. There are a many #define and const int here. If I am correct that will definitely grow with your project. Having all the constants in a different file is always a good idea if you are considering making it even moderately big. So to your ...

The rules are as follows: 60+ days must pass between when the post is created and when it is deleted for the rep to "stick" The score must be 3 or higher at at the time the post was deleted (since the score can't change while it's deleted, that's the same as current score)

There are no practical uses of Brainfuck.

This code reads names and ages from an array and prints them. Then it increments all of the ages and re-prints the names and ages. This was written in an anti-functional, anti-OO paradigm. #include <iostream> using namespace std ; const int size = 3 ; const char * names [] = {"Bob", "Alice", "...

I have a form that allows the user to select a server. This will execute the exact same query just on a different server. private void QueryButton_Click(object sender, EventArgs e) { switch (this.FindByComboBox.SelectedIndex) { case 0: ByTargetVDN(); brea...

I am using this script to get the admin pages via this query string ?page= once the admin is logged in. Just needing a review, opinions Function: // GET PAGE FROM QUERY STRING public function page_select($page) { $ext = '.php'; $file = 'pages/'.$page.$ext; if(file_exists($file)) { ...