« first day (4181 days earlier)      last day (55 days later) » 

00:20
REFRESH! There are 5571 unanswered questions (92.8188 answered)
 
1 hour later…
01:44
0
Q: Read a helpfiles textfile or potentially delete one if given an argument that's in the list

BrainFRZI'm working on a MUD (multiplayer text game), and the helpfile system adds missing helpfiles (ones that are looked for but don't exist) in the following format, including the room number, character name, and desired helpfile. I tried to be as efficient as possible, but I'm not very experienced wi...

 
3 hours later…
04:52
With that said, code review questions should be posted to the Code Review SE. — Some programmer dude 40 secs ago
I figured this code was too simple to bother posting it on Code Review. I believe my questions are rather simple to digest, maybe not to a passer by but to someone actually willing to read a bit more than 5 lines of text. — JustLearning 1 min ago
 
2 hours later…
07:04
@Peter my comment is not addressed to the OP; true, the OP could have written if a && !b and spare us from that if a == true && b == false, but my comment is addressed to user Pete Becker who noted that int x = 3; if (x == true) ... is valid C and C++, which of course it is, but it would not pass code review under my watch. — Mike Nakis 43 secs ago
07:37
0
Q: Opening URL with C

yurichI wrote this code for opening URLs using C. Is using enum for function result a good practice? I also thought about sanitizing the url but it didn't seem easy and is, probably, not a part of this function's responsibility. #include <stdbool.h> #include <stdlib.h> #include <string.h> #include <std...

08:22
0
Q: EntityParser: parsing objects from XML file

SergeyI was tasked with implementing a feature that allows to load entities from a local XML file. Surprisingly, even though similar features were implemented elsewhere, we didn't have an object-oriented parser that loaded actual entities. So I decided to write one. I'm not particularly proud of my cod...

possible answer invalidation by Toby Speight on question by yurich: codereview.stackexchange.com/posts/294068/revisions
possible answer invalidation by Toby Speight on question by yurich: codereview.stackexchange.com/posts/294068/revisions
09:29
if the code works as and you want somebody to reflect on your code, then please consider moving the question to codereview.stackexchange.comDarkBee 24 secs ago
@Duga Just the closing code fence
@[type here] the question needs work before it's suited to Code Review. You could have pointed the asker at A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. we need a good description of the purpose of the code to give context, and question titles should simply say what the code is for (the question is always, "How can I improve this?"). It's important that the code works correctly; include the unit tests if possible. — Toby Speight 9 secs ago
possible answer invalidation by yurich on question by yurich: codereview.stackexchange.com/posts/294068/revisions
possible answer invalidation by yurich on question by yurich: codereview.stackexchange.com/posts/294068/revisions
possible answer invalidation by yurich on question by yurich: codereview.stackexchange.com/posts/294068/revisions
possible answer invalidation by yurich on question by yurich: codereview.stackexchange.com/posts/294068/revisions
possible answer invalidation by yurich on question by yurich: codereview.stackexchange.com/posts/294068/revisions
 
1 hour later…
11:10
11:47
@JustLearning: "I figured this code was too simple to bother posting it on Code Review." > No such thing ! Your sample is the exact right size to talk about some general design strategies IMO. — nick 23 secs ago
If you "came across" this code (i.e. you're not the author or maintainer), then it's not suitable for Code Review, unfortunately. — Toby Speight 50 secs ago
If this actually is your own code, then be sure to read A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. question titles should simply say what the code is for, as the question is always, "How can I improve this?". Be sure that the code works correctly; include your unit tests if possible. You'll likely get some suggestions on making it more efficient, easier to read, and better tested. — Toby Speight 7 secs ago
12:20
@Duga @TobySpeight rolled this back and commented.
 
2 hours later…
14:42
0
Q: Pull data from the database to bind and download in text file C#

Rahul HendaweThe code below was written by a different developer who is no longer with the company. Because everything is written inside of a single method, the thing is a little difficult to understand. Could someone kindly examine this code and assist me in reworking it in a way that adheres to SOLID princi...

 
1 hour later…
15:50
0
Q: N-Body simulator in Rust implementing Barnes Hut and Leapfrog

epestrI have written a N-body simulator in Rust implementing Barnes Hut algorithm and Leapfrog integrator. My code seems to work fine, but I'd like to review on techniques which can improve performance while having the code be idiomatic rust. Ideally I'd like to know if there is something that would ma...

16:17
Monking
16:36
This question is similar to: Preferred Github workflow for updating a pull request after code review. If you believe it’s different, please edit the question, make it clear how it’s different and/or how the answers on that question are not helpful for your problem. — AD7six 37 secs ago
17:24
Monking
 
1 hour later…
18:28
Monking
@TobySpeight thanks for the edit. I'm a bit rusty, and my answers can use a review.
 
2 hours later…
20:18
0
Q: Automating Arch Linux Installation with Custom Partitioning and Disk Setup

DarKnightzI'm trying to automate my Arch Linux installation using a bash script. The script would allow me to choose between installing Arch on a single SSD or using a combination of SSD (for root and home) and HDD (for specific user directories like Downloads, Documents, etc.). I'd like some feedback on m...

20:41
0
Q: Simple console calculator app. Looking for structure/best practices tips

MouserrI'm very much new to coding. The template for a .NET Console app opens up blank. I added lines like using System.ComponentModel.Design; internal class Program private static void Main(string[] args) despite not knowing the purpose or necessity. I'd really just like to know what I can change to ma...

 
2 hours later…
22:11
22:55
0
Q: bash script which does error handling on undefined variables and parameters

NickotineWe have a script at work which fails intermittently. There are variables chained together with && so no errors are given on what went wrong. Devops are complaining about this lack of error handling as they don't know where things are going wrong so they asked us to sort it. I came up with sketch ...

0
Q: Base16/32/64 implementation for C++ ranges

niloIntroduction The following code is an implementation of, in ambition, RFC 4648 compliant Base16, Base32 and Base64 conversions as range adaptors and constrained algorithms in C++23. It can be used at compile time or at run time. I'll take any feedback, but I am especially interested in feedback f...


« first day (4181 days earlier)      last day (55 days later) »