The 2nd Monitor

Duga

00:20

REFRESH! There are 5571 unanswered questions (92.8188 answered)

Captain Obvious

01:44

0

Q: Read a helpfiles textfile or potentially delete one if given an argument that's in the list

I'm working on a MUD (multiplayer text game), and the helpfile system adds missing helpfiles (ones that are looked for but don't exist) in the following format, including the room number, character name, and desired helpfile. I tried to be as efficient as possible, but I'm not very experienced wi...

c file-system

Duga

04:52

With that said, code review questions should be posted to the Code Review SE. — Some programmer dude 40 secs ago

I figured this code was too simple to bother posting it on Code Review. I believe my questions are rather simple to digest, maybe not to a passer by but to someone actually willing to read a bit more than 5 lines of text. — JustLearning 1 min ago

Duga

07:04

@Peter my comment is not addressed to the OP; true, the OP could have written if a && !b and spare us from that if a == true && b == false, but my comment is addressed to user Pete Becker who noted that int x = 3; if (x == true) ... is valid C and C++, which of course it is, but it would not pass code review under my watch. — Mike Nakis 43 secs ago

Captain Obvious

07:37

0

Q: Opening URL with C

I wrote this code for opening URLs using C. Is using enum for function result a good practice? I also thought about sanitizing the url but it didn't seem easy and is, probably, not a part of this function's responsibility. #include <stdbool.h> #include <stdlib.h> #include <string.h> #include <std...

c url

Captain Obvious

08:22

0

Q: EntityParser: parsing objects from XML file

I was tasked with implementing a feature that allows to load entities from a local XML file. Surprisingly, even though similar features were implemented elsewhere, we didn't have an object-oriented parser that loaded actual entities. So I decided to write one. I'm not particularly proud of my cod...

java parsing xml

Duga

possible answer invalidation by Toby Speight on question by yurich: codereview.stackexchange.com/posts/294068/revisions

Duga

09:29

if the code works as and you want somebody to reflect on your code, then please consider moving the question to codereview.stackexchange.com — DarkBee 24 secs ago

Toby Speight

@Duga Just the closing code fence

Duga

@[type here] the question needs work before it's suited to Code Review. You could have pointed the asker at A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. we need a good description of the purpose of the code to give context, and question titles should simply say what the code is for (the question is always, "How can I improve this?"). It's important that the code works correctly; include the unit tests if possible. — Toby Speight 9 secs ago

possible answer invalidation by yurich on question by yurich: codereview.stackexchange.com/posts/294068/revisions

Duga

11:10

You may be interested in codereview.stackexchange.com. — deceze ♦ 12 secs ago

Duga

11:47

@JustLearning: "I figured this code was too simple to bother posting it on Code Review." > No such thing ! Your sample is the exact right size to talk about some general design strategies IMO. — nick 23 secs ago

If you "came across" this code (i.e. you're not the author or maintainer), then it's not suitable for Code Review, unfortunately. — Toby Speight 50 secs ago

If this actually is your own code, then be sure to read A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. question titles should simply say what the code is for, as the question is always, "How can I improve this?". Be sure that the code works correctly; include your unit tests if possible. You'll likely get some suggestions on making it more efficient, easier to read, and better tested. — Toby Speight 7 secs ago

pacmaninbw

12:20

@Duga @TobySpeight rolled this back and commented.

Captain Obvious

14:42

0

Q: Pull data from the database to bind and download in text file C#

The code below was written by a different developer who is no longer with the company. Because everything is written inside of a single method, the thing is a little difficult to understand. Could someone kindly examine this code and assist me in reworking it in a way that adheres to SOLID princi...

c# linq postgresql .net-core entity-framework-core

Captain Obvious

15:50

0

Q: N-Body simulator in Rust implementing Barnes Hut and Leapfrog

I have written a N-body simulator in Rust implementing Barnes Hut algorithm and Leapfrog integrator. My code seems to work fine, but I'd like to review on techniques which can improve performance while having the code be idiomatic rust. Ideally I'd like to know if there is something that would ma...

beginner rust numerical-methods physics

skiwi