The 2nd Monitor

Duga

12:18 AM

REFRESH! There are 6096 unanswered questions (92.1711 answered)

Duga

1:44 AM

possible answer invalidation by Paul J. Lucas on question by Paul J. Lucas: codereview.stackexchange.com/posts/293211/revisions

possible answer invalidation by Paul J. Lucas, Paul J. Lucas on question by Paul J. Lucas: codereview.stackexchange.com/posts/293211/revisions

possible answer invalidation by Paul J. Lucas on question by Paul J. Lucas: codereview.stackexchange.com/posts/293211/revisions

Peilonrayz

2:47 AM

@Duga Handled

@Duga Fine

Duga

possible answer invalidation by Paul J. Lucas, Paul J. Lucas on question by Paul J. Lucas: codereview.stackexchange.com/posts/293211/revisions

possible answer invalidation by Paul J. Lucas on question by Paul J. Lucas: codereview.stackexchange.com/posts/293211/revisions

If you never have another variable called responseData, and never want anyone else to approve your code reviews, sure. Try this for an example of why that's an issue: const foo = () => { bar = 1 }; foo(); console.log(bar);. Undeclared variables are globals. — Zac Anger 48 secs ago

possible answer invalidation by Paul J. Lucas on question by Paul J. Lucas: codereview.stackexchange.com/posts/293211/revisions

Duga

3:32 AM

So I see a bunch of code review problems. cs is a span of int: it should be a span of const int. You take a mutable reference to a vector jnt: that should be const. Your variable names are horrible - "x" and "i" and "cs" - as if you think using letters slows doen your code. There are a lot of assumptions about indexing and values being non-negative: if incorrect, you'll get gonzo results. Code should assert that indexes are in range before []ing. Efficiency wise, you find an iterator, theb repeat lookup wastefully. Try: if(auto it=memo.find(foo); it!= memo.end()) return it->second; — Yakk - Adam Nevraumont 7 secs ago

Heslacher

4:21 AM

Monking

Captain Obvious

10:10 AM

1

Q: How to optimize authentication and authorization, API calls in a task management frontend application?

Let me give a brief explanation of the mini-application I've designed using Angular : A simple login page that requires user email and password as credentials. Once logged in, the user is moved to a page where a list of tasks is displayed in the form of individual boxes. This code review is not f...

Duga

11:16 AM

You can also post the **working ** version of your code on Code Review if you are interested in getting feedback on any aspect of it, including how to do things differently. — toolic 19 secs ago

Duga

4:01 PM

This sounds less like a programming issue and more like you're looking for a code review. If that's the case, try codereview.stackexchange.com/help/on-topic as such questions are typically too subjective for SO. — gunr2171 6 secs ago

Welcome to Stack Overflow! Before you post at Code Review, be sure to read A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. question titles should simply say what the code is for, as the question is always, "How can I improve this?". Be sure that the code works correctly; include your unit tests if possible. You'll likely get some suggestions on making it more efficient, easier to read, and better tested. — Toby Speight 9 secs ago

skiwi

6:58 PM

Monking

Duga

7:20 PM

The line found_line=$(echo "${contents_file}" | grep "^${char}") being present in your shell script means there are probably bigger issues than the problem you're asking about as a) you're apparently reading the contents of a file into a variables, b) you're probably using some kind of shell read loop, c) you're spawning a subshell unnecessarily, d) you're using echo instead of printf, etc. You may want to post your script on codereview.stackexchange.com to get feedback on it. — Ed Morton 46 secs ago

Duga

7:44 PM

Seems be doable, but what is finalList and where does it come from? And since the code is working, Code review seems a better fit for this question. — Chaosfire 8 secs ago

Duga

8:22 PM

We also would remind and urge one another to use the new pattern in code reviews. — Fildor 42 secs ago

Transcript for