The 2nd Monitor

7:07 PM

> This is implimentation of Datepicker by our outsource colleagues.

Any thoughts on this?^

@Phrancis As currently worded, Off-Topic.

To make it On-Topic, it would have to be "I've made this code as good as I think I can, what else can I do to improve it?"

Mat's Mug

[...] by our outsource colleagues - Is this code that you own or otherwise maintain? Picking on someone else's code isn't exactly professional, and off-topic on this site. — Mat's Mug ♦ 24 secs ago

if outsource colleagues wrote it and OP is now "stuck with it" and needs to maintain and fix it, then I don't see a problem.

if it's to build a case against that provider, we have a problem.

Phrancis

> Please help me find other problems. I believe that this code is not ready for production, and it can lead to unpredictable behavior. Am I biased?

I don't like the premise of the question

Mat's Mug

vote as appropriate

Phrancis

Already did ;)

Kaz

7:12 PM

To add to @Mat'sMug point: If you want to make this question On-Topic, you need to be able to (honestly) say: "I have this code. I have tried to make it as good as I can. What else can I do to improve it?". — Kaz 1 min ago

Mat's Mug

mug needs caffeine. bbl.

Kaz

OP needs to "make" it their own code before they put it on CR. How they use the feedback they then receive, and how it might reflect on their adjustments and the original code are their concern.

Thomas Ward

@Mat'sMug bring me some, too. :P

Captain Obvious

0

Q: get and set cookie

I use this code which is working, and before I use it in prod I would like to get your feedback if there is better way to write this code(especially the for loop and the function global variables...) function getCookie() { var cookieName = "cookie-send="; var ca = document.cookie.split(...

javascript

0

Q: plz tell me a code of this programm

Create a class called shape. Use this class to store two int type values that could be used to compute the area of figures i-e of a rectangle and triangle. Define members function as Setvalues…used to set the values of variables Getvalues…used to get the values of variables area_r…used to dete...

c++

Thomas Ward

@Mat'sMug This sounds like "inherited code" too, I've run into this in my workplace (though it was by someone no longer on the team, rather than 'outsourced' development)

@CaptainObvious Wow, really? people just asking for code...

Mat's Mug

7:20 PM

Not happening.

Thomas Ward

@Mat'sMug the coffee you're going to share with me, or the post? :P

(I just saw it was flung into the Void)

Vogel612

Mugged, it seems

Mat's Mug

@Mat'sMug I must maintain this code in the future. For that reason I seeking for review of code. I need an independent view. — 4ell 31 secs ago

@ThomasWard yup

Duga

7:50 PM

From this point of view you hardly find a question on Stack Overflow which doesn't fit to "opinion-based" category :) We are not Code Review for perform suboptimizations, so it is sufficient to choose only generic approach. — Tsyvarev 23 secs ago

Mast

To everyone closing the question: code being maintained by the OP is on-topic. Take a look at the help center. — Mast 44 secs ago

You must have written it, own it or maintain it.

So what's up with this comment?

Thomas Ward

And have permission to post it, if it's workplace-proprietary and they own the rights rather than you personally. (we don't like copyright takedowns)

Mast

codereview.stackexchange.com/questions/144670/…

Y no onebox...

@ThomasWard Of-course.

Mat's Mug

@Mast because comment is roomba'd

Thomas Ward

it's why i have one set of code I haven't posted for code review - not permitted :P

Mast

7:53 PM

@ThomasWard Got loads of those.

The list isn't growing though, I no longer write software for my job.

Malachi

@Phrancis I agree with you.

Thomas Ward

heh

@Mast my job isn't development, but this was dropped in my lap so meh

Malachi

@DanLyons Halo is one letter short of HAL

Kaz

@Mast That they also need to understand it. And by definition, once they understand it, they can fix any problems they're aware of. And then once they've fixed any problems they can think of, it becomes a good On-Topic CR question.

Captain Obvious

0

Q: Shell Script Merge Error

I am working on automerge of two branches in SVN using shell scripting. But after doing checkout and then doing cd to working copy and running this merge command I am getting below error: Checked out revision 117230. wait cd R1abc svn update At revision 117230. + svn merge --dry-run svn://scm....

shell svn

Mat's Mug

7:58 PM

still, there's a difference between a "poor CR question" and an "off-topic CR question"

@CaptainObvious here, that is an off-topic CR question

RoboSanta

Tumbleweed candidate; zero score, no answers, no comments, and low views: Algorithm using translate service from Angular 2 javascript algorithm typescript

Malachi

someone else want to take a look at this answer and tell me if I am incorrect?

a single meeting will have a beginning and an end, by definition the beginning will be before the end. the goal of the code is to find meetings that overlap each other. a single meeting will not overlap itself. — Malachi 5 mins ago

Mast

@Kaz While I somewhat agree with this sentiment, "once they've fixed any problems they can think of", there's plenty of questions not adhering to that.

Mat's Mug

it's nice to have and it makes a great CR post. but it's not what makes an on-topic question

Kaz

@Mast Sure, but "somebody else's code that I can see problems with and want people to point out even more problems with", at some point, crossed over to the other side of the gray zone. At least for me.

Mat's Mug

8:07 PM

eh, that's why it's community votes driving the show

sometimes I'm happy my votes are binding :)

Malachi

@Kaz if it were phrased something like "how can I make this code better?" I would say it is on topic, but the OP uses the word "problem" so I agree

Mat's Mug

@Malachi he's got a point:

@Malachi Nothing in the existing code would prevent a meeting with with and start time after the end time. For the second time that would break the algorithm. Not going to discuss this with you further. Good day. — Paparazzi 7 mins ago

Malachi

if it has an end datetime before a beginning datetime, then it isn't really a meeting is it?

Mat's Mug

the point is that there's nothing to prevent that from happening, regardless of how much sense it would make

RoboSanta

Naruto answer; accepted non-selfie answer with 0 score: Read from DataInputStream (Socket connection) java io stream

Malachi

8:10 PM

that should break the application and cause an exception, shouldn't it? I would assume that this is part of a larger application that already has meetings in it

but OP gives the Meeting class

Mat's Mug

public class Meeting
{
    public DateTime Start { get; private set; }
    public DateTime End { get; private set; }

    public Meeting(DateTime start, DateTime end)
    {
        this.Start = start;
        this.End = end;
    }
}

yes, and nothing prevents making an instance with End < Start

Duga

This question is probably more suited to codereview.se. — ArchbishopOfBanterbury 1 min ago

Captain Obvious

0

Q: Check repository for a nested entity

I have a Product entity and a ProductCategory entity. Given the Product entity, my application checks the database via a repository to see if the ProductCategory already exists. If the category is not found in the database, then the application should persist it. Currently, I have this code in t...

java repository jpa ddd

0

Q: injectOptions jQuery plugin

Over the past year I've found myself moving from back-end development to something more akin to full-stack development. I've created the following jQuery plugin as a test of my hopefully-not-so-fledgling JavaScript/jQuery skills. The plugin is used to inject <option> tags into the element(s) spec...

javascript jquery plugin

RoboSanta

Ripe zombie; open question with answers, at least one answer having score 0, no answer having score > 0: Find items in a table that match a set of conditions in another table performance sql sql-server

Duga

possible answer invalidation by Kris Swat on question by Kris Swat: codereview.stackexchange.com/posts/144587/revisions

@AdelKhatem , this is a codereview question :/ — amanuel2 48 secs ago

Mat's Mug

8:24 PM

hi @Atomic_alarm!

Duga

CodeReview: link. — wOxxOm just now

Malachi

in C# if I want to throw an exception from a property set, would you look down on me with disdain @Mat'sMug?

Mat's Mug

from a setter or an indexer, no. from a getter, ....wear a helmet ;-)

Captain Obvious

-1

Q: Java programming

this is an assignment for my cs class and i have no idea how to start it. any help is greatly appreciated. Data File for Grades Write a program that processes the file Grades.dat and produces a report with the following headings: Grades for CIS1100 Last Name First Name ID Aver...

java

Malachi

@Mat'sMug yeah from a getter wouldn't make much sense, would it?

Mat's Mug

8:29 PM

@Malachi tell that to Microsoft's VBIDE API

but yeah, see MSDN / best practices regarding throwing exceptions from properties

Malachi

8:40 PM

I posted a review....tell me what you think?

oh hey it is almost 5

traffic is going to suck

Mat's Mug

    private set
    {
        End = value < Start ? Start.AddMinutes(15) : value
    }

IMO that is a very bad idea

where's the 15 coming from?

just throw instead

also... wouldn't compile

Malachi

I mentioned that I didn't like that. and I think I need private properties in order to do this

because the shortcut actually creates the private properties, right?

I think I still need to have a default value for the properties as well...

I have edited it

Mat's Mug

9:00 PM

if (start > end)
{
    throw new ArgumentException("Cannot create a meeting that ends before it starts.");
}

^^ IMO that's the only sensible thing to do. in the constructor.

that 15-minute arbitrary thing is just adding failure points and unspecified behavior

and your return x.End > y.Start; is wrong

that only tells you if meeting A ends after meeting B started

if meeting A starts after B ended, your condition is true but the meetings don't overlap

Malachi

@Mat'sMug that should be covered by the OrderBy(m.Start) shouldn't it?

I am running some things in LinqPad but I am getting something weird, let me put the other condition back in

still getting a weird match

Mat's Mug

IMO that kind of condition shouldn't be assuming anything - I'd go with return x.Start >= y.Start && x.End <= y.End; or something like that

(busy ATM, didn't think that one through, don't take it for cash)

Malachi

that actually works

Mat's Mug

lol, oh well :)

Malachi

not perfect though

I tried to add new Meeting(DateTime.Parse("1/1/2015 23:20", format), DateTime.Parse("1/2/2015 00:00", format)) and it didn't register that it overlapped new Meeting(DateTime.Parse("1/1/2015 23:20", format), DateTime.Parse("1/1/2015 23:50", format)),

Captain Obvious

9:26 PM

0

Q: Encrypting and decrypting strings using Caesar cipher

I was inspired by a solution in Think Python: How to Think Like a Computer Scientist. I structured mine according to it, and used the technique used in rotate_letter. It's here if you're interested. How can I make this better in all aspects (documentation, algorithm, variable names, and etc.)? I...

python beginner algorithm python-3.x cryptography

Mat's Mug

so it doesn't work then

Malachi

they are backwards because of the way that the Overlappings Method is written....I just found it, let me make a few tweaks

	public static IEnumerable<Meeting[]> Overlappings(this IEnumerable<Meeting> meetings)
	{
	    var first = (Meeting)null;
	    foreach (var meeting in meetings.OrderBy(m => m.Start))
	    {
	        if (first != null && meeting.OverlapsWith(first))
	        {
	            yield return new [] { first, meeting };
	        }
	        first = meeting;
	    }
	}

	public static bool OverlapsWith(this Meeting second, Meeting first)
	{
		first.End.Dump();
		second.Start.Dump();
		return first.End > second.Start;

the current iteration is the second meeting, not the first meeting, we were looking at it backwards and not even knowing it.

Mat's Mug

actually, why can't there be a bool Overlaps(Meeting other) instance method on the Meeting type itself?

I'd remove the OverlapsWith extension method and put it in Meeting - there's no need to extend a type you already own

Malachi

it should be in the meeting class

it doesn't feel right for some reason.....

Mat's Mug

9:43 PM

why wouldn't it?

Mast

This user could use an account merge.

Mat's Mug

requested 2 hours ago ;-)

TTQW

Mast

:-)

Malachi

okay, now I have the right code

@Mat'sMug codereview.stackexchange.com/a/144692/18427

for when you get home

Captain Obvious

10:04 PM

0

Q: Dictionary Parser Class

I'm working on a parser library for substituting strings in dictionaries, with things like globals etc. Wanting to get opinions on the direction I'm taking and where I can improve the script. This currently works class DictParser(object): def __init__(self, dictionary): self.working_...

python dictionary

0

Q: Is this function ready for production?

We have a function declaration as stated below... function itemIncludesTotal(item){ var includeItem = false; if (item.lineItem.hasOwnProperty("details") && item.lineItem.details.hasOwnProperty("total") && item.lineItem.details["total"] && !item.lineItemRestriction ...

java javascript programming-challenge ruby functional-programming

Jamal

@CaptainObvious Can anyone tell if this is actually real or just hypothetical? Sometimes the OP doesn't best know how to determine that.

Captain Obvious

0

Q: Plotting the Koch Snowflake

The Koch snowflake is a well known fractal. Beginning with an equilateral triangle, a smaller equilateral triangle is placed halfway along each edge of the shape. This process then repeats on each edge of the new shape. Here is my attempt to plot this in MATLAB. clc, clearvars, close all; leng...

matlab fractals

0

Q: Scala Play ReactiveMongo web app

This is my first project that I've written using Scala and the Play framework. It's a simple application that allows the user to store pictures and see them (no edit/delete functionality, just to keep the code review simple). I have included a couple of questions as TODOs in the source code (onl...

scala nosql

Duga

10:23 PM

it's a good question for codereview.stackexchange.com, though i didn't downvote — tinySandy 14 secs ago

Mast

10:36 PM

@Jamal Doesn't look reviewable to me.

@Duga Possibly incoming.

Jamal

Probably not, but I don't quite have enough expertise to provide any specific reasons, so I sent it to chat.

Mast

Broken. I don't know who blindly upvoted it, but it's broken.

Don't upvote broken code.

Not if it's failing half the tests anyway.

Captain Obvious

-1

Q: What is wrong with my Python code and tests?

I've been asked to implement the following task before an interview: Give the following specification: "Account" is a simple command line accounting tool that takes a text file as input. The input file consists of one or more lines, each of which is in the following format: 1) mm-dd-yyyy ...

python

Duga

Please update your answer with what you expect it to do, what it's actually doing and any errors you're getting. This is a QA site, not a code review forum so you have to provide a clear question. — Soviut 57 secs ago

Jamal

chat.stackexchange.com/rooms/47093/…

Captain Obvious

10:55 PM

0

Q: How to simplify repeated build job syntax?

I've the following Groovy script: node { stage('Testing') { build job: 'Test', parameters: [string(name: 'Name', value: 'Foo'), string(name: 'Param1', value: Param1), string(name: 'Param2', value: Param2), string(name: 'Param3', value: Param3), string(name: 'Param4', value: Param4), ...

groovy

0

Q: Monte Carlo PI code error

I wrote a sample code in python for the calculation of PI with Monte Carlo simulation. But the output of the result is never 3.14. It is just some random fraction of 3. from __future__ import print_function import random import math class Point(): def __int__(self): self....

python

Jamal

@CaptainObvious This is probably hypothetical as well.

Dan Pantry

Docker is pretty cool

Captain Obvious

11:33 PM

0

Q: Find indices of first pair of numbers that sums to zero

Here is the task from a beginner's course: "Write a method that takes an array of numbers. If a pair of numbers in the array sums to zero, return the positions of those two numbers. If no pair of numbers sums to zero, return nil." Below is the model solution. It does not use idiomatic Ruby, ...

beginner ruby

Transcript for