The 2nd Monitor

EBrown

7:03 PM

@Mast Ah, looks like he fixed it then.

Mast

Yea, it is now.

OP being a good guy.

EBrown

I'm willing to bet, that he hit the "code" button, it said, "enter code here" (or whatever), then he pasted directly from the IDE. The question box had already put four spaces on the first line, but did not do so for subsequent lines.

Mast

Just threw away somebody's re-open flag. Seems it already had 4 re-open votes, but I simply don't agree with re-opening it...

EBrown

What question is that?

Mast

-1

Q: Storing object pointers in a thread-safe way

I am designing a note manager. The GUI Thread A and background sync Thread B could hold the same note pointer at the same time. class NoteManager { public: Note* getNote(const std::wstring& noteId) { std::lock_guard<std::mutex> lock; auto iter ...

It's hypothetical IMHO.

And originally asking for design practices, we don't do design.

It's a shame, really, that code really needs some fixing up.

But he needs to learn how to state a proper question first.

We don't tolerate //DO SOMETHING

My 'Leave Closed' vs 'Reopen' ratio is about 50/50 I noticed.

Malachi

7:14 PM

opinions are like armpits, everyone has them and they all stink.

EBrown

Or as Stephen Colbert says, "Opinions are like a-holes, everyone has them and mine is the best."

Captain Obvious

0

Q: Parsing a string to multiple objects in c#

Here is the code I use to get the different weather forecasts from the Environment Canada website. public static void Main() { string url = "http://dd.weather.gc.ca/nowcasting/matrices/SCRIBE.NWCSTG." + DateTime.Now.ToString("MM.dd.HH") + "Z.n.Z"; string allStations = Decompress.zDecompr...

c# parsing

Malachi

I think I VTR'd that one @Mast, but for some reason I don't think I can take it back

EBrown

@Malachi I personally won't VTR until the //do something., and //here the syncb deleted. et. al. bits go away.

Malachi

I missed those couple of // do something comments towards the end there. I saw all the stuff they added and thought it was gtg

I agree it is still not ready to be open

EBrown

7:18 PM

And //DO OTHER ACTIONS is just wrong.

If you don't scroll through the code it looks like regular code. Nothing suspicious about it. :P

Mast

@Malachi Scratch that.

Malachi

@Mast codereview.stackexchange.com/revisions/99102/2

EBrown

@Mast He edited it three hours ago.

Mast

Revisions are a b-tch.

Or a b|tch for those inclined.

@Malachi To be honest, such reviews should be done carefully.

Otherwise there is no point in having that queue.

EBrown

That was the first and only actual Review Task I have completed.

Malachi

7:25 PM

@Mast I saw an improvement and that actual code was added to the question

Mast

The question with reviewing isn't whether the edit is an improvement. It's whether it's enough improvement to invalidate the close reason.

Malachi

I am not going to argue with you.

@Jamal I explicitly searched in Meta for questions like that, and didn't find anything....

Mast

I'm not trying to, just hoping people will take note and review carefully.

Ismael Miguel

@Mast Until I elaborate what?

Mast

Follow the links.

Jamal

7:30 PM

@Malachi Either way, the MSE questions suggests that it's just not an ability, thus it's not considered a bug.

EBrown

@Jamal Meta question on what?

Jamal

0

Q: Why Can't I Retract my Reopen Vote?

On This question I voted to reopen after the second edit, but then later I realized that I shouldn't have voted to reopen, but I can't take it back, it seems the functionality doesn't exist. If I click Okay it says that I have already voted, and if I click cancel it closes the alert

bug vote-to-reopen

Ismael Miguel

@Mast It's in the comments. Basically, I asked for further explanation on that answer, since it is a total mash of nonsense and good content. I wanted to clear it out, but he simply ignored my request to come here to explain his answer. And I downvoted based on the bad content and being ignored.

Mast

@IsmaelMiguel What about the content is bad?

EBrown

> it is a total mash of nonsense and good content

Ismael Miguel

7:35 PM

That would require a huge attention span from you

Stack Exchange

1

Q: Why can't I retract my reopen vote?

On this question, I voted to reopen after the second edit. I later realized that I shouldn't have voted to reopen, but I can't take it back. It seems the functionality doesn't exist. If I click "Okay," it says that I have already voted, and if I click "Cancel," it closes the alert:

bug status-bydesign vote-to-reopen

Ismael Miguel

One of the bad things is that he says this:

There are 2 problems in this piece of code. First is why are you even trying to use try-catch. Your code doesn't seem predictable when it has something like a try-catch. Solve the root problem as to why you're experiencing this error, before resorting to a try-catch.

The next is optimization. Engines like V8 optimize code heavily (and which is why Chrome is fast). However, code inside a try-catch doesn't get optimized because it is unpredictable. The compiler "bails out".

So what you can do is place all of your code in the try-catch inside a function and call that function in the try-catc…

Besides not being useful, it destroys functionality and breaks the code

Mast

Your code depends on try-catch?

Ismael Miguel

Just because one function crapped out, I have to kill the whole queue?

EBrown

Seems very useful to me. He's advising you to not use a try/catch so that the engine can optimize it.

Duga

7:37 PM

Perhaps you need to ask on the codereview site — David Heffernan 42 secs ago

Ismael Miguel

I know about that

And I used anyway

In 2% of the code

Mast

So it's valuable advice not warranting a downvote.

Hosch250

@Malachi You should put that on MSE.

Jamal

@Duga Seriously?

Ismael Miguel

@Mast I don't find it valuable

Mast

7:37 PM

@Hosch250 Note Jamal's comment, it already is, sort of.

Malachi

@Hosch250 @Jamal already linked to that

Votes are to be spent at the desire of the spender, that is why they are anonymous

Ismael Miguel

Function('return this')()

While this relatively looks safe (because the string isn't arbitrary), you will run into issues when using this piece of code in environments with very strict CSP rules. This includes mobile devices, browser extensions and some websites who lock down these things for security.

Hosch250

OK.

Ismael Miguel

More from the same answer

I've never had any sort of problem with that function

Duga

@DavidHeffernan I hope you're joking. Code Review does not tolerate this. — Mast 45 secs ago

Malachi

7:39 PM

@Mast you are wrong in that it isn't the right thing for @IsmaelMiguel to do. it is his decision and his alone what to do with his votes.

Ismael Miguel

@Malachi ?

Shaun H

@IsmaelMiguel If you haven't seen yet, I added to my answer on your validation question.

Mast

@Malachi That's true, but in this case I doubt it's the right thing to do.

@IsmaelMiguel That doesn't make it false by default.

Jamal

@Duga I liked it better when Programmers was SO's toilet bowl. At least it's easier to understand CR's scope.

EBrown

If it were me, the answer seems extremely intelligent and helpful.

@Mast Do you have a link to this answer?

Ismael Miguel

7:40 PM

@Mast But doesn't make it useful. Only obfuscates the useful stuff

0

A: Function queue for synchronous execution

With this in mind, it also allows to execute them with a defined delay, to prevent them from blocking the browser. This is a common misconception of how the timers work. Currently executing code doesn't stop when a timer expires. That callback waits until the currently running code finishes....

Mast

Jan 16 at 16:56, by Marc-Andre

Nobody understand Programmers scope correctly :P

Ismael Miguel

@Malachi But I may want to justify it, as I did in a comment.

Malachi

dang it I keep starting to edit a post and then change thoughts

Ismael Miguel

Here is gold in that answer:

Mast

@EBrown Which is why I started this. It looks like good advice.

Ismael Miguel

7:41 PM

getQueue: function(){
  return queue;
},

I wouldn't want one to manipulate the queue outside if I were you. It could mess up your code. I suggest you return a copy of the queue, and not the queue array itself. Use slice to return a copy of the queue.

clear: function(){
  queue = [];
  return window.FnQueue;
},

A better way to clear an array without creating another array is to just set the length to zero.

Malachi

@IsmaelMiguel and that is perfectly fine, between you and the answerer.

Mast

Sure, it could have been written better, but he'll learn.

Ismael Miguel

@Malachi That's what I wanted to do. He simply gave me the finger

EBrown

@Mast I upvoted it because after reading it, the answer is well thought out and intelligent.

@IsmaelMiguel Not everyone has time to bow to your will. You would do well to learn that.

Malachi

@IsmaelMiguel or they haven't logged onto Stackexchange yet.

Ismael Miguel

7:42 PM

@Malachi He edited the answer 2 minutes later. He is really active

Malachi

oh

Ismael Miguel

@EBrown I'm not. I asked clarification in a clean way, since the answer is full of bloat. He ignored, I downvote.

EBrown

I really don't know how to say it in less than 2500 characters... Ping me on chat.stackexchange.com/rooms/25699/javascript-libraries — Ismael Miguel Jul 26 at 19:23

That does not ask for clarification.

Ismael Miguel

@EBrown Should I have been even more clear? I say there: "I have too much to say, and can't say it here because it would bloat the comment section. Please, ping me on <link> so we can discuss it"

Malachi

I am not sure about posting that CRMeta question on Meta, @Jamal has already tagged it status-by-design and there is already a really old Meta question asking the same thing

but again the Meta question is old

Mast

7:45 PM

@IsmaelMiguel Don't get me wrong, but you tend to think a lot of people want to give you the finger.

Jamal

You could also raise a bounty on the existing feature request.

Mast

We don't give each other the finger on CR. We ain't SO.

8

Ismael Miguel

@Mast What I meant with that is that he simply ignored it. And even after explaining the downvote, I haven't heard of him.

My vote stands

The question has really good content and really bad content

Mast

@IsmaelMiguel If I was him, I'd really give you the finger after that comment, delete the answer and ignore you.

Your comment does not ask for elaboration.

It reads like you want to open a flame war.

2

EBrown

Perhaps he doesn't care, as you already: 1. downvoted him, 2. accepted an answer, 3. explained nothing of why you didn't like his answer.

Mast

7:47 PM

That ^^

Ismael Miguel

@EBrown I can't explain it in the comment section. It would bloat and then it would be deleted even before he saw it.

EBrown

In my eyes, all three of those are finalization remarks. That is, you've made up your mind. Next, please.

You can indicate some semblance of what you dislike of it, and get clarification on bits at least.

Ismael Miguel

@EBrown I've accepted the answer a few days ago, less than 3

I've waited

I didn't accepted it 1 second after

I waited to get some feedback

EBrown

I.e.: "Can you elaborate on 'wouldn't want one to manipulate the queue outside' please?"

Ismael Miguel

@EBrown That was clear. I loved that part. That is one of the good things in the answer

EBrown

7:50 PM

It was an example, no need to be pedantic.

Ismael Miguel

I know, and I'm saying that what I need clarification of is in everything else

The whole answer, besides 2 points

Mast

@IsmaelMiguel Code Review is not about what you need. It's about what you get.

6

Ismael Miguel

And the answer seems a lot shorter than what I remember

Mast

Thou shall accept every critique on your code as long as it's constructive.

Ismael Miguel

@Mast Great part of it wasn't.

EBrown

7:51 PM

@Mast Unless thou are Ismael Miguel.

You just said part of it was very constructive.

Ismael Miguel

If he comes over and explain his answer, I will gladly revert my downvote

@EBrown A small part

EBrown

11 mins ago, by Ismael Miguel

Here is gold in that answer:

Ismael Miguel

11 mins ago, by Ismael Miguel

getQueue: function(){
  return queue;
},

I wouldn't want one to manipulate the queue outside if I were you. It could mess up your code. I suggest you return a copy of the queue, and not the queue array itself. Use slice to return a copy of the queue.

clear: function(){
  queue = [];
  return window.FnQueue;
},

A better way to clear an array without creating another array is to just set the length to zero.

That is the gold

EBrown

I'm not even going to continue this, I feel as if I'm arguing with a child.

Ismael Miguel

Yes, I freaking loved that bit

EBrown

7:53 PM

It's fine, you have the right to use Up/Down votes as you wish.

Ismael Miguel

@EBrown And I feel no one even cares about what I say

EBrown

Forget I was even part of this discussion, wouldn't want to upset anyone.

Ismael Miguel

I'm not upset

Malachi

yeah take the conversation to The Nth Monitor please

Ismael Miguel

@Malachi It would be off-topic there

Hosch250

7:54 PM

@JeroenVannevel Are you around?

Malachi

have the conversation by all means, just not in here, it's getting lengthy

Hosch250

Comments do not show up under Statements - I already tested that.

Ismael Miguel

The conversation died

And I have to get my pizza

Hosch250

The rest I'll fix.

SirPython

@IsmaelMiguel Don't sit on it this time.

4

Ismael Miguel

7:55 PM

@SirPython Nah. This time it comes in a box

Mast

I recently wrote a post about a FizzBuzz split up over 2 files. I clearly stated it was split up for a reason. However, he decided to critique on it anyway. He raised some valid points afar from that, so he even got an upvote. I just accepted the other answer, which happened to have more gold in it anyway.

EBrown

@Mast I'd just drop it, man. There's no point. What's done is done.

Mast

@EBrown Just offering an alternative to @IsmaelMiguel his approach.

EBrown

Also, @Mast do you have any input on this question? It seems pretty well-written.

Hosch250

@EBrown This was flagged.

EBrown

7:59 PM

@Hosch250 Too late to edit now, mods can either edit/remove it or not.

Mast

@EBrown OP doesn't know for sure it's working.

That should raise a red flag when reading it.

Phrancis

Long and short of it: The SE system works; use the tools given to you (votes, accepts, comments, etc.). To just sit here in chat arguing about every little thing is not productive

5

EBrown

That was the only issue I saw with it as well.

Though, he does say: "Even though it hasn't finished it is working as expected due to some testing I did."

(Emphasis mine)

Mast

@EBrown I expect all my code to work. Doesn't make me right though.

If it was accepting user input and would work on smaller problems and work on that, it would be great. Now, nobody knows.

EBrown

Well, provided he is not fudging that sentence, then his code does do what he says it should (at least while he is testing it), and it should still be considered on-topic.

Mast

8:04 PM

@EBrown Have you checked?

EBrown

I don't have a python interpreter at all. (I'm not a python person, lol.)

Mast

I'll put it in a file and check.

EBrown

You could start it with a **much** smaller square:
8 1 6
3 5 7
4 9 2
is a valid square.

Just replace 58 in all his code with 15.

Mast

@EBrown Nope, it needs an external file.