The 2nd Monitor

rolfl

2:00 PM

@SeanParsons - working on giving you write access here....

RubberDuck

@SimonAndréForsberg this search may interest you. codereview.stackexchange.com/…

Donald.McLean

I've been mod for 18 month, and I've handled more flags on astronomy than the other astronomy mods and the community mods combined. We've only had 463 flags, total, over the entire lifespan of the site.

rolfl

@SeanParsons - you should be able to chat nw.

> 9.3k flags, average handling time 0 days 3 hours 53 minutes 0 seconds

This quarter:

> 1.3k flags, average handling time 0 days 0 hours 14 minutes 0 seconds

Hmmm... that seems fishy

Donald.McLean

That's not too bad considering you have more than 10x the astronomy question count.

rolfl

We handle a lot of auto-close-without-comment flags.

which we just routinely decline.

Simon André Forsberg

2:05 PM

@Donald.McLean Greetings Fridays. It's P R O G R A M S !!!!!!!!!

rolfl

Like this one: vvvvvvv

(come on Captain.....)

Simon André Forsberg

@rolfl I rarely see Jamal commenting when closing a question.

rolfl

If the close reason is obvious, we don't

-1

Q: PHP parameter naming conventions (singular or plural)

When a PHP function has an parameter that can except either a single element or a collection of elements should the parameter be named using a singular or plural noun? The example I have is the following: /** * @param string|array $feature */ function addSupport($feature) { // ... } The...

Simon André Forsberg

@rolfl That thing still exists?

Captain Obvious

-1

Q: PHP parameter naming conventions (singular or plural)

When a PHP function has an parameter that can except either a single element or a collection of elements should the parameter be named using a singular or plural noun? The example I have is the following: /** * @param string|array $feature */ function addSupport($feature) { // ... } The...

php naming

Simon André Forsberg

2:12 PM

@RubberDuck this search is also interesting

RubberDuck

@SimonAndréForsberg Only 143? heh..

Simon André Forsberg

@Jamal I disagree with this:

You don't really need to provide links to separate implementations. That's only necessary for follow-up posts. — Jamal ♦ 2 days ago

I don't see any harm in providing a link to a different implementation in a different language...?

It's a way of pimping your other questions

rolfl

@CaptainObvious Much better question now!

skiwi

@RubberDuck Heck, I didn't even know that existed!

RubberDuck

Most people don't.

Morwenn

2:23 PM

Oh, so that's what moderation tools actually are :o

rolfl

not sure if you are all joking....

codereview.stackexchange.com/review

then click "Tools" at the top left.

Morwenn

No seriously, it's the first time I ever see this page.

Sean Parsons

Hello Everybody

rolfl

Also, note that on the top-right, there's also 4 tabs for different aspects.

RubberDuck

@SeanParsons hello!

rolfl

2:26 PM

Hey Sean. Pleased you got here.

Sean Parsons

Asam I

DJanssens

I guess you need a specific amount of rep before being able to see those Tools @rolfl?

rolfl

I have given you write-access to this room only... when you have 50 rep network-wide, you can chat in any room

Morwenn

By the way, does anybody know if SE blogs are still being developped?

Sean Parsons

Thank you!

rolfl

2:27 PM

@Morwenn Not at the moment... there were issues.

Morwenn

Meh :/

rolfl

@DJanssens codereview.stackexchange.com/help/privileges/moderator-tools

Donald.McLean

@Morwenn I think they're only available in graduated sites.

rolfl

@Everyone, when you got 2000 rep, did you read the message you got? codereview.stackexchange.com/help/privileges/moderator-tools

it is all in there ;-)

Morwenn

@Donald.McLean That's not true, Islam.SE had an active blog while being in beta.

DJanssens

2:29 PM

1.4k rep to go :D

Mat's Mug

Hi!

rolfl

@Morwenn - there were issues with the blog system, the SE folk thought they would make an exception for Code Review, but then decided to revamp the whole thing instead.

Donald.McLean

Ok then, they're normally only available to graduated sites. Obviously they make some exceptions.

rolfl

that revamp is still probably 6-8 weeks away, and in 6-8 weeks will be another 6-8 weeks....

4

Morwenn

@rolfl Yeah, I know that, but it has been a while since then. I mean, I haven't heard of the revamp since.

Well...

rolfl

2:30 PM

Nahhh, there's been no news since the last time we asked.

Donald.McLean

@rolfl Sounds like the stories the old timers at my office tell. One woman went to three separate "one year to launch" parties.

2

rolfl

Perhaps it is time to ask again.

Morwenn

I raised the idea on Meta one year and 2 days ago. Since then, I had time to get two diplomas and find two jobs...

(And also to do nothing during 6 months)

Mat's Mug

I just scored +32 scanning through my own unaccepted questions and going on a checkmark-spree. Some were waaay overdue. Sorry for the delay, @Community

in VBA, 18 secs ago, by Chrismas007

A programmers wife is having a baby. When the baby is born, the doctor hands the baby to the programmer to announce the gender. The wife says, "Is it a boy or a girl?" The programmer responds, "True."

Morwenn

Someone's been programming in PROLOG.

Sean Parsons

2:43 PM

What language do you guys mainly code in?

Mat's Mug

c#vba t-sql

rolfl

@Morwenn The official word is that the SE staff have not been working on blogs for sites "for a while", and that the concept is not being discussed actively in their regular meetings.

Morwenn

c++

Simon André Forsberg

java

brainfuck

2

rolfl

english

Mat's Mug

2:44 PM

^^ mainly?

Donald.McLean

scala javascript

Morwenn

If my job is also taken into account, then python and soon enough java with probably a bit of c.

Sean Parsons

im a Javascript guy, you guys stay on here a lot?

Simon André Forsberg

@Mat'sMug Look at my question tags :) The top language tags are java and brainfuck :)

RubberDuck

@Mat'sMug Holy moly. Thanks Mug. I guess now I have to go answer a few questions so I can repcap today...

> +90

Donald.McLean

2:46 PM

@SeanParsons Mostly when I'm "at work".

Sean Parsons

What framework are you using?

Donald.McLean

Lift

Mat's Mug

Sean Parsons

Ahh, never heard of it. I'm using Angular

Donald.McLean

@SeanParsons Lift is a framework for web apps, uses Scala on the server and JavaScript/JQuery on the client.

Sean Parsons

2:48 PM

So your a full-stack?

Donald.McLean

@SeanParsons I am a one-man project.

Sean Parsons

Good for you, I'm focusing on being a front-end developer.

Donald.McLean

And the app has been in production for a year or so.

Sean Parsons

I've only been coding for 4.5 months so i'm trying to comprehend a layer completely before I extend to another.

Donald.McLean

@SeanParsons I've been a full time paid developer for 27 years. I took my first programming class almost 39 years ago.

Lyle's Mug

2:51 PM

sorry I have to post this....

Sean Parsons

I'm just getting into the game, I'm 23 years old.

I really enjoy it though!

Donald.McLean

@SeanParsons You're one year older than my youngest child, and younger than the older two.

But since you have no control over your age, we won't hold it against you.

rolfl

4 years ago you were half my age.

Jeroen Vannevel

I feel like I'm reading a riddle

Morwenn

Well, I'm 23 years old too.

Donald.McLean

2:54 PM

I'm half tempted, on a lark, to post an iTunes playlist programming question.

Lyle's Mug

HEY I actually got my accept on ▼▼▼

25

A: Stored procedure

You have a lot of if statements in your SQL. This screams at me that you are doing something in your SQL that should be done in the application, and that this SQL should be separated into two distinct stored procedures. The benefits of doing this: Faster stored procedures Use a coding langua...

Donald.McLean

I don't often ask questions, but when I do, I always accept the best answer.

9

Lyle's Mug

@Donald.McLean this needs to be pinned!

Jeroen Vannevel

@DanPantry:

GET http://guesstheurf.azurewebsites.net/api/games
Authorization: Bearer SNGVRVjPL1eOdWsbFOZ3apsnkwk8ZrxMChMrXyUqp46PycgFQjwZvyMs6an3DlmZyypFJGWWWKhnXnhB_zpl1LQq8zENTBJeonVQ3MI41e2CNXABuIZKKbQjKRjnYJ6GLMMqazZy0w9b_Y6EeW4RGik9BheIqQF01nqhX1elHcChUtNqr-EiZShIyY4LenqMYtVMtGNRu1CTUzHNf_FZMUZVHIa19vORreKwoK1VJYF8T-c_uHTvTGIGpl2mexsi7IbOt4dKkfQbzCevbI4iSwEhLc_hiBMzbbIhGlsGXTU

Duga

It's important to note that code reviews currently can only be requested and viewed by VS Premium and Ultimate users, not VS Professional. — Jazaret 13 secs ago

Sean Parsons

3:00 PM

Yes @Morewenn, you can be 23 too but you've probably been doing this for some time.

@Morwenn

i'm just hopping on the bang wagon.

2

band*

Morwenn

@SeanParsons Well, I have been "coding" for ~6 years, but it has only been 3 years since I seriously decided to write beautiful code.

Jamal

@SimonAndréForsberg Then the pimping can be done in the comments.

Morwenn

I you want a serious young programmer, there's @Doorknob on Programming Puzzles and Code Golf.

rolfl

He's not so serious.... he's joking all the time ;-)

and have you seen the code he writes?

Morwenn

Serious enough to become moderator at 13 :)

rolfl

3:08 PM

2

A: Make a caeser cipher

Golfscript, 1 character 0 Outputs the input string rotated by 0 characters, plus the digit 0 to show how to decode it. (sorry, I couldn't resist)

Morwenn

44

Q: How can I kill puppies without consequences?

The starting pets can sometimes get quite annoying, since they keep getting in your way. Those little dogs keep blocking my path! Therefore, I quite reasonably want to slaughter them brutally. But of course I want to do this safely. I've noticed that whenever I kill my pet, I "hear the rumble of...

nethack

RubberDuck

@Morwenn 3 years well spent.

Mat's Mug

Sigh. Are these provocative question titles on SE becoming a form of click whoring? — Roger Dahl Mar 9 '14 at 3:36

Captain Obvious

3:26 PM

1

Q: Two-player match-picking game

I'm looking for some feedback on my first program. It's a small game you play with matches. It's a two-player game, where the players take turns picking matches (1, 2 or 3) and cannot pick the same number of matches as the other player: if player one picks 2 matches, player two will have to pick...

java game

0

Q: Seemingly redundant conditionals...or not?

I'm working on some code that has the following pattern of conditionals inside it. It doesn't look great, but it doesn't look terrible. Please, shed some light on the underlying reason this is not passing my smell test. I'd love to see some alternatives. I'm guessing it's because it's completel...

c# conditions

moarboilerplate

all right fellas lets chat

I cam

can't* really post the code I'm working with, so I basically rewrote it with hypothetical names

I'm pretty sure it's only being flagged as "off-topic'" is because I replaced the names with hypothethiical names

Simon André Forsberg

@Jamal sure it can, but what is wrong about doing it in the question itself? I personally think that edit was a bit overly-pedantic. Besides, you didn't add it as a comment, or asked the OP to add it as a comment.

Mat's Mug

@moarboilerplate I'm pretty sure you're not interested in answers saying "use meaningful names, 'a' is a bad name for a variable...

Jamal

@SimonAndréForsberg I forgot to do that, but it may not matter so much now.

Simon André Forsberg

@Jamal forgot? "may not matter so much now"? Obviously you found that it mattered enough in the first place to edit it....

Dan Pantry

3:39 PM

@JeroenVannevel well done

Sean Parsons

@Morwenn Great!, I can't wait to get to that point. I was formally in the construction business. I never looked back since I left it.

Duga

I'm voting to close this question as off-topic because it is about code review — tnw 1 min ago

Thank you Comintern. I didn't know Code Review existed. I will look in to that as well. — fonzy16 1 min ago

Mat's Mug

@moarboilerplate there's nothing wrong with "anonymizing" code. The only thing is, it's pretty hard to do that correctly, without stripping so much context that the code doesn't mean anything anymore.

RubberDuck

@moarboilerplate you want to know what's bad about this?

public void BuzzRedux(bool a, bool b)
{
    if (a || b)
    {
        if (a && b)
        {
            It = "foo";
        }
        else
        {
            It = a ? "bar" : "baz";
        }
    }
}

It should just be...

Dan Pantry

I haev 15 minutes left on my work day and I have to refactor static code with a circular reference

@_@.

RubberDuck

3:43 PM

public void BuzzRedux(bool a, bool b)
{
     if (a || b)
     {
         It = SomeMethod(a,b);
     }
}

With all that other logic buried in a method.

Rainbolt

I don't agree with that refactoring.

RubberDuck

Why?

Rainbolt

The method is not unnecessarily long.

Nor is it complex

Dan Pantry

but it violates SRP.

Thus is needs a refactor.

RubberDuck

@DanPantry took the words out of my mouth.

Rainbolt

3:45 PM

It's only responsibility is to determine what It should be.

Simon André Forsberg

   if (a && b)
    {
        It = "foo";
    }
    else if (a || b)
    {
        It = a ? "bar" : "baz";
    }

Sean Parsons

^ looks good.

Simon André Forsberg

Don't make the boolean logic more complicated than it has to be

RubberDuck

Nice option there ^^

Simon André Forsberg

No need for nesting.

Dan Pantry

3:46 PM

it won't work with the testing

original code was if a or b and then if a and b

that would only ever work if a && b thus making a || b pointless

Simon André Forsberg

I think you're wrong, @DanPantry.

Sean Parsons

^

Simon André Forsberg

Read the logic again.

RubberDuck

No.. I think Dan's right.

Dan Pantry

public void BuzzRedux(bool a, bool b)
{
    if (a || b)
    {
        if (a && b)
        {
            It = "foo";
        }
        else
        {
            It = a ? "bar" : "baz";
        }
    }
}

Sean Parsons

3:47 PM

else if will run another logic test.

Dan Pantry

This is what I read, and I am right

RubberDuck

Wait..

No. Idk.

Dan Pantry

there is no need t ohave that a || b

Simon André Forsberg

@DanPantry If a is set but not b, the else will run.

moarboilerplate

here are osme unit tests

Dan Pantry

3:48 PM

@Simon yes, I know

Rainbolt

Dan, provide some a and b that produces different results for each code.

Dan Pantry

but you could just remove teh a || b out then.

Simon André Forsberg

there's a case if a is false and b is false.

moarboilerplate

tyhe code will work

correct. and it's ignored

null is expected

Dan Pantry

  if (a && b)
  {
      It = "foo";
  }
  else
  {
      It = a ? "bar" : "baz";
  }

moarboilerplate

3:48 PM

anwayy. i changed the code

RubberDuck

Yeah. @Simon is right. The his code works.

Simon André Forsberg

@DanPantry Wrong.

RubberDuck

@DanPantry That code is the one that's not like the others.

Dan Pantry

yeah, I am wrong. just realized

Simon André Forsberg

if (!a && !b) should not change the value of It

Dan Pantry

3:49 PM

I didn't know the original problem, and iddn't see that

moarboilerplate

 [TestClass]
    public class ThingTests
    {
        [TestMethod]
        public void FooTest()
        {
            var thing = new Thing();
            thing.Buzz(true, true);
            Assert.AreEqual("foo", thing.It);
        }

        [TestMethod]
        public void BarTest()
        {
            var thing = new Thing();
            thing.Buzz(true, false);
            Assert.AreEqual("bar", thing.It);
        }

        [TestMethod]
        public void BazTest()
        {
            var thing = new Thing();

Sean Parsons

Simons code looked right.

Dan Pantry

My bad.

Simon's code works, yeah.

I didn't see the original problem just butted in mid way

Either way WTF is the problem here

fizzbuzz?

Simon André Forsberg

There is a original problem?

Dan Pantry

As in what is the problem the code is trying to solve

Not as in what is the problem with the code

RubberDuck

3:50 PM

@DanPantry that's why it's off topic. =;)-

moarboilerplate

i changed the variable names

suddenly it will become on-topic

Simon André Forsberg

@DanPantry yeah, exactly what I meant. I have also no clue about the context here.

RubberDuck

Was off topic. Looks good to my eyes now.

0

Q: Seemingly redundant conditionals...or not?

I'm working on some code that has the following pattern of conditionals inside it. It doesn't look great, but it doesn't look terrible. Please, shed some light on the underlying reason this is not passing my smell test. I'd love to see some alternatives. I'm guessing it's because it's completel...

c# conditions

Dan Pantry

@moarboilerplate Oh right.

Yes because it removes context

Rainbolt

Someone suggested burying the four lines of actual logic (yea, it's only four lines without braces) in another method. I wouldn't. A single IF ELSE IF that assigns to a single variable can't possibly be in violation of the SRP.

RubberDuck

3:51 PM

@moarboilerplate just be prepared for the "use an enum" answer. =)

Dan Pantry

@Rainbolt well, it is doing if and else and defining 'fizz' and 'buzz' ;-)

moarboilerplate

ahem

that's bar and baz

Mat's Mug

@RubberDuck totally. and that answer isn't possible without proper context.

Dan Pantry

I need a hair cut because you just split mine

moarboilerplate

so yes, we can use an enum

but that's not really possible for me

having said that

i don't see the context provides much else

especailly since the source of the smell is checking permutations

Mat's Mug

3:54 PM

that you can see. the point of peer reviewing is making sure you saw everything there is to see...

RubberDuck

@moarboilerplate I fixed the code so that it compiles.

Simon André Forsberg

@Rainbolt I agree.

Jeroen Vannevel

The code doesn't make any sense though

moarboilerplate

whoops

RubberDuck

@SimonAndréForsberg @Rainbolt, well..... after seeing Simon's solution. I agree as well. Maybe...

Jeroen Vannevel

3:54 PM

It sets the role for.. what? There is no user object connected to all that

Dan Pantry

If you set it to 'fizz buzz' or 'baz bar' with the proper variable names it's pretty obvious what the intention is (and imo it should be off topic just for being fizz buzz ;)) and people can understand what your code is doing

if people have to mentally decipher the variable names before reviewing your code, then you're doing it wrong

moarboilerplate

@DanPantry it's not fizz buzz

Dan Pantry

The context should by and large be easy for a reviewer to deduce so they can actually, you know, review your code

moarboilerplate

and please be less condescending

Dan Pantry

I was talking about the code sample I was given

Simon André Forsberg

3:55 PM

How is the resulting Role value used? What checks do you run on it? I am suspecting that there might be more smells there. — Simon André Forsberg 2 mins ago

moarboilerplate

correct

Dan Pantry

I'm not being condescending.

I have not viewed your question, I am looking at the I = "baz" thing.

Jeroen Vannevel

@moarboilerplate Can you clarify how your code is used? Because I don't see how this makes sense, considering you're not setting the role of a user

moarboilerplate

I think that's a slippery slope

@JeroenVannevel because

Dan Pantry

My point being that if you use 'minified', random crap variable names and someone has to work out in their head what they are meant to do, then you are doing it wrong. That is why we use sensible names rather than a or b, and is also why just changing the name of a variable can lead things to being off topic. You would use sensible names in production code, I don't see why it shoudl be different for CR.

Mat's Mug

3:57 PM

^^ that

Dan Pantry

We are, in essence, antoher programmer coming along to look at your code. If we can't understand it, then what chance does another programmer who hates his job have?

moarboilerplate

@DanPantry fair point

Dan Pantry

The idea behind code reviews is to improve your code but also point out how understandable it is to other users.

Besides if you give us code that is not production code then you'll probably throw out the code adn the review will be useless anyway... :^) (the royal you, not ACTUALLY you)

Mat's Mug

and your question should allow answerers to address any and all aspects of the code, per the on-topic checklist

moarboilerplate

So the class's Role value is set inside the assembly by DAL/backend code, and the frontend code inspects it for permissions

but what improvement does that provide?

Sean Parsons

4:05 PM

Yeah, I posted a snippet of a responsive jQuery navigation I created and I got some great feedback, I will always from now on use code review to sharpen my code. Because having other programmers look at my code who have been in the game for a long time is a invaluable resource.

2

Mat's Mug

@moarboilerplate it helps reviewers understand the problem your code is solving...

Duga

I'm voting to close this question as off-topic because. can we move it to code review? codereview.stackexchange.com — guitarthrower 1 min ago

Mat's Mug

@SeanParsons also feel free to review other people's code, too - you'd be surprised at the things you can find, even in more experienced programmers' code ;)

rolfl

And even more surprised at how much you learn reviewing someone else's code.

Mat's Mug

the more reviewers, the more happy reviewees!

moarboilerplate

4:09 PM

@Mat'sMug this is a piece of code that looks at values passed to it from internal code, and returns a role to frontend code

Sean Parsons

Most of the people I see posting questions are further along than I am in programming but that's a given since I've been doing it for a short amount of time but I enjoy looking at the things they can do with the same technology I am using that I cant do yet, it's great!

moarboilerplate

@Mat'sMug is it unclear?

Mat's Mug

it's not. the question has my reopen vote, and I agree with the closing of revision 1

s/closing/put-on-hold

moarboilerplate

@Mat'sMug yep

@Mat'sMug I really am curious to see how the added context provides anything but a suggestion to use an enum

Mat's Mug

it makes a better CR question that's not entirely focused on an atomic problem that only the OP knows about

moarboilerplate

4:17 PM

@Mat'sMug I agree with that, but the rub is that you sacrifice all other contexts that the problem can be applied to. Which is sometimes the spark for an answer

Jeroen Vannevel

@moarboilerplate Why isn't the role associated with a particular user?

There's nothing to improve here other than an apparent architectural fault

Sean Parsons

Are all of you at work, home, school? whats the deal?

moarboilerplate

@JeroenVannevel the problem I have with the code is with the conditional structure, which is confined to the class

Jeroen Vannevel

What us the problem with it?

is*

moarboilerplate

it's messy

Jeroen Vannevel

4:19 PM

I'll need you to be a little more technical

Mat's Mug

@SeanParsons work

moarboilerplate

@JeroenVannevel it doesn't look right to me. I'm actually looking for an explanation of why it doesn't look right to me. If I could explain that to you, I'd probably have my answer

Jeroen Vannevel

It doesn't look right because there is a structural flaw in your role management system and the lack of enums that you don't want to use

If you REAAALLLYYYYYY want to be like this: add in another default fallthrough if statement to set the Role to string.Empty

Hosch250

@Mehrad I can read/write C at a certain level, but I have never actually tried to do anything it.

Jeroen Vannevel

Because now subsequent calls to SetRole() will interfere

moarboilerplate

4:23 PM

@JeroenVannevel If I changed it to use enums, the conditions would remain the same

Jeroen Vannevel

as in: SetRole(true, true) sets the role to FullAccess

But if you then call SetRole(false, false), it will still be FullAccess

which is no bueno

moarboilerplate

it will be null

Jeroen Vannevel

No it won't

moarboilerplate

oh, if it was called multiple times, yes

it's a void method with side effects. that is bad, but not what led me to the question

Simon André Forsberg

@moarboilerplate Not necessarily. If you use enums, you could use more tricks me thinks.

Jeroen Vannevel

4:25 PM

So add the 4th check: else { Role = string.Empty; }

moarboilerplate

on the consuming code, but not in the mproblematic method

Simon André Forsberg

The consuming code and this method is a bit tied.

The problem is the approach.

moarboilerplate

I think that is the source of one problem with the code, but not what I'm worried about. As an enterprise dev you have to put up with some smells as you focus on others. In this case I'm worried about cleaning up this class so it works the same way as it did before

Jeroen Vannevel

I just gave you 3 problems about that code!

What more do you want?! It's 10 lines of code total with really just an if-statement

Are you saying it doesn't work as it should? How did it work then?

moarboilerplate

I'm not saying that

I'm saying I'm focusing on cleaning up this class

and only this class

Jeroen Vannevel

4:28 PM

4th problem: your strings should be accessed in one constant (or a resource file) so you don't have typo errors

moarboilerplate

those are all fair points\

do you have any thoughts on the conditionals other than adding the 4th statement?

Jeroen Vannevel

No.

moarboilerplate

@SimonAndréForsberg it would be nice if I could use enum flags to use bitwise ops on permissions...

however that's one of those things that would require a bit of a rewrite, so that's not going to happen

Mat's Mug

this is CR, we don't care what can actually happen - only what should happen to the code for it to shine :)

rolfl

Reopened ... (right...?)

moarboilerplate

4:36 PM

@rolfl yep

time for everyone to tear me a new one :)

well, more like a third

Duga

4:52 PM

Perhaps this would fare better on [codereview.stackexchange.com] ? — user667489 15 secs ago

Duga

5:04 PM

%200_success - is it a good fit because of the wording, or because it is more likely to get good answers on codereview? Are there enough numpy users on codereview to justify such a move? — hpaulj 1 min ago

Mat's Mug

5:16 PM

Why doesn't this guy just come over and start reviewing numpy questions then?

2

"But CR is too small" is utter bullshit

RubberDuck

@hpaulj let's move this conversation to chat. — RubberDuck 11 secs ago

Duga

I'm voting to close this question as off-topic because it belongs in another site, codereview — A.J. 31 secs ago

RubberDuck

@Duga I give up....

Lyle's Mug

2 accepted answers in one day! wow!

Simon André Forsberg

@Lyle'sMug Were both answers old answers on questions posted by @Mat'sMug?

Lyle's Mug

5:27 PM

neither of them were

Hosch250

Trying to get my Nokia 520 to download Windows Preview.

Duga

@A.J. a) When voting to close for belonging on other sites normally, the questions are migrated not closed. Code Review is not a migration target for a number of reasons. Please don't vote to close questions because they "belong at Code Review" (vote to close as "too broad" or "primarily opinion-based" instead) b) Explaining code, which half of this question is about, is explicitly off-topic for Code Review, so technically, this question as it looks right now, does not really belong there. — Simon André Forsberg 1 min ago

Hosch250

Apparently MS' servers are overloaded.

It was just released 28 minutes ago.

There are a bunch of new devices supported this release, so I'm not really surprised.

Duga

@SimonAndréForsberg I disagree. This question is explicitly asking for coding feedback, which is the reason CodeReview is in existence — A.J. 23 secs ago

Simon André Forsberg

@RubberDuck me too ^^

Hosch250

5:30 PM

What are they supposed to do, flag for migration?

RubberDuck

@Duga whiskey, tango, foxtrot

Simon André Forsberg

@A.J. Very well, then there is a risk that the question will be closed on two sites then... if you want to discuss this further, I suggest we take the discussion to chat — Simon André Forsberg 6 secs ago

Duga

Give it a shot on CodeReview! — Drop 1 min ago

Simon André Forsberg

@Hosch250 or VTC as "Too broad".

RubberDuck

@A.J.... not to be rude, but Simon is a regular on CR. You have 121 rep there. — RubberDuck 30 secs ago

A.J.

5:33 PM

sup

Simon André Forsberg

Hi @A.J., thanks for stopping by!

Hosch250

Hi.

Welcome to The 2nd Monitor!

A.J.

no problem

Yeah I don't really use CodeReview :D

Simon André Forsberg

It's nice that you want to help people find Code Review, but voting to close as "belongs on Code Review" is not always very helpful

A.J.

Yeah oh well. Apparently 3 other people agreed with my misunderstanding :D

Simon André Forsberg

5:36 PM

imagine that the Stack Overflow question will be closed with the reason "belongs on Code Review", and then the OP will come here and post a question, and then what if it becomes closed here as well? Did it then really "belong on Code Review"?

Captain Obvious

0

Q: Refactoring spaghetti code

I'm beginning the long process of refractoring an Android app written entirely in SpaghettiJava™. I've been programming for a relatively short period of time (two years), and have tried refactoring the code base multiple times, but always get hung up on the wrong things and end up making very slo...

java android

Hosch250

Lol "SpaghettiJava™"

Simon André Forsberg

@A.J. The question is slightly problematic for CR because the OP did not write all the code himself, and also doesn't entirely understand the code.

Asking for a review of code that you did not write is off-topic on Code Review, there's a meta about that... hold on...

21

Q: Why is only my own written code on-topic?

I tend to disagree with point #2 on the Help Center: Did I write that code? I believe any code, written by one self or anyone else should be eligible for code review. Many a times, you're reviewing others' code. Any specific reason for this restriction?

discussion faq site-policy licensing

Captain Obvious

0

Q: Optimizing jQuery/JS Switch Statement

I am trying to optimize the following switch statement, but I'm having a brain fart about how to do it. Here's the code: $('.newsroom-tabs div.pane-content ul li').click(function(){ // get the class name of the clicked link var className = $(this).attr('class'); // variable so that jQuery isn't ...

javascript beginner performance jquery

A.J.

Agreed

hpaulj

5:45 PM

I'm raising objections to moving numpy questions to codereview because a common numpy question involves speed improvement, usually by vectorization or use of cython or numba. I'm afraid that moving that kind of question to CR just because it uses words like 'speed' or 'improve' just puts it out of sight of SO experts who could help. People who understand numpy issues should have a say in what gets moved.

Simon André Forsberg

@RubberDuck @Mat'sMug Look who is here ^^

RubberDuck

@hpaulj well, that's a fair point. But we would also invite you to be part of our community as well.

It's not an either or.

We could certainly use a few more domain experts.

Simon André Forsberg

@hpaulj Welcome to The 2nd Monitor. It's a rare thing to see a Stack Overflow user not want questions moved to Code Review. We see a whole lot of "this questions belongs at Code Review" for these kinds of questions, why would numpy be an exception?

RubberDuck

Not sure if @200_success is around, but he may be interested in this conversation as well.

Also, looking at the question, it looks like some random user suggested CR and 200 simply agreed that it would be on topic here.

That doesn't mean it's off topic on SO, or that anyone is trying to poach questions @hpaulj.

Captain Obvious

0

Q: Tic Tac Toe in JavaScript

I'm a beginner and just finished my first Tic Tac Toe program. I was looking to get some feedback on some of the portions that seem a bit repetitive. Is there a way to make this more dry vs. hard coding? Also, I had a friend help me with the winner stack portion and I seem to understand that it ...

javascript tic-tac-toe

Duga

5:52 PM

It's not up to us to create the organization, but up to you! Come up with an idea of how you want to organize it, show us, and ask for more "philosophical" organizational questions. Otherwise, go to Code Review. — Cinch 1 min ago

RubberDuck

In fact, we regularly remind people that being on topic on a different site, doesn't mean it's off topic there.

Simon André Forsberg

@CaptainObvious @A.J. See what @CaptainObvious posted ^^

A.J.

oh oops :o

Simon André Forsberg

@A.J. I am not sure if it will be closed or not. It is a bit of a problematic question as I have said. We will see what happens.

A.J.

Yeah, k guys I gtg my plane departs in 10 minutes

Hosch250

5:56 PM

See you.

Simon André Forsberg

@A.J. Safe journey!

RubberDuck

> but I don't seem to understand how allThree() is actually validating correctly. The (player) argument on each of the functions has really got me thrown for a loop as these are not tied to anything in the above code. I understand that it works and what it accomplishes. I just don't understand how it is verifying without being tied to a variable.

Questions seeking explanations of some one else's code is off topic.

Simon André Forsberg

@RubberDuck I know... what's the best course of action here, edit or VTC?

RubberDuck

I VTC'd. He doesn't want a review. He wants an explination.

Simon André Forsberg

The user arrived from SO, closing it on two sites is unlikely to give him a good user experience, should we care about that?

RubberDuck

6:00 PM

.... we should. Yes.

But that doesn't make it on topic.

Simon André Forsberg

@RubberDuck the first part of his question wants a review.

RubberDuck

If you feel you can salvage it, I would be happy to retract my close vote.

Duga

Maybe this needs to be moved to code review — NathanOliver 10 secs ago

200_success

@RubberDuck I figured that the interview question was off-topic for Stack Overflow since the efficiency questions were a bit of a non-sequitur for that particular piece of code. So, despite the technical questions at the end, what the OP really needs is a code review.

Simon André Forsberg

@RubberDuck parts of his code is not his own... complicated.

Hosch250

6:05 PM

Anyone else hear anything about the government trying to take over the email industry?

My family is telling me all sorts of things, but I can't find anything on the web.

Simon André Forsberg

@Hosch250 NSA? Yeah, I've heard about it.

Duga

@NathanOliver "I know I am off" indicates that the author knows that it's buggy. That makes it off-topic for Code Review. — 200_success 1 min ago

Hosch250

No, this is where they are going to take over private company's email services.

And they are going to charge us to have an account.

Captain Obvious

0

Q: Python style 'with' in C++

Spoiler: I have already posted this on StackOverflow. Only by recommendation in a comment I learned of this site. NOTE: I kept the original title from the SO question, albeit it may be a bit misleading. I do not intend to enable Python style C++ programming. Far from it - I'm a total Python newb...

c++

200_success

@Hosch250 I dunno, but the NSA could run the most effective spam filtering service ever, if they wanted to.

Hosch250

6:09 PM

I'd rather have the spam than have emails controlled by the government.

If they are, I'm going back to emailing paper letters.

Duga

6:22 PM

@hpaulj I'm suggesting that since the question meets the on-topic criteria for Code Review, cross-posting may be justified. However, the author specifically asks about how to use "in-place" methods, which makes it not off-topic for Stack Overflow, and thus not a candidate for migration. — 200_success 20 secs ago

As you don’t seem to have a problem, I guess this question would be a better fit for Code Review. — unor 17 secs ago

Mat's Mug

@Hosch250 "emailing paper letters" sounds like "blowing off a ~~candle~~ lightbulb"...

Duga

@hpaulj Code Review has over 200 NumPy questions, of which 90% have an answer. You might want to check it out. — 200_success 55 secs ago

Captain Obvious

0

Q: Compute weighted average around a point in a matrix quickly

I have a short snippet of code that simply computes a weighted average for surrounding elements in a square matrix. The actual implementation that I'm working on is not an average (more complex equation), but I am using this one to figure out how to handle various performance hinderances. A few ...

c++ performance c++11 matrix

0

Q: Simple LZW Compression Algorithm. Feedback on this C++ code?

I'm trying to be a better C++ programmer. It's a simple version of LZW compression algorithm with 12 bit codes. I want to know whats good and whats bad about this code, be as picky as you like. Also rate it out of ten if you like too. Thank you. // Compile with gcc 4.7.2 or later, using the fol...

c++ c++11

Jeroen Vannevel

6:42 PM

oauthforaspnet.com

^ Kinky

irisclasson.com/2015/03/30/…

This is quite possible the worst color scheme for code snippets ever

nhgrif

6:57 PM

@Hosch250 you don't email paper letters... And you can't go back to something you're too young to have ever done... Also, if not the government, who do you think puts the US in USPS???

Transcript for