if (x >= 0) {
return true;
}
return false;
if (x <= 0) {
return true;
}
return false;
if (matcher.find()) {
return true;
}
return false;
Are constructs I'd express as
return x >= 0;
and
return x <= 0;
and
return matcher.find...
In one of my recent projects I faced the problem of transforming an abstract class into another abstract class. The classes were structured like this and are part of an api for questionnaires:
abstract class AnswerConstraint { /* shared implementation for all entities */ }
class LengthConstrain...
I am using json parsing for my login page but i get full String same as printed in Json file and not able to get the exact value when user enter valid Username and Password.
It has been said in various comments that on Code Review we review code and not design.
I find this statement not very clear though. Obviously, if someone has an UML and not any written code, that's off-topic on Code Review.
However, if there is a question with a finished implementation, such a...
I was wondering if, as part of asking for a review here, can I ask about how useful my code is? That is, getting feedback about what possible use-cases the code I have written has and if people would use it if it were a library.
I would not intend on asking only about the usefulness but of cours...
Wells, for the nth time... Good IO library design
Copying my comment in verbatim, with extra emphasis:
Wells this is the really really grey area hmms? I took a quick glance at the GitHub project, quite interesting... Obviously the whole project will be too big to be reviewed here (and beside...
The first thing you can do is to store the intermediate objects in variables,
in order to get rid of the repeated and deeply nested objectForKey: chains
like
NSArray *keys4 = [[[[plistDictionary objectForKey:key] objectForKey:key2] objectForKey:key3] allKeys];
Then it would look like this:
NS...
I am working on my first HTML5/CSS web site and, like all of my first-time projects, they end up cumbersome, crude, and hard to work with when changes need to be made later in the life cycle. I am attaching some code with a small amount of HTML and CSS. I have read up on CSS and HTML and, after q...
Good afternoon, I started to code on Android, but I think my code is very heavy and may slow down the performance of my app.
For example, when I run my app and I try to drag the page in one of my webviews, it's pretty laggy.
Here is the code (without the imports ^^) :
package com...
I have two classes, Node2D and Node3D:
class Node3D(object):
@property
def coords(self):
return self.__dict__
@coords.setter
def coords(self,Coords):
self.set_coords(**Coords)
@Validator(ValidateKeys, 'x','y','z')
def set_coords(self,**Coords):
pa...
I code Haskell as a hobbyist. I'm interested in feedback on my naive implementation of Conway's Game of Life. Specifically, as stated in the Quick Tour of the website, I am interested in:
Best practices and design pattern usage
Correctness in unanticipated cases
Admitting the naivete of the i...
I'm wondering if my design is flawed or if I'm thinking this incorrectly:
I have a class Lexer that has a number of methods. All methods are regex processing methods that take a string as an argument (sometimes the same string), and all return a list of matches (list could be empty)
I need the ...
This is a simple Trie data structure for strings, except it puts the strings into the structure backwards.
The insert method simply iterates over chars from the string-to-be-inserted backwards, and starting at the root of the graph, looks for an edge that is labeled with the current char. If ...
while reading a data structure book, i have implemented chained hash table, i want to share the code with you and get you're opinion about it :
chained_hash_table.h
#ifndef CHAINED_HASH_TABLE_H_INCLUDED
#define CHAINED_HASH_TABLE_H_INCLUDED
#include <stdlib.h>
#include "../linked_list/linked_l...
In a previous question I posted a method for easy std::bitset IO on a bit-for-bit basis. This question was later followed up in another solution. Both of these solutions had limitations; the interface of my original solution was not pretty, and the second method was limited to 64 bit std::bitsets...
I've started learning Mithril framework, it looks pretty awesome;
I've created a basic blog app and have a few questions about code style and structure...
please, review this code:
var app = {};
app.PostList = function(list) {
return m.prop(list || []);
};
app.vm = {};
app.Post = function(d...
public static void main(String[] args)
{
textbox();
}
public static void textbox()
{
String c;
int width,height;
char character;
Scanner sc = new Scanner(System.in);
System.out.println("Enter the text to center: ");
c=sc.nextLine();
System.out.println("Enter t...
I asked one question on code review yesterday about my code style, logic and readability of code. Hence, today I kept all those suggestions in mind while solving a new problem question.
The question is such: Given an array S of n integers, find three integers in S such that the sum is closest to...
Following up on Integrating Unit Testing functionality into an old COM-based IDE, I made quite a few changes to the UI, and now the code-behind for my TestExplorerWindow is starting to feel somewhat bloated, at least compared to what it was... I blame the added toolbar and the fancypants progress...
I want my entire node application to use one single mongodb connection, at least that's what I think is better. I wrote this little script and want some feedback on it. Especially if what I'm doing makes sense.
This is my mongodb.js file
'use strict';
// Mongodb module.
var MongoClient = r...
