The 2nd Monitor

Vogel612

2:00 PM

@Morwenn flag for migration...

Morwenn

:o

Utkarsh

4

Q: Fare Chart in HTML

I am a beginner and I have made a Fare Chart in HTML. I'm pretty sure it will look horrible to any developer out there, but hey, that's why I've posted it. I'd like a general review of this. I'm especially concerned about the quality and enhancements of this form. What should I do to add attract...

html

Vogel612

@Morwenn community mods can migrate questions to other sites.. AFAIR the migration with fixed flaggable paths is only available for graduated sites, though. This means you probably need to flag for community mod attention and specify Migration to SO on request by OP as reason.

Morwenn

Well that's what I just did. But I think that the "does not contain working code" actually implies a migration to SO whatsoever.

BenVlodgi

@Malachi its fine to chose another answer. His was the most upvoted. I was addressing you entire program. If you want to learn from your mistakes though, and not listen to advice from others then you don't have to post code here. there is nothing wrong with posting bad code, or learning from your mistakes. but ignoring advice because you want to learn it the hard way seems counter-intuitive.

@Malachi I'm glad you're looking into enums, because I have been harping on you to use them from the get-go

syb0rg

2:13 PM

So many people in chat :)

Jesus Christ

yep

Morwenn

nope

BenVlodgi

@Malachi I get the feeling you havent actually ran any of the code that I've posted. if you were to actually copy-pasta it, you can see how simple and effective it is

Vogel612

@syb0rg hum. 22. but about 10 actively writing..

BenVlodgi

@Vogel612 YOU'RE actively writing

Simon André Forsberg

2:15 PM

@skiwi Which is why I say again (sorry, but really...) that I'm not so sure you need all those generics

Vogel612

@Morwenn of course it implies a migration, but the story is, that the question style is a completely different..

Marc-Andre

@Vogel612 You didn't count how many of them are reading ! Even if they don't write ;)

Vogel612

@Marc-Andre You can try to do that..

Simon André Forsberg

@JesusChrist I didn't know you reviewed code. But perhaps you're looking for this?

2

Marc-Andre

Eheheh just trying to be funny! It's not because people are not writing that they are not participating ( IMHO)

Nobody

2:16 PM

yep, constantly on the watch

syb0rg

Ditto ^^

BenVlodgi

@Malachi in my next review, which would you rather have, Me review your entire code, or just point out one wrong thing.

This is in no way a slander against Mat'sMug, his review was good. but honestly... do you not want me to tell you the truth, which is use enums and OO design where appropriate. Which yes... is something you are learning by trial and error.. good! but I feel like you ignore most of what I say

syb0rg

Wow, my sockpuppet's question is popular!

24

Q: Chat bot for posting recent answers

I am the half-robot side of syb0rg that will be posting the recent answers of Code Review to the CR Answers chatroom. Here is the list of review suggestions I would like, in order of preference: Efficiency (with API requests, speed of login and posting answers, etc.) Security issues Best pract...

optimization ruby security stackexchange

Mat's Mug

0

A: 'Canonical' questions to help address common issues

This thought occurred to me as well, after writing this exception-centric answer, this SOLID tutorial and this comment-centric answer. I completely agree with @svick's comment: This sounds like a good idea to me. If we go forward with this, such questions should probably be marked as communi...

@syb0rg your sockpuppet is earning a [badge:good-question] (silver!)!

BenVlodgi

@Mat'sMug @Corbin I would be very much in favor of having a community wiki of those common problems/answers

Mat's Mug

2:27 PM

I think by doing that, CR is putting the "wiki" in "community wiki" - best usage of CW across SE, I find

BenVlodgi

;)

Nobody

How should this be handled? One question per "flaw"?

Morwenn

The job looks like writing a common denominator for style guides for some languages.

Simon André Forsberg

I'm just 2 rep ahead of ChrisW right now

@Nobody At least one answer per flaw. A quite long and detailed answer.

One question can contain multiple flaws, IMO - but not too many.

Nobody

I think one flaw per question makes linking easier

Mat's Mug

2:34 PM

I was thinking one answer per flaw

3

BenVlodgi

should we Post the questions as something like
Title: C# Exception throwing

review this code =>

throw new Exception();

Mat's Mug

(And link to answers)

Morwenn

out-of-ammo

BenVlodgi

then have a community wiki answer

Simon André Forsberg

@BenVlodgi That's very little code. We should provide some context for that. A real working small program where that line is used.

BenVlodgi

2:35 PM

@SimonAndréForsberg... indeed

Morwenn

@Mat'sMug I totally agree with this statement.

BenVlodgi

@SimonAndréForsberg I wasn't about to make a problem program though :D

Nobody

@SimonAndréForsberg: Couldn't that be too distracting from the real problem?

BenVlodgi

and in that case.. that is actually nearly all you need to know

or should we make an actual wiki for these answers?

Nobody

@Mat'sMug: One answer per flaw might have problems where there are several good answers and you want to link only one

BenVlodgi

2:36 PM

@Nobody then link to the question ;)

Nobody

the point is: you mean a specific answer

Morwenn

That said, there are already great CW on SO that can be linked to (e.g. the one about operators overloading in C++, except it's not a CW and sbi is earning tons of rep thanks to it).

Nobody

you can't refer to that

Marc-Andre

Wow someone post a bounty on one of my question on meta SO!

Morwenn

Haha, rep is a strange beast of meta.

Mat's Mug

2:40 PM

@Nobody for example, a wiki c# question would have naming issues, and bad comments. The question would be CW, therefore all answers would be auto-CW; one answer would address the naming (in a generic, wiki way), another would address the bad comments (also in a generic, wiki way); then the question could be edited to add bad exception handling, and an answer could be added to address bad exception handling (...in a generic, wiki way).

and then when you come across a post with bad comments, you can link to the generic wiki bad comments answer, and have a review that's more focused on the OP's other code issues, while still addressing the bad comments issue.

Utkarsh

whose mug is this?

i.stack.imgur.com/cLiNJ.jpg?s=128&g=1&g&s=32

;p

Mat's Mug

:)

Nobody

@Mat'sMug: I feel the issues should be handled seperately to reduce coupling but thats just my opinion (obviously)

Stack Exchange

0

Q: Optimizing ugly string parser

I wrote a cstring parser. It has to work with a relatively wide amount of arguments (usually 3 or 4, but maybe in future with a different amount), which are separated by an "," or ";". My wish is to make at least Function 1 less static and save some code. However, I don't really want to use dynam...

c++ c parsing cstring

Mat's Mug

@Nobody one issue per question would harm the answers per question metric, while one issue per answer would give it a boost!

Nobody

2:50 PM

@Mat'sMug: Noone prevents multiple answers from existing ^^

Malachi

@rolfl that one was the By The Way BTW (Normal.BTW)

Mat's Mug

multiple canonical answers? ...

Nobody

well thats not what I said but even that would be possible

there is not always just one right way

it depends on the circumstances

Mat's Mug

true

Simon André Forsberg

@Nobody If there is only a question with a one-liner, then the question quality would drop significantly.

Malachi

2:53 PM

@BenVlodgi sure attack me while I am not in the room.......lol.. but seriously I do read your code. it is just a little intimidating to me, as I am still learning, but I do read your answers through, and do take those things to heart. I think you are a good programmer from what I have seen, and so I don't dismiss any of what you say, I do realize the looping thing and the bracket thing is a difference in style. the rest is stuff that I haven't learned yet.......

@BenVlodgi so what you think is me bucking you, is more or less me trying to make sense of it all so that I understand what is going on with the code and idea behind it.

Nobody

@SimonAndréForsberg: I was not talking about one-liner questions

you can fill it with rich background

but it should not introduce other flaws

that would make it ambiguous

Malachi

anyway Work.BTW

BenVlodgi

@Malachi srry, its why I @ you, so you get it eventually :)
I know you're learning, and I do forget how some of these things can be intimidating... I've been coding for many many years and some things feel literally second nature. I'm glad you are learning, and I hope I can continue to help.

3

Stack Exchange

0

Q: Implement strtod parsing

In this comment the OP wrote, I am a newbie so i would like to know how would i parse the negetive numbers/arguments ? In this answer @200_success showed an implementation using the strtod function. The following is my implementation of the strtod function: A valid floating point numbe...

c++ c reinventing-the-wheel

skiwi

@SimonAndréForsberg Unless I can get this working, I will look into other ways to get it working without that much generics:

0

Q: Using generics restricts me to using a specific type while I want to use all possible subclasses of that type

I have the following code, which ended up this way due to other constraints: public interface Action { } public interface Result { } public interface Player<A extends Action, R extends Result, P extends Player<A, R, P>> { } public interface Game<A extends Action, R extends Result, P extends P...

java generics inheritance

Simon André Forsberg

3:04 PM

@skiwi What about this? public class RPSGame extends AbstractGame<RPSGesture, RPSResult, RPSPlayer<RPSPlayer>> { }

skiwi

@SimonAndréForsberg RPSPlayer (the inner one) cannot have a raw type

Simon André Forsberg

oh dear...

Vogel612

@Malachi would like to change that... make BTW the enumeration class, an thus have BTW.Normal and BTW.Work

feels more intuitive for me

skiwi

@SimonAndréForsberg Yep, go try to add infinite recursion there

That is why generics can get messed up

Simon André Forsberg

@skiwi What about including the details about who made the move within the Action / RPSGesture class?

skiwi

3:11 PM

Hmm

I can check that aswell

Also this code is so bad that even @BoristheSpider is lost

Vogel612

@skiwi who's that??

some celeb on SO?

Simon André Forsberg

public interface Action {
    Player getWho();
}
class RPSGesture {
    ...
    @Override
    RPSPlayer getWho() {  ... } // Covariant return types being used here!
}

skiwi

He answers generics quite a lot of time @Vogel612 In all honesty, not even close to @JonSkeet

So @SimonAndréForsberg, you are proposing to get rid of most covariance return types in the method signatures, but try to inroduce them in the return types?

2 more rep to max out SO today... Let's find some unaccepted answer in one of my questions

Vogel612

@skiwi maybe I should give him some work to do with my generic ConstraintViolation Processor, which (should) via reflection compares two fields...

gotta love Class<T extends Comparable>

Simon André Forsberg

@skiwi Huh? Get rid of covariant return types? No, I'm saying that you should use them.

skiwi

3:15 PM

The whole covariant method parameter types introduce generic problems

covariant return types solve problems

As I see it so far

Simon André Forsberg

Does my example code above help you?

skiwi

I'll try to get a better example @SimonAndréForsberg

I cannot fully test it now

Simon André Forsberg

OK

skiwi

Still at work

But have access to my code

Simon André Forsberg

same here

skiwi

3:17 PM

Yay for not having much responsibilities/deadlines

Malachi

@Vogel612 I approve this message

skiwi

I'm still trying to come up with an usecase

Malachi

BTW.Work

Morwenn

I can haz [badge:nice-question]?

9

Q: Expression template to compute the Euclidean distance

I was writing some geometry-related code again and had a closer look at my function supposed to compute the Euclidean distance between two points (N-dimensional points by the way, hence the N template parameter). Here is a simplified version: template<std::size_t N, typename T> auto distance(con...

c++ c++11 mathematics

Malachi

I just tried to ping someone in chat.stackexchange.com/rooms/13448/holy-mother-of-loops and I was the only one there

Nobody

3:25 PM

@Morwenn:

Malachi

@SimonAndréForsberg Jesus never worries about power outages, because Jesus Saves

Morwenn

@Nobody Or at least upvote the accepted answer, it's great :p

Aw, thank you :3

Malachi

@rolfl it's a toss up on this question yours answer is ahead of mine by my vote right now

skiwi

Do you mean with covariance return methods @SimonAndréForsberg that you do like return (SomeCast)this;?

Nobody

@Malachi: Your answer could explain a little more instead of just stating

Malachi

3:31 PM

not any more....lol whoever voted should read the comments. not sure if it is the version of SQL Server that I am using or the way that I am Querying the SQLite Database

Nobody

@Morwenn: Do you know how many edits it takes to make an answer community wiki? I believe your accepted answer is one edit short of it ^^

Simon André Forsberg

@skiwi I mean that you override a method and use a more specific return type than the original

skiwi

@SimonAndréForsberg Yeah I see

Morwenn

@Nobody Yes, I realized it. That guy updated his post like 5 times before I could even finish to read it.

skiwi

I did not want to the reverse of that for method parameters, but it seems like I need to do it

or well it is not the reverse, it is the same actually

For using it inside a method, coming from a generic interface, you also need to downcast them

Else you end up in generic recursion.

So instead of public void onPostAction(final RPSHumanPlayer target, final RPSGesture gesture, final RPSResult result) {, you get...

@Override
public void onPostAction(final Player<RPSGesture, RPSResult> superTarget, final RPSGesture gesture, final RPSResult result) {
    Objects.requireNonNull(superTarget);
    Objects.requireNonNull(gesture);
    Objects.requireNonNull(result);
    RPSHumanPlayer target = (RPSHumanPlayer)superTarget;
    if (this.equals(target)) {
        System.out.println("I played " + gesture + " and the result was a " + result);
    }
    //TODO decouple view
}

@SimonAndréForsberg Do you see what I mean now?

Malachi

3:39 PM

@Nobody I added some explanation to the answer

5

A: Another way to run reports on a SpiceWorks SQLite database using a linked server in SSMS?

I was able to remove the second query and merge it with the first one like this, I don't know why I didn't try it like this to begin with, probably because I wanted to tread lightly on this shaky bridge. I still don't have a solid way of passing variables to the OPENQUERY, but that is a questio...

Nobody

good :)

however, you had my vote anyway ^^

2

skiwi

@SimonAndréForsberg The only thing I think is ugly is the typecast, but I see no other way to get rid of it

syb0rg

@Mat'sMug How is your own chat bot coming along?

Simon André Forsberg

@skiwi I would use onPostAction(RPSAction action) where RPSAction has get methods for player, result and gesture.

Malachi

@Nobody there was plenty that I left out, even on the question. didn't take to long to type up though.

anyway BTW.Work

Mat's Mug

3:40 PM

@syb0rg all I have is working API calls... I need to look into a websockets bot implementation to see how I could login and post what I fetched from the API.

Simon André Forsberg

@skiwi If you go with RPSAction, your Player type can be Player<T> without the need for any more detailed generics than that

or well, possibly with Action also...

skiwi

@SimonAndréForsberg That would not be in line with how the program is structured at the moment... So canot really just change it

Malachi

@skiwi are you coding in Java?

Simon André Forsberg

Yes, I think typecasts are fine

@skiwi Then at least consider it for the future :)

Malachi

is it a version that I can get my hands on? I would like to play with your code when You have a working version.

later when I am at home though

skiwi

3:42 PM

@Malachi Yes

Soon...

I need to fix one problem in the Scanner, and decouple some of the 'view' functionality

Malachi

got my screens for my computer, actual computer won't be here for at least another two weeks. they ship it on the 25th

@skiwi wait, what are you coding? I thought it was a RPS game?

Vogel612

@Malachi i take you ordered on the same day??

Malachi

@Vogel612 yeah.

@Vogel612 I also ordered a laptop for the wife, and that won't get shipped until the 27th

Vogel612

well when I ordered my new PC everything was brought on the same day...

Malachi

but we also got some printer ink

Vogel612

3:44 PM

but the postman forgot the Screen and 2.1 Sound system at first...

Malachi

@Vogel612 I customized the PC a little bit.

skiwi

@Malachi It is an RPS game yes

Vogel612

me 2 ...

but they just sent it together..,.

was kinda funny, when I told the postman: "there should be another 2 items" and he had to come back 20 minutes later when he had found them...

skiwi

Please enter your gesture:
r
The AI played PAPER and the result was a WIN
I played ROCK and the result was a LOSS

Malachi

I think that my wife said I got the speakers too.. that will be cool for a while. when I am coding on my laptop I can hook them up and listen to my trap or glitch hop or Dubstep and annoy my wife and kids. my Son loves my music though

Mat's Mug

3:46 PM

@all What do you think?

0

Q: Common coding issues - C#

This question is intended to be used for linking to common issues, as discussed on meta. Feel free to modify this post, it's Community Wiki! When modifying this question, one should add a specific and common coding issue, and address it in a new, general-purpose answer that reviewers can ...

c# best-practice review-wiki

Vogel612

@skiwi why not one message?

Mat's Mug

(created review-wiki)

skiwi

@Vogel612 Because they are individual messages

Vogel612

@Mat'sMug why is that question not CW??

Malachi

@Mat'sMug shouldn't that be a Meta question?

skiwi

3:47 PM

Currently the AI knows about the result of both the player and the AI

And so does the player

In a later stage if there's ever a GUI it doesn't matter anyway

Mat's Mug

@Vogel612 interesting, I meant to make it CW

Malachi

for about the third time now BTW.BTW.Work

Mat's Mug

@Malachi didn't occur to me that we'd want to have them on the meta site...

Vogel612

@Malachi forget it.. I tried too, but I can't..

Mat's Mug

I'll flag for "migration"

Nobody

3:48 PM

can we try to find other useless meanings for BTW?

3

Malachi

@Vogel612 I can't see if someone is sneaking up behind me anymore, new office space

Vogel612

Why? you wanna add more elements to teh enum?

Stack Exchange

0

Q: Common coding issues - C#

This question is intended to be used for linking to common issues, as discussed on meta. Feel free to modify this post, it's Community Wiki! When modifying this question, one should add a specific and common coding issue, and address it in a new, general-purpose answer that reviewers can ...

c# best-practice review-wiki

Vogel612

@Malachi haaha

@StackExchange slow.. waaay too slow

Nobody

@Vogel612: Are there only two elements? Then it is basically a boolean

Vogel612

3:50 PM

@Nobody well that's a bit harder to reflect word-wise

skiwi

The problem is that when I fail to enter a message in time, the program steals the console input, so I can never ever enter it in time again.

Nobody

yep

Vogel612

BTW vs !BTW

and noone knows which is which..

Nobody

BTW btw

Mat's Mug

by the woods

Vogel612

3:51 PM

also you could in fact have bool?..

@Mat'sMug thanks.

Mat's Mug

born to win

Nobody

@Mat'sMug: you mean "buy the woods"

Vogel612

this will make a nice answer to the meme-question

Nobody

BTW: browsing the web

well I got to go

see you

Mat's Mug

later!

it appears only a moderator can wikify a question..

wow my first off-topic question!

Vogel612

3:56 PM

0

A: What's a Zombie? And what are the many other memes of Code Review?

Meme: BTW Originator: [attributed to] Malachi, Mat's Mug and Others Cultural Height: The 2nd Monitor Background: The many ways of backronymizing btw led to the introduction of the BTW enum: public enum BTW{ Normal, Work, Woods, Win, Web } This list does not claim completen...

rolfl

@Vogel612 - backronym is cute, and that reminds me of 'retronym', also a cute word....

Retronym

A retronym is a type of neologism that provides a new name for something to differentiate the original from a more recent form or version. Advances in technology are often responsible for retronym coinage. For example, the term "acoustic guitar" was coined at the advent of electric guitars, Examples Sometimes retronyms serve to differentiate two similarly named people, as with U.S. President George Bush, who, after his son George W. Bush was elected president in 2000, was typically referred to as "George Bush, Sr.", "George H. W. Bush", "H. W.", or "Bush 41" (as he was the 41s...

Vogel612

@rolfl I really like that word now too..

skiwi

Yay I know what I am doing wrong, but TTQW now

Vogel612

Why the friggin hell did they have Exception Declaration in Java.. gotta hate throws....

Mat's Mug

Thinking again, the review-wiki post(s) do somewhat belong on the main site, if they're shaped as every other Q&A on the main site...

rolfl

4:17 PM

  PID       %CPU    Size     Res    Res     Res     Res    Shared    Faults  Command
             Used      KB     Set    Text    Data     Lib    KB     Min   Maj
    49278  3111.5 78474432 20011264      64 73571712       0 1542848      0      0 java

That is some multi-threaded Java for you ;-)

Only got another hour or so to go.

Vogel612

well I'll just grab a coffee and get the ClassLevelAnnotation CrossFieldConstraint Validator running... even though I have not the slightest clue.. in the next max. 1.5 hrs..

yee-ha <-- I should add sound to that...

rolfl

Just say ..... (Howard Dean)

Vogel612

??

Stack Exchange

0

Q: Scala DRY-ness problem with Immutable Domain Model

Let's consider the following simple domain model: case class TagTest (i:Int,nodes:mutable.Set[NodeTest]=mutable.Set[NodeTest]()){ def addNode(n:NodeTest)={nodes+=n;n.tags+=this} def removeNode(n:NodeTest)={nodes-=n;n.tags-=this} } case class NodeTest(i:Int,tags:mutable.Set[TagTest]=mutable...

scala type-safety immutable domain

skiwi

4:36 PM

Hey, back home

Darn, I can only ask 6 questions within 24 hours on SO -.- Great

rolfl

Rep Cap, Star Cap, Vote Cap, and now a Q cap?

I wonder..... is there an A cap?

skiwi

I don't know :o

I still do not understand why they cannot show upfront you cannot ask a question now... Would save me the burden of typign the whole question and then figuring it out.

@rolfl You happen to know anything about FutureTask?

rolfl

Yes.

skiwi

Mind if I ask you the question then?

rolfl

@skiwi That is a good question for MSO.

skiwi

4:51 PM

Thanks I'll post it there soonish

Marc-Andre

@rolfl I'm pretty sure it already been ask

skiwi

@Marc-Andre I can't find it via the (broken) search functionality there

Marc-Andre

Wait I'll try myself!

skiwi

to search?

Marc-Andre

Yep

skiwi

4:53 PM

@rolfl I have a doAction() method that eventually calls the scanner.next() (waiting until user input), and I have this:

default public A doActionWithTimeout(final Executor executor, final int period, final TimeUnit unit) {
    FutureTask<A> futureTask = new FutureTask<>(this::doAction);
    executor.execute(futureTask);
    try {
        return futureTask.get(period, unit);
    } catch (InterruptedException ex) {
        futureTask.cancel(true);
        Thread.currentThread().interrupt();
        return doActionBackup();
    } catch (ExecutionException ex) {
        throw new IllegalStateException(ex);
    } catch (TimeoutException ex) {

Does it make sense? I want to kill the doAction() after 10 seconds... Haven't used FutureTask ever before.

rolfl

75

A: The Complete Rate-Limiting Guide

Rate Limit Rationale Comments Voting 5 seconds 5 comment flags/day 30 comment upvotes/day no limit for ♦ mods timer resets Deleting (treated like voting) 5 seconds no limit for ♦ mods timer resets Creating 15 seconds 5 seconds for ♦ mods timer resets Editing 5 seconds; comme...

Malachi

11 more upvotes on my SQL Answers and I will have an SQL Badge!

Marc-Andre

49

Q: Please warn about exceeding 50 question limit prior to asking a new question

It's a shame to type out an entire question, press post and then: Sorry, you are only allowed to ask 50 questions in a 30 day period Could you put some sort of notice on the page itself before submitting it to let you know the question won't be going through? Or perhaps tell me how many qu...

feature-request asking-questions

skiwi

Thanks for finding @Marc-Andre

Saved me a duplicate post

Marc-Andre

No problem I was sure to have read something like that!

Jamal

4:57 PM

So, I have decided to keep this here as it doesn't seem to be fitting for Meta, but have instead made it CW:

1

Q: Common coding issues - C#

This question is intended to be used for linking to common issues, as discussed on meta. Feel free to modify this post, it's Community Wiki! When modifying this question, one should add a specific and common coding issue, and address it in a new, general-purpose answer that reviewers can ...

c# best-practice review-wiki

Mat's Mug

@Jamal saw that - I agree. I have also put in an excerpt for the new tag:

> Questions under this tag regroup common code issues that are often encountered in code that is posted for review. Use this tag for Community Wiki questions that aim at providing general-purpose, one-size-fits-all answers to these common issues, so that reviewers can link to them when reviewing real code.

Jamal

Also, it helps avoid the mistake made on the Meta question about Python: if we keep it here, we get syntax-highlighting. However, I'm not quite sure what to do with that one on Meta. I might just have to migrate it here.

rolfl

@skiwi - that code looks OK, but I worry that you are only considering half the problem.

FutureTask.cancel does not necessarily cancel the FutureTask.

Mat's Mug

@Jamal the only thing that really bothered me was that I sort of had to put a tag in the title...

Jamal

@Mat'sMug That's not a huge deal. For these, it'll help more with separating them by language.

Marc-Andre

5:03 PM

@Mat'sMug Well why not come up with a real title about what the code does and add an header explaning what is the goal of the question (well the header is alredy there ...)

skiwi

@rolfl What I in reality want it simply have something for which I can say, after 10 seconds you have no right to execute anymore, and then the method should stop executing (with an exception or anything), it seems quite hard to implement such basic thing.

rolfl

Yes, it is hard to implement that.

What you have a is a good way to start a task, and to trigger a timeout.

That's not the problem.

The problem is that the task, if it is already running, is hard to kill.

Mat's Mug

@Marc-Andre thought about that, but at the same time I wanted a title that also says what the post is for (...thinking again, the review-wiki tag does that)

rolfl

calling cancel() is a 'suggestion'

The running task has to check to see whether it has been cancelled and respond if it was.

Setting the FutureTask to call Thread.interrupt() when cancel is called means that you have to be even more careful.

Marc-Andre

@Mat'sMug Well the question is still under the same rules of quality as any other questions. It should lead by example, not be an exception because of his status.

2

rolfl

5:06 PM

interrupted threads do not get interrupted.....

Mat's Mug

@Marc-Andre that's true

rolfl

They have a flag set on them, and certain operations check that flag.... and, only if you do one of those operations will you actually trigger the interrupt.

skiwi

I'm sorry @rolfl but I need to have dinner now... I'm also wondering how I can kill a scanner.next()... (Over the other issues you mention)

rolfl

You possibly can't

Stack Exchange

0

Q: CLIPS and Java... "communication" problems

I'm doing a CLIPS expert system, with which you interact via the GUI in Java. I have create this project, you found here: https://github.com/gioce90/SCUBA_Diving_ExpertSystem My expert system involves planning scuba diving (I'm creating for academic purposes, I love SCUBA, and so...). While cr...

java

skiwi

5:08 PM

Then I have an issue.

Mat's Mug

@skiwi what if I ran an async task that executed a SELECT statement on a database, that ran for 12 whole seconds? I'd just kill the SQL client? (and actually review the schema and rework indexes and something's fishy with that SELECT, but still)

It's simpler to let it run in the background and return whenever it does - the task can cancel itself when it can

or I'm making stuff up?

rolfl

That's close enough.

Simon André Forsberg

@Mat'sMug Are you reaching for 2x Taxonomist?

Mat's Mug

heck, why not?

rolfl

What, on the butt tag?

Malachi

5:20 PM

@rolfl I am trying to impress you as a programmer!

2

0

A: Return the top 5 of each kind of record

On your final and completed code, there is no reason to create a variable for a number that doesn't change. So this: WHERE [DistinctTop].[RowRank] <= @TopCount Should become this: WHERE [DistinctTop].[RowRank] <= 5 The less variables and things that are created on the database the better, ...

Mat's Mug

@Malachi my eyes exploded when I saw the last part at the bottom!

3

rolfl

Yeah, BOLD is a turn off...

It's also a comment, not an answer

BenVlodgi

@Malachi you like if-else chains?

if (depth == 0)
    if (wasDeep)
    {
        nBody.Add(new VBlock(nextBlock.ToArray()));
        nextBlock = null;
    }
    else if (Utils.GetNodeType(line).GetType() == typeof(VProperty))
        nBody.Add(new VProperty(line));
    else
    {
        nextBlock = new List<string>();
        nextBlock.Add(line);
    }
else
    if (nextBlock == null)
        throw new MalformedVMFException();
    else
        nextBlock.Add(line);

rolfl

@Malachi GOT MY +1 BUT RECOMMEND LOSING THE CAPS, AND PROVIDING A REFERENCE TO CTE

2

BenVlodgi

I always forget to else-if

I missed one

looks less intimidating as else-if =\

Malachi

5:32 PM

@rolfl @Mat'sMug Fixed the Caps should I remove the comment altogether?

@BenVlodgi is this an answer somewhere?

BenVlodgi

@Malachi naw, just code I'm writing...don't worry, will be posted for review

2

Malachi

@BenVlodgi I double like code to review. makes me wish I was single again....

BenVlodgi

@Malachi althought I'm putting in extra brackets because I know people are going to point that out, and I don't want to hear it

become single... then CR all day

and cry at night

2

Malachi

@BenVlodgi what is the V stuff all about?

BenVlodgi

I'm parsing a VMF into a tree structure

Malachi

5:35 PM

@BenVlodgi I don't think you can write the outside if statement without using brackets.

BenVlodgi

so its just an indicator

you can... if it is just one line

Malachi

@BenVlodgi I thought at first it was VB code then I saw SemiColons

BenVlodgi

I'm not about that life

I just have to get this thing working before I can post it for review =\

Malachi

@BenVlodgi you have multiple if statements nested inside that if statement, I think you have to have brackets surrounding the nested statements that you want considered part of outside if statement

@BenVlodgi I love my Family, wouldn't give them up for anything

BenVlodgi

@Malachi oh its THAT kind of not single

Malachi

5:38 PM

BTW.normal I am going BTW.work

BenVlodgi

maybe it should be btw is lowercase

Malachi

@BenVlodgi yeah, you could be me in about 7 years

BenVlodgi

but Back To Work uppercase

@Malachi scary thoughts man

rolfl

@skiwi - have a laugh at my expense.... I have this fancy code I wrote this morning: pastebin.ca/2668202 But, it ran for 2 hours, processed an input file with 125million lines of data. and output all the data, except for the last 3 or so lines.

Malachi

@BenVlodgi it's the same Enumeration, right?

BenVlodgi

5:40 PM

@Malachi you dont need the nested brackets... it works, well the code I posted works is what I mean

not sure what you mean with with enumeration :P

rolfl

Did it in 32 threads, concurrently, great..... but, if you don't shut down a thread pool, it never stops.... and if you don't subit the last chunk of data, it never ends... and you don't get to see the last of your data, and the open file never flushes to disk, and you can't get it out.

BenVlodgi

@rolfl wow... pastebin is blocked at my work... but not pastebin.ca

win

Malachi

@BenVlodgi you are right, if there was another piece of code inside the if statement, then you would have to use brackets, but the nested if statement is one piece so as long as the scope isn't broken it will follow that one until it is finished, and then exit the outside if statement

BenVlodgi

@Malachi exactly ;)

Malachi

@BenVlodgi BTW Enumeration right now it holds Work and Normal until we find more things that match the acronym

anyway BTW.Work

BenVlodgi

5:44 PM

ohhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

hah

@Mat'sMug does the main question HAVE to be a question?.... couldn't it instead be a table of contents of the answers or something.
I realize this makes that whole thread completely off-topic.. but it make it more of a wiki

Mat's Mug

@BenVlodgi that's the meta-discussion @svick is referring to ;)

@Matt's Mug I think this discussion belongs in meta, so I deleted my comment before I noticed your response. I'm going to explain my opinion there. — svick 33 mins ago

(in response to)

@svick I wanted to make this post a somewhat examplary question (granted, title is bad from that point of view), keeping it on-topic for the main site. Having the "reviewed" code in the question gives a bit of context to the answers. — Mat's Mug 39 mins ago

BenVlodgi

I guess that makes sense if the answers need any context. but there are some general rules that dont really require that

skiwi

I'm back, time to read up

@Mat'sMug If I tell you that you have 10 seconds (possibly 9 for safety reasons) to execute your AI code in... And you go over that time limit, then you have a problem if you were doing something critical in that time, that's how I see it.

Transcript for