« first day (3496 days earlier)      last day (513 days later) » 

12:07 AM
0
Q: DI structure in multi-module app

JustSightseeingI've been learning about multi-module apps, for a while I've been using the "one module per layer" approach (was a bit forced due to the work reasons), but I started creating apps with modules per feature, which seems just way better, but I'm not sure whether I did the best job about the hilt DI ...

 
REFRESH! There are 7624 unanswered questions (90.0106 answered)
 
@Duga it appears user reversed code changes, though it doesn't appear to have invalidated the one answer
 
possible answer invalidation by Sᴀᴍ Onᴇᴌᴀ on question by Nicolas Menettrier: codereview.stackexchange.com/posts/281499/revisions
 
@Duga code fence
 
possible answer invalidation by Sᴀᴍ Onᴇᴌᴀ on question by Nicolas Menettrier: codereview.stackexchange.com/posts/281499/revisions
 
12:32 AM
0
Q: Replacing banned words from a given text

TomaszOleszkoThe following algorithm is used to find a word from Blacklisted words in a string (called text) and replace these words with censored text, as shown in the example. Example: Blacklist ["bomb"] text: "bomb bombs" Output: "b*** bombs" Code public List<string> Blacklist { get; set; } = new List<st...

 
1:04 AM
This code deserves "code review with extreme prejudice ...". — Stephen C 39 secs ago
 
1:45 AM
Please include relevant code in the question itself, rather than providing a link. If your code is working and you would like tips on improving it, consider asking on Code Review. If you go that route, make sure to first read their posting guidelines. Otherwise, your question might get closed there as well. — John Coleman 15 secs ago
 
 
2 hours later…
3:26 AM
0
Q: Is there a way to shorten this roman to int program?(python)

Woeful ForestI'm writing a roman numeral to integer program and was testing some preexisting code with a few modifications I made. list1={'I':1,'IV':4,'V':5,'IX':9,'X':10,'XL':40,'L':50,'XC':90,'C':100,'CD':400,'D':500,'CM':900,'M':1000} def romanint(str): result=0 count=0 while (count < len(str))...

 
4:08 AM
If you want review of working code, see our sister site Code Review. — Charles Duffy 41 secs ago
 
0
Q: Having a separate validation util for common checks

srkI am working on a project where I see the following methods wrapped in a Util class public static Boolean isEmpty(Collection<?> collection) { return (collection == null || collection.isEmpty()); } public static Boolean isNotEmpty(Collection<?> collection) { return !isEmpty(collection); } U...

 
4:53 AM
I’m voting to close this question because 'Code reviews' should be posted on codereview.stackexchange.com after reading their help and faq pages. Stack Overflow is for code that doesn't work. — steven7mwesigwa 6 secs ago
I’m voting to close this question because 'Code reviews' should be posted on codereview.stackexchange.com after reading their help and faq pages. Stack Overflow is for code that doesn't work. — steven7mwesigwa 32 secs ago
 
5:05 AM
Monking
 
@steven7mwesigwa As it currently stands, the question would be closed on Code Review for lack of context. Experience tells us people won't read the help, so please do not make such recommendations. — Mast 55 secs ago
 
5:43 AM
Monking
 
 
1 hour later…
7:32 AM
As tripleee says, these lines are nonsense, because they would hang indefinitely due to lacking input to sed. But even if there would be a stdin for the sed command, the code is highly questionable (because of the backticks) and I would be more than surprised if there would be a reasonable use for this. I don't think these two lines would survive any serious code review. — user1934428 35 secs ago
 
7:53 AM
@flyingfox It wasn't me that downvoted, but I suppose questions about improving working code belong on SE Code Review and not SO. At least, that would be my best guess for the downvote — icecub 51 secs ago
possible answer invalidation by M472 on question by su sahin: codereview.stackexchange.com/posts/281547/revisions
Before you post at Code Review, make sure to read A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. question titles should simply say what the code does, as the question is always, "How can I improve this?". Be sure that the code works correctly; include your unit tests if possible. You'll likely get some suggestions on making it more efficient, easier to read, and better tested. — Toby Speight 34 secs ago
possible answer invalidation by M472 on question by su sahin: codereview.stackexchange.com/posts/281547/revisions
 
8:31 AM
@Duga That's okay - just moved the code from one style of block to another.
 
 
1 hour later…
9:40 AM
May I know if using new Promise would cause a problem called anit-pattern? coz I have tried to use new promise constructor to fix this problem. But some code reviewer said it is anti-pattern code, and shouldn't write it. But only writing .then really couldnt achieve what I want — Ae Leung just now
 
0
Q: Drawing d3 Plots and Synchronizing Inputs

Felix B.1. Price Inputs I am trying to build an interactive Microeconomics 101 lesson. For this, I want to plot demand and supply graphs for two goods. These depend on prices. I thought of three ways to input a price Text Input fields (for price 1 and price 2). Advantage: unlimited range A 2d-space to p...

 
9:53 AM
Your code is working as expected. This means you have posted the question in the wrong forum. You should instead post this question on Code Review codereview.stackexchange.comfreeflow 1 min ago
I’m voting to close this question because It should be a Code Review question — freeflow 33 secs ago
 
10:09 AM
So I can delete this question here and ask it on code review? — VBAbyMBA 51 secs ago
 
10:57 AM
-1
Q: find words with specific pattern and replace with its equivalent from a table list

VBAbyMBAI need to find words with the following pattern in one go: started to [infinitive verb] began to [infinitive verb] started [progressive verb] began [progressive verb] For example: started to arise began to arise started arising began arising Right now I am using two step method. find the fir...

 
11:22 AM
0
Q: Statically allocated buffer using templates

hellothereI want to have some classes that would contain arrays of different sizes. I want this to be statically allocated because it is intended for an embedded system. The only good solution I can think of is using templates. However, I want to use the same class type to access those objects. This is my ...

 
11:48 AM
Using your own server to host the common repo? It's nit like a bullet proof thing.... you will have to deal with issues like "how do we do code reviews?" but at least you are no longer tied to limits from a provider. — eftshift0 just now
 
12:12 PM
0
Q: Raytracing in Julia

M472This is my first project in julia. It is a raytracer based on spheres. using Random: rand, seed!, randn using LinearAlgebra: norm, normalize, ×, ⋅ using Statistics: mean using ImageCore: RGB, ⊙, clamp01 using FileIO: save ±(a, b) = @. a + [-1, +1] * b Black = RGB{Float32}(0.0, 0.0, 0.0) White =...

 
12:37 PM
0
Q: Json file send batches to Hubspot api

vijaylakI tried many ways and tested many scenarios I did R&D a lot but unable to found issue/solution I have a requirement, The HubSpot API accepts only 15k rec every time so we have large json file so we need to split/divide like batches wise 15k rec need to send api once 15k added in api it sleeps 10 ...

 
1:02 PM
0
Q: Return a random integer with a probability progression

EdeniaA function random_int_with_probability that returns a random number within a range, where the chance to get a bigger value decreases linearly towards the maxima. In the example below, the chance decreases by 10%, meaning to you will have guaranteed 100% chance to at least get 1, then have 90% to ...

 
 
1 hour later…
2:03 PM
@Mast Any chance you can review this, I don't know VHDL. I had the author change from their own language to English.
 
2:30 PM
I’m voting to close this question because it belongs on Code Review, not Stack Overflow. Asking for improvements to already-working code is off-topic here. — MattDMo 46 secs ago
 
 
1 hour later…
3:32 PM
0
Q: Python context manager for importing modules outside my local directory?

MYKI implemented this context manager for importing modules from arbitrary directories. Good? Bad? - Keen to get thoguts: Implementation import sys class CustomPath: def __init__(self, path:str): self.original_path = sys.path self.custom_path = path def __enter__...

 
3:52 PM
Since the code works, this is a question for Code Review, but not for StackOverflow — Rabbid76 44 secs ago
I’m voting to close this question because it belongs on Code Review. — MattDMo 15 secs ago
 
4:08 PM
> I think it works well, but I'm not sure since I'm new to the VHDL world. Could someone please help me? Is my code correct?
I tried to simulate with modelsim, ma for all the output signals the value is X or U, underlined in red — Lucy Nov 21 at 18:42
The requirements do not specify the kind of reset, it's your choice. You asked why you have undefined signals, and I explained why, and how to solve it. See my edit, too. — the busybee Nov 21 at 21:26
It's a low-effort reposter. I'm not a fan.
FPGA software like Quartus and ModelSim is always a pain to configure for first run.
 
@MattDMo, the question needs work before it's suited to Code Review. You should have pointed the asker at A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. we need a good description of the purpose of the code to give context, and question titles should simply say what the code does (the question is always, "How can I improve this?"). It's important that the code works correctly; include the unit tests if possible. — Toby Speight 6 secs ago
 
I could make a minor nitpick about initializing the signals properly and some formatting should it stay open, but I don't have time for that before the weekend.
I'd really want to run the code.
 
0
Q: Project naming convention strategy

Dan BeaulieuI would like a review of a project structure that I have been using in recent solutions. It's been working for me but I am about to employ this naming system on another project and am getting a bit of resistance, which is making me rethink my naming strategy. My system has been to name my project...

 
4:31 PM
possible answer invalidation by seriously on question by seriously: codereview.stackexchange.com/posts/281474/revisions
 
@Duga Code fence
 
possible answer invalidation by seriously on question by seriously: codereview.stackexchange.com/posts/281474/revisions
 
5:13 PM
0
Q: Note book program

RoMMkWhat my code do is pretty simple: it's a basic note book. You can take a note. You can delete a note. You can see all your notes. You can change a note. You can also see a see a specific note; for this you will need its name. You can restart everything you did until now, When you take a note you ...

 
Monking
 
5:25 PM
Monking
@Duga its okay - code fence was previously showing with code; link reference added after closing code fence
 
5:37 PM
@CaptainObvious Better than their last attempt.
 
0
Q: RAII POSIX process created by fork

jezzaBy analogy with std::thread, I feel the urge to write something like the following: class posix_process { public: explicit posix_process(std::function<void()> proc_main) : _pid(fork()) { if (_pid == -1) throw std::system_error(errno, std::generic_category(), "fork"...

0
Q: Implementation of Task Manager

HarryI have implemented some basic functionalities of task manager wherein whenever a new process is created it will be added to list of processes. Also if any process creates thread(s) it will get added to the thread list which is per process. ProcessManager.h #ifndef DLP_PROCESS_MANAGER_H #define DL...

 
5:55 PM
@Mast Okay, they did make the effort to translate into English.
 
6:19 PM
@pacmaninbw Yes, I'm considering what's wisdom here.
 
-1
Q: how can i optimize my code so that it can run much more effciently?

ImBadAtMathbasiclly i am making a small game where at the current stage i click somewhere and color will spread out like a wave. currently it does that, but i am bad at life, so my system is that it checks each and every squares up down left and right square to see if its red. if it is, make that square red...

 
 
1 hour later…
7:31 PM
@Mast I get that.
 
8:10 PM
If you're after general review, rather than a specific question, it might be worth checking out codereview.stackexchange.comflanker 47 secs ago
 
8:22 PM
Is anyone here interested in the design of programming languages?
A couple of users mainly active on SO and CG&CC is trying to get an Area 51 proposal of the ground, but they don't have momentum yet.
108
Programming Language Design

Proposed Q&A site for designers and implementers of computer programming languages

Currently in definition.

 
If your code works and you'd like suggestions on improvements, post it on the Code Review SEWoodford 31 secs ago
@Woodford Not really. What is requested here, is additional features. That's out of scope for Code Review. Once the features are implemented we can take a look at them, but we don't add features to existing code. — Mast 37 secs ago
 
9:29 PM
I’m voting to close this question because it is asking to improve working code. ask on Code ReviewDaniel A. White 11 secs ago
 
 
1 hour later…
10:32 PM
If by "optimalize" you mean make the code cleaner, you might want to post this on Code Review. But you'll need to include more context and better explain what you're doing. — shmosel 45 secs ago
 

« first day (3496 days earlier)      last day (513 days later) »