« first day (394 days earlier)      last day (3615 days later) » 

8:01 PM
I think it's a off-by-one error..., maybe someone spots it?
private int computeMaxSum(final int[] array) {
    int[] maximumSum = {Integer.MIN_VALUE};
    internalComputeMaxSum(array, 0, array.length, maximumSum);
    return maximumSum[0];
}

private int internalComputeMaxSum(final int[] array, final int i, final int j, final int[] maximumSum) {
    System.out.println("i = " + i + " / j = " + j + " / maximumSum = " + maximumSum[0]);
    if (j == i) {
        return returnReturn(0, maximumSum);
    }
    if (j - i == 1) {
        return returnReturn(array[i], maximumSum);
 
@DaggNabbit I personally voted to re-open because I didn't agree (or see indications of) that it was broken code / asking for code to be written.
 
@DaggNabbit Not a single-reopen, no. Community did it.
 
Does the code posted there even make sense?
 
Hmm, it was a "how do I do X" question
i asked here if it was OT and Jamal thought so, so it was closed
 
Dagg
If you press the edited link.
can you see that?
 
8:04 PM
ah, sneaky
 
Damn, you ain't no new user ... ;-)
 
lol yeah i just missed the edit
 
Hit the reopen queue.
 
oh, it shows us who reopened it now, cool
i think that didn't used to show up
 
Off-topic on Code Review is complicated.
 
8:06 PM
i'm sure the initial revision was OT
 
If the user has crap code, and they want it repaired, or new functionality implemented
 
i suppose the next revision was ok
 
they can ask, but that does not mean it will happen. If the code they have works, then the working code can be reviewed without having to implement the requested features, etc.
 
but you can have working code that doesn't do what you want it to do yet
 
It is fuzzy..... the answer on that question is a decent answer given the bad question.
 
8:07 PM
and ask how to get it to do that
 
@Vogel612 your welcome, was after all good code, tyhat's why nobody answered it already I guess
 
that seems like not a code review
 
I know....
I am not expressing myself very well.....
 
lol me either
 
You can review the parts that are shown, and then, out of the goodness of your heart, help the person on their way
Code Review has this one factor on the on-topic page:
> Do I want feedback about any or all facets of the code?
 
8:09 PM
Evening all
 
This can be used to make things odd.
Hi Stuart.
 
I'm personally not a fan of that clause
i often only want feedback on one very specific aspect
 
In essence, a reviewer is free to ignore any special requests.....
That's the reason for that clause.... because, often you have other/bigger problems that need to be addressed first.
 
yeah but in my case what seems to happen is...
 
Now I broke something in more ways than one
Find Maximum Sub-array Problem => [13] (hot Infinityms - cold 36,153ms (total 41,947ms))
 
8:11 PM
i want a review of high-level design....
and i get a review of bike-sheddy little piddly stuff
 
@skiwi Ouch!
 
Or maybe I forgot to fix the number of iterations
 
0
Q: "Scripting.FileSystemObject" Replacement module in VBA

ptwalesI have found Scripting.FilesystemObject to be slow and unstable. Calling file_object.Name repeatedly has caused my code to crash excel on multiple instances. Therefore I made a module where all of my file System helper functions reside. I called it os after python's os module as I tried to emu...

0
Q: Security: Allowing Users to Input HTML

MeredithI am currently working on a project that requires users to input text that may or may not be formatted (if it helps, just think of it as a Stack Exchange clone, even though that's not quite accurate). Instead of opting for some sort of BB Code or other markup language to allow users to format the...

 
@DaggNabbit What I saw was that the existing code was working, as I understood it he wanted to do it better. Now, he apparently didn't know how to do it better, even though he knew what kind of better he was looking for. For me I compared it a bit like making a field private in Java. In Java, it's just a keyword. In JavaScript, it's apparently not that simple.
 
@DaggNabbit If you want design advice, it can be given as a side0effect of a review, but it is primarily on-topic on Programmers.
 
8:13 PM
@DaggNabbit Littler stuff is easier to review. Design review is much harder and (arguably) open to more controversy--it's often much more difficult to justify why you'd do things one way instead of another, except with a kind of lame-sounding "because that's worked well for me".
 
@DaggNabbit Which is the reason for one of my recent meta-questions.
14
Q: Can we ask reviewers to *not* focus on something?

Simon André ForsbergOur Help Center says: Do I want feedback about any or all facets of the code? However, sometimes we might have some code that we are aware has flaws in it, or we would just for one reason or another want reviewers to not comment about something. When asking a question on Code Review, can w...

@rolfl Does Programmers really do design-code-reviews though? As in, you take a bunch of working code (that would be on-topic on Code Review), you post it on Programmers, and ask for a design review on it?
 
No.
But, you can go there and say, I want to do X, this is my design, what's wrong with it.?
 
That's what I thought. Which is why the grey line is becoming even more grey.
 
In essense, while code review insists on code, programmers despises it.
 
@SimonAndréForsberg You could try it, but I think chances of getting (useful) answers would be...minimal at best, and chances of its getting closed fairly substantial.
 
8:16 PM
And how would I show them "this is my design"?
@JerryCoffin Everything has a fairly substantial chance of getting closed on Programmers.
 
@SimonAndréForsberg Unfortunately, true. In this case, the chances would go from 2 out of 3 up to probably closer to 9 out of 10.
 
TTGTB
 
Yes, yes it is, but, is it working?
 
I've never understood what's on or off topic for programmers
after Mark Trapp ragequit i just decided not to post there
 
8:20 PM
@rolfl Still trying to figure out what the top one has to do with any interpretation of "design".
 
I dont know what's on topic or off anywhere
 
lol
 
@DaggNabbit I never made a conscious decision, but rarely post there any more.
@StuartBlackler Code Reviews are topical here. Flaming is topical on M.SO. Not sure about much else... :-)
 
we have a graphics design site somewhere right? Im guessing that would be the best place for web design feedback?
 
Yes, there is.
 
8:23 PM
@JerryCoffin literally given up with SO. So hostile I think
 
@StuartBlackler But, that's not for web design ;-)
 
@rolfl oh. snap! Dont you think there are just too many sites?
 
@StuartBlackler i think it's the "cops are assholes" syndrome
 
@StuartBlackler Depending on what part of a web design you care about, it might make more sense on the UI/UX site, or on WebMasters.
 
@StuartBlackler graphicdesign.stackexchange.com/help/on-topic looks like the one
 
8:25 PM
 
-1
Q: String character array

Hemraj0 down vote A company decided to award its employees with an end of year bonus, according to the following criteria: Years of service Bonus on salary (>15year 15%) (11-15years 10%) (5-10years 7%) Create a program in C that will: (A) Accept the name, basic salary and years of service of an emp...

1
Q: File reader/writer (text)

Mat's MugFollowing-up on this post, I wanted to be able to use my FileWriter with a syntax reminiscent of .net's using blocks, which ensure proper disposal of resources (i.e. closing the file/stream). What I have can be successfully used like this: Dim file As New file Dim path As String path = "c:\test...

 
I could see a web design code (e.g. HTML, CSS, PHP, etc.) being posted on CR to review the code for best practices, performance, etc. but as far as the looks of it... Maybe webmasters??
 
last night i was wondering what it would be like if there were a different SE for each programming language
and SO just went away
 
@StuartBlackler I still post there now and again, but with my history (going all the way back to Fidonet) I have pretty thick skin.
 
holy crap that's oldschool
 
8:27 PM
@rolfl " for power users of web applications."
 
forgot all about fidonet
 
Grapghic design looks more on-topic on graphicdesign.stackexchange.com
 
@DaggNabbit Bad idea, IMO. Even when they're tagged with a language, quite a few questions there are fundamentally language-independent. People can know a language very well, and still not know the best algorithm for a particular problem.
@DaggNabbit Sometimes I wish I could too... :-)
 
lol
2
all i used to do on my local BBS was play Doom
i was too young to care about stuff like this
and I'd guess that "quite a few" is less than 1% btw
 
@DaggNabbit I was younger then than now, but old enough to spend a year as moderator of C_ECHO, then another as mod on CPLUSPLUS.
 
8:31 PM
were you active on usenet too?
i used to read the various comp.langs and sometimes participate
 
@DaggNabbit Yes, fairly (for 15 years or so).
 
Any chance someone has experience with finding an internship in California as a European?
 
i think california likes free work as much as anyone
if you want to do some free work in florida hit me up
 
@DaggNabbit I'll let you know in case my girlfriend decides to move to Florida ;)
 
0
Q: Question inside answer

trapoMy question: Spliterator implementation got two answers. Into one of these, there's a question for me: one of the performance advantages of Spliterator is the forEachRemaining() method, and you have chosen not to implement it. Why? What's the best way to handle it? A comment or an edit? A c...

 
8:42 PM
TTQW - sorry wasn't really "there" today :(
 
@DaggNabbit It's high enough that I have silver badges in both C# and Java there, despite fairly minimal knowledge of either, and never having actively followed either tag.
 
1
Q: Optimising o(mn) solution for longest common subsequence problem

swapedoc Given two strings string X of length x1 and string Y of length y1, find the longest sequence of characters that appear left to right (but not necessarily in contiguous block) in both strings. e.g. if X = ABCBDAB and Y = BDCABA, the LCS(X,Y) = {"BCBA","BDAB","BCAB"} and LCSlength is 4. I...

 
@JerryCoffin i see what you mean... so the questions were directed at Java or C# but were just algorithm questions or whatever that could apply to any language
i think it's maybe more of a problem on CR actually, people take best practices from one language and try to apply them somewhere they don't really make sense
of course splitting up CR would be ridiculous
 
@DaggNabbit Mostly anyway, yes. I suppose I might have happened to answer some question that was really about those languages, but I certainly don' t know either well enough for that to be very many in either case.
@DaggNabbit Maybe--but a lot here comes back to fairly generic things like naming conventions. Yes, if a particular naming convention is common in a particular language, you might as well use that, but in most cases from a code review standpoint the problem is simply that there seems to be no system or convention in use at all.
 
@JerryCoffin I'm thinking of things like advising against implicit typecasting in weakly-typed languages e.e
i think i just discovered the best coffee ever
it's flavored with pine nuts
 
9:07 PM
@DaggNabbit Well, it's certainly true that if you're going to give advice about a particular subject, it's probably best to have at least some knowledge of that subject in the context of the language at hand. That's part of why I (sort of) avoid questions about C# and Java--although I may be able to think of a decent way to do something, I'm rarely sure my solution would be optimal (or even accepted) in that language.
@DaggNabbit "Best coffee" presupposes that there's such a thing as "good coffee", so it's logically fallacious from before the beginning, so to speak. :-)
 
Awesome! Another non-coffee-drinking programmer!
 
i knew something was off about you two ;)
 
I know another thing that is a bit off,
 
i count 60
 
@DaggNabbit On CR, it looks more like 190 for you.
 
9:15 PM
lol
someone just upvoted some ancient thing of mine
 
Scratch that, make that 180 170 instead.
 
lol thanks
 
hmm i need to update one of those
 
9:32 PM
0
Q: plotting many images at once in matplotlib

john mangualI am using numpy and matplotlib to do a statistical simulation. The simulation itself is pretty fast thanks to numPy vectorizatio, however the plotting is slow since I still use a for loop. Here is the result: Right now, I call matplotlib.pyplot.plt 10000 times, which can't possibly be opti...

0
Q: Search for User by first and/or last name, efficiently

incogneatoI am refactoring a user search that just feels dirty. (Users#search) I need to allow a blank param to search on partial or only a first or last, but don't want to return all the records in the database (which is what seems to be happening when I search with one value nil). That said, what's th...

 
Requirements
• Strong understanding of mobile networking best practices: request limiting, request caching, batching, content aggregation, minification, integrating with rest and tcp/udp services, etc.
• Expert performance profiler: understands the importance of optimizing for speed, memory usage and end-user responsiveness
• Comfortable using asynchronous, multi-threaded, parallel programming paradigms and other techniques to maximize UI responsiveness
• You know how to make the unthinkable happen: long data lists and thousands of images don’t scare you, animations are cake
"Internship"
 
0
Q: Changing attributes in different objects

WelshGandalfFirst some background - I am developing a python program which has thousands of lines spread across many files. I have intermediate programming skills - and no commercial oop experience, and have taught myself python recently. I have come across a problem which I can solve, in a number of differe...

 
@JeroenVannevel at least whoever wrote those up knew what they wanted and didn't just copy a bunch of irrelevant stuff out of another listing
 
9:49 PM
0
Q: Retaing and passing data between Activities

lschessingerI'm making an Android app where users can create posts. This process of creating a new post can potentially be a few activities/screens, so I need a way to save and pass the data between the activities. My first (bad) solution was just to pass the data with the intent in a Bundle, but this soon ...

0
Q: Check if a number is divisible by 3, efficiently

JavaDeveloperEfficient way to check if a number is multiple of three. Looking for code review, best practices and optimizations. public final class DivThreeEfficiently { private DivThreeEfficiently() {} /** * Returns true if the input number is divisible by three. * Else returns false. ...

 
10:20 PM
is this comment what I think it is?
''
' vbDirectory option still includes files.
' FML
Function FolderExists(ByVal file_path As String)
"FML"... I lol'd regardless
 
10:31 PM
I have to admit I lol'd too
Is it code from your work, Mug?
If it is, then I suppose there's been other ones who've hated that job just as much as you do now.
 
nope, it's from a question posted for review!
my predecessors (and some colleagues) were O(2^n) in many more places than I am (ref. that pinned measure your progress link), such a comment couldn't have been one of theirs ;)
it requires investigation and understanding.. two things that a just-get-it-done coder doesn't care about...
 
0
Q: Java SFTP JSCH security

CrizlyMy code below works fine but as per my servers rules i'm required to log in to SFTP using my main server username and password, obviously a little bit of a security concern. My question is ... is the code below secure, are the files to be transferred and the login credentials encrypted? I'm usin...

 
@Mat'sMug TS
It's been a lot of Java Questions today
It's been a while since @palacsint posted an answer, and visited the chat.
Reputation today: 200
Lines of code for one of my projects written today: 0
 
11:03 PM
@SimonAndréForsberg it's been a lot of Java Questions today lately
@SimonAndréForsberg +82 today... but I worked a little (gotta catch up with work tonight actually)
 
My question made it to the hot list!!
4
First time ever I have a hot question!!
 
congrats!
 
A message of mine has received three stars in the chat!!
^^ I remember the times when that felt special around here.
 
At my work, we have a combobox called "cbxAssPuller"
 
11:18 PM
@SimonAndréForsberg so lol
@nhgrif let me guess where it pulls its data from...
 
(and let that be a lesson for everyone using signed 32-bit values ... ;-)
 
Hmm... so... Swift...
Hopefully I can be the Swift guy here, in addition to ObjC...
 
And here's the same bug bringer in C: ideone.com/RRTi8W (in case people blame Java for WTF's).
 
11:34 PM
hey @ckuhn203!
 
Hey @Mat'sMug. I saw your question. I was just gonna take a look at it.
 
cool!
 
I'm still learning how to give a good answer here. World different than SO.
 
oh yeah! (and so much more fun too!)
 
Fix my broken code (SO) vs. Fix my working code (CR) I like this place much better
 
11:37 PM
Yes!
I learn more here.
 
Bahh .. I have not learned a thing here since .... oh, just earlier today ;0
2
 
I managed to write a C# answer earlier. I barely know C#. Good learning experiene.
 
I have an answer-in-progress on that question ;)
 
Oh, you answered the pizza question
 
(and it went unnoticed.. 21 minutes to reload...)
 
11:40 PM
I'm reading it, but.... it's C#
+1 for decimal.
 
oh, ..do I have to find another reason to upvote now? ...I guess not :)
 
Ahhhh crap .... no! Don't right-align your comments like that!.
 
huh?
oh, the OP!
 
I did not even see the comments until I read the answer.
Well, not those comments
 
I think you're swooshing me again
 
11:49 PM
3
Q: My first multi threading class

blaze4218I've thrown everything I can at this, and I can't get it to lock or crash. My hope is that I have applied the principles correctly. I write client apps in JavaScript, and this is only the 3rd .NET class I've ever written (using JScript), so a topic as advanced as this really needs a once over by ...

^^^ comments
Scroll down, see them all?
Now... when you have done that ......
....
 
oh what a jerk sorry that's mean
 
Now, scroll right.
Then scroll up again.
 
OMG and OP is arguing that point, too!
 
Yup ... Probably has a second monitor and got it configured to split the code over both... left with code, right with comments
 
That guy's using even longer lines than I am! Take that, @Nobody's screen!
 
11:52 PM
Hopefully someone will still come along who knows more about what you're doing. I just saw some things that raised flags and wanted to make sure you got some feedback. — ckuhn203 4 hours ago
@ckuhn203 that's the spirit!
(and BTW I don't think we'll find many [if any] people to disagree with you here)
@rolfl I was still on the pizza post
 
bahahahaha
I'm staying.
You guys make me laugh.
 
@Mat'sMug I think I need to disagree with that on principle. :-)
 
reload in ~5 minutes... (hand is on the trigger)
@JerryCoffin by all means, go ahead - right-align all your comments to column #842 in all of your code base!
 
@Mat'sMug That's where the "on principle" part comes in: I'm certainly not going to format comments that way. :-)
 
11:57 PM
tss... chicken :p
 
@Mat'sMug I actually just saw a code obfuscation using the right aligned comment technique. 2+2 = 5. Evil genius.
 
on Code Golf SE right? saw that one too!
 
@Mat'sMug Goodness, your eyes must be pretty bad. That's a wasp, not a chicken. Both winged creatures though, so I guess you're doing better than whoever it was who thought it was a spider...
 
Yeah.
Those guys are next level.
 
@Mat'sMug Who said anything about flying? :-)
 
11:59 PM
(poor unicorns)
 

« first day (394 days earlier)      last day (3615 days later) »