← 1 message moved from The Auditorium

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/lexer.py: "again, this much docstring is not needed. Just put inline comments next to the enum values in the class declaration below"

pxeger requested changes on PR #206 (Vyxal/Vyxal)

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "I don't think these annotations arte necessary given they're constant literals that can easily be inferred. They just make the code more cluttered/hard to read"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "This condition seems to be duplicated?"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "N.B. if you make `StructureType` and enum then this `str` annotation would change to `StructureType`."

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: ""overview" seems like a strange name choice"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "Don't annotate everything! You really only need to do function signatures and everything else can be inferred."

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "seems very janky"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "again, duplication of the annotation already on the function"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "make it an enum to get better typing support"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "duplicated again?"

pxeger commented on PR #206 (Vyxal/Vyxal) in file vyxal/parser.py: "still too much docstring"

pxeger commented on PR #206 (Vyxal/Vyxal) in file tests/test_parser.py: "this is very janky - what are you trying to achieve? It seems like you're not running your code correctly if you need this"

pxeger commented on PR #206 (Vyxal/Vyxal) in file tests/test_parser.py: "what exactly is "the workflow"? Using `pytest`? Just use pytest; it's not very complicated"

ysthakur commented on PR #206 (Vyxal/Vyxal) in file tests/test_parser.py: "Yeah, the tests should simply be functions whose names start with `test_`. We shouldn't need the `__name__ == "__main__"` thing *anywhere* except in the main interpreter file."

← 15 messages moved from Vyxal

It is enough. I said: Please, prove that the question is PSQ. You answered: (Proof) First i’ve tried to manipulate the equation and then square both sides but it didn’t work". Says who? I don't see the results of the squaring. Anyone can claim they tried something. Heck, I also can say I tried (I didn't)... "then i’ve tried to prove it by contradiction in other word i wanted to show that a,b Can’t have the same parity" Again, that's not a try, but a mere claim of a try......

Where is the full context?

ysthakur commented on PR #206 (Vyxal/Vyxal) in file tests/test_parser.py: "Doesn't seem that bad, but maybe we could use relative imports (`...`) instead?"

← 2 messages moved from Vyxal

@XanderHenderson "I suggest you should have chosen to ignore users that you object to". You're not the only one around here that knows when enough is enough. Please practice what you preach to me.

← 1 message moved from CURED