« first day (87 days earlier)      last day (54 days later) » 

12:45 AM
@ArtOfCode I just pulled and started looking around -- you've broken a ton of stuff. Regardless of the merit of putting stuff in Dispatch or not, please don't merge this to master. I will do some work today and tomorrow to fix the broken stuff, so please hold off on merging until monday.
 
1:34 AM
I'm reading over your commits and trying to reimpliment what you did in a way that doesn't break stuff but still doing what you want :)
 
2:20 AM
@thesecretmaster what stuff?
 
Everything that already referred to RR
I am working through and making things agree. There's also duplication that I'm removing.
I also just want to understand what you did, and so I was reading through your commits anyways.
I'll push my branch in a sec, so you can see what I'm doing.
Woah, you rewrote the whole creation flow?!?
That is ... I really like that. That cleans up many annoying things about the current RR controller too.
 
I rewrote everything
That's why it took so long :P
@thesecretmaster This is mostly intentional, unless I missed some stuff I didn't realise. Everything that referred to RR is now obsolete, including RR itself, and could actually be removed. CAD is a replacement.
The two major bits were the request creation flow, and the CAD dashboard - have a look at that if you haven't already
/cad/1/dashboard
 
2:43 AM
I'm looking at everything. At the moment, I'm skeptical of the idea that CAD replaces everything.
But I'm only halfway through the commit history.
I started with a new branch from master and basically am recreating all that you did, with some changes, so I can sort through it better mentally.
I've just finished your Nov. 21 commits.
I don't think I'm going to get through everything tonight, so can you please wait to merge until I've read through everything? I already have some questions and changes and suggestions on your PR, and either way, you at least need to put in into the nav before you merge into master.
 
3:10 AM
obviously it doesn't replace translations and broadcast :P
 
Yes, of course.
Anyways, I think I'm going to call it a night after I review 4e7dea7. Would you mind not merging until I've finished reviewing?
 
3:25 AM
Heh, did you forget to add the Gemfile in bb892e6f9c7e0a0be11e5cc444ddcbb680cf890a? I see the Gemfile.lock changed, but nothing in Gemfile.
 
3:43 AM
Anyways, I'm done for the night, please don't merge the PR until I've reviewed the last 10 commits.
Which should be early in the day tomorrow.
 
 
2 hours later…
6:11 AM
@thesecretmaster no, that would actually be a gem that I added to try out and then removed again
 
 
12 hours later…
6:37 PM
OK, I'm mostly done with your PR. I've got some changes I want to make, so I'll do them on a separate branch. I'd like for you to look at them before you merge your PR.
 
@thesecretmaster run me through the changes?
 
Lemme finish, I'll push it on to a different branch, then you can look. I'm not quite done yet, still sorting out why you did some things the way you did.
I should finish later today.
I'm just trying to make things click together better and also further refactor the old RR controller.
 
7:22 PM
@thesecretmaster The old RR controller is obsolete. It can be deleted. If there's stuff in it that isn't replicated in the new stuff, it needs to be moved to another controller - either Dispatch::RequestsController or something else
Otherwise we get left with two request controllers, and it gets confusing because you forget which code is where.
We can move Dispatch::Request* to ::Request*
@thesecretmaster I can probably answer questions about why :P
 
 
1 hour later…
8:32 PM
@ArtOfCode I'm just moving stuff around. I don't want 2 request controllers either.
 
8:48 PM
I've pretty much ended up moving all the stuff into RescueRequests. Now I gotta rename it to Requests and move some stuff out of it.
I'll probobly end up with more or less what you have, but I want to do it myself.
 

« first day (87 days earlier)      last day (54 days later) »