« first day (2794 days earlier)      last day (386 days later) » 

mansellan
mansellan
12:00 AM
v3 has to do LSP I think...
 
Duga
Duga
REFRESH!
[Minesweeper] 126 Games Played. 84 Bombs Used. 15685 Moves Performed. 29 New Users
[Zomis/status-check] 63 additions. 0 deletions. 1 commits
[rubberduck-vba/Rubberduck] 1 issue comments
[Zomis/Duga] 4 additions. 2 deletions. 2 commits
 
Vogel612
Vogel612
@mansellan LSP was first mentioned in 2016 in this chatroom... yikes
 
mansellan
mansellan
ikr...
 
Vogel612
Vogel612
I just reread a bit of one of the first proper discussions on that...
 
mansellan
mansellan
It's actually easier to do it whilst we have everything in .Net. There are NuGets available.
 
Vogel612
Vogel612
12:04 AM
And noticed that I raised the issue of the VBE prettyprinting certain things and the compiled VBA possibly differing from the source code input..
 
mansellan
mansellan
huh?
 
Vogel612
Vogel612
mostly thundercode is an issue here...
like the use or bracketed names
 
mansellan
mansellan
you still talking about LSP?
 
Vogel612
Vogel612
especially of bracketed names for reserved identifiers
which is... basically unsolvable at the parser level with the setup we currently have anyways..
@mansellan yea. in a way
 
mansellan
mansellan
oh... yea i see
daaaang
LSP not designed for... "unusual" languages.
 
Vogel612
Vogel612
12:07 AM
VBA is not an unusual language
the VBE is just a horrible messy and actively sabotaging environment to extend
 
mansellan
mansellan
[_I
Disagree
A Bit]
As String
 
Mathieu Guindon
Mathieu Guindon
@mansellan yes
 
Vogel612
Vogel612
@mansellan um... how do line continuations work inside bracketed identifiers? while were at that?
 
mansellan
mansellan
@Vogel612 bah. clearly not a thunder user. My point stands, plenty of weirdness available.
 
mansellan
mansellan
12:33 AM
Can we up to net472? It's plenty old now, but lets you use many bits of C#10.
 
Vogel612
Vogel612
@mansellan good question
honestly we could even try for core 3, I think
 
mansellan
mansellan
the leap from framework to core is scary for some I think. and 4.8 is pointless. our company has been trying to move from 472 to core for ~2 years now..
472 with c#10 is pretty good tbh
 
Vogel612
Vogel612
we wanted to try for core basically since it reached version 2
 
mansellan
mansellan
our newer stuff is on 6. it's awesome.
 
 
3 hours later…
Feeds
Feeds
3:53 AM
 
 
2 hours later…
this
this
5:42 AM
while a number of projects probably can run on .net 5/6, the Rubberduck.VBEditor probably can't due to the typelib support.
 
 
5 hours later…
M.Doerner
M.Doerner
11:05 AM
Just to mention it, if we go LSP, we will have to send some data you usually do not sed. AFAIU, usually, you only send over source changes. We will also have to send info from the typelib API.
And we can basically only query the changes there on project level.
 
 
1 hour later…
Freeflow
Freeflow
12:10 PM
I've been round tripping a project between VBA and twinBasic. Rubberduck picks up an awful lot of fluff that is not yet flagged in twinBasic.
 
 
4 hours later…
Duga
Duga
3:43 PM
[rubberduck-vba/Rubberduck] build for commit f9baa8cf on next: AppVeyor build cancelled
BUILD FAILURE!
[rubberduck-vba/Rubberduck] build for commit f9baa8cf on next: CI failed.
BUILD FAILURE!
[rubberduck-vba/Rubberduck] build for commit f9baa8cf on next: CI failed.
BUILD FAILURE!
 
Mathieu Guindon
Mathieu Guindon
3:59 PM
The webhook URL format seems to have changed, as well as the content type. I think the hook setup is missing the "secret" ...would that be the PAT we've regenerated and encrypted on AppVeyor?
> {"message":"Webhook request does not contain signature."}
 
Mathieu Guindon
Mathieu Guindon
4:22 PM
Dammit this is so frustrating
 
Mathieu Guindon
Mathieu Guindon
4:48 PM
Webhook gets delivered, receives a 204 OK, ..and then nothing.
 
this
this
which webhook are we talking about?
 
Mathieu Guindon
Mathieu Guindon
5:08 PM
The AppVeyor CI hook that's supposed to trigger builds for PR and push events
 
this
this
5:42 PM
according to GH's setting, the content is application/x-www-url-encoded but AppVeyor's documentation seem to imply it's JSON.
 
Duga
Duga
[rubberduck-vba/Rubberduck] web-flow pushed commit 394cfab9 to next: Update appveyor.yml
[rubberduck-vba/Rubberduck] web-flow pushed commit 7a6bfed9 to next: Update appveyor.yml
[rubberduck-vba/Rubberduck] build for commit 7a6bfed9 on next: Error parsing appveyor.yml
BUILD FAILURE!
[rubberduck-vba/Rubberduck] web-flow pushed commit 0adff04b to next: Update appveyor.yml
[rubberduck-vba/Rubberduck] build for commit 0adff04b on next: Error parsing appveyor.yml
BUILD FAILURE!
 
Mathieu Guindon
Mathieu Guindon
looks like push is working (kinda) on next
 
Duga
Duga
[rubberduck-vba/Rubberduck] web-flow pushed commit 7c523c49 to next: Update appveyor.yml
 
Mathieu Guindon
Mathieu Guindon
6:04 PM
@Duga queued for 22 minutes, and counting... wtf
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 394cfab9 on next: AppVeyor build failed
BUILD FAILURE!
 
Mathieu Guindon
Mathieu Guindon
geez
wow nice, some random test failing out of the blue
at least it built
so push works, but not pr
I'm contacting support
 
Vogel612
Vogel612
6:20 PM
@this wrong webhook end.
Mat is talking about the webhook that sends a request to appveyor, not the ones we can trigger from appveyor
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 7c523c49 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 7c523c49 on next: 97.58% (target 0.00%)
 
Duga
Duga
6:40 PM
> CI build isn't triggering, AppVeyor support says to try closing & reopening the pull request - just a heads-up that I'm going to try doing that.
 
Vogel612
Vogel612
redelivered the "opened" webhook payload...
still no luck it seems
 
Mathieu Guindon
Mathieu Guindon
> In your AppVeyor account GitHub is authorized as “GitHub App”, so repository-level webhooks won’t work. GitHub App uses a single centralized webhook handler.
 
Vogel612
Vogel612
that's under "Integrated Apps" in the settings
you might be able to update the access for the app here
 
Duga
Duga
> OK, it looks like "AppVeyor" GitHub App is not installed for account rubberduck-vba.
> I mean it's probably installed on GitHub side, but AppVeyor doesn't see it. Go to "New project" page in AppVeyor and do "Import existing installations".
[rubberduck-vba/Rubberduck] build for commit 7c523c49 on next: AppVeyor build failed
BUILD FAILURE!
> @FeodorFitsner now I can see the project twice... once with the (correct) buildnumber 6051 as the last build and once as the new project.
[rubberduck-vba/Rubberduck] build for commit 7c523c49 on next: CI failed.
BUILD FAILURE!
[rubberduck-vba/Rubberduck] build for commit 7c523c49 on next: CI failed.
BUILD FAILURE!
 
Vogel612
Vogel612
6:56 PM
wtf AV, why would you search for the sln there?
> msbuild "C:\projects\rubberduck\Rubberduck.sln"[..]
 
Mathieu Guindon
Mathieu Guindon
7:07 PM
@Duga that's the AV support guy!
 
Vogel612
Vogel612
@MathieuGuindon yea, I ran into him back when I was bugging them about csproj patching not working
 
Duga
Duga
> You don't need to create a new project under your user.
If you go to https://github.com/organizations/rubberduck-vba/settings/installations ensure you have "AppVeyor" app installed:

![image](https://user-images.githubusercontent.com/5041459/151674267-83231616-1f18-469a-a8e3-1c6446d56876.png)
 
Vogel612
Vogel612
^ that's for you, mat, cuz I can't go there
 
Duga
Duga
> @FeodorFitsner I confirm that AV is installed, and has the following permissions:

- Read access to code, members, metadata, and pull requests
- Read and write access to checks and commit statuses

Repository access
- All repositories
This applies to all current and future repositories.
 
Mathieu Guindon
Mathieu Guindon
Weird, I thought you had org-level admin access
 
Vogel612
Vogel612
7:17 PM
seems to require owner privs
 
Mathieu Guindon
Mathieu Guindon
in any case, the app is there and has the required accesses
> If you are planning to use GitHub App (vs OAuth) going forward then you can remove that webhook. Not sure what you mean by “org-level” webhook – AppVeyor expect org-level webhook configured only for syncing teams/memberships.
 
Duga
Duga
> OK, would you mind if I create a fake test PR and play with it?
> @FeodorFitsner absolutely no problem with that!
> null
 
Mathieu Guindon
Mathieu Guindon
I'm confused. if "your AppVeyor account GitHub is authorized as “GitHub App”, so repository-level webhooks won’t work" and then "AppVeyor expect org-level webhook configured only for syncing teams/memberships", and "you can remove that [repository-level] webhook" -- something isn't adding up
 
Duga
Duga
> I can see the GitHub webhook firing and receiving a 204 OK response, but on the AppVeyor side there's no event, and nothing happening.
> OK, thanks for letting know. That webhook is ignored when GitHub is authorized as an App.

However, it looks like we've found the issue. We'll take a deeper look at what's going on and deploy a bug fix later today. Thanks for your patience! I'll provide an update here.
 
Vogel612
Vogel612
7:37 PM
welp
good to know that apparently appveyor is that bad at their job :D
bit harsh, but eh
 
Mathieu Guindon
Mathieu Guindon
> That webhook is ignored when GitHub is authorized as an App
is it just me or that makes no sense at all??
like, I'd need to _un_authorize GitHub for it to work?
I guess we'll have to wait for the update
 
 
3 hours later…
Duga
Duga
10:34 PM
> We've deployed AppVeyor update with a fix. I've been able to start a new build of my test PR: https://ci.appveyor.com/project/rubberduck-vba-releasebot/rubberduck/history

Well, you have to close/open this PR again to start a new build.
[rubberduck-vba/Rubberduck] build for commit 634e8c93 on unknown branch: AppVeyor build succeeded
 
Mathieu Guindon
Mathieu Guindon
10:57 PM
Woot!
 
Vogel612
Vogel612
@Duga okay wow that's... new
We could really try to get that bot it's proper (bot) tag
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 634e8c93 on unknown branch: 97.58% (target 0.00%)
> @FeodorFitsner Thanks for the help :+1:
> OK, it looks like "AppVeyor" GitHub App is not installed for account rubberduck-vba.
> Sure, glad it works again!
> I mean it's probably installed on GitHub side, but AppVeyor doesn't see it. Go to "New project" page in AppVeyor and do "Import existing installations".
> @FeodorFitsner now I can see the project twice... once with the (correct) buildnumber 6051 as the last build and once as the new project.
> @FeodorFitsner I confirm that AV is installed, and has the following permissions:

- Read access to code, members, metadata, and pull requests
- Read and write access to checks and commit statuses

Repository access
- All repositories
This applies to all current and future repositories.
> OK, would you mind if I create a fake test PR and play with it?
> @FeodorFitsner absolutely no problem with that!
> You don't need to create a new project under your user.
If you go to https://github.com/organizations/rubberduck-vba/settings/installations ensure you have "AppVeyor" app installed:

![image](https://user-images.githubusercontent.com/5041459/151674267-83231616-1f18-469a-a8e3-1c6446d56876.png)
> cleaned up some comments from the troubleshooting of the AppVeyor issues we've been having
 
Mathieu Guindon
Mathieu Guindon
@Vogel612 sure!
 
Duga
Duga
11:16 PM
[rubberduck-vba/Rubberduck] build for commit afdfd1a8 on unknown branch: AppVeyor build succeeded
 
Duga
Duga
11:45 PM
[rubberduck-vba/Rubberduck] 1508 stars vs. [decalage2/oletools] 1899 stars
 
Vogel612
Vogel612
something's still wrong with the damn coverage reporting.
blegh
 

« first day (2794 days earlier)      last day (386 days later) »