VBA Rubberducking

Duga

12:02 AM

REFRESH!

[Minesweeper] 73 Games Played. 50 Bombs Used. 9154 Moves Performed. 12 New Users

[rubberduck-vba/Rubberduck] 3 issue comments

Duga

1:38 AM

> Partially addresses the warnings from #5881

Because certain supertypes can have foreign names, they may require bracketing. However, we also need to handle cases where the supertype names might be already bracketed or contains qualified names (e.g. `Excel.Worksheet` or `VBAProject.Class1`), we need to be pessimistic about the legality of the name when resolving the supertype in the `TypeHierarchyPass`. The new method introduced will attempt to split the supertype name on the `.` and bracket

Duga

1:59 AM

[rubberduck-vba/Rubberduck] build #6017 for commit 8e7a7f6998 @ 2.5.2.6017 build success

[rubberduck-vba/Rubberduck] build for commit f77d87e8 on unknown branch: AppVeyor build succeeded

Duga

9:18 AM

[rubberduck-vba/Rubberduck] BZngr synchronized pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

Duga

9:40 AM

[rubberduck-vba/Rubberduck] build #6018 for commit 71e380e4fe @ 2.5.2.6018 build success

[rubberduck-vba/Rubberduck] build for commit c106c802 on unknown branch: AppVeyor build succeeded

M.Doerner

@Duga Please also note that we have inspections relying on the supertype names, AFAIK. So, we should really only introduce brackets if we have to to make the name parsable.

Duga

9:56 AM

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/QuickFixes/Abstract/QuickFixBase.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/QuickFixes/Concrete/RemoveUnassignedIdentifierQuickFix.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/QuickFixes/IQuickFix.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.Refactorings/DeleteDeclarations/Abstract/IDeclarationDeletionGroup.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.Refactorings/DeleteDeclarations/DeleteEnumMembers/DeleteEnumMembersRefactoringAction.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

Duga

1:43 PM

[rubberduck-vba/Rubberduck] bclothier created comment on pull request #5888: Improve handling of supertypes with foreign identifiers

> As I mentioned in the OP, this will cause the tests on the implicit worksheet inspection to fail because it does not handle the bracketed version. I want to avoid making it conditional to bracket the name because that would devolve into whack-the-mole game trying to find all possible offensive characters that could appear in a supertype name. When running the bracketed name via the expression parser in the TypeHierarchyPass, it gets stripped away for the purpose of comparing against other de

[rubberduck-vba/Rubberduck] retailcoder commented on Rubberduck.CodeAnalysis/QuickFixes/Concrete/RemoveUnassignedIdentifierQuickFix.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

Duga

2:35 PM

[rubberduck-vba/Rubberduck] bclothier created comment on issue #5881: Unexpected Access form control supertype names

> Just to take some notes based on the PR #5888 that may be relevant for full resolution of hidden interfaces.

The supertypes are also provided from the `Implements` statement, handled within `DeclarationSymbolsListener`. This is deferred until the resolution in `TypeHierarchyPass` and for that reason, the `GetText()` is used there. That made me wonder whether it was possible to implements a poorly named module. Thankfully, VBA does not seem to permit names like those:
```
Implements [Bad N

Duga

3:48 PM

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/QuickFixes/Concrete/RemoveUnassignedIdentifierQuickFix.cs of pull request #5734: Introduce DeleteDeclarationsRefactoringAction replacing IModuleRewritingExtensions.cs

Duga

8:55 PM

[rubberduck-vba/Rubberduck] ctrlpprint starred us

2

Duga

9:52 PM

[rubberduck-vba/Rubberduck] Energeer added label bug to issue #5889: Implicit reference to ActiveWorkbook

[rubberduck-vba/Rubberduck] Energeer opened issue #5889: Implicit reference to ActiveWorkbook

Duga

10:26 PM

[rubberduck-vba/Rubberduck] Energeer added label bug to issue #5890: Unexpected Set Assignment with incompatible object type

[rubberduck-vba/Rubberduck] Energeer opened issue #5890: Unexpected Set Assignment with incompatible object type

[rubberduck-vba/Rubberduck] Energeer edited issue #5889: Unexpected Implicit reference to ActiveWorkbook

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5889: Unexpected Implicit reference to ActiveWorkbook

> Thanks for reporting this since it is a bug, indeed.

However, could you see whether this still occurs in a newer prerelease? This should be fixed since the overhaul of the inspection in prerelease 2.5.2.5911.

[rubberduck-vba/Rubberduck] Energeer edited issue #5890: Unexpected Set Assignment with incompatible object type

Duga

10:47 PM

[rubberduck-vba/Rubberduck] Energeer created comment on issue #5889: Unexpected Implicit reference to ActiveWorkbook

> Thanks, I've just installed 2.5.2.6015.

You're right, it appears to be fixed now - the inspection is not showing.

Duga

11:17 PM

[rubberduck-vba/Rubberduck] Energeer starred us

2

[rubberduck-vba/Rubberduck] kaxir starred us

2

Duga

11:47 PM

[rubberduck-vba/Rubberduck] 1433 stars vs. [decalage2/oletools] 1763 stars

Transcript for