« first day (2536 days earlier)      last day (644 days later) » 

Mathieu Guindon
Mathieu Guindon
12:01 AM
We got $11.59 today from a donator saying "Rubberduck is great!"
 
Duga
Duga
RELOAD!
[rubberduck-vba/Rubberduck] 88 commits. 1 closed issue. 155265 additions. 76071 deletions.
[Minesweeper] Games Played: 87, Bombs Used: 55, Moves Performed: 12563, New Users: 10
 
Mathieu Guindon
Mathieu Guindon
@MDIsmailHosen I usually write the code and then write the article, but sometimes I make a few minor tweaks afterwards; that looks like it. Not sure Extract Interface is aware of the backing UDT, but forwarding the implementation to the existing properties is already nice - which one you want mostly depends on whether your getters have any logic beyond returning the backing value: there isn't really any right or wrong way here.
 
 
1 hour later…
Duga
Duga
1:21 AM
 
 
7 hours later…
Duga
Duga
8:49 AM
> Minor Italian translation missed in IvenBach's ConsolidateResourceCleanup and ancestral typo (I think) in English default RefactoringsUI resource file.
 
Duga
Duga
9:12 AM
[rubberduck-vba/Rubberduck] build for commit 5ee2a9d3 on unknown branch: AppVeyor build succeeded
 
 
4 hours later…
Duga
Duga
12:51 PM
[rubberduck-vba/Rubberduck] PhilCattivocaratere pushed commit f31e713e to next: Ancestral typo, I think
[rubberduck-vba/Rubberduck] PhilCattivocaratere pushed commit 5ee2a9d3 to next: Minor Italian translation missed in IvenBach's ConsolidateResourceCleanup
Merge pull request #5774 from PhilCattivocaratere/ConsolidateResourceItaTranslation

Consolidate resource Italian translation
 
Duga
Duga
1:13 PM
[rubberduck-vba/Rubberduck] build for commit a7070203 on next: AppVeyor build succeeded
 
 
2 hours later…
Duga
Duga
3:38 PM
> Linking #5765
 
 
1 hour later…
IvenBach
IvenBach
4:47 PM
@Duga Self-note: MoveToFolder command in CodeExplorer context menu shows #Caption. Correct when I get back.
 
 
2 hours later…
MD Ismail Hosen
MD Ismail Hosen
6:29 PM
@MathieuGuindon Thank you for the response. I have tried to run that i think that it is better to call that property instead of this.PropertyName as property implementation may be have something more than just getting UDT member value. Another issue i have found when following that article is that internal was never set to any object and that obj was never used. I guess that set result.user=obj instead of internal.
 
 
3 hours later…
Duga
Duga
9:57 PM
> **Rubberduck version information**
The info below can be copy-paste-completed from the first lines of Rubberduck's log or the About box:

Rubberduck version 2.5.2.5920 loading:
Operating System: Microsoft Windows NT 6.2.9200.0 x64
Host Product: Visual Basic x86
Host Version: 6.00.9782
Host Executable: VB6.EXE;


**Description**
Fresh install of RD, first time ever. I'm clicking the "Pending" button in the toolbar, and after a short moment it comes back from disabled state wi
 
Duga
Duga
10:36 PM
> Thanks for the report, that special-form syntax is ...apparently not quite there yet!
> We have a special grammar rule for `Circle`: https://github.com/rubberduck-vba/Rubberduck/blob/a707020343a71bc5bf9b700b339c7c2deb858c67/Rubberduck.Parsing/Grammar/VBAParser.g4#L581

It's expecting expressions after every comma, which is not what you have here. In theory the grammar rule could be adapted to allow for empty expressions, which would match the optional argument usage.

If we'd attempt to be strict, we might adapt the grammar rule to deal with the full syntax as specified in [t
 
Vogel612
Vogel612
@MathieuGuindon I've been looking for the docs there for ages. Why is it so incredibly hard to find old VBA docs again?
 
Duga
Duga
> Tangentially related: #4875. We may want to validate that other special form parsing rules also account for optional arguments correctly.
 
Mathieu Guindon
Mathieu Guindon
@Vogel612 weird, wouldn't the special forms be in MSVBAL?
but yeah, this used to be much easier
 
Duga
Duga
> Worth noting that radius is required.
 
Vogel612
Vogel612
@Duga @mansellan we're usually assuming that the code does parse as legal VBA
so Rubberduck's parser can be slightly more lax
@MathieuGuindon the documentation remarks that the method is only available on reports and when handling Print events...
maybe that's an artefact of the fac that it's the access docs though...
 
mansellan
mansellan
10:48 PM
@Vogel612 iirc it's access forms and reports, and VB6 forms.
 
Vogel612
Vogel612
@MathieuGuindon MSVBAL mentions <special-form> and lists "Circle" as one option available, but never fully specifies the syntax for that special form
> A <special-form> is a <reserved-identifier> that is used in an expression as if it was a program defined procedure name but which has special syntactic rules for its argument
 
mansellan
mansellan
Huh. #TIL that my works PC doesn't include Access :-(
 
mansellan
mansellan
11:02 PM
quickfix seems to be to just make the expression optional, e.g. ` circleSpecialForm : (expression whiteSpace? DOT whiteSpace?)? CIRCLE whiteSpace (STEP whiteSpace?)? tuple (whiteSpace? COMMA whiteSpace? expression?)+; ` (air-coded)
not entirely precise, but should allow it to parse
or, I think this would be fully precise:
circleSpecialForm : (expression whiteSpace? DOT whiteSpace?)? CIRCLE whiteSpace (STEP whiteSpace?)? tuple whiteSpace? COMMA whiteSpace? expression (whiteSpace? COMMA whiteSpace? expression? (whiteSpace? COMMA whiteSpace? expression? (whiteSpace? COMMA whiteSpace? expression? (whiteSpace? COMMA whiteSpace? expression?)?)?)?)?;
 
Greger
Greger
11:46 PM
[rubberduck-vba/Rubberduck]: 1338 stars vs. [decalage2/oletools]: 1544 stars
 

« first day (2536 days earlier)      last day (644 days later) »