VBA Rubberducking

12:02 AM

RELOAD!

[rubberduck-vba/Rubberduck] 10 commits. 1 opened issue. 1 closed issue. 8 issue comments. 2201 additions. 2248 deletions.

[Zomis/FactorioMods] 2 commits. 58 additions. 1 deletion.

[Minesweeper] Games Played: 65, Bombs Used: 47, Moves Performed: 9100, New Users: 9

Feeds

2:03 AM

Extremely rude how Turing's later formulations of the halting problem called me out by name specifically.

Duga

[rubberduck-vba/Rubberduck] retailcoder created comment on pull request #5740: Make SelectedDeclarationProvider argument-aware

> Okay now this is getting pretty nice..

![image](https://user-images.githubusercontent.com/5751684/115645470-709a2b00-a2ee-11eb-91f6-468cca12fb11.png)

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5740: Make SelectedDeclarationProvider argument-aware

this

@Duga woah, slick!

I think for a next PR we could add highlighting to the reference dialog to help show which part of the code the reference is on

and then the "Title" would totally pop out

Mathieu Guindon

tbh I'd want an inspection for that string literal argument passed to an enum parameter

@this IKR?

but yeah highlighting the ref in the "context" string would be awesome

this

2:21 AM

@MathieuGuindon that requires knowledge about the parameters. Way too many functions in various OM takes Variants but in reality they only want a particular subtype of variant.

e.g. Msgbox "derp", "1" is technically legal both to compile and run

Mathieu Guindon

but Buttons is VbMsgBoxStyle

this

oh you're right.

Mathieu Guindon

"Title" is a type mismatch every time :)

this

that's a different problem (implicit conversion of something to enum)

Mathieu Guindon

true - but I think it's fair enough to warn about it at least

this

2:23 AM

yes, in this case, it's pretty clear-cut

even 1 should be suspicious

Mathieu Guindon

"1" would be legal but suspicious enough to warrant a flag

this

and a 10K volt through keyboard, too?

Mathieu Guindon

twice

this

I mean, 1 is bad enough, but "1", WTH are you doing, man?

Mathieu Guindon

:D

this

2:24 AM

oooorrrrr..... msgbox "hi", 0.6

Mathieu Guindon

dang now you gotta go full-ThunderCode and give it a Date lol

this

msgbox "hi", #2021/04/21#

This is fine

Mathieu Guindon

ducky: ~*bzzzt~

BigBen

@this wtf

Duga

[rubberduck-vba/Rubberduck] build for commit 46452a1a on unknown branch: AppVeyor build succeeded

IvenBach

7:44 AM

@Duga @MathieuGuindon I forgot to ask. Why is it that the other collapse/expand all commands which set the a private backing field IsExpanded to false collapses everything? I saw that was the case for the inspections window.

I think I also checked TestExplorer too. Same result.

Just realized how late it is and I need sleep to properly ask my question. Will reword it tomorrow.</iven>

Mumble mumble unit test with mixed IsExpanded nodes testing that all nodes are respectively set new values when command is invoked.

M.Doerner

10:16 AM

@this I think you meant MsgBox "hi", #12/31/1899#.

FreeMan

10:58 AM

@SonGokussj4 I've found that Alt-Tab - Alt-Tab rehooks all the hotkeys. Much faster than move-hand-from-keyboard-to-the-mouse-find-the-cursor-move-it-to-another-application-window-click-move-it-back-to-the-VBE-click-again-move-hand-back-to-keyboard. Unfortunately, I tend to do that a fair bit to get 'round the keyhook "issue". :(

Unfortunately, it does not work to move between RE/IDE windows. That needs hotkeys of some sort.

FreeMan

12:20 PM

@this is odd to me. I'm sure it's supposed to be this way, I've just never noticed before.

I'm using TurtleGit and when I do a git|diff, then double click one of the files, if I hover over the line numbers, it shows me the full path\filename

On the left, which I believe is what's currently in git, it shows me this:

when I hover over the row numbers on the right, it shows me this:

Why does it have the %temp% path on the right, current git code?

Is that because it has to extract from the local git repository what's currently checked in, and it extracts it to %temp%?

Also, I'm wondering what the heck it's actually comparing against since it's showing me diffs of missing @folder ... annotations.

I've had those in my code from loooooong before I started using git.

I love the concept of git, I've just had the most difficult time being consistent enough in my use of it (i.e. long breaks between programming sessions) to become actually reasonably conversant in its use.

FreeMan

1:37 PM

I've noticed this appearing in the log:

2021-04-22 09:17:26.4648;ERROR-2.5.2.5834;Rubberduck.UI.Command.MenuItems.CommandBars.AppCommandBarBase;Assignment of CommandBarButton.Caption or .TooltipText for ContextDescriptionLabelMenuItem threw an exception.;System.ArgumentException: Value does not fall within the expected range.
   at Microsoft.Office.Core.CommandBarControl.set_TooltipText(String pbstrTooltip)
   at Rubberduck.VBEditor.SafeComWrappers.Office12.CommandBarButton.set_TooltipText(String value) in C:\projects\rubberduck\Rubberduck.VBEditor.VBA\SafeComWrappers\Office\CommandBarButton.cs:line 236

~~in build .5834~~ (that was obvious from the log entry). Anything to be concerned about?

Seems to be happening somewhat regularly. Can post a full log if desired.

related?

2021-04-22 09:17:43.8003;INFO-2.5.2.5834;Rubberduck.Parsing.Common.ParsingStageTimer;Resolved user declaration in 9ms.;
2021-04-22 09:17:44.0813;INFO-2.5.2.5834;Rubberduck.Parsing.VBA.RubberduckParserState;RubberduckParserState (69) is invoking StateChanged (ResolvedDeclarations);
2021-04-22 09:17:44.1153;ERROR-2.5.2.5834;Rubberduck.UI.Command.MenuItems.CommandBars.AppCommandBarBase;Assignment of CommandBarButton.Caption or .TooltipText for ContextDescriptionLabelMenuItem threw an exception.;System.ArgumentException: Value does not fall within the expected range.

could just be that my project has gone wonky again. :(

That error repeats about another 8-10 times

Also, several of these at random locations:

2021-04-22 09:17:48.3786;WARN-2.5.2.5834;Rubberduck.CodeAnalysis.Inspections.Logistics.Inspector;System.ArgumentException: Unsupported operation (Is) passed to Evaluate function
   at Rubberduck.CodeAnalysis.Inspections.Concrete.UnreachableCaseEvaluation.ParseTreeExpressionEvaluator.Evaluate(IParseTreeValue LHS, IParseTreeValue RHS, String opSymbol) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Concrete\UnreachableCaseEvaluation\ParseTreeExpressionEvaluator.cs:line 39
   at Rubberduck.CodeAnalysis.Inspections.Concrete.UnreachableCaseEvaluation.ParseTreeValueVisitor.VisitBina…

Started browsing the log because the QF - Adjust Attribute Values for a "Value does not match between attribute and annotation" inspection doesn't seem to be fixing the attribute value.

Going to close Access, install older build, see if issue persists. Oddly, I got prompted on exit (of Access) to name the module I'd made the @Description change in, even though this module has existed under this name for several years.

:( issue with the QF exists in .5824 as well. :( Issue incoming

Duga

2:23 PM

[rubberduck-vba/Rubberduck] daFreeMan added label feature-inspection-quickfixes to issue #5742: QuickFix for AttributeValueOutOfSync isn't working

[rubberduck-vba/Rubberduck] daFreeMan added label bug to issue #5742: QuickFix for AttributeValueOutOfSync isn't working

[rubberduck-vba/Rubberduck] daFreeMan opened issue #5742: QuickFix for AttributeValueOutOfSync isn't working

> **Rubberduck version information**
The info below can be copy-paste-completed from the first lines of Rubberduck's log or the About box:

Rubberduck version 2.5.2.5824 loading: (NOTE: Problem also exists in .5834)
Operating System: Microsoft Windows NT 10.0.18363.0 x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5110.1000
Host Executable: MSACCESS.EXE;

**Description**
Selecting the `Adjust attribute value(s) | Selected occurrence` quick fix for the noted inspec

Mathieu Guindon

> Failed to get host document Quarterly Report.Form_GenQuarterlyRpt;System.Runtime.InteropServices.InvalidComObjectException: COM object that has been separated from its underlying RCW cannot be used.

@FreeMan ^^ this doesn't look good, nothing in RD is going to work smoothly if this exception is getting logged

Duga

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5742: QuickFix for AttributeValueOutOfSync isn't working

> > Failed to get host document Quarterly Report.Form_GenQuarterlyRpt;System.Runtime.InteropServices.InvalidComObjectException: COM object that has been separated from its underlying RCW cannot be used.

I don't think it's a bug with the quick-fix.

FreeMan

Well, y'all know you can count on me to blindly stumble across the worst of the scum in the pond...

Mathieu Guindon

lemme try that repro

FreeMan

I'm reasonably certain you could use a shorter @Description string, just so long as it contains a \` and a ` for testing purposes. ;)

lol... even within the code formatting it doesn't like \\ and \

oh, likes it better without.

Duga

2:36 PM

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5742: QuickFix for AttributeValueOutOfSync isn't working

> Ok the exceptions are unrelated, but there *is* something about escapes being ...escaped:

![image](https://user-images.githubusercontent.com/5751684/115733034-83484a80-a356-11eb-84be-6ccc228ee019.png)

FreeMan

@MathieuGuindon this may have been a 1-off issue. I closed Access, reopened, parsed, fixed the noted inspection and have not seen a recurrence of that showing up in the log.

Duga

[rubberduck-vba/Rubberduck] daFreeMan created comment on issue #5742: QuickFix for AttributeValueOutOfSync isn't working

> > Failed to get host document Quarterly Report.Form_GenQuarterlyRpt;System.Runtime.InteropServices.InvalidComObjectException: COM object that has been separated from its underlying RCW cannot be used.

May well have been a one-off issue. After closing Access, reopening, parsing and applying the quick fix, I've not seen a recurrence of that in the log.

I noted it as an exception because I came across it and wasn't sure if it was related or not.

FreeMan

^made that a part of the official record...

Duga

3:20 PM

[rubberduck-vba/Rubberduck] retailcoder edited issue #5742: Synchronizing attributes escapes backslashes, which keeps the annotation de-synchronized

FreeMan

^ you and your specifics...

BigBen

4:58 PM

> Wait. Say this out loud.

and then you can access it unqualiifed from anywhere in your code, whether to read it or to write it.

This probably isn't a good idea.

lololololol

Mathieu Guindon

#HadTo

FreeMan

Anybody else been getting this on SE/SO sites?

Mathieu Guindon

the "Learn how review queues work" pop-up

yes

FreeMan

yeah... (had a screen shot. dunno what I did wid it). Glad it's not just me...

@BigBen Unfortunately, for average Joe from Accounting, that is head exploding stuff right there. I mean, using an int as a row counter? The guy doesn't understand.

Full marks for trying, but Public Property Get? What in the name of all that's holy does that mean???

Mathieu Guindon

5:34 PM

the real thing OP wants is in the last paragraph.

that is, Rubberduck telling them "you're pulling that sheet by name, why?"

I often use a Property Get member on Worksheet modules where I have a ListObject, so I can do Sheet1.Table instead of having Sheet1.ListObject("TableName") all over the code

now granted, making a public property in ThisWorkbook for a Worksheet that already exists at compile-time in ThisWorkbook is dumb.

BigBen

6:00 PM

@MathieuGuindon this is a good idea, may steal that.

Mathieu Guindon

steal it!

FreeMan

6:12 PM

I get that. You get that. Average Joe in Accounting doesn't have a clue what that means...

Mathieu Guindon

@FreeMan sure but since it's not an idea I wanted Average Joe in Accounting to copy-pasta into their own code without reading all the way to the part about implicit containing workbook references, I left it up to the reader to explore :)

FreeMan

fair 'nuf

BigBen

6:46 PM

IMHO, Average Joe in Accounting should learn how to code well.

Vogel612

@BigBen Average Joe in Accounting shouldn't need to learn how to code

BigBen

I'll agree to disagree.

Vogel612

why would an accountant need to learn to talk to computers?

an accountant needs to know about accounting

BigBen

Because accountants do things horribly inefficiently

(speaking from experience working at a financial institution)

Accounting + Code is much better than just Accounting.

Vogel612

the core issue is that the accountant needs a software solution for a problem they have and their boss didn't give them one

which is ... an issue with that boss and not the accountant

Mathieu Guindon

6:50 PM

the accountant doesn't need to learn about properties, they much more likely need to learn about Power Query and Power Apps

BigBen

^^^^^^^^^^^^^^^

Vogel612

well "issue" could also be that the company just doesn't have the resources to create a new software solution to that particular issue

BigBen

Which is why Excel gets (ab)used by Accounting.

Vogel612

tadah

you're kind of making my point for me :D

BigBen

Eh but I'm ok with Accounting becoming shadow IT

because to your point ... company doesn't have resources, and Accounting needs to be (more) efficient.

Enter VBA + ducky.

Mathieu Guindon

6:54 PM

"+ ducky" being the part that tells them when they're about to shoot their own foot off

BigBen

oh wait. One problem. Company blocks Accounting from installing ducky.

Mathieu Guindon

#badcompany

BigBen

#verybad #duckyneedspromoted

Vogel612

@MathieuGuindon mumble mumble OpSec mumble mumble

also joke's on y'all the accounting person uses ledger on an old IBM-500 running a POSIX-based OS from four decades ago

Mathieu Guindon

pfft. yeah, right. same company's website is riddled with SQL injection vulns, but sure it's an open-source tool that's the threat.

this

7:31 PM

@MathieuGuindon but, but, it's written by a Canadian and a ducky with crossbow!!!! How can we trust them?!?

2

and ANYONE can contribute?!? Oh, the horrors!

Mathieu Guindon

7:53 PM

lol

Mathieu Guindon

11:37 PM

@SonGokussj4 FYI I got a repro with find symbol freezing to death, I should have a PR tonight

Greger

[rubberduck-vba/Rubberduck]: 1325 stars vs. [decalage2/oletools]: 1518 stars

Transcript for