VBA Rubberducking

Duga

12:01 AM

RELOAD!

[rubberduck-vba/Rubberduck] 2 commits. 2 closed issues. 1 issue comment. 40 additions. 2 deletions.

[Zomis/Games] 1 issue comment.

[Minesweeper] Games Played: 124, Bombs Used: 68, Moves Performed: 16692, New Users: 10

IvenBach

What category would FooConverters fall into? Refactoring or CodeAnalysis?

this

Neither.

ought to be its own namespace.

IvenBach

There has been

return styles.Select(s => RubberduckUI.ResourceManager.GetString("EndOfLineCommentStyle_" + s, CultureInfo.CurrentUICulture)).ToArray();

or similar.

this

unless the converter is specific to only to one of Refactoring or CodeAnalysis

IvenBach

I'm at a loss as to how to categorize them.

this

12:13 AM

ah, those are fun

IvenBach

I tried searching for the type but it didn't come up.

this

no that's a prefixed key

I assume if you search for EndOfLineCommentStyle_, you'll find more than one possible matches

IvenBach

3 matches come up and they are all converters.

Searching for those converters returns no results.

Apologies if I botch poorly some of these migrations.

IvenBach

8:03 AM

Methinks VS is taunting me by giving bogus errors.

Hey now VS. Quit being a turd and lying. git checkout next was building previously. You lie about it missing metadata files.

IvenBach

8:39 AM

mumble mumble turn it off and back on again fixed it.

IvenBach

8:56 AM

'Foo' does not contain a definition for 'Bar'. Yet when I navigate to it the red squiggly disappears. C'mon VS.... gimme a break.

Duga

12:37 PM

[rubberduck-vba/Rubberduck] BZngr synchronized pull request #5605: QuickFix/RefactoringAction to infer Explicit AsTypeNames for Implicit Type declarations

Duga

1:01 PM

[rubberduck-vba/Rubberduck] build for commit 91baa35d on unknown branch: AppVeyor build succeeded

Vogel612

2:04 PM

@MathieuGuindon same same

mansellan

2:29 PM

pond - random question. does anyone know how the xkcd feed is set up? I'm trying to set the same thing up in a work Teams channel. I tried to use the rss app in teams to subscribe, which works, but it just posts a link rather than the actual comic strip...

Vogel612

it's just an RSS feed

mansellan

comes though like this

Vogel612

the oneboxing is possibly special for xkcd

mansellan

ah ok

Vogel612

the XML that the RSS exposes has a link that's pointing to the image

and SE chat only posts that link

which in turn is oneboxed

mansellan

2:33 PM

ah I see. I need to find out how to extract that link then. thanks :-)

this

~~I think you can just linkt he png directly. They have a consistent format.~~ Doesn't seem to be case.

Vogel612

the RSS gives you some XML. it's just that XML you want

for xkcd specifically (and probably for all proper rss feeds) you want the XPath rss/channel/item[0]/link@value

mansellan

thanks :-)

Duga

4:23 PM

[rubberduck-vba/Rubberduck] IvenBach rejected pull request #5409: Add access keys for settings window

Duga

4:35 PM

[rubberduck-vba/Rubberduck] IvenBach created comment on pull request #5409: Add access keys for settings window

> Unintended close.

[rubberduck-vba/Rubberduck] IvenBach reopened pull request #5409: Add access keys for settings window

[rubberduck-vba/Rubberduck] build for commit f1a9e7ad on unknown branch: AppVeyor was unable to build non-mergeable pull request

BUILD FAILURE!

[rubberduck-vba/Rubberduck] codecov[bot] edited comment on pull request #5409: Add access keys for settings window

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5409?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`next@e498d95`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `85.84%`.

```diff
@@ Coverage Diff @@
## next #5409 +/- ##
=======================================
Coverage ? 61.26%
==============

[rubberduck-vba/Rubberduck] codecov[bot] edited comment on pull request #5409: Add access keys for settings window

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5409?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`next@e498d95`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `85.84%`.

```diff
@@ Coverage Diff @@
## next #5409 +/- ##
=======================================
Coverage ? 61.26%
==============

IvenBach

5:53 PM

@this you available assist? Trying to figure out how to fix "Unable to create manifest resource name ..." and "Metadata file FooBar could not be found".

Pretty sure they're 2 heads on the same coin.

Just nuked each resource file to recreate them in the hopes that fixes it.

Mathieu Guindon

@IvenBach check/compare the properties between different .resx files, then between different translations - should be consistent

something something custom tool something

IvenBach

Resx Manager. I've been using it for export - edit - import.

:confused: I nuked the resx file. Recreated it and changed accessibility from internal->public and now Designer is saying I deleted a string...

I get that all the keys/values were deleted but AIUI that should be tracked when the key is deleted. Not tied to changing accessibility.

IvenBach

6:29 PM

Not sure what to look for. I checked each file and they appear correct.

Mathieu Guindon

6:45 PM

The modifier is for the generated code; needs to be public in rd.resources

I suppose internal makes no difference in other assemblies

this

i think internal ought to be the default for the other projects.

Sorry, @IvenBach, tied up at the moment

IvenBach

No worries.

I'm to the point of redoing the work so I can get this in.

IvenBach

7:28 PM

Testing with new branch starting from upstream/next it builds fine. Adding a resource file causes a manifest error message to appear.

Time for lunch to take a break.

IvenBach

9:04 PM

Trying to rubberduck the issue out loud: fresh git checkout -b SettingsPage2 and building is fine.

Inserting the resource file where I want it to go Rubberduck.Core.UI.Inspections.InspectionResultsUI.resx causes build error.

git restore to return to the state before the resource was added builds, as expected.

Adding resource to Rubberduck.Core.FooBar.resx builds just fine.

Renaming to Rubberduck.Core.InspectionResultsUI.resx also builds fine.

Moving to Rubberduck.Core.UI.Inspections.InspectionResultsUI.resx brings up the "Unable to create a manifest resource name for ..." error.

Return it to Rubberduck.Core.InspectionResultsUI.resx and builds fine, as expected.

Builds fine in Rubberduck.Core.VersionCheck.InspectionResultsUI.resx`.

Builds just fine in several other Rubberduck.Core.<Folder>.InspectionResultsUI.resx

Moving it to Rubberduck.Core.UI.InspectionResultsUI.resx and it barfs.

Longshot deleted the folder Rubberduck.Core.UI and restored it. Adding Rubberduck.Core.UI.FooBar.resx to test if it happened-to-be the file name. Manifest error.

IvenBach

11:20 PM

^ VS 16.5.5. Going to update VS and see if that resolves it.

Nope...

IvenBach

11:46 PM

The desrcription

Unable to create a manifest resource name for "UI\Inspections\Resource1.resx". Could not find file 'C:\Users\ivenbach\source\repos\Rubberduck\Rubberduck.Core\UI\Inspections\Resource1.cs'.

doesn't make much sense. that file won't exist because it's a resx file.

Transcript for