« first day (2258 days earlier)      last day (922 days later) » 

Duga
Duga
12:00 AM
RELOAD!
[rubberduck-vba/Rubberduck] 1 issue comment.
[Minesweeper] Games Played: 121, Bombs Used: 72, Moves Performed: 17765, New Users: 15
 
 
1 hour later…
Feeds
Feeds
1:10 AM
 
 
17 hours later…
Duga
Duga
6:35 PM
> **Rubberduck version information**

Version 2.5.0.5524
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5026.1000
Host Executable: EXCEL.EXE

**Description**
When pressing the tab key after preforming a search in Add/Remove references a "Null Reference" error occurs. Pressing tab in other locations will also cause this error. Also, when pressing ENTER while the cursor is in the search textbox closes the references Dialogue.

**To
> Same issue also happens if when choosing the other tabs in the reference dialogue.
> Wow! Thanks for this amazingly extensive report!

Looks like some temporal coupling is going on, probably code in the ViewModel making assumptions about the state of things. Without looking at the code in question, the provided stack trace makes it seem an easy fix. Obviously the ViewModel will need a number of additional unit tests, too.
 
Duga
Duga
7:05 PM
> Here:

https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-27

Removing the assumption that there *is* a selected item should fix the NRE.
> Here:

https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-L27

Removing the assumption that there *is* a selected item should fix the NRE.
> Here:

https://github.com/rubberduck-vba/Rubberduck/blob/9ed85e0a1df599d03f9793ddc89b16bcb7cb7b47/Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml.cs#L23-L27

Removing the assumption that there *is* a selected item should fix the NRE. Actually the fix should probably be to assign the `.Text` to `cs?.SomeProperty ?? string.Empty`.
 
Duga
Duga
7:51 PM
 
Duga
Duga
8:02 PM
> ###**Rubberduck version information**

Version 2.5.0.5524
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.5026.1000
Host Executable: EXCEL.EXE

**Description**
The short description and path at the bottom of the Add/Remove Reference dialogue is not in sync with the item selected in the list when scrolling with the arrow keys.

**To Reproduce**
- Open the RubberDuck Add/Remove references Dialogue Box.
- Select any item in the
 

« first day (2258 days earlier)      last day (922 days later) »