Hm, how is the Obsolete annotation supposed to work?
It has a fixme // FIXME correctly handle the fact that the replacement documentation is only the first parameter! and a member ReplacementDocumentation, which is not used.
Should the potential first argument be loaded into that member?
Or is the state relating to arguments the problem?
My point was that it probably should be represented as a querying service rather than just a "declaration finder" that happens to also find annotations or other things.
but I assume this is too late. An option would be to decorate such annotation parameter as basically "concatenate everything else you find on the rest of the line."
(hey, I've been absent but I'm still alive!) Speaking of annotations, I'd like to suggest that the procedure do Apply the @PredeclaredId and @Exposed ones (https://stackoverflow.com/questions/58600560/how-to-set-the-attribute-vb-predeclaredid-using-rubberduck-predeclaredid) to be included into their wiki entry (https://github.com/rubberduck-vba/Rubberduck/wiki/VB_Attribute-Annotations)
I've tried to use them before, without success, and thought they were inactive due to some bug. Only today it crossed my mind to google it more thoroughly and came across that Stack Overflow thread
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5404?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request head (`RefactorParseTreeInspections@d21dacf`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-head-commit). > The diff coverage is `n/a`.
@M.Doerner I know I asked a similar question before but if we are passing in the declaration finder into the DoGetInspectionResults, will that influence what results get returned due since the members of the declaration don't change for a given instance (right?)?
still related to those two annotations (PredeclaredId and Exposed) you refer to their appliance as a quickfix. Were they intended to behave in the same way as the @Folder ones do? (meanong, they take effect simply by pressing the Sync button)
The only difference in that regard is that currently a very tiny chance exists that the state to validate whether results are ignored differs from the state to generate the results.
if there's no technical impediment for them to behave the same way, I'd also suggest that their syntax was something like '@PredeclaredId("True") / '@PredeclaredId("False") and they could appear by default (the same way @Folder() does)
In my mind, getting a consistent result is important, and that should be determined at the time of the parse button being clicked (or triggered) but not in the middle of parse.
@CarlosGustavoReetz I think you can do that. But note that you will get inspections for redundant attributes
@CarlosGustavoReetz The attribute annotations work as follows. The annotation itself is just a marker specifying the expected attribute and they do not directly influence the attribute itself. This marker is picked up by the attribute annotation inspections, which report mismatches between the attributes and annotations. The quickfixes allow to sync the annotations and attributes, in both ways.
so if you had @PredeclaredId(false), it would be flagged as redundant because default is false anyway, but @PredeclaredId(true) would be OK and a bit more explicit than just @PredeclaredId (also legal).
@this @M.Doerner, what I had in mind would probably require a lot of refactoring to implement (and probably run into technical difficulties) but it's as follows:
instead of handling these annotations via the Code Inspections, handle it "in the same way" (actually, I don't know how this is currently implemented, I know only the behavior I see from the user perspective) the @Folder is.
Uppon creation a new Class Module would have @Folder annotation (as currently happens), @PredeclaredId(False) (or true if created via the special template Rubberducj offers) and @Exposed(False)
@CarlosGustavoReetz this would imply automatically synchronizing the annotation value to the underlying attribute, which is not always what you'd want to happen
for example if the attribute is correct and the annotation wasn't updated to reflect that.
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5404?src=pr&el=h1) Report > Merging [#5404](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5404?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/9734c7ff3a1dfd33341a1e877a5e69d52cbd858f?src=pr&el=desc) will **increase** coverage by `0.3%`. > The diff coverage is `86.93%`.
No Argument '@PredeclaredId '@Exposed '@DefaultMember '@Enumerator
With Argument '@ModuleDescription("Description of the module's purpose") '@VariableDescription("It's a thing") '@Description("Does something") '@ExcelHotkey("D")
'@Folder("VBAProject") <- I just noticed this one is't listed at the Wiki among the others
VBA Rubberducking
VBA Rubberducking