« first day (2084 days earlier)      last day (1096 days later) » 
00:00 - 21:0021:00 - 00:00

9:00 PM
To get the correct caption, we force the VBE to activate the correct project.
 
Ah!
that was the piece I was missing
 
Please keep in mind that this will only be the fallback solution going forward.
 
> bclothier - Yes I have oleview. Attached is the RxInventor.tbl file. Inventor ships with these two in the respective 'bin' and 'bin32' folders. The VBA IDE seems to detect the one it wants depending on whether your Excel install is 32 or 64 bit.

[Inventor 2020.zip](https://github.com/rubberduck-vba/Rubberduck/files/4227387/Inventor.2020.zip)
 
Noted
 
We first try to simply get the information from the filename property.
Have you tested whether that throws for unsaved projects?
For VBA, we guard against it, but not for VB6.
 
9:01 PM
Not yet, on a slow internet connection atm
cloning your branch atm
 
Ah, ok.
 
wow, you have a lot of branches :-)
 
I should clean them up at some point.
Most have been merged.
 
> Attached IDL file as requested.

[RxInventor.IDL.txt](https://github.com/rubberduck-vba/Rubberduck/files/4227435/RxInventor.IDL.txt)
 
9:18 PM
@M.Doerner Doesn't throw, just returns null.
time to drive home, bbl
 
9:35 PM
@Duga I won't be able to review this until tomorrow
 
> Awesome! That is very helpful. As soon as I am able, I will do some testing with the TLB/IDL files and see what might be causing it to fault.
 
@mansellan nice. Then we fall back to the caption correctly.
I'll have to fix up the regexes, though.
 
10:19 PM
@mansellan One more thing: could you test whether the API has the same problem as the one of the API regarding the caption length?
I.e. could you see what is returned from the caption, if the project name has something like 82 characters?
For VBA, we get the first 99 characters of the caption, followed by garbage.
 
i think it’s actually 98 /nitpick
 
10:35 PM
I counted 99.
100 was the first garbage character.
Wow, ImplementInterface is kind of broken.
 
sure, will take a look
 
10:58 PM
Looks like it's not an issue - the IDE won't allow more than 40 chars for project name. Even hacking the VBP, only the first 40 chars are used.
 
OK, then it should actually always succeed.
 
It looked fine at its 40 maximum
 
> For the record, the reason the resolver is throwing an exception here, is to avoid needing to deal with the consequences of a resolver pass that wouldn't have access to all the declarations available in referenced libraries - every single constant defined in the failing-to-load library would be treated as an undeclared variable in user code; a lot of inspections would be issuing a TON of false positives, and then types and members of a referenced library would be treated like user code, so Rub
 
That gives me the impression that they just reused the code for VBA but relaxed the restrictions.
 
^ very likely!
 
@IvenBach Late to comment on this, but actually I would say not. The inspection would examine an aspect of the Excel OM, and we already have a [library-specific] tag which seems a better fit.
 
11:55 PM
Why do we have two different classes Parameter for ExtractInterface and ImplementInterface, which are both borked.
They also do exactly the same, but with different member names.
 
00:00 - 21:0021:00 - 00:00

« first day (2084 days earlier)      last day (1096 days later) »