Should that be? I'd expect with the other modules being deleted with Replace that would also be the same for document modules.

We could change the replace command to clear the code behind of all document modules.

RELOAD!

[rubberduck-vba/Rubberduck] 3 opened issues. 13 issue comments.

[Minesweeper] Games Played: 110, Bombs Used: 71, Moves Performed: 13914, New Users: 19

@IvenBach document modules belong to the host, not the VBIDE

Where do the standard and class modules belong? The VBIDE?

These are things I'm just starting to understand.

Well, the project anyway

But what about the code behinds of the document modules?

I'd expect them to be overwritten based on the component name

(and warned if attributes are to be lost)

@IvenBach only the host app knows how to add or remove document modules

What should the replace command do with the documents for which no file has been provided?

leave them alone, I suppose

Should it clear them?

nah, uselessly destructive

^^ That's the behavior I'd expect.

Having one set of behavior for .bas and .cls when choosing replace and another for .doccls doesn't feel right.

They're fundamentally different and simply can't be handled the same way

so, if you want to use SC for VBA, put as little code as possible in doc modules

and that's it, I'm blogging about this

Because of those differences making a proxy for them is the preferred alternative?

Mines Excel specific though as that's all I use.

@MathieuGuindon Already looking forward to the article sensei.

@IvenBach and scary at times, too

~.~

In other news, rubberduckvba.com apparently fits on a single floppy disk

Tweet about it.

> What can your devs do for you? We can fit XX number of code inspections and a duck on a floppy.

@MathieuGuindon FWIW, I don't feel the same way with Access documents but that's only because it already has the SC support present so it's easy enough to SC them compared to an Excel worksheet, and it can implement interfaces to which I've used to good effect.

IDK if there's other hosts, but I think Access is likely the only one host to have that support.

@this oh I'm definitely only talking about Excel here - other hosts, other rules!

One thing Sage300 did right: no document modules!

I do wonder how many sets of rules there are.

200-some, IIRC

one per host? Yeah, I guess that'd be the case.

Ok, I have moved most of the checks to the ImportCommand now.

Now, I just have to write a million tests to cover the new functionality.

lol

I guess it also depends on what the document it is. Excel spreadsheet don't really lead itself well to reusable component the same way a form would, I guess.

Well, and Ishould review the user notifications and align the resource keys to the new location.

@M.Doerner that's the easy part, right? ;-)

which part, the resources?

The tests. That was me being facetious.

I actually just have to port and adapt the correct tests for the UpdateFromFilesCommens.

the entitlement is strong with this one

It's just annoying work.

@FreeMan wait, wut? sensible countries drive on the left ;-)

@M.Doerner that, I don't know. I suspect it ignores the change, like it ignores source file changes. VB6 is from an era before external changes, before multi-dev considerations. I'll check and get back to you.

There's also .vbg files to consider (the predecessor to .sln, and vastly inferior)

@mansellan IIRC VB6 Enterprise shipped with VSS (gasp)

Wut wait a minute why how did I not ever know about .vbg?!!

@MathieuGuindon True. But until vary late (VSS 2005), the only sharing in VSS was "I've got this file, everyone else wait"

lol yeah

Lock-Edit-Commit

well it's safe

VS2005 introduced Edit-Resolve-Commit, but too late for anyone to care.

About 7 years after MS stopped caring about classic VB

@MathieuGuindon Because it solved almost nothing?

(speaking as someone who had one in a business setting, and was disappointed)

IDK, does it make multiple .vbp in the PE?

@mansellan what does/doesn't it do?

I mean, I worked with .vbp and ..yeah. makes me wonder what could possibly have gone wrong with .vbg...

Sure, it's like Excel, multiple projects in the PE. The vbg puts them into a group. But it's not like modern VS... Everything has to be done via COM, you can't treat it like sorta-one-big-project.

It's difficult to explain... Same idea, more sucky.

It basically got you nothing much above "load project 1". "Compile to dll." "load project 2"". "Reference project1.dll".

I know that's kinda what VS does. But it wasn't the same.

1998 was tough =)

^

Thing is, VSS became TFS. They moved the storage to SQL, added some niceties, and hoped nobody would notice.

it checks out

TFS was just a rebranding exercise. VSS2008 didn't sound so good.

did VSS live that long?

I'd thought it dead in the "VS.NET" era

It lived on in TFVC. Which MS have now accepted is now dead, they're full-on with Git in Azure DevOps.

Azure sounds nice

It's actually difficult to kill TFVC repos in Azure DevOps. It's still the default.

yikes

@MathieuGuindon Azure DevOps is really nice.

It kinda just works.

Huh? No

It has been defaulting to git for a good while

At least when I make new project, I don't have to do anything - it just has git OOB

TFS (aka VS' VSS) can burn in a tire fire.

VSS = ???

Visual source safe

MS's bad ancient take on SC.

I think DevOps is a not too bad, but a bit lacking in some areas.

In particular the diff view is inferior to GitHub's.

[rubberduck-vba/Rubberduck] jzabroski starred us

[rubberduck-vba/Rubberduck] MDoerner milestoned issue #5274: Follow up on SC style import commands

[rubberduck-vba/Rubberduck] MDoerner milestoned issue #5279: Fixes around array access references

[rubberduck-vba/Rubberduck] MDoerner milestoned issue #5298: Convert function to procedure leaves broken code.

[rubberduck-vba/Rubberduck] MDoerner assigned MDoerner to issue #5298: Convert function to procedure leaves broken code.

[rubberduck-vba/Rubberduck] MDoerner assigned MDoerner to issue #5293: Code Explorer Sync>Replace aborts silently

[rubberduck-vba/Rubberduck] MDoerner milestoned issue #5293: Code Explorer Sync>Replace aborts silently

[rubberduck-vba/Rubberduck] MDoerner added label difficulty-04-quackhead to issue #5288: Refactor Rename should also update any CustomUI xml files

[rubberduck-vba/Rubberduck] MDoerner added label PR-Status: WIP to pull request #5274: Follow up on SC style import commands

[rubberduck-vba/Rubberduck] MDoerner milestoned issue #5277: Array & undeclared Redim'd variables' refcounts and renaming are incorrect

Should we really overwrite the contents of forms without binary and documents on import or should the import command be guaranteed to be non-destructive?

Currently, if there is an exception withing an action executed under parser suspension, we swallow the exception and return that there was an unexpected error as suspension result.

I think that this is very unexpected behaviour.

Shouldn't we let the exception bubble up?

At least, we have to report the exception on the result, which is something I will add anyway.

Argh! MS, why do you have to do stuff so inconsistently?

The type returned from Dictionary<TKey, TValue>.Values implements ICollection<TValue>, which contains Remove(TValue item), but invoking that member causes an exception.

Either don't put Remove on the interface of don't say that the type implements the interface!

[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5274: Follow up on SC style import commands

[rubberduck-vba/Rubberduck] MDoerner removed label PR-Status: WIP from pull request #5274: Follow up on SC style import commands

[rubberduck-vba/Rubberduck] MDoerner unassigned MDoerner from issue #5292: Code Inspection's "Copy to Clipboard" doesn't

[rubberduck-vba/Rubberduck] MDoerner edited pull request #5274: Follow up on SC style import commands

[rubberduck-vba/Rubberduck] MDoerner created comment on pull request #5274: Follow up on SC style import commands

> Now, most of the checks introduces for UpdateFromFilesCommand are executed for all import commands. We check that the component names for the files are unique (Otherwise the import is non-deterministic since the VBE numbers the later imported components and the order cannot be determined by the user.), we check that binary files are present (VBA only) and if they are not abort unless there is a different import path into existing modules (currently for user forms). In this case we check whe

[rubberduck-vba/Rubberduck] build for commit 93028391 on unknown branch: AppVeyor build succeeded

@MathieuGuindon That makes no sense whatsoever! What does "cows circulating on the other side of the road" even mean???

eh

@this "standard gauge" railroad width was determined by the width of a Roman Centurion's chariot. The Romans built their roads to fit their chariots. The locals they dominated build their wagons to work on those nice stone roads. The rest, as they say, is history...

catching up on yesterday afternoon

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5287: Using the refactoring dialog Close button executes the refactoring

> The problem here arises because we never set the dialog result if the dialog is closed not using the button. This causes the observed behaviour since the first element of the results enum is Execute. This can be fixed by either making Cancel the first element or adding a third value Undetermined as the first value.

[rubberduck-vba/Rubberduck] MDoerner unassigned bclothier from issue #5287: Using the refactoring dialog Close button executes the refactoring

[rubberduck-vba/Rubberduck] MDoerner assigned MDoerner to issue #5287: Using the refactoring dialog Close button executes the refactoring

Not good, after cancelling a rename refactoring I consistently get a restart of Excel after close.

Hm, the problem only occurs if the dialog is cancelled.