> Now, `ReorderParametersRefactoring` is fixed as well.
The new behaviour is that whenever there is a named argument, we make all positional arguments named and drop all missing arguments. Otherwise, we reorder the positional and missing arguments and drop afterwards trailing missing arguments.
> I will extend this PR and move the validation logic for documents and user forms to the import command. However, I will not perform the exclusion based on possibly required and possibly not existing binary files for VB6 since we should not cripple the ability to import these just because we have not implemented a way to get the right binary names.
slips quietly back under the covers of his VBA code to clean things up. Ignores email issues for a while with the expectation that they'll miraculously go away through benign neglect
> **Rubberduck version information** ``` Version 2.4.1.5200 OS: Microsoft Windows NT 10.0.17134.0, x64 Host Product: Microsoft Office 2016 x64 Host Version: 16.0.4912.1000 Host Executable: EXCEL.EXE ```
**Description** The `UseMeaningfulNames` inspection only triggers on variables declared in the _currently compilable_ path of a conditionally compiled block of code. When fixing that name using `Refactor|Rename`, only the _currently compilable_ section of code is modified. This leaves
Is it possible for RD to detect that there are pre-compiler directives and issue some sort of warning along the lines of "CAUTION - You might be about to break your code! ZOMG!! Danger, Will Robinson, Danger!" or something like that?
I mean, I'd think a programmer advanced enough to use precompiler directives would recognize the fact that only one of his 2 Dim statements had just been updated and she'd make the effort to manually update the other one, but, sometimes you get busy or distracted and forget.
OK. I'm cool with it either way. In... 4 or so years of ducking, this is the first I've run into it, so it is a rare thing, and yeah - it's the cost of doing conditionally compiled business, I guess.
It's been documented. People can discuss. It can be closed when appropriate.
Just want to say guys, I ran my every-utility-I've-ever-built dev template workbook through the parser for the first time in a year or so, and it didn't throw a single error.
> This behaviour is currently by designer. We only ever look at the currently selected version of the code according to the compilation arguments.
The reason we only look at that version is that we require valid VBA code in order to parse and resolve it. Conditional compilation directives allow to split code at arbitrary points, usually leading to invalid code if they are ignored entirely. Looking at all possible versions is also problematic since the number of possible combinations grows exp
We can ignore a specific inspection result, and we can ignore an entire module. Would it be reasonable to ignore an entire procedure? For example, I have multiple TestSomeFunctionThatRequresParameters that I'd like to ignore completely. They're not part of a full-on test suite and don't fit the duck's test harness format, but I do use them and it'd be nice to ignore the not-perfect code in them.
anyone offhand know how to navigate to the "default app settings" via the cmd prompt? not finding anything online and not able to guess what to add onto "start ms-settings:"
omfg i figured it out... ms-settings:appsfeatures. there's an "s" after app ='/
> I fully recognize that this isn't easy. I acknowledge that it may not need to be "fixed". It's unlikely that most people will run into it, and those that do will know that the price of conditionally compiled code can be high.
Look at this report as an opportunity to get the brains trust gathered around a pot of coffee to have a discussion of whether it _should_ be fixed, if it _can_ be fixed, or if it's just _caveat emptor_.
I won't be offended if this is closed as "by-design", "decline
Iirc the reason for my chat ban was that i was accused of multi-accounting, they thought that since they couldn't link my SO account to my SE ones, I had multiple accounts. Contrary, I had simply set SO to private until I could delete it.
Unjust, but the mod was confused, so I just weathered it out. No hard feelings.
To be honest, I appreciate it in a few ways, because it gave me some cooldown time from stuff that was happening around that time, and gave me a while to mature a little bit... heh.
> One thing we can do at least is to at least recognize that the inspections and the refactorings are on a module that contains a conditional compilation directives and flag. Thus when the user tries to execute a refactoring or a quickfix, they will be provided with a warning that the change may not be complete on such module, and that they may need to take care.
As a matter of coding practice, it's kind of a big code smell if you are sprinkling the conditional compilation all over the place
> **Rubberduck version information** ``` Version 2.4.1.5200 OS: Microsoft Windows NT 10.0.17134.0, x64 Host Product: Microsoft Office 2016 x64 Host Version: 16.0.4912.1000 Host Executable: EXCEL.EXE ```
**Description** The `Convert function to procedure` quick fix does _not_ change `Exit Function` statements to `Exit Sub` statements
**To Reproduce** Steps to reproduce the behavior: 1. Write a `Function` that does not assign the return value 2. Plop an `Exit Function` in there 3
@Hosch250 Indeed. You'll be able to tell the parents of young children. They'll be able to step on them and scream in silence so they don't wake up the little kids.
> **Rubberduck version information** ``` Version 2.4.1.5200 OS: Microsoft Windows NT 10.0.17134.0, x64 Host Product: Microsoft Office 2016 x64 Host Version: 16.0.4873.1000 Host Executable: MSACCESS.EXE ```
**Description** Executing the `Remove unused declaration` quick fix is logging errors, but fails silently to the user.
**To Reproduce** Steps to reproduce the behavior: 1. Write a procedure 2. Don't call it 3. Parse 3. Execute the `Removed unused procedure` quick fix on it.
shrugs it's only really relevant if you have the hand coordination to do that part, it's easily the hardest part of the entire game, and if you fail it, you still can play the game.
> Hrm... just for giggles, I saved my .accdb and closed Access. After reopening the file, I did a C&R, parsed, and the duck was able to successfully execute the quick fix.
My .accdb file was ~7MB after the C&R. It's about 14MB now. It was >50Mb before the C&R. Don't know if that had anything to do with it. I've been doing a _lot_ of code cleanup this morning, so I think Access leaves random junk behind from that and requires a bit of tidying up every now and then.
@FreezePhoenix a little different than i played growing up; we had a "jack pit" and anything that didn't land in the pit were put to the side and counted AGAINST your score. We wouldn't catch the ball between bounces unless you wanted to stop. On the first bounce you pick up one, on the second bounce two, etc., and you catch the ball if you want to stop; if you miss a pick-up/bounce combo everything you picked up was put back into the pit.
my one cousin was an asshole, so we put the stipulation that you could only bounce the ball so high
@this hrm... now you've got me thinking. I know they're starting to push O365 and that I've got it on my laptop. I guess I haven't installed it on my desktop machine.
I know they want to do the web-apps for as many people as they can, but you can't VBA in web-app, so some of our people (like me) are keeping the desktop installs. Is O365 desktop called '2016 Pro plus'? ;)
Talking about time on my hands, I was reading an Ask Reddit thread last night (after work).
It was something along the lines of "The pilot calls for a member of <your career> here. What do you do?"
There were several hilarious responses.
> I'm a structural engineer. Do you need an emergency runway? > I'm a canoe instructor. > I'm a skydiving instructor. I don't think you really want me. > Not sure what you need an emergency stripper for... > I'm a window washer. Need the bird poop off the windshield?
> I'm IT. I can turn the plane off and on again.
And the obligatory "I'm a pilot. I'll help fly the plane."
> Just wanted to add that this is an issue with the Code Inspections window as well. Recently there has been a couple of false positives I didn't get before (I think there are issues for them, I'll check later) and I am up to 2000+ inspections. Clicking on an inspection can sometimes take a couple of minutes. Expanding a group with 500 cases locks Excel up for 5 minutes.
One is that you added one for `LineLabelNotUsedInspection` which triggers for all of the unit tests because you have one su
> Just wanted to add that this is an issue with the Code Inspections window as well. Recently there has been a couple of false positives I didn't get before (I think there are issues for them, I'll check later) and I am up to 2000+ inspections. Clicking on an inspection can sometimes take a couple of minutes. Expanding a group with 500 cases locks Excel up for 5 minutes.
One is that you added one for `LineLabelNotUsedInspection` which triggers for all of the unit tests because you have one su
> @Irubataru the scrollbars are definitely not helping WPF's rendering performance. 5 minutes to expand a group is unacceptable! I presume you have the results grouped with the default grouping, which would be by inspection type (readability & maintainability/code quality/language opportunitites/etc.)? Does grouping by inspection (procedure not used/etc.) or by module help it a bit or not at all?
Can't stand the set coming up this time. Yang is pretty much the only one I even remotely like--only since he's open to talking through things with the opposition.
I'll probably cast a protest vote for someone or other. Of course, report has it that in MN, write-in ballots are just thrown out entirely. They don't even count the non-written-in sections.
> Well, it basically just depends on the number of elements in the group. So if I create smaller groups it takes a shorter amount of time. I will probably simply disable the inspections that I don't need / has false positives when I am done checking them. Basically my plan is to check LineLabelNotUsedInspection for all of the ones that are not in my unit tests and then disabling the inspection, however it is taking quite a long time as everything is quite slow.
@Hosch250 to not dig into specific policies/people, i am not sure how i feel statistically about the next election. in the existing two-party system, the incumbent's party does not pick a new person as to not split their votes while the other party will have numerous people which inherently splits votes. there have only been, i believe, 5/43 instances where the incumbent was not put back into office, and of those times, the opposition party did not have >1 person vying for position within 9
> Well, it just depends on the number of elements in the group. So if I create smaller groups it takes a shorter amount of time. I will probably simply disable the inspections that I don't need / has false positives when I am done checking them. Basically my plan is to check LineLabelNotUsedInspection for all of the ones that are not in my unit tests and then disabling the inspection, however it is taking quite a long time as everything is quite slow.
I pledge my eternal servitude and everlasting gratitude to Presidenta For Life AOC, under one nation, suffering and misery equally for all. Glory to the People's Democratic Repulik of AOC!
> Well, it just depends on the number of elements in the group. So if I create smaller groups it takes a shorter amount of time. I will probably simply disable the inspections that I don't need / has false positives when I am done checking them. Basically my plan is to check `LineLabelNotUsedInspection` for all of the ones that are not in my unit tests and then disabling the inspection, however it is taking quite a long time as everything is quite slow.
@this whatever it is, the general consensus is that something divisive will be stated once and entire sides will flock to the calling as pushed by media... i'm waiting to see what the next "lockbox" is goign to be (he only said it 3 times in that entire debate, but sure as shit that's what i remember Gore for"
@Hosch250 get the zombie uprising going and rather than turning over in their graves at this shitshow they might likely be the ones ripping the heads off the ones fucking it up
@this Yeah, completely kills the zombie theme for me. Especially when they are viewed as basically just bones crawling along. Like, WT*? Even if there were tendons, you need muscles...
it is all dependent on the corpse still being mechanically functional but it can't last that long, esp. because to contract muscles requires chemical reactions and some means of reversing the reaction, which is what oxygen/blood basically does.
Like ants, but even they are considered lately to not work together so much as just all wanting to go back to the nest carrying something too large for it.
If they worked together, they wouldn't have half of them hanging on to the top of whatever they were carrying and being dragged by the rest of them.
@this yeah... i really hate that concept. the muscles/tendons need to be intact, otherwise things physically couldn't move. i would rather take the scientific possibility (even infinitesimally small) to magical stuffs
@Cyril so you'd prefer TWD's premise over Ash & Evil Dead premise?
See, if you say it's black magic, that they are powered by supernatural mana, then it already explains why they can animate a rotting corpse and still be functional. You can't do that with a virus explanation.
oh; my wife watched that... not really sure the premise, but i think people are infected? doesn't honestly make sense if the required synapse structure of the brain is destroyed (aka a bullet throught he corpus collosum) then you cannot move the rest of the body. that's supposed to be some type of biological agent turned virus?
yeah, i still live in my bubble... hell, i'm listening to boys ii men atm. motownphilly, bitch1
@this to the zombie thing... government creates a parasitic spider-tardigrade hybrid, where the webs have conductance and sheating to allow axon-al synapse firing to cross... not saying we need the way that happened, but might be a step closer to pushing for the requirements of an 'intact' host-body. the issue would then be driver; pure instinct, or would the previous mind come back? now we're having a convo with nietsche
Does anyone remember whether they showed that the allocations of unmanaged memory is directly tied to the toolwindow?
To be honest, when I look at WPF, I feel quite lost because I don't even know where to look for performance problems. It's based on a quite tall stack that can throw exceptions then swallow it and make all binding errors basically undetectable runtime errors.
Need to merge data per column if records in the first column are the same.
I wrote a VBA code and it works but it works very slow as it executes "merge" function per each row no matter if consequent cells are the same or different.
Sub DuplicateValues()
'Declare All Variables:
Dim myCell As R...
@this depends on what the policy states... for most that i've seen, they essentially say "use work stuff for work stuff" and "don't leave your hardware visible, put it in the trunk"
Were I the IT director, I'd certainly not want them running bluetooth enabled PC. That's a vulnerable point since you don't need physical access to the machine
my father has a couple coworkers who live 150+ miles from their plant and they've been driving it for >30 years. i remember being in DC and had a coworker who would drive in daily from West Virginia... i met him about 20 years into that endeavour
i would say, it works for some folks, not for others
@this i did that for a month straight, then got an apt 4 miles from work so i could walk, then only drive home on the weekends. money was tighter, but i had a higher quality of life
A question for @this TortoiseGit expert (or @that one... :) Is it possible to delete a branch with TG? I know how to do it from the bash prompt, I'm just wondering if they've got a menu item anywhere. A browse through the help seems to indicate no, but I figured I'd ask.
![[proudly greeting the hotel manager at the door] "Did I do aa good job?"](https://imgs.xkcd.com/comics/hotel_room_party.png "[proudly greeting the hotel manager at the door] \"Did I do aa good job?\"")
Need to merge data per column if records in the first column are the same.
I wrote a VBA code and it works but it works very slow as it executes "merge" function per each row no matter if consequent cells are the same or different.
Sub DuplicateValues()
'Declare All Variables:
Dim myCell As R...
VBA Rubberducking
VBA Rubberducking