TortoiseGit's import keeps telling me that a file on disk is newer than/different from the one on disk. Right-click | Diff on the file (in Win Exp) shows me zero differences. Why's it keep saying it needs to be imported?
The code does exist in my accdb, too.
This is after having already imported it once.
even when it's set to compare whitespace it says they're the same
@Duga Typo alert: .16231 doesn't appear to be anywhere near close to a valid build number
carp. changed branches, that's why.
coulda sworn I'd check them in and merged to master though. :/
> A refactor rename of a class or module should check the CustomUI Xml for the host document to ensure that any ribbon callbacks are update appropriately.
> The module or class name is specified in the Custom UI but there is nothing in the VBA that indicates that a module responds to Ribbon callbacks other than the naming convention you adopt.
For example I have extensive ribbon customisation for a Word Template. To organise this I have VBA modules called
the hypothetical plugin could conceivably provide a list of Declarations/IdentifierReferences to enable refactorings / quickfix to work without knowing the particulars.
> How is Rubberduck supposed to know where to find the XML for the custom UI? I toyed with Ribbon stuff once, and there doesn't seem to be any standard way to do this - you could have your XML inlined in concatenated string literals, or loaded from disk, or pulled from a database.
And then sure you could have an `onAction` callback, but then you could have callbacks to determine visibility of UI elements, or to load a picture, or a description, ...what specific XML attributes in what specific
> We can identify GetCustomUI as a callback - but the only requirement is that the method returns a String that contains the XML; RD could invoke that callback if it exists and get the XML, and then we can traverse elements and see what the attributes are, but without knowing what attribute is a callback, we have nothing actionnable.
> We can identify `GetCustomUI` as a callback - but the only requirement is that the method returns a `String` that contains the XML; RD could invoke that callback if it exists and get the XML, and then we can traverse elements and see what the attributes are, but without knowing what attribute is a callback, we have nothing actionnable.
And then, we can refactor/rename the callback, but we can't fix the actual XML attribute value(s).
> I envisaged that it would be possible during a refactor rename to determine when a class or module is being renamed and to then use the two names to do a find/replace in the CustomUI.CustomUI14.xml. IN my case the regex would have been to replace '"<0 or more spaces><findname>' with '\1\2<replacename>'. This didn't seem to onerous a task but I'd have to admit my viewpoint is limited to Word so I don't know how the difficulty increases with other office apps.
> I envisaged that it would be possible during a refactor rename to determine when a class or module is being renamed and to then use the two names to do a find/replace in the CustomUI.CustomUI14.xml. IN my case the regex would have been to replace '"<0 or more spaces><findname>' with '\1\2<replacename>'. This didn't seem to onerous a task but I'd have to admit my viewpoint is limited to Word so I don't know how the difficulty increases with other office apps.
> I'm not very familiar with Ribbon XML. When I toyed with it I noticed that `GetCustomUI` was happy to load inline XML from a string, and couldn't care less where the actual content came from (you could load the XML from a file, from a database, or you could hard-code it into the callback).
How does RD know to even look in `CustomUI.CustomUI14.xml`? Or is it `CustomUI.xml`? Is there a standard .xml filename that will always be loaded if present?
> I think the best we can do is invoke the GetCustomUI callback on parse to get the XML, then parse it, and if that succeeds and we have a list of callback attributes somewhere, then we can identify all callback procedures as such and avoid tripping "Procedure not used" (#1186), and even render the XML in some toolwindow (#3369), but pushing changes to the XML doesn't seem realistic.
> I think the best we can do is invoke the GetCustomUI callback on parse to get the XML, then parse it, and if that succeeds and we have a list of callback attributes somewhere, then we can identify all callback procedures as such and avoid tripping "Procedure not used" (#1186), and even render the XML in some toolwindow (#3369), but pushing changes to the XML doesn't seem realistic (although the XML render could very well identify callbacks referring to methods that don't exist in the VBA cod
> The zip file that is a word template contains a directory 'CustomUI'. In that directory will be the CustomUI10.xml or CustomUI14.xml that represents the ribbon customisations. As far as I understand its just a single file. I'd assume other names are possible but this is what you end up with using the CustomUI tool.
Below is the xml for the Callbacks captured by the RibbonResponderCheckboxes Module after manually find and replacing 'RibbonResponder' by 'RibbonCallbacksFor'
This is the master form for my project. I have made no changes, I simply set a breakpoint in the code (testing my command line parameter handling). I added a few logging lines to a different module, hit ctrl-s (which should do an auto-export of changed modules) and this is the only thing Tortoise claims changed
> Side note - there's no GetCustomUI callback... that was a remnant of my foggy memory from when I last toyed with Ribbon XML. And in the absence of such a callback... there's simply no way for RD to know where/how to get the custom XML... short of implementing a way to somehow associate an XML file with a VBA project (and without project-level config, that's a stretch).
Correct; the point is that with original code foo!bar.Value, it would not be safe to refactor into foo.Value just because we no longer take the bar as a parameter to the Item default member
But I have to set up the logic, add an appropriate refactoring exception, add a resource string, which needs to be translated, and register the exception in the notifier.
In which case, that is also fine, I guess. Mat did say that under no circumstances any refactoring should end up with invalid code. So as long your existing work doesn't lead to that, I think that is also fine (not doing anything for the Remove Parameter refactor)
VBA Rubberducking
VBA Rubberducking