Private Function OpenDatabase(ByVal path As String) As Access.Application
Dim database As Access.Application
database.OpenAccessProject FilePath:=path, Exclusive:=True
Set OpenDatabase = database
End Function
The whole access DB has some setup that it goes through to determine if it's running in Dev or Prod, then there are some classes that need to be set up and finally run the method that downloads all the necessary files.
Yeah... This is going to be a big bite. I'm not sure that the access code is really amenable to being called this way. May take some access refactoring to make it so. Which wouldn't be a bad thing in the long run...
Yes - I assumed that we don't have the entire code, and if it's missing yet he is able to use the object without errors about it being not set, then that means it got assigned the default instance. I've seen people do that by mistake.
Whenever I have to do something like opening another application, I actually write a wrapper class to ensure that the application quits once the object goes out of scope.
> **Rubberduck version information** Version 2.4.1.23886 OS: Microsoft Windows NT 10.0.18362.0, x64 Host Product: Microsoft Office x86 Host Version: 16.0.12026.20320 Host Executable: EXCEL.EXE
Rubberduck does not find/recognize hidden enum member references.
**To Reproduce** 1. Create module with the following content: ``` Option Explicit Enum FruitTypes [_First] = 1 Apple = 1 Orange = 2 Plum = 3 [_Last] = 3 End Enum
``` Public Enum FruitType [_First] = 1 Apple = 1 Orange = 2 Plum = 3 [_Last] = 3 End Enum
Sub DoSomething() MsgBox CStr(FruitType.[_First]) End Sub ``` The References collection for Enum Member [_First] is empty. It does not recognize `MsgBox CStr(FruitType.[_First])` as a reference. This issue is described further in #5228
2019-10-16 12:03:10.8715;WARN-2.4.1.5086;Rubberduck.Inspections.Rubberduck.Inspections.Inspector;System.InvalidCastException: Unable to cast object of type 'Rubberduck.Parsing.Symbols.ExternalProcedureDeclaration' to type 'Rubberduck.Parsing.Symbols.ModuleBodyElementDeclaration'.
at Rubberduck.Inspections.Concrete.EmptyMethodInspection.<>c__DisplayClass1_0.<DoGetInspectionResults>b__0(Declaration member) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Concrete\EmptyMethodInspection.cs:line 45
hey, @skiwi! How many browser tabs do you have open today?
(which shouldn't be that surprising since I'm 99% sure VBA internally uses the same oleaut functions)
I know, I know.
but VBA is far tooo goosey-loosey.
MUST PARSE ALL!, it thinks
Anyway that's why I think there's a new opportunity to provide users with methods to perform locale-sensitive (or insensitive) tests to help them avoid pains with implicit localization VBA + OS may foster.
this is an excellent question. My first instinct is to make it early-bound, but I'm not seeing anything that allows one to specify which version one is creating.
Of course, if you only have one referenced in the project, then you're guaranteed to have the correct one...
notes that the default Reference Manager is a nightmare and runs screaming back to the Duck
> This PR addresses the invalid cast exception reported by @daFreeMan in chat. > 2019-10-16 12:03:10.8715;WARN-2.4.1.5086;Rubberduck.Inspections.Rubberduck.Inspections.Inspector;System.InvalidCastException: Unable to cast object of type 'Rubberduck.Parsing.Symbols.ExternalProcedureDeclaration' to type 'Rubberduck.Parsing.Symbols.ModuleBodyElementDeclaration'. > at Rubberduck.Inspections.Concrete.EmptyMethodInspection.<>c__DisplayClass1_0.<DoGetInspectionResults>b__0(Declaration member) in...
C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Concrete\EmptyMethodInspection.cs:line 45 > at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext() > at System.Linq.Enumerable.WhereEnumerableIterator1.MoveNext() > at System.Linq.Enumerable.Count[TSource](IEnumerable`1 source) > at Rubberduck.Inspections.Abstract.InspectionBase.GetInspectionResults(CancellationToken token) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Abstract\InspectionBase.cs:line 112...
> at Rubberduck.Inspections.Rubberduck.Inspections.Inspector.RunInspection(IInspection inspection, ConcurrentBag`1 allIssues, CancellationToken token) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Inspector.cs:line 179;System.InvalidCastException: Unable to cast object of type 'Rubberduck.Parsing.Symbols.ExternalProcedureDeclaration' to type 'Rubberduck.Parsing.Symbols.ModuleBodyElementDeclaration'. > at...
Rubberduck.Inspections.Concrete.EmptyMethodInspection.<>c__DisplayClass1_0.<DoGetInspectionResults>b__0(Declaration member) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Concrete\EmptyMethodInspection.cs:line 45 > at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext() > at System.Linq.Enumerable.WhereEnumerableIterator1.MoveNext() > at System.Linq.Enumerable.Count[TSource](IEnumerable`1 source) > at...
Rubberduck.Inspections.Abstract.InspectionBase.GetInspectionResults(CancellationToken token) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Abstract\InspectionBase.cs:line 112 > at Rubberduck.Inspections.Rubberduck.Inspections.Inspector.RunInspection(IInspection inspection, ConcurrentBag`1 allIssues, CancellationToken token) in C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Inspector.cs:line 179
@BZngr I'd think anything that throws a WARN in the log is an issue of some sort that could use a good dressing, but I'm good with your method, too. :)
I pass the control from a form to a method that populates it. Since I'm now bypassing the form (running it when a command line parm is set), I need to be able to pass a ListBox in to populate it then pass that to the procedure that loads based on what's been selected in the list box.
What I just realized was that newing up the form on which the ListBox normally resides gets it populated as part of the on_activate, so Dim myForm as theFormInQuestion gets me a populated ListBox which I then pass to the procedure that loads the data.
I've got 4 sets of ListBoxen on the form. Click "Load Data" and it calls the Load routine passing in each of the list boxes and a param to indicate which type of data is being loaded.
No, no .rowsource on the listboxen. One of the conveniences is that I have a proc that populates the ListBox. Guess I'll modify that to populate an array now, add a proc to populate the ListBox from the array (for form use) then be able to reuse the exiting (modified) proc to populate the array for the automated process, too.
maybe it isn't as big an effort as I was thinking.
A lot of this code is old. Written before I'd met the duck and started to learn better, so it was of the Make it work variety, with little to no effort to Make it right.
I get it. I do really think that's a time to refactor, even if you're in a rush to get it working because otherwise, you end up taking more time fighting with the UI you didn't even need.
I think those PRs are ready to be merged: 5203, 5207, 5212, 5224, 5227, and 5229. The 5226 just need a bit more review. Not sure if 5202 is already ready to be merged given the open question RE: VB6 tests.
No. it's just stupid Excel. It'll do it even if I've never opened the VBE.
I've been having semi-regular Excel crash-on-exit issues since I got upgraded to a new machine. I don't think this one has as much RAM as my old one did - that may well be the issue.
maybe I should check for Office updates instead of waiting for corporate IT to decide to push them...
On the bright side Make it work worked. Now on to Make it right.
And we all know how well clever implementations do.
sigh...
#GettingLotsOfMileageOuttaThatQuote
Dumb question: Say a guy wanted to move from his own source control import/export routines to using OASIS-SVN for that purpose. What's the best way to update everything in git since all the file names and locations will be changing?
am I going to take several extra seconds/minutes to make it all align in some centerline that I can't see?.... No, thanks.
so I tend keep it all left-aligned, with indentations.
with K & R bracing
which AFAIK, nobody else does. :(
I do agree with some of the points -- e.g. preferring singulars over plurals
this is a sampling of how I style my SQL.
SELECT
t.foo,
t.bar,
t.baz
o.foobar,
o.barfoo
FROM dbo.something AS t
INNER JOIN duo.other AS o
ON t.ID = o.SomethingID
WHERE t.foo = 123
AND o.foobar >= '2019-01-01'
AND o.foobar < '2020-01-01'
AND NOT EXISTS (
SELECT NULL
FROM dbo.lame AS l
WHERE o.ID = l.OtherID
);
> Do not use database server specific keywords where an ANSI SQL keyword already exists performing the same function. This helps to make code more portable.
LOL
hmm some advice given are questionable.
aw, c'est la vie.
> Keep the length to a maximum of 30 bytes—in practice this is 30 characters unless you are using multi-byte character set.
If I For Each my way through a Collection, I can get the Item property, but not the Key property, is that correct? I'm not seeing any way to get the key back out.
Ancedotally, I've heard that Scripting.Dictionary is usually the better choice over VBA.Collection; only reason to use VBA.Collection is to avoid having an external reference (late or early)
@Freeman A scripting dictionary returns the key in a For Each loop so that you can do .Item(key). What you can't do is to provide the value and get the key back. For that I wrote a VBA class in C# (my Kvp) class. Happy to share the C# code if helps.
VBA Rubberducking
VBA Rubberducking